Re: [PR] KAFKA-14133: Move MeteredTimestampedKeyValueStoreTest, ReadOnlyWindowStoreFacadeTest and TimestampedWindowStoreBuilderTest to Mockito [kafka]

2023-10-09 Thread via GitHub
clolov commented on code in PR #14412: URL: https://github.com/apache/kafka/pull/14412#discussion_r1350155561 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java: ## @@ -223,38 +208,9 @@ public void shouldThrowNullPointerIfInn

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-10-09 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2023-10-09 Thread via GitHub
mimaison commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1752766226 Thanks @Vaibhav-Nazare for the KP and PR. I've not looked at Jenkinsfiles in a while, can you clarify why you used nested `stage` fields unlike the other existing platforms? --

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-09 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1752756051 Hello @gharris1727 Do you have time to take a look at final patch that transfer `ReassignPartitionCommand` from scala to java? -- This is an automated message from the Apache Git S

[jira] [Resolved] (KAFKA-15521) Refactor build.gradle to align gradle swagger plugin with swagger dependencies

2023-10-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15521. Fix Version/s: 3.7.0 Resolution: Fixed > Refactor build.gradle to align gradle swag

Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]

2023-10-09 Thread via GitHub
mimaison merged PR #14473: URL: https://github.com/apache/kafka/pull/14473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
iit2009060 commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752650126 > > > > > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
iit2009060 commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752640268 > > > > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2.1

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
hudeqi commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752610656 > > > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2.12 / te

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
iit2009060 commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752558048 > > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2.12 /

[jira] [Commented] (KAFKA-15565) KafkaAdminClient does not honor request timeout ms

2023-10-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773185#comment-17773185 ] Divij Vaidya commented on KAFKA-15565: -- I agree with [~pnee] . This does not seem l

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
hudeqi commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752555087 > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2.12 / testCl

Re: [PR] Kraft support for Integration Tests [kafka]

2023-10-09 Thread via GitHub
dengziming commented on PR #14295: URL: https://github.com/apache/kafka/pull/14295#issuecomment-1752541040 I create https://issues.apache.org/jira/browse/KAFKA-15566 for these flaky tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (KAFKA-15566) Klaky tests in FetchRequestTest.scala in KRaft mode

2023-10-09 Thread Deng Ziming (Jira)
Deng Ziming created KAFKA-15566: --- Summary: Klaky tests in FetchRequestTest.scala in KRaft mode Key: KAFKA-15566 URL: https://issues.apache.org/jira/browse/KAFKA-15566 Project: Kafka Issue Type:

Re: [PR] Kraft support for Integration Tests [kafka]

2023-10-09 Thread via GitHub
dengziming commented on PR #14295: URL: https://github.com/apache/kafka/pull/14295#issuecomment-1752533154 I find that there are many flaky tests in `FetchRequestTest.scala`, can you help investigating them @mannoopj . https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14295/4/#s

Re: [PR] Kraft support for Integration Tests [kafka]

2023-10-09 Thread via GitHub
dengziming merged PR #14295: URL: https://github.com/apache/kafka/pull/14295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
iit2009060 commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752515026 @hudeqi There is one test case failing related to the above change https://github.com/apache/kafka/pull/14381, can you help me resolving it , in the local it is not failing ? -- Th

Re: [PR] KAFKA-15560: Upgrade argparse4j to 0.9.0 [kafka]

2023-10-09 Thread via GitHub
divijvaidya commented on PR #14507: URL: https://github.com/apache/kafka/pull/14507#issuecomment-1752509517 > Changed to only have to have JDK 9 (or higher) for building. We cannot pick up 0.9 version change because we still support JDK 8 (see README.md at the root of this project).

[jira] [Commented] (KAFKA-15560) Upgrade argparse4j to 0.9.0

2023-10-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773158#comment-17773158 ] Divij Vaidya commented on KAFKA-15560: -- We cannot pick up moving to 0.9 version cha

Re: [PR] KAFKA-15536:Dynamically resize remoteIndexCache [kafka]

2023-10-09 Thread via GitHub
hudeqi commented on code in PR #14511: URL: https://github.com/apache/kafka/pull/14511#discussion_r1349931016 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -554,6 +554,115 @@ class RemoteIndexCacheTest { assertTrue(cache.internalCache().esti

Re: [PR] KAFKA-15536:Dynamically resize remoteIndexCache [kafka]

2023-10-09 Thread via GitHub
hudeqi commented on code in PR #14511: URL: https://github.com/apache/kafka/pull/14511#discussion_r1349931417 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -554,6 +554,115 @@ class RemoteIndexCacheTest { assertTrue(cache.internalCache().esti

<    1   2