[jira] [Updated] (KAFKA-15593) Add 3.6.0 to broker/client upgrade/compatibility tests

2023-10-11 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15593: --- Fix Version/s: 3.7.0 > Add 3.6.0 to broker/client upgrade/compatibility tests >

[jira] [Assigned] (KAFKA-15593) Add 3.6.0 to broker/client upgrade/compatibility tests

2023-10-11 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-15593: -- Assignee: Satish Duggana > Add 3.6.0 to broker/client upgrade/compatibility tests >

[jira] [Created] (KAFKA-15593) Add 3.6.0 to broker/client upgrade/compatibility tests

2023-10-11 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15593: -- Summary: Add 3.6.0 to broker/client upgrade/compatibility tests Key: KAFKA-15593 URL: https://issues.apache.org/jira/browse/KAFKA-15593 Project: Kafka

[jira] [Created] (KAFKA-15594) Add 3.6.0 to streams upgrade/compatibility tests

2023-10-11 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15594: -- Summary: Add 3.6.0 to streams upgrade/compatibility tests Key: KAFKA-15594 URL: https://issues.apache.org/jira/browse/KAFKA-15594 Project: Kafka Issue

Re: [PR] MINOR: add quick start for tiered storage feature [kafka]

2023-10-11 Thread via GitHub
kamalcph commented on code in PR #14528: URL: https://github.com/apache/kafka/pull/14528#discussion_r1356064302 ## docs/ops.html: ## @@ -3984,27 +3984,73 @@ Configurations Example +Quick Start Example + +Apache Kafka doesn't provide an out-of-the-box RemoteStorageManager

Re: [PR] MINOR: add quick start for tiered storage feature [kafka]

2023-10-11 Thread via GitHub
kamalcph commented on code in PR #14528: URL: https://github.com/apache/kafka/pull/14528#discussion_r1356064302 ## docs/ops.html: ## @@ -3984,27 +3984,73 @@ Configurations Example +Quick Start Example + +Apache Kafka doesn't provide an out-of-the-box RemoteStorageManager

Re: [PR] MINOR Updated documentation.html to have 3.5 and 3.6 previous release doc links [kafka]

2023-10-11 Thread via GitHub
satishd merged PR #14510: URL: https://github.com/apache/kafka/pull/14510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-11 Thread via GitHub
yashmayya commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1356053586 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356041608 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356044046 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -847,11 +847,11 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356043842 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -413,7 +413,7 @@ public static void before()

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356044046 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -847,11 +847,11 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356043842 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -413,7 +413,7 @@ public static void before()

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on PR #14523: URL: https://github.com/apache/kafka/pull/14523#issuecomment-1758892421 > Thanks for extending this test. This is very helpful. > > I am wondering, if it would be beneficial to add more input record, such that a few windows have more than one

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356042346 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356041608 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

[jira] [Assigned] (KAFKA-15301) [Tiered Storage] Historically compacted topics send request to remote for active segment during consume

2023-10-11 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Wang reassigned KAFKA-15301: -- Assignee: Jimmy Wang > [Tiered Storage] Historically compacted topics send request to remote

[jira] [Updated] (KAFKA-15592) Member does not need to always try to join a group when a groupId is configured

2023-10-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15592: --- Parent: KAFKA-14048 Issue Type: Sub-task (was: Bug) > Member does not need to always try

[jira] [Created] (KAFKA-15592) Member does not need to always try to join a group when a groupId is configured

2023-10-11 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15592: -- Summary: Member does not need to always try to join a group when a groupId is configured Key: KAFKA-15592 URL: https://issues.apache.org/jira/browse/KAFKA-15592 Project:

Re: [PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

2023-10-11 Thread via GitHub
philipnee commented on PR #14532: URL: https://github.com/apache/kafka/pull/14532#issuecomment-1758856125 @cadonna @mjsax @lucasbru - Any one of you would be interested in reviewing this PR? I think this is a fairly straightforward patch. -- This is an automated message from the Apache

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
showuon merged PR #14484: URL: https://github.com/apache/kafka/pull/14484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-11 Thread via GitHub
philipnee commented on PR #14390: URL: https://github.com/apache/kafka/pull/14390#issuecomment-1758845137 Hello @dajac @lianetm @kirktrue - I think the scope of this PR extended a bit beyond "replacing GroupState" because we've realized the member may join/leave the group anytime during

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
showuon commented on PR #14484: URL: https://github.com/apache/kafka/pull/14484#issuecomment-1758844798 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1355991839 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15492: Enable spotbugs when building with Java 21 [kafka]

2023-10-11 Thread via GitHub
ijuma commented on PR #14533: URL: https://github.com/apache/kafka/pull/14533#issuecomment-1758815150 Looks like the new version is not in the Maven repo yet. Will remove draft once that's resolved. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] KAFKA-15492: Enable spotbugs when building with Java 21 [kafka]

2023-10-11 Thread via GitHub
ijuma opened a new pull request, #14533: URL: https://github.com/apache/kafka/pull/14533 Update to spotbugs 4.8.0, changelog: https://github.com/spotbugs/spotbugs/blob/4.8.0/CHANGELOG.md ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[jira] [Assigned] (KAFKA-15492) Enable spotbugs when building with Java 21

2023-10-11 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-15492: --- Assignee: Ismael Juma > Enable spotbugs when building with Java 21 >

[jira] [Commented] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-10-11 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774288#comment-17774288 ] Jimmy Wang commented on KAFKA-15388: Hi [~christo_lolov]  I hope you're doing well. I wanted to ask

[jira] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-10-11 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388 ] Jimmy Wang deleted comment on KAFKA-15388: was (Author: JIRAUSER300327): Hi [~christo_lolov] , Have you worked on this issue? If not, I would like to give it a try. Thanks so much. >

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-11 Thread via GitHub
rbaddam commented on PR #14491: URL: https://github.com/apache/kafka/pull/14491#issuecomment-1758769891 Hi @mjsax, @jlprat, @satishd, @jolshan, @raboof, @dajac, Would any of you be available to review this new PR I raised? Your insights and suggestions would be very helpful.

Re: [PR] [MINOR] More image replay test cases [kafka]

2023-10-11 Thread via GitHub
ahuang98 commented on code in PR #14206: URL: https://github.com/apache/kafka/pull/14206#discussion_r1355932210 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -627,10 +629,13 @@ public void testTopicDualWriteDelta() throws

Re: [PR] [MINOR] More image replay test cases [kafka]

2023-10-11 Thread via GitHub
ahuang98 commented on code in PR #14206: URL: https://github.com/apache/kafka/pull/14206#discussion_r1355932210 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -627,10 +629,13 @@ public void testTopicDualWriteDelta() throws

Re: [PR] KAFKA-15355: Message schema changes [kafka]

2023-10-11 Thread via GitHub
soarez commented on code in PR #14290: URL: https://github.com/apache/kafka/pull/14290#discussion_r1355927097 ## generator/src/main/java/org/apache/kafka/message/FieldSpec.java: ## @@ -157,11 +157,6 @@ private void checkTagInvariants() { this.taggedVersions

[jira] [Created] (KAFKA-15591) Trogdor produce workload reports errors in KRaft mode

2023-10-11 Thread Xi Yang (Jira)
Xi Yang created KAFKA-15591: --- Summary: Trogdor produce workload reports errors in KRaft mode Key: KAFKA-15591 URL: https://issues.apache.org/jira/browse/KAFKA-15591 Project: Kafka Issue Type: Bug

Re: [PR] MINOR: Fix `KafkaStreams#streamThreadLeaveConsumerGroup` logging [kafka]

2023-10-11 Thread via GitHub
ableegoldman merged PR #14526: URL: https://github.com/apache/kafka/pull/14526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-11 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-15571: --- Fix Version/s: 3.5.2 3.7.0 3.6.1 >

[jira] [Resolved] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-11 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-15571. Resolution: Fixed > StateRestoreListener#onRestoreSuspended is never

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-11 Thread via GitHub
ableegoldman commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1758665862 Merged to trunk and will backport to 3.6 and 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-11 Thread via GitHub
ableegoldman merged PR #14519: URL: https://github.com/apache/kafka/pull/14519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-11 Thread via GitHub
ableegoldman commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1758663469 By the way, make sure to format the PR titles exactly as recommended -- there are some integrations that regex match and rely on this (you had a slash `/` instead of a colon `:`)

[jira] [Comment Edited] (KAFKA-15566) Klaky tests in FetchRequestTest.scala in KRaft mode

2023-10-11 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774251#comment-17774251 ] Justine Olshan edited comment on KAFKA-15566 at 10/11/23 10:24 PM: --- I

[jira] [Commented] (KAFKA-15566) Klaky tests in FetchRequestTest.scala in KRaft mode

2023-10-11 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774251#comment-17774251 ] Justine Olshan commented on KAFKA-15566: I closed my ticket. These are not flaky and failing

[jira] [Resolved] (KAFKA-15589) Flaky kafka.server.FetchRequestTest

2023-10-11 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-15589. Resolution: Duplicate Duplicate of https://issues.apache.org/jira/browse/KAFKA-15566 >

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-11 Thread via GitHub
jolshan commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1758628495 Disabled the failing tests as this is a known issue: https://github.com/apache/kafka/pull/14525 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: Disable flaky kraft-test in FetchRequestTest [kafka]

2023-10-11 Thread via GitHub
jolshan merged PR #14525: URL: https://github.com/apache/kafka/pull/14525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Kraft support for Integration Tests [kafka]

2023-10-11 Thread via GitHub
jolshan commented on PR #14295: URL: https://github.com/apache/kafka/pull/14295#issuecomment-1758626352 Ah I also filed a JIRA for this. They are not flaky and failing on most builds. I don't think we should have merged this. https://issues.apache.org/jira/browse/KAFKA-15589. We should

[jira] [Updated] (KAFKA-15590) Replica.updateFetchStateOrThrow should also fence updates with stale leader epoch

2023-10-11 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-15590: --- Summary: Replica.updateFetchStateOrThrow should also fence updates with stale leader epoch (was:

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-11 Thread via GitHub
CalvinConfluent commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1758611548 @splett2 @hachikuji Ticket created https://issues.apache.org/jira/browse/KAFKA-15590 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (KAFKA-15590) Replica.updateFetchState should also fence updates with stale leader epoch

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15590: -- Summary: Replica.updateFetchState should also fence updates with stale leader epoch Key: KAFKA-15590 URL: https://issues.apache.org/jira/browse/KAFKA-15590 Project:

[PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

2023-10-11 Thread via GitHub
philipnee opened a new pull request, #14532: URL: https://github.com/apache/kafka/pull/14532 Several places in the code, we relies on making a system time call to get the response time. This is not ideal because these system calls can add up. Instead, time is already retrieved on the top

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355750615 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -44,7 +44,6 @@ def setUp(self): self.trogdor.start() if self.zk:

[jira] [Created] (KAFKA-15589) Flaky kafka.server.FetchRequestTest

2023-10-11 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-15589: -- Summary: Flaky kafka.server.FetchRequestTest Key: KAFKA-15589 URL: https://issues.apache.org/jira/browse/KAFKA-15589 Project: Kafka Issue Type: Task

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-11 Thread via GitHub
jolshan commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1758474606 I also filed: https://issues.apache.org/jira/browse/KAFKA-15589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-11 Thread via GitHub
jolshan commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1758466564 AK builds have not been happy lately :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2023-10-11 Thread via GitHub
jimbogithub commented on PR #14531: URL: https://github.com/apache/kafka/pull/14531#issuecomment-1758458826 See https://issues.apache.org/jira/browse/KAFKA-14546 for rationale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2023-10-11 Thread via GitHub
jimbogithub opened a new pull request, #14531: URL: https://github.com/apache/kafka/pull/14531 Allow custom Partitioners to fallback to default partitioning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15576: Add 3.6 to core upgrade and compatibility tests [kafka]

2023-10-11 Thread via GitHub
mjsax commented on PR #14527: URL: https://github.com/apache/kafka/pull/14527#issuecomment-1758413129 Seems this does not cover KS -- btw: there is some issue for KS system tests right now, and as a matter of fact, we did not even add the missing upgrade tests in older release yet (PR is

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355666083 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1):

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355663593 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1):

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355653216 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -764,6 +769,9 @@ def prop_file(self, node): else:

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355652198 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -407,6 +411,7 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI

[jira] [Updated] (KAFKA-15588) Purge the unsent offset commits/fetches when the member is fenced

2023-10-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15588: --- Labels: kip-848 kip-848-client-support kip-848-e2e (was: ) > Purge the unsent offset

[jira] [Updated] (KAFKA-15588) Purge the unsent offset commits/fetches when the member is fenced

2023-10-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15588: --- Parent: KAFKA-14048 Issue Type: Sub-task (was: Bug) > Purge the unsent offset

[jira] [Created] (KAFKA-15588) Purge the unsent offset commits/fetches when the member is fenced

2023-10-11 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15588: -- Summary: Purge the unsent offset commits/fetches when the member is fenced Key: KAFKA-15588 URL: https://issues.apache.org/jira/browse/KAFKA-15588 Project: Kafka

[jira] [Comment Edited] (KAFKA-14546) Allow Partitioner to return -1 to indicate default partitioning

2023-10-11 Thread James Olsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774202#comment-17774202 ] James Olsen edited comment on KAFKA-14546 at 10/11/23 7:11 PM: --- I'm still

[jira] [Comment Edited] (KAFKA-14546) Allow Partitioner to return -1 to indicate default partitioning

2023-10-11 Thread James Olsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774202#comment-17774202 ] James Olsen edited comment on KAFKA-14546 at 10/11/23 7:09 PM: --- I'm still

[jira] [Commented] (KAFKA-14546) Allow Partitioner to return -1 to indicate default partitioning

2023-10-11 Thread James Olsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774202#comment-17774202 ] James Olsen commented on KAFKA-14546: - I'm still hoping for a solution to this issue.  I can

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355617795 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1): self.logger.debug("Produce

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355617795 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1): self.logger.debug("Produce

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355435960 ## tests/kafkatest/services/kafka/config.py: ## @@ -28,7 +28,8 @@ class KafkaConfig(dict): config_property.METADATA_LOG_SEGMENT_BYTES: str(9*1024*1024), # 9 MB

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355605756 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1): self.logger.debug("Produce

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-11 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1355561775 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -709,6 +727,16 @@ public void complete(Throwable

[jira] [Created] (KAFKA-15587) Limit the number of records per batch in GroupCoordinatorShard#cleanupGroupMetadata

2023-10-11 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-15587: Summary: Limit the number of records per batch in GroupCoordinatorShard#cleanupGroupMetadata Key: KAFKA-15587 URL: https://issues.apache.org/jira/browse/KAFKA-15587 Project:

Re: [PR] MINOR: Upgrade Gradle wrapper to version 8.4 [kafka]

2023-10-11 Thread via GitHub
ijuma commented on code in PR #14502: URL: https://github.com/apache/kafka/pull/14502#discussion_r1355560355 ## gradlew: ## @@ -214,11 +215,11 @@ fi # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-11 Thread via GitHub
jeffkbkim commented on PR #14467: URL: https://github.com/apache/kafka/pull/14467#issuecomment-1758248999 created https://issues.apache.org/jira/browse/KAFKA-15587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-11 Thread via GitHub
C0urante commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1355538647 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Upgrade gradle to 8.4 [kafka]

2023-10-11 Thread via GitHub
ijuma closed pull request #14530: MINOR: Upgrade gradle to 8.4 URL: https://github.com/apache/kafka/pull/14530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] MINOR: Upgrade gradle to 8.4 [kafka]

2023-10-11 Thread via GitHub
ijuma commented on PR #14530: URL: https://github.com/apache/kafka/pull/14530#issuecomment-1758243845 I missed that. We can close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (KAFKA-15586) Clean shutdown detection, server side

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15586: -- Summary: Clean shutdown detection, server side Key: KAFKA-15586 URL: https://issues.apache.org/jira/browse/KAFKA-15586 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-15585) DescribeTopic API

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15585: -- Summary: DescribeTopic API Key: KAFKA-15585 URL: https://issues.apache.org/jira/browse/KAFKA-15585 Project: Kafka Issue Type: Sub-task Reporter:

[jira] [Created] (KAFKA-15584) ELR leader election

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15584: -- Summary: ELR leader election Key: KAFKA-15584 URL: https://issues.apache.org/jira/browse/KAFKA-15584 Project: Kafka Issue Type: Sub-task Reporter:

[jira] [Created] (KAFKA-15583) High watermark can only advance if ISR size is larger than min ISR

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15583: -- Summary: High watermark can only advance if ISR size is larger than min ISR Key: KAFKA-15583 URL: https://issues.apache.org/jira/browse/KAFKA-15583 Project: Kafka

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
dajac commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355512521 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1): self.logger.debug("Produce

[jira] [Created] (KAFKA-15582) Clean shutdown detection, broker side

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15582: -- Summary: Clean shutdown detection, broker side Key: KAFKA-15582 URL: https://issues.apache.org/jira/browse/KAFKA-15582 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-15581) Introduce ELR

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15581: -- Summary: Introduce ELR Key: KAFKA-15581 URL: https://issues.apache.org/jira/browse/KAFKA-15581 Project: Kafka Issue Type: Sub-task Reporter: Calvin

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-11 Thread via GitHub
dajac commented on PR #14467: URL: https://github.com/apache/kafka/pull/14467#issuecomment-1758200615 @jeffkbkim Could you please file a JIRA for the max record size case? We will need to find a solution for this at some point. -- This is an automated message from the Apache Git Service.

[jira] [Updated] (KAFKA-15332) Eligible Leader Replicas

2023-10-11 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-15332: --- Description: A root ticket for the KIP-966 The KIP has accepted

[jira] [Updated] (KAFKA-15332) Eligible Leader Replicas

2023-10-11 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-15332: --- Description: A root ticket for the KIP-966 The KIP has accepted

[jira] [Created] (KAFKA-15580) KIP-966: Unclean Recovery

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15580: -- Summary: KIP-966: Unclean Recovery Key: KAFKA-15580 URL: https://issues.apache.org/jira/browse/KAFKA-15580 Project: Kafka Issue Type: New Feature

  1   2   >