[jira] [Commented] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781069#comment-17781069 ] Ismael Juma commented on KAFKA-15754: - [~jolshan] I think this issue can happen if s

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376569126 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -602,36 +546,37 @@ public void testRestartConnectorAndT

Re: [PR] KAFKA-15695: Update the local log start offset of a log after rebuilding the auxiliary state [kafka]

2023-10-30 Thread via GitHub
nikramakrishnan commented on PR #14649: URL: https://github.com/apache/kafka/pull/14649#issuecomment-1785694098 Thanks for your comments, @divijvaidya, @kamalcph, @satishd. I have addressed your comments, please review! -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-15695: Update the local log start offset of a log after rebuilding the auxiliary state [kafka]

2023-10-30 Thread via GitHub
nikramakrishnan commented on code in PR #14649: URL: https://github.com/apache/kafka/pull/14649#discussion_r1376562518 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/LocalLogStartOffsetTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software F

Re: [PR] KAFKA-15695: Update the local log start offset of a log after rebuilding the auxiliary state [kafka]

2023-10-30 Thread via GitHub
nikramakrishnan commented on code in PR #14649: URL: https://github.com/apache/kafka/pull/14649#discussion_r1376560901 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/LocalLogStartOffsetTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781061#comment-17781061 ] Justine Olshan commented on KAFKA-15754: Hey [~ppatierno] sorry you encountered

[jira] [Assigned] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2023-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-15573: -- Assignee: Lianet Magrans > Implement auto-commit on partition assignment revocation >

[jira] [Resolved] (KAFKA-15539) Client should stop fetching while partitions being revoked

2023-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15539. Resolution: Duplicate > Client should stop fetching while partitions being revoked > -

[jira] [Assigned] (KAFKA-15539) Client should stop fetching while partitions being revoked

2023-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-15539: -- Assignee: Lianet Magrans (was: Kirk True) > Client should stop fetching while partit

[jira] [Updated] (KAFKA-15574) Update states and transitions for membership manager state machine

2023-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to update the state machine so that it correctly acts as the glue

Re: [PR] MINOR: Remove ambiguous constructor [kafka]

2023-10-30 Thread via GitHub
cadonna commented on PR #14598: URL: https://github.com/apache/kafka/pull/14598#issuecomment-1785652776 @kirktrue While I agree having a complete object at construction time is something worth pursuing, in this specific case the completion callback references the unsent request object. An e

Re: [PR] KAFKA-15355: Message schema changes [kafka]

2023-10-30 Thread via GitHub
rondagostino commented on code in PR #14290: URL: https://github.com/apache/kafka/pull/14290#discussion_r1376334060 ## clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java: ## @@ -19,7 +19,7 @@ /** * An exception that may indicate the client's me

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376522158 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -127,94 +134,86 @@ private enum SourceSink { n

[jira] [Resolved] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2023-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15573. Resolution: Duplicate > Implement auto-commit on partition assignment revocation > ---

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376517329 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -281,45 +274,38 @@ public void testDestroyConnector() t

Re: [PR] KAFKA-15643: Fix error logged when unload is called on a broker that was never a coordinator. [kafka]

2023-10-30 Thread via GitHub
rreddy-22 commented on code in PR #14657: URL: https://github.com/apache/kafka/pull/14657#discussion_r1376517081 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1359,7 +1359,8 @@ public void scheduleUnloadOperation(

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376516820 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -281,45 +274,38 @@ public void testDestroyConnector() t

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376517843 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -127,94 +134,86 @@ private enum SourceSink { n

Re: [PR] KAFKA-15643: Fix error logged when unload is called on a broker that was never a coordinator. [kafka]

2023-10-30 Thread via GitHub
rreddy-22 commented on code in PR #14657: URL: https://github.com/apache/kafka/pull/14657#discussion_r1376515172 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1370,7 +1371,9 @@ public void scheduleUnloadOperation(

[jira] [Resolved] (KAFKA-15753) KRaft support in BrokerApiVersionsCommandTest

2023-10-30 Thread Sameer Tejani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer Tejani resolved KAFKA-15753. --- Resolution: Duplicate > KRaft support in BrokerApiVersionsCommandTest >

[jira] [Commented] (KAFKA-15753) KRaft support in BrokerApiVersionsCommandTest

2023-10-30 Thread Sameer Tejani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781048#comment-17781048 ] Sameer Tejani commented on KAFKA-15753: --- You're right, thanks for pointing it out

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

2023-10-30 Thread via GitHub
artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376507019 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

2023-10-30 Thread via GitHub
artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376502780 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376493619 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -656,48 +600,40 @@ public void testRestartConnectorAndT

Re: [PR] KAFKA-15428: Cluster-wide dynamic log adjustments for Connect [kafka]

2023-10-30 Thread via GitHub
C0urante commented on code in PR #14538: URL: https://github.com/apache/kafka/pull/14538#discussion_r1360796008 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15693: Immediately reassign lost connectors and tasks when scheduled rebalance delay is disabled [kafka]

2023-10-30 Thread via GitHub
vamossagar12 commented on code in PR #14647: URL: https://github.com/apache/kafka/pull/14647#discussion_r1376482532 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -463,6 +464,14 @@ protected void handleLos

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376484462 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -602,36 +546,37 @@ public void testRestartConnectorAndT

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376483865 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -528,72 +483,61 @@ public void testRestartConnectorAndT

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

2023-10-30 Thread via GitHub
jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376481605 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-10-30 Thread via GitHub
C0urante commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1376416990 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -528,72 +483,61 @@ public void testRestartConnectorAndTas

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376422951 ## docker/resources/common-scripts/configure: ## @@ -0,0 +1,147 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376408368 ## docker/resources/common-scripts/kafka-propertiesSpec.json: ## @@ -0,0 +1,25 @@ +{ + "prefixes": { +"KAFKA": false, +"CONFLUENT": true + }, + "ren

[jira] (KAFKA-13965) Document broker-side socket-server-metrics

2023-10-30 Thread Jay Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13965 ] Jay Wang deleted comment on KAFKA-13965: -- was (Author: JIRAUSER302731): Took ticket and working on it. I think below need to be added: * connection-accept-throttle-time * connection-accept-ra

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376400897 ## docker/jvm/Dockerfile: ## @@ -0,0 +1,101 @@ +### +# Licensed to the Apache Soft

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376399971 ## docker/jvm/Dockerfile: ## @@ -0,0 +1,101 @@ +### +# Licensed to the Apache Soft

Re: [PR] KAFKA-15562: ensure commit request manager handles errors correctly [kafka]

2023-10-30 Thread via GitHub
philipnee commented on PR #14639: URL: https://github.com/apache/kafka/pull/14639#issuecomment-1785408525 @lucasbru - Thanks for taking time reviewing this PR. I addressed your previous comment. Let me know if there's anything unclear on this PR. -- This is an automated message from the A

Re: [PR] KAFKA-15693: Immediately reassign lost connectors and tasks when scheduled rebalance delay is disabled [kafka]

2023-10-30 Thread via GitHub
C0urante commented on code in PR #14647: URL: https://github.com/apache/kafka/pull/14647#discussion_r1376363059 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -463,6 +464,14 @@ protected void handleLostAss

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376346564 ## docker/docker_release.py: ## @@ -0,0 +1,80 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376346564 ## docker/docker_release.py: ## @@ -0,0 +1,80 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] KAFKA-15562: ensure commit request manager handles errors correctly [kafka]

2023-10-30 Thread via GitHub
philipnee commented on code in PR #14639: URL: https://github.com/apache/kafka/pull/14639#discussion_r1376339956 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -215,16 +296,117 @@ public NetworkClientDelegate.UnsentRequest

Re: [PR] Kafka 15680 [kafka]

2023-10-30 Thread via GitHub
C0urante commented on PR #14630: URL: https://github.com/apache/kafka/pull/14630#issuecomment-1785353764 @kumarpritam863 I understand that the code changes are small, and I'm glad to hear that pre-prod testing indicates that this commit has the intended effect. However, I still think that u

[PR] KAFKA-15740: KRaft support in DeleteOffsetsConsumerGroupCommandIntegrationTest [kafka]

2023-10-30 Thread via GitHub
linzihao1999 opened a new pull request, #14669: URL: https://github.com/apache/kafka/pull/14669 The tests in DeleteOffsetsConsumerGroupCommandIntegrationTest in core/src/test/scala/unit/kafka/admin/DeleteOffsetsConsumerGroupCommandIntegrationTest.scala update to support KRaft. ### Co

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
Lucent-Wong commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1376291255 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1335,7 +1339,7 @@ private[group] class GroupCoordinator( // Failed to

[jira] [Created] (KAFKA-15755) LeaveGroupResponse v0-v2 should handle no members

2023-10-30 Thread Robert Wagner (Jira)
Robert Wagner created KAFKA-15755: - Summary: LeaveGroupResponse v0-v2 should handle no members Key: KAFKA-15755 URL: https://issues.apache.org/jira/browse/KAFKA-15755 Project: Kafka Issue Typ

[PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]

2023-10-30 Thread via GitHub
linzihao1999 opened a new pull request, #14668: URL: https://github.com/apache/kafka/pull/14668 The tests in DescribeConsumerGroupTest in core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala update to support KRaft. ### Committer Checklist (excluded from commit messag

[jira] [Comment Edited] (KAFKA-13965) Document broker-side socket-server-metrics

2023-10-30 Thread Jay Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780743#comment-17780743 ] Jay Wang edited comment on KAFKA-13965 at 10/30/23 1:10 PM:

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2023-10-30 Thread via GitHub
Owen-CH-Leung commented on code in PR #14645: URL: https://github.com/apache/kafka/pull/14645#discussion_r1376191766 ## release.py: ## @@ -730,7 +730,7 @@ def select_gpg_key(): fail("Ok, giving up") if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag): fail("Ok, g

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2023-10-30 Thread via GitHub
Owen-CH-Leung commented on code in PR #14645: URL: https://github.com/apache/kafka/pull/14645#discussion_r1376191766 ## release.py: ## @@ -730,7 +730,7 @@ def select_gpg_key(): fail("Ok, giving up") if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag): fail("Ok, g

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2023-10-30 Thread via GitHub
Owen-CH-Leung commented on code in PR #14645: URL: https://github.com/apache/kafka/pull/14645#discussion_r1376191766 ## release.py: ## @@ -730,7 +730,7 @@ def select_gpg_key(): fail("Ok, giving up") if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag): fail("Ok, g

Re: [PR] KAFKA-15432:RLM Stop partitions should not be invoked for non-tiered storage topics [kafka]

2023-10-30 Thread via GitHub
divijvaidya commented on code in PR #14667: URL: https://github.com/apache/kafka/pull/14667#discussion_r1376157216 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -630,13 +630,17 @@ class ReplicaManager(val config: KafkaConfig, // Third delete the logs and

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
sanjay-awatramani commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376147150 ## docker/resources/common-scripts/configure: ## @@ -0,0 +1,147 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
sanjay-awatramani commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376140333 ## docker/jvm/Dockerfile: ## @@ -0,0 +1,101 @@ +### +# Licensed to the Apache Sof

Re: [PR] KAFKA-15445: [WIP] Add JVM Docker image [kafka]

2023-10-30 Thread via GitHub
sanjay-awatramani commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1376137680 ## docker/jvm/Dockerfile: ## @@ -0,0 +1,101 @@ +### +# Licensed to the Apache Sof

[jira] [Commented] (KAFKA-15038) Use topic id/name mapping from the Metadata cache in the RemoteLogManager

2023-10-30 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780989#comment-17780989 ] Owen C.H. Leung commented on KAFKA-15038: - Hi [~hudeqi] , Yes I'm still working

Re: [PR] MINOR: Rename log dir UUIDs [kafka]

2023-10-30 Thread via GitHub
soarez commented on PR #14517: URL: https://github.com/apache/kafka/pull/14517#issuecomment-1784988208 Thank you for reviewing and merging @dengziming 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

2023-10-30 Thread via GitHub
vamossagar12 commented on code in PR #14327: URL: https://github.com/apache/kafka/pull/14327#discussion_r1376038092 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -669,7 +668,12 @@ private void throwIfConsumerGroupHeartbeat

Re: [PR] MINOR: Rename log dir UUIDs [kafka]

2023-10-30 Thread via GitHub
dengziming merged PR #14517: URL: https://github.com/apache/kafka/pull/14517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[jira] [Commented] (KAFKA-15753) KRaft support in BrokerApiVersionsCommandTest

2023-10-30 Thread Zihao Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780959#comment-17780959 ] Zihao Lin commented on KAFKA-15753: --- Hi This issue looks like been fixed. > KRaft su

Re: [PR] KAFKA-14133: Migrate ProcessorStateManagerTest and StreamThreadTest to Mockito [kafka]

2023-10-30 Thread via GitHub
clolov commented on PR #13932: URL: https://github.com/apache/kafka/pull/13932#issuecomment-1784954065 The pull request is still relevant! Don't review it for now, I will rebase once more and address any outstanding comments and ping you when ready. -- This is an automated message from th

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
vamossagar12 commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1375947390 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala: ## @@ -609,7 +609,7 @@ class GroupMetadataTest { @Test def testReplaceGroupInsta

[jira] [Assigned] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paolo Patierno reassigned KAFKA-15754: -- Assignee: Paolo Patierno > The kafka-storage tool can generate UUID starting with "-"

[jira] [Comment Edited] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780949#comment-17780949 ] Paolo Patierno edited comment on KAFKA-15754 at 10/30/23 10:54 AM: ---

[jira] [Comment Edited] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780949#comment-17780949 ] Paolo Patierno edited comment on KAFKA-15754 at 10/30/23 10:39 AM: ---

[jira] [Commented] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780949#comment-17780949 ] Paolo Patierno commented on KAFKA-15754: While I could provide a fix by using th

[jira] [Updated] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paolo Patierno updated KAFKA-15754: --- Description: Using the kafka-storage.sh tool, it seems that it can still generate a UUID st

[jira] [Updated] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paolo Patierno updated KAFKA-15754: --- Description: Using the kafka-storage.sh tool, it seems that it can still generate a UUID st

[jira] [Created] (KAFKA-15754) The kafka-storage tool can generate UUID starting with "-"

2023-10-30 Thread Paolo Patierno (Jira)
Paolo Patierno created KAFKA-15754: -- Summary: The kafka-storage tool can generate UUID starting with "-" Key: KAFKA-15754 URL: https://issues.apache.org/jira/browse/KAFKA-15754 Project: Kafka

[jira] [Resolved] (KAFKA-15689) KRaftMigrationDriver not logging the skipped event when expected state is wrong

2023-10-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15689. --- Fix Version/s: 3.7.0 Resolution: Fixed > KRaftMigrationDriver not logging the skipped event w

Re: [PR] KAFKA-15689: Logging skipped event when expected migration state is wrong [kafka]

2023-10-30 Thread via GitHub
showuon merged PR #14646: URL: https://github.com/apache/kafka/pull/14646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
vamossagar12 commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1375947390 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala: ## @@ -609,7 +609,7 @@ class GroupMetadataTest { @Test def testReplaceGroupInsta

Re: [PR] MINOR: Using INFO level for logging the state transition during the ZooKeeper to KRaft migration [kafka]

2023-10-30 Thread via GitHub
showuon merged PR #14651: URL: https://github.com/apache/kafka/pull/14651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Using INFO level for logging the state transition during the ZooKeeper to KRaft migration [kafka]

2023-10-30 Thread via GitHub
showuon commented on PR #14651: URL: https://github.com/apache/kafka/pull/14651#issuecomment-1784844755 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-15632: Drop the invalid remote log metadata events [kafka]

2023-10-30 Thread via GitHub
satishd commented on PR #14576: URL: https://github.com/apache/kafka/pull/14576#issuecomment-1784839263 @showuon @clolov It looks like the comments have been addressed. Do you have any other comments on this PR? -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (KAFKA-15686) Consumer should be able to detect network problem

2023-10-30 Thread Jiahongchao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780930#comment-17780930 ] Jiahongchao commented on KAFKA-15686: - It's helpful, but from this metric it's hard

Re: [PR] KAFKA-15695: Update the local log start offset of a log after rebuilding the auxiliary state [kafka]

2023-10-30 Thread via GitHub
satishd commented on code in PR #14649: URL: https://github.com/apache/kafka/pull/14649#discussion_r1375930372 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1754,6 +1754,7 @@ class UnifiedLog(@volatile var logStartOffset: Long, leaderEpochCache.foreach(_.cle

Re: [PR] MINOR: Fix typo [kafka]

2023-10-30 Thread via GitHub
divijvaidya merged PR #14665: URL: https://github.com/apache/kafka/pull/14665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2023-10-30 Thread via GitHub
divijvaidya commented on code in PR #14645: URL: https://github.com/apache/kafka/pull/14645#discussion_r1375892033 ## release.py: ## @@ -80,9 +80,9 @@ def fail(msg): if delete_gitrefs: try: -cmd("Resetting repository working state to branch %s" % sta

[PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
Lucent-Wong opened a new pull request, #14666: URL: https://github.com/apache/kafka/pull/14666 Problem statement: In static membership protocol, the clientId and clientHost are not changed when static member is replaced. This will make it confused for user when describe the consumer

[jira] [Assigned] (KAFKA-15687) Update host address for the GoupMetadata when replace static members

2023-10-30 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang reassigned KAFKA-15687: --- Assignee: Yu Wang > Update host address for the GoupMetadata when replace static members >

[PR] MINOR: Fix typo [kafka]

2023-10-30 Thread via GitHub
wushujames opened a new pull request, #14665: URL: https://github.com/apache/kafka/pull/14665 Fix typo in a comment ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify docume

Re: [PR] [WIP]KAFKA-15444: Native docker image [kafka]

2023-10-30 Thread via GitHub
VedarthConfluent commented on code in PR #14556: URL: https://github.com/apache/kafka/pull/14556#discussion_r1375771218 ## docker/test/requirements.txt: ## @@ -0,0 +1,6 @@ +confluent_kafka Review Comment: This suggestion has been incorporated. Now we are using CLI scripts in

Re: [PR] KAFKA-15562: ensure commit request manager handles errors correctly [kafka]

2023-10-30 Thread via GitHub
lucasbru commented on code in PR #14639: URL: https://github.com/apache/kafka/pull/14639#discussion_r1375757133 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -215,16 +296,117 @@ public NetworkClientDelegate.UnsentRequest t

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2023-10-30 Thread via GitHub
Owen-CH-Leung commented on PR #14645: URL: https://github.com/apache/kafka/pull/14645#issuecomment-1784605103 @divijvaidya Can I get your feedback for this PR ? Many Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

<    1   2