cadonna commented on PR #14912:
URL: https://github.com/apache/kafka/pull/14912#issuecomment-1843369990
Failures are unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
hanyuzheng7 commented on code in PR #14906:
URL: https://github.com/apache/kafka/pull/14906#discussion_r1417716664
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -254,12 +255,12 @@ private QueryResult runRangeQuery(final Query
hanyuzheng7 commented on code in PR #14906:
URL: https://github.com/apache/kafka/pull/14906#discussion_r1417713307
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, fina
hanyuzheng7 commented on code in PR #14906:
URL: https://github.com/apache/kafka/pull/14906#discussion_r1417710159
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, fina
dajac commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417699258
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoComm
hanyuzheng7 commented on code in PR #14906:
URL: https://github.com/apache/kafka/pull/14906#discussion_r1417693358
##
docs/streams/upgrade-guide.html:
##
@@ -136,7 +136,7 @@ <
Streams API changes in 3.7.0
IQv2 supports RangeQuery that allows to specify
unbou
dajac commented on PR #12065:
URL: https://github.com/apache/kafka/pull/12065#issuecomment-1843299429
@dengziming Are you still interested in doing this? It would be great to fix
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lianetm commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1843296141
@philipnee agree on leaving the membership manager determine the epoch to
use to leave group. That's already in the [state
machine](https://github.com/apache/kafka/blob/adcbdaca72a3484d72
AndrewJSchofield opened a new pull request, #14945:
URL: https://github.com/apache/kafka/pull/14945
In the new consumer, the commit request manager and the membership manager
are separate components. The commit request manager is initialised with group
information that it uses to construct
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1417658955
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -653,12 +653,15 @@ public DeadlineAndEpoch metadataRefreshDeadlin
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1843269344
@junrao Build passed with unrelated flaky tests failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1417650715
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -778,18 +783,23 @@ public void testGroupIdNull() {
@Tes
dajac merged PR #14687:
URL: https://github.com/apache/kafka/pull/14687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
philipnee commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417647914
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
sw
philipnee commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417647206
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
sw
[
https://issues.apache.org/jira/browse/KAFKA-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15910.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> New group coordinator needs to generate snapshot
dajac merged PR #14849:
URL: https://github.com/apache/kafka/pull/14849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
soarez commented on PR #14838:
URL: https://github.com/apache/kafka/pull/14838#issuecomment-1843250009
@rondagostino I'm trying to figure the test failures out, I've not yet been
able to reproduce any failures locally.
--
This is an automated message from the Apache Git Service.
To respon
tledkov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1417629458
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/CsvUtils.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on PR #14925:
URL: https://github.com/apache/kafka/pull/14925#issuecomment-1843245379
> The latest build failed for disk full 😆
I discussed this with the INFRA team. Here is what I got:
> Due to a whole heap of builds by mainly Kafka and KIE hogging executors -
dajac merged PR #14931:
URL: https://github.com/apache/kafka/pull/14931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
kirktrue commented on PR #14931:
URL: https://github.com/apache/kafka/pull/14931#issuecomment-1843227108
@dajac—failing tests appear unrelated. Do we need four green builds before
merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15027:
Labels: kip (was: )
> Implement rack aware assignment for standby tasks
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15024:
Labels: kip (was: )
> Add cost function for task/client
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15054:
Labels: kip (was: )
> Add configs and logic to decide if rack aware assignment should be
[
https://issues.apache.org/jira/browse/KAFKA-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15025:
Labels: kip (was: )
> Implement min-cost flow without balancing tasks for same subtopolog
[
https://issues.apache.org/jira/browse/KAFKA-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax closed KAFKA-15026.
---
> Implement min-cost flow balancing tasks for same subtopology
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15023:
Labels: kip (was: )
> Get rack information for source topic partitions for a task
> -
[
https://issues.apache.org/jira/browse/KAFKA-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15026:
Labels: kip (was: )
> Implement min-cost flow balancing tasks for same subtopology
>
[
https://issues.apache.org/jira/browse/KAFKA-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15026.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> Implement min-cost flow balancing tasks
[
https://issues.apache.org/jira/browse/KAFKA-15022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15022.
-
Fix Version/s: 3.7.0
3.6.0
Resolution: Fixed
> Support rack aw
mjsax merged PR #14921:
URL: https://github.com/apache/kafka/pull/14921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-15348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15348:
Labels: kip (was: )
> Range IQs with versioned state stores
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15347.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> Single-Key_multi-timestamp IQs with vers
[
https://issues.apache.org/jira/browse/KAFKA-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15346:
Labels: kip (was: )
> Single-Key_single-timestamp IQs with versioned state stores
> -
[
https://issues.apache.org/jira/browse/KAFKA-15347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15347:
Labels: kip (was: )
> Single-Key_multi-timestamp IQs with versioned state stores
> --
mjsax merged PR #14626:
URL: https://github.com/apache/kafka/pull/14626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cadonna opened a new pull request, #14944:
URL: https://github.com/apache/kafka/pull/14944
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
lucasbru commented on PR #14937:
URL: https://github.com/apache/kafka/pull/14937#issuecomment-1843148936
Yes, I think using events is much clearer. @kirktrue do you agree with this
approach? Then I'd suggest we close the other PR and continue with this one.
--
This is an automated message
tledkov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1417541595
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -593,6 +593,16 @@ public static String join(T[] strs, String separator) {
return join
lucasbru commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1417532026
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -778,18 +783,23 @@ public void testGroupIdNull() {
@Test
soarez commented on PR #14943:
URL: https://github.com/apache/kafka/pull/14943#issuecomment-1843136280
@cmccabe @rondagostino PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
soarez opened a new pull request, #14943:
URL: https://github.com/apache/kafka/pull/14943
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade no
lucasbru commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417523313
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerTestBuilder.java:
##
@@ -331,34 +331,35 @@ public
AsyncKafkaConsumerTestBuilder(Optional
rondagostino commented on PR #14838:
URL: https://github.com/apache/kafka/pull/14838#issuecomment-1843104348
[Still 110 failing
tests](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14838/14/tests),
which seems like a lot, especially since
https://github
soarez commented on PR #14942:
URL: https://github.com/apache/kafka/pull/14942#issuecomment-1843100363
@rondagostino @cmccabe @pprovenzano please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mwesterby opened a new pull request, #14942:
URL: https://github.com/apache/kafka/pull/14942
Adds a new metric, QueuedReplicaToDirAssignments, which, when queried, will
return the total number of replica to directory assignments that are currently
queued in the AssignmentsManager.
##
lucasbru commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417484146
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
swa
Andrew Schofield created KAFKA-15978:
Summary: New consumer sends OffsetCommit with empty member ID
Key: KAFKA-15978
URL: https://issues.apache.org/jira/browse/KAFKA-15978
Project: Kafka
clolov commented on PR #14832:
URL: https://github.com/apache/kafka/pull/14832#issuecomment-1843067050
Heya @satishd and @showuon! I hope I have addressed your comments with the
latest commits 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
AndrewJSchofield commented on PR #14925:
URL: https://github.com/apache/kafka/pull/14925#issuecomment-1843058587
The latest build failed for disk full 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wcarlson5 merged PR #14924:
URL: https://github.com/apache/kafka/pull/14924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
AndrewJSchofield commented on code in PR #14926:
URL: https://github.com/apache/kafka/pull/14926#discussion_r1417454887
##
tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java:
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
wcarlson5 merged PR #14916:
URL: https://github.com/apache/kafka/pull/14916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
AndrewJSchofield commented on code in PR #14926:
URL: https://github.com/apache/kafka/pull/14926#discussion_r1417454119
##
tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java:
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
aiven-anton commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1417450738
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -14,14 +14,16 @@
// limitations under the License.
// Version 1 adds Zk broke
VedarthConfluent opened a new pull request, #14941:
URL: https://github.com/apache/kafka/pull/14941
This PR adds Github Actions Workflow for promoting an RC docker image to
final release. It makes the process of releasing docker image more streamlined,
as discussed in
[KIP-975](https://cwi
VedarthConfluent opened a new pull request, #14940:
URL: https://github.com/apache/kafka/pull/14940
This PR will add a Github Actions Workflow, that will help in publishing RC
docker image that can be reviewed and voted on by the community, as mentioned
in
[KIP-975](https://cwiki.apache.or
lucasbru opened a new pull request, #14939:
URL: https://github.com/apache/kafka/pull/14939
`DelegationTokenEndToEndAuthorizationWithOwnerTest` can leak a thread,
causing problems with many tests.
This is due to an admin client that isn't being closed when a (flaky) test
fails. Using
[
https://issues.apache.org/jira/browse/KAFKA-15977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-15977:
--
Assignee: Lucas Brutschy
> DelegationTokenEndToEndAuthorizationWithOwnerTest leaks th
lucasbru merged PR #14878:
URL: https://github.com/apache/kafka/pull/14878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #14878:
URL: https://github.com/apache/kafka/pull/14878#issuecomment-1842982496
Test failures are unrelated.
There are a lot of tests caused by an unrelated test leaking an admin client
thread in one build due to a flaky test. I created
https://issues.apache.
[
https://issues.apache.org/jira/browse/KAFKA-15977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15977:
---
Description:
[https://ci-builds.apache.org/blue/rest/organizations/jenkins/pipelines/Kafka/p
Lucas Brutschy created KAFKA-15977:
--
Summary: DelegationTokenEndToEndAuthorizationWithOwnerTest leaks
threads
Key: KAFKA-15977
URL: https://issues.apache.org/jira/browse/KAFKA-15977
Project: Kafka
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1417380722
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -14,14 +14,16 @@
// limitations under the License.
// Version 1 adds Zk broker epo
soarez commented on code in PR #14926:
URL: https://github.com/apache/kafka/pull/14926#discussion_r1417345140
##
tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java:
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
VedarthConfluent opened a new pull request, #14938:
URL: https://github.com/apache/kafka/pull/14938
This PR will add user documentation and examples for the docker image as
described in
[KIP-975](https://cwiki.apache.org/confluence/display/KAFKA/KIP-975%3A+Docker+Image+for+Apache+Kafka)
[
https://issues.apache.org/jira/browse/KAFKA-15879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vedarth Sharma updated KAFKA-15879:
---
Summary: Add documentation and examples for the Docker image (was: Add
documentation for th
[
https://issues.apache.org/jira/browse/KAFKA-15879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vedarth Sharma updated KAFKA-15879:
---
Description:
AC:-
* Update quickstart with docker image details and docker section in getti
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1417285321
##
core/src/test/scala/integration/kafka/api/MetricsTest.scala:
##
@@ -320,16 +320,28 @@ class MetricsTest extends IntegrationTestHarness with
SaslSetup {
assertTr
msn-tldr commented on PR #14916:
URL: https://github.com/apache/kafka/pull/14916#issuecomment-1842857934
@wcarlson5 The failures are unrelated check here
https://ge.apache.org/s/ul2ost2737xbg/tests/overview?outcome=FAILED
--
This is an automated message from the Apache Git Service.
To r
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1417191376
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1417188902
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -299,7 +329,7 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417143188
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -513,4 +513,28 @@ public void close() throws InterruptedException {
eventHandl
satishd merged PR #14905:
URL: https://github.com/apache/kafka/pull/14905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #14905:
URL: https://github.com/apache/kafka/pull/14905#issuecomment-1842685829
Jenkins test failures are unrelated to this PR, merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
satishd commented on code in PR #14905:
URL: https://github.com/apache/kafka/pull/14905#discussion_r1417134578
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1443,11 +1443,14 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* @return the segments ready to b
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417129195
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -513,4 +513,28 @@ public void close() throws InterruptedException {
eventHandl
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417124246
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -513,4 +513,28 @@ public void close() throws InterruptedException {
eventHandl
[
https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793645#comment-17793645
]
Omnia Ibrahim commented on KAFKA-15853:
---
[~fvaleri] Am still working on it it's ne
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417121867
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,14 @@ class BrokerLifecycleManagerTest {
result
}
- def poll[T](
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417116727
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+ /**
lucasbru commented on code in PR #14936:
URL: https://github.com/apache/kafka/pull/14936#discussion_r1417082199
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -79,6 +84,10 @@ private class StateUpdaterThread extends Thread {
lucasbru commented on PR #14922:
URL: https://github.com/apache/kafka/pull/14922#issuecomment-1842617271
Ah, I think you are using fetch deadlines to avoid calling the RPC forever.
That makes sense. But then, we can probably still just keep a single deadline
(the max of all calls) and a sin
lucasbru commented on code in PR #14922:
URL: https://github.com/apache/kafka/pull/14922#discussion_r1417077988
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -713,6 +727,48 @@ boolean runLoop() {
return true;
}
+
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1842612531
@mimaison Thanks for the review I'll to this asap by the end of day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AndrewJSchofield commented on code in PR #14926:
URL: https://github.com/apache/kafka/pull/14926#discussion_r1417070856
##
tools/src/test/java/org/apache/kafka/tools/ClientMetricsCommandTest.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
omkreddy merged PR #14552:
URL: https://github.com/apache/kafka/pull/14552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #14935:
URL: https://github.com/apache/kafka/pull/14935#discussion_r1417064532
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##
@@ -65,6 +69,9 @@ public class GlobalStreamThread extends Thread {
AndrewJSchofield commented on code in PR #14926:
URL: https://github.com/apache/kafka/pull/14926#discussion_r1417065760
##
tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java:
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
lucasbru commented on code in PR #14922:
URL: https://github.com/apache/kafka/pull/14922#discussion_r1417036886
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -1477,6 +1533,29 @@ public Object getStateLock() {
return state
jlprat commented on PR #14816:
URL: https://github.com/apache/kafka/pull/14816#issuecomment-1842584596
@cmccabe
https://github.com/apache/kafka/blob/83110e2d425b49fed8ad5fdc6e93579423c73289/metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java#L158
is where you can fi
Ashwin Pankaj created KAFKA-15976:
-
Summary: KIP-995: Allow users to specify initial offsets while
creating connectors
Key: KAFKA-15976
URL: https://issues.apache.org/jira/browse/KAFKA-15976
Project:
[
https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793602#comment-17793602
]
Federico Valeri edited comment on KAFKA-15853 at 12/6/23 9:57 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793602#comment-17793602
]
Federico Valeri edited comment on KAFKA-15853 at 12/6/23 9:55 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793602#comment-17793602
]
Federico Valeri commented on KAFKA-15853:
-
[~omnia_h_ibrahim] I have a tools PR
fvaleri commented on PR #14847:
URL: https://github.com/apache/kafka/pull/14847#issuecomment-1842545770
@showuon it is called when you instantiate the KafkaConfig object, so it's
the constructor:
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaConfig.scala#L
AndrewJSchofield commented on code in PR #14912:
URL: https://github.com/apache/kafka/pull/14912#discussion_r1417011418
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -966,22 +967,25 @@ private void
testUpdateFetchPositio
lucasbru commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416992430
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -198,6 +219,17 @@ public long maximumTimeToWait(long currentTi
cadonna commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416983368
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -103,6 +103,12 @@ public class HeartbeatRequestManager implemen
101 - 200 of 211 matches
Mail list logo
