clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1417285321
##########
core/src/test/scala/integration/kafka/api/MetricsTest.scala:
##########
@@ -320,16 +320,28 @@ class MetricsTest extends IntegrationTestHarness with
SaslSetup {
assertTrue(metrics.isEmpty, s"$errorMessage: ${metrics.keys}")
}
+ private def fromNameToBrokerTopicStatsMBean(name: String): String = {
+ s"kafka.server:type=BrokerTopicMetrics,name=$name"
+ }
+
private def verifyRemoteStorageMetrics(shouldContainMetrics: Boolean): Unit
= {
val metrics = RemoteStorageMetrics.allMetrics().asScala.filter(name =>
KafkaYammerMetrics.defaultRegistry.allMetrics.asScala.find(metric => {
metric._1.getMBeanName().equals(name.getMBeanName)
}).isDefined
).toList
+ val aggregatedBrokerTopicStats = Set(BrokerTopicStats.RemoteCopyLagBytes)
Review Comment:
Correct! I will add a few of the other metrics in the KIP via this
aggregator - I just wanted to start with one to see whether people agree with
it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
