clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1417191376
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
meter.close()
}
- def close(): Unit = metricTypeMap.values.foreach(_.close())
+ def close(): Unit = {
+ metricTypeMap.values.foreach(_.close())
+ metricGaugeTypeMap.values.foreach(_.close())
+ }
+}
+
+class BrokerTopicAggregatedMetric() {
+ private val partitionMetricValues = collection.concurrent.TrieMap[Int,
Long]()
Review Comment:
To be honest, I was looking for a concurrent implementation in Scala world
and this is all I found -
https://www.scala-lang.org/api/2.13.11/scala/collection/concurrent/index.html.
I shall swap it for a concurrent map from Java world!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
