[PR] MINOR: Use docker buildx to promote docker image [kafka]

VedarthConfluent opened a new pull request, #14974: URL: https://github.com/apache/kafka/pull/14974 Use docker buildx to promote the image. This action is already being used in Release Candidate workflow. ### Committer Checklist (excluded from commit message) - [ ] Verify design an

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

dajac commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1420064193 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -971,12 +989,59 @@ private CompletableFuture invokeOnPartitionsLos

[PR] MINOR: Fix raft-metrics descriptions at docs/ops.html [kafka]

tkuramoto33 opened a new pull request, #14973: URL: https://github.com/apache/kafka/pull/14973 [The current documentation](https://kafka.apache.org/36/documentation/#kraft_quorum_monitoring ) has descriptions of raft-metrics like the following. > kafka.server:type=raft-metrics,name

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420051909 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -34,7 +31,16 @@ public class LogicalSegmentIterator implements Versi

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

dajac commented on PR #14857: URL: https://github.com/apache/kafka/pull/14857#issuecomment-1846677800 @lianetm The last build failed with some compilation issue. Could you please address them? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] MINOR: Avoid leaking threads in DelegationTokenEndToEndAuthorizationWithOwnerTest.testDescribeTokenForOtherUserFails [kafka]

dajac merged PR #14959: URL: https://github.com/apache/kafka/pull/14959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15911: making sure the follower is making progress [kafka]

showuon commented on code in PR #14971: URL: https://github.com/apache/kafka/pull/14971#discussion_r1420033396 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -129,16 +135,46 @@ public void updateCheckQuorumForFollowingVoter(int id, long currentTimeMs) {

Re: [PR] Revert "MINOR: Add junit properties to display parameterized test names (#14687)" [kafka]

dajac commented on PR #14961: URL: https://github.com/apache/kafka/pull/14961#issuecomment-1846673486 @alok123t Are you interested in giving it another try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Revert "MINOR: Add junit properties to display parameterized test names (#14687)" [kafka]

dajac merged PR #14961: URL: https://github.com/apache/kafka/pull/14961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Use regctl in docker image promote workflow [kafka]

omkreddy merged PR #14972: URL: https://github.com/apache/kafka/pull/14972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Use regctl in docker image promote workflow [kafka]

omkreddy commented on PR #14972: URL: https://github.com/apache/kafka/pull/14972#issuecomment-1846672373 Merging as this only githuib action change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] MINOR: Use regctl in docker image promote workflow [kafka]

VedarthConfluent opened a new pull request, #14972: URL: https://github.com/apache/kafka/pull/14972 Docker Image Promote github Actions Workflow was using crane github action, which is not allowed to run in apache github actions. So now using [regctl](https://github.com/marketplace/actions/

[PR] KAFKA-15911: making sure the follower is making progress [kafka]

showuon opened a new pull request, #14971: URL: https://github.com/apache/kafka/pull/14971 Just because the leader returned a successful response to FETCH and FETCH_SNAPSHOT doesn't mean that the followers were able to handle the response correctly. For example, imagine the case wher

Re: [PR] KAFKA-15883: Implement RemoteCopyLagBytes [kafka]

kamalcph commented on PR #14832: URL: https://github.com/apache/kafka/pull/14832#issuecomment-1846574284 Will review the patch by today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KAFKA-15364: Handle log directory failure in the Controller [kafka]

cmccabe commented on PR #14902: URL: https://github.com/apache/kafka/pull/14902#issuecomment-1846549181 Thanks for the PR. A few important points: * We can't put mutable sets (like `HashSet`) in a timeline data structures. It breaks the invariants. *Only* immutable data structures can

[PR] KAFKA-15714: KRaft support in DynamicNumNetworkThreadsTest [kafka]

phong260702 opened a new pull request, #14970: URL: https://github.com/apache/kafka/pull/14970 The following tests in DynamicNumNetworkThreadsTest in core/src/test/scala/integration/kafka/network/DynamicNumNetworkThreadsTest.scala need to be updated to support KRaft ### Committer Che

Re: [PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

hanyuzheng7 commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1846532869 > @hanyuzheng7 Thanks for the KIP and implementation. Maybe align the variable names with what you introduced in the KIP (or the other way around)? `newTimeFrom/To` -> `timeFrom/To` `

[PR] Native docker image kafka 15444 [kafka]

kagarwal06 opened a new pull request, #14969: URL: https://github.com/apache/kafka/pull/14969 This PR aims to add Apache Kafka Native Docker image as per the following [KIP-974](https://cwiki.apache.org/confluence/display/KAFKA/KIP-974%3A+Docker+Image+for+GraalVM+based+Native+Kafka+Broker).

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

lianetm commented on PR #14857: URL: https://github.com/apache/kafka/pull/14857#issuecomment-1846507735 Closing/re-opening to trigger the build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

lianetm closed pull request #14857: KAFKA-15574; [2/N]: Client state machine updates URL: https://github.com/apache/kafka/pull/14857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] MINOR: Improve KRaftMigrationZkWriter test coverage [kafka]

github-actions[bot] commented on PR #13802: URL: https://github.com/apache/kafka/pull/13802#issuecomment-1846498639 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

hachikuji commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419880301 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceL

Re: [PR] KAFKA-15365: Broker-side replica management changes [kafka]

rondagostino commented on PR #14881: URL: https://github.com/apache/kafka/pull/14881#issuecomment-1846430171 @OmniaGM can you resolve the conflicts here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

rondagostino merged PR #14790: URL: https://github.com/apache/kafka/pull/14790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

rondagostino commented on PR #14790: URL: https://github.com/apache/kafka/pull/14790#issuecomment-1846426477 `66 tests have failed. There are 33 new tests failing, 33 existing failing.` Many of them are common issues in recent build, and I ran several other test classes locally -- they a

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

artemlivshits commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419832287 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -976,6 +975,231 @@ class ReplicaManager(val config: KafkaConfig, } } + /** + * Append

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419813957 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceLoc

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

hachikuji commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419811977 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceL

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419795598 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -971,12 +989,59 @@ private CompletableFuture invokeOnPartitions

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419786380 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceLoc

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419786380 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceLoc

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419782648 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419770188 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -941,39 +851,209 @@ class ReplicaManager(val config: KafkaConfig, } } - private def partition

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

hachikuji commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419770109 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceL

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

hachikuji commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419770109 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceL

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419769846 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -941,39 +851,209 @@ class ReplicaManager(val config: KafkaConfig, } } - private def partition

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419768887 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -180,12 +179,12 @@ private void process(final ListOff

Re: [PR] KAFKA-15629: Support ResultOrder to TimestampedRangeQuery. [kafka]

mjsax merged PR #14907: URL: https://github.com/apache/kafka/pull/14907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15629: Support ResultOrder to TimestampedRangeQuery. [kafka]

mjsax commented on code in PR #14907: URL: https://github.com/apache/kafka/pull/14907#discussion_r1419763796 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java: ## @@ -254,12 +255,12 @@ private QueryResult runRangeQuery(final Query quer

Re: [PR] KAFKA-15629: Support ResultOrder to TimestampedRangeQuery. [kafka]

mjsax commented on code in PR #14907: URL: https://github.com/apache/kafka/pull/14907#discussion_r1419762701 ## streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java: ## @@ -100,17 +99,25 @@ public boolean isKeyAscending() { * @return a new RangeQ

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on PR #14958: URL: https://github.com/apache/kafka/pull/14958#issuecomment-1846252181 PR need to be rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on code in PR #14958: URL: https://github.com/apache/kafka/pull/14958#discussion_r1419755463 ## docs/streams/upgrade-guide.html: ## @@ -134,6 +134,24 @@ < Streams API changes in 3.7.0 + +IQv2 supports MultiVersionedKeyQuery (introduced in

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on code in PR #14958: URL: https://github.com/apache/kafka/pull/14958#discussion_r1419757044 ## docs/streams/upgrade-guide.html: ## @@ -134,6 +134,24 @@ < Streams API changes in 3.7.0 + +IQv2 supports MultiVersionedKeyQuery (introduced in

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on code in PR #14958: URL: https://github.com/apache/kafka/pull/14958#discussion_r1419756415 ## docs/streams/upgrade-guide.html: ## @@ -134,6 +134,24 @@ < Streams API changes in 3.7.0 + +IQv2 supports MultiVersionedKeyQuery (introduced in

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on code in PR #14958: URL: https://github.com/apache/kafka/pull/14958#discussion_r1419756273 ## docs/streams/upgrade-guide.html: ## @@ -134,6 +134,24 @@ < Streams API changes in 3.7.0 + +IQv2 supports MultiVersionedKeyQuery (introduced in

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419756648 ## core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala: ## @@ -168,8 +168,37 @@ object AbstractCoordinatorConcurrencyTest { watch

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on code in PR #14958: URL: https://github.com/apache/kafka/pull/14958#discussion_r1419755463 ## docs/streams/upgrade-guide.html: ## @@ -134,6 +134,24 @@ < Streams API changes in 3.7.0 + +IQv2 supports MultiVersionedKeyQuery (introduced in

Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]

mjsax commented on code in PR #14958: URL: https://github.com/apache/kafka/pull/14958#discussion_r1419754832 ## docs/streams/upgrade-guide.html: ## @@ -134,6 +134,24 @@ < Streams API changes in 3.7.0 + +IQv2 supports MultiVersionedKeyQuery (introduced in

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419754322 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceLoc

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419750410 ## core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala: ## @@ -168,8 +168,37 @@ object AbstractCoordinatorConcurrencyTest { watch

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419750410 ## core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala: ## @@ -168,8 +168,37 @@ object AbstractCoordinatorConcurrencyTest { watch

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

hachikuji commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419739785 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int, delayedProduceL

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

mjsax commented on code in PR #14936: URL: https://github.com/apache/kafka/pull/14936#discussion_r1419743348 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -772,6 +817,26 @@ public Set getStandbyTasks() { ); }

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

rondagostino commented on PR #14790: URL: https://github.com/apache/kafka/pull/14790#issuecomment-1846221720 Ah, ok, we can keep it as it is, then. WiIl wait for build to finish and them merge assuming the test failures can be discounted. -- This is an automated message from the Apache G

[jira] [Updated] (KAFKA-15981) only record GenericGroup state metrics once per group during load

[ https://issues.apache.org/jira/browse/KAFKA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-15981: - Description: Currently, we increment generic group metrics whenever we create a new GenericGroup object

[PR] Minor: JBOD migration [kafka]

pprovenzano opened a new pull request, #14968: URL: https://github.com/apache/kafka/pull/14968 Minor changes to allow migration with JBOD enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15906: Emit latest MM2 offset syncs every offset.flush.interval.ms [kafka]

gharris1727 commented on PR #14967: URL: https://github.com/apache/kafka/pull/14967#issuecomment-1846192427 Hi @urbandan @C0urante could you PTAL at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] KAFKA-15906: Emit latest MM2 offset syncs every offset.flush.interval.ms [kafka]

gharris1727 opened a new pull request, #14967: URL: https://github.com/apache/kafka/pull/14967 MirrorMaker2 defines the `offset.lag.max` configuration, which defines a target interval between offset syncs emitted to the offset syncs topics. The actual number of offset syncs may be mor

Re: [PR] MINOR: Remove `SubscribedTopicRegex` field from `ConsumerGroupHeartbeatRequest` [kafka]

jeffkbkim commented on PR #14956: URL: https://github.com/apache/kafka/pull/14956#issuecomment-1846189539 is the corresponding jira https://issues.apache.org/jira/browse/KAFKA-14517? if so, maybe we can mention this PR in the jira -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on code in PR #14937: URL: https://github.com/apache/kafka/pull/14937#discussion_r1418128177 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1024,15 +1037,14 @@ private void close(Duration timeout, boolean

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

OmniaGM commented on PR #14790: URL: https://github.com/apache/kafka/pull/14790#issuecomment-1846172826 > @OmniaGM The commit is worded as `KAFKA-15363: Broker log directory failure changes`. Is this correct? The branch is `KAFKA-15357`. So I'm a bit confused as to what is correct. The

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1846153413 Hi @kirktrue @lucasbru - Sorry about the huge PR. But I've addressed most of your comments if not all (apologize if not). I've left comments on places where a bit more discussions are

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on code in PR #14937: URL: https://github.com/apache/kafka/pull/14937#discussion_r1419688648 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -315,7 +315,8 @@ public void testFetcherCloseClosesFetchSessi

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on code in PR #14937: URL: https://github.com/apache/kafka/pull/14937#discussion_r1419688146 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -810,89 +854,87 @@ public void testGroupMetadataAfterCreation

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on code in PR #14937: URL: https://github.com/apache/kafka/pull/14937#discussion_r1419685035 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -82,6 +82,7 @@ public PollResult poll(long currentTimeMs) {

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

soarez commented on PR #14790: URL: https://github.com/apache/kafka/pull/14790#issuecomment-1846145896 @rondagostino: The branch name is wrong/misleading. This is the JIRA https://issues.apache.org/jira/browse/KAFKA-15363 -- This is an automated message from the Apache Git Service

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on code in PR #14937: URL: https://github.com/apache/kafka/pull/14937#discussion_r1419683491 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -178,27 +171,11 @@ static void runAtClose(final Collection> req

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

philipnee commented on code in PR #14937: URL: https://github.com/apache/kafka/pull/14937#discussion_r1419683219 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1050,6 +1060,85 @@ private void close(Duration timeout, boolean

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419681488 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -976,6 +975,231 @@ class ReplicaManager(val config: KafkaConfig, } } + /** + * Append messa

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

hachikuji commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419677251 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -976,6 +975,231 @@ class ReplicaManager(val config: KafkaConfig, } } + /** + * Append mes

[jira] [Commented] (KAFKA-15843) Review consumer onPartitionsAssigned called with empty partitions

[ https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794436#comment-17794436 ] Lianet Magrans commented on KAFKA-15843: Hey [~ableegoldman] , thanks a lot for

[jira] [Assigned] (KAFKA-15906) Emit offset syncs more often than offset.lag.max for low-throughput/finite partitions

[ https://issues.apache.org/jira/browse/KAFKA-15906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-15906: --- Assignee: Greg Harris > Emit offset syncs more often than offset.lag.max for low-throughput

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

rondagostino commented on PR #14790: URL: https://github.com/apache/kafka/pull/14790#issuecomment-1846126373 @OmniaGM The commit is worded as `KAFKA-15363: Broker log directory failure changes`. Is this correct? The branch is `KAFKA-15357`. So I'm a bit confused as to what is correct. T

[jira] [Commented] (KAFKA-15985) Mirrormaker 2 offset sync is incomplete

[ https://issues.apache.org/jira/browse/KAFKA-15985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794433#comment-17794433 ] Greg Harris commented on KAFKA-15985: - Hi [~Reamer] The default value of `offset.lag

Re: [PR] KAFKA-15022: tests for HA assignor and StickyTaskAssignor [kafka]

lihaosky commented on PR #14921: URL: https://github.com/apache/kafka/pull/14921#issuecomment-1846123923 Fixing in https://github.com/apache/kafka/pull/14965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-15978: Update member information on HB response [kafka]

AndrewJSchofield closed pull request #14945: KAFKA-15978: Update member information on HB response URL: https://github.com/apache/kafka/pull/14945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15978: Update member information on HB response [kafka]

AndrewJSchofield commented on PR #14945: URL: https://github.com/apache/kafka/pull/14945#issuecomment-1846120099 Closing and re-opening PR to rebuild. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] KAFKA-15988: Reuse embedded clusters across test cases in Connect OffsetsApiIntegrationTest suite [kafka]

C0urante opened a new pull request, #14966: URL: https://github.com/apache/kafka/pull/14966 [Jira](https://issues.apache.org/jira/browse/KAFKA-15988) Using a similar approach to the existing [ConnectorRestartApiIntegrationTest suite](https://github.com/apache/kafka/blob/c062e5a1f91f44

Re: [PR] KAFKA-15977: Fix leak in DelegationTokenEndToEndAuthorizationWithOwnerTest [kafka]

lucasbru merged PR #14939: URL: https://github.com/apache/kafka/pull/14939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15977: Fix leak in DelegationTokenEndToEndAuthorizationWithOwnerTest [kafka]

lucasbru commented on PR #14939: URL: https://github.com/apache/kafka/pull/14939#issuecomment-1846074979 Test failures unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

lucasbru commented on code in PR #14922: URL: https://github.com/apache/kafka/pull/14922#discussion_r1419615776 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -713,6 +723,44 @@ boolean runLoop() { return true; } +

Re: [PR] KAFKA-15364: Handle log directory failure in the Controller [kafka]

rondagostino commented on PR #14902: URL: https://github.com/apache/kafka/pull/14902#issuecomment-1846025840 @soarez Can you rebase this now that https://github.com/apache/kafka/pull/14863 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] Rackaware assignment tests fix [kafka]

lihaosky opened a new pull request, #14965: URL: https://github.com/apache/kafka/pull/14965 Assignment shouldn't remain the same for balanced strategy since we use max flow to recalculate the assignment first ### Committer Checklist (excluded from commit message) - [ ] Verify desig

[jira] [Created] (KAFKA-15988) Kafka Connect OffsetsApiIntegrationTest takes too long

Chris Egerton created KAFKA-15988: - Summary: Kafka Connect OffsetsApiIntegrationTest takes too long Key: KAFKA-15988 URL: https://issues.apache.org/jira/browse/KAFKA-15988 Project: Kafka Issu

Re: [PR] KAFKA-15426: Process and persist directory assignments [kafka]

cmccabe commented on PR #14863: URL: https://github.com/apache/kafka/pull/14863#issuecomment-1845996759 committed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] KAFKA-15563: Provide informative error messages when Connect REST requests time out [kafka]

C0urante commented on PR #14562: URL: https://github.com/apache/kafka/pull/14562#issuecomment-1845996495 Thanks Greg! I've made one final tweak to the integration tests. Hoping this doesn't affect test stability; will merge if things look alright on Jenkins. -- This is an automated messag

Re: [PR] KAFKA-15426: Process and persist directory assignments [kafka]

cmccabe closed pull request #14863: KAFKA-15426: Process and persist directory assignments URL: https://github.com/apache/kafka/pull/14863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-15563: Provide informative error messages when Connect REST requests time out [kafka]

C0urante commented on code in PR #14562: URL: https://github.com/apache/kafka/pull/14562#discussion_r1419525430 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -771,6 +779,114 @@ private Map defaultSinkConnectorProp

Re: [PR] KAFKA-15426: Process and persist directory assignments [kafka]

cmccabe commented on code in PR #14863: URL: https://github.com/apache/kafka/pull/14863#discussion_r1419522832 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2016,6 +2021,70 @@ ListPartitionReassignmentsResponseData listPartitionRea

Re: [PR] MINOR: Support to update Async Consumer group member label (KIP-714) [kafka]

mjsax merged PR #14946: URL: https://github.com/apache/kafka/pull/14946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419471126 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -169,7 +169,7 @@ class PlaintextConsumerTest extends BaseConsumerTest { starting

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419470226 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -790,6 +812,197 @@ public void testOnSubscriptionUpdatedTra

[jira] [Updated] (KAFKA-15846) Review consumer leave group request best effort

[ https://issues.apache.org/jira/browse/KAFKA-15846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15846: --- Description: New consumer sends out a leave group request with a best effort approach. Trans

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419469606 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -790,6 +812,197 @@ public void testOnSubscriptionUpdatedTra

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419466482 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -790,6 +812,197 @@ public void testOnSubscriptionUpdatedTra

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419466253 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackCompletedEvent.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

jolshan commented on code in PR #14774: URL: https://github.com/apache/kafka/pull/14774#discussion_r1419463731 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -941,39 +851,209 @@ class ReplicaManager(val config: KafkaConfig, } } - private def partition

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419463055 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -180,12 +179,12 @@ private void process(final ListOff

Re: [PR] KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks [kafka]

kirktrue commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1419459827 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -979,12 +1026,124 @@ private CompletableFuture invokeOnPartitio

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

mjsax commented on PR #14922: URL: https://github.com/apache/kafka/pull/14922#issuecomment-1845908617 Thanks. Will address the comment in a follow up PR and merge this as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   3   >