Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
junrao commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1460103407 ## server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java: ## @@ -14,10 +14,11 @@ * See the License for the specific language

[jira] [Updated] (KAFKA-16180) Full metadata request sometimes fails during zk migration

2024-01-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16180: - Description: Example: {code} java.util.NoSuchElementException:

[jira] [Updated] (KAFKA-16180) Full metadata request sometimes fails during zk migration

2024-01-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16180: - Description: Example: {code} java.util.NoSuchElementException:

[jira] [Created] (KAFKA-16180) Full metadata request sometimes fails during zk migration

2024-01-19 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16180: Summary: Full metadata request sometimes fails during zk migration Key: KAFKA-16180 URL: https://issues.apache.org/jira/browse/KAFKA-16180 Project: Kafka

Re: [PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-19 Thread via GitHub
gharris1727 commented on code in PR #15233: URL: https://github.com/apache/kafka/pull/15233#discussion_r1459984454 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java: ## @@ -132,7 +127,6 @@ public void stop() { */ public void cancel() {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459837546 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459839177 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459839177 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459839177 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459868777 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -187,16 +197,69 @@ object ConsumerGroupCommand extends Logging { } def listGroups():

Re: [PR] MINOR: Note that Java 11 support for broker and tools is deprecated for removal in 4.0 (KIP-1013) [kafka]

2024-01-19 Thread via GitHub
ijuma merged PR #15236: URL: https://github.com/apache/kafka/pull/15236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459842466 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -187,16 +197,69 @@ object ConsumerGroupCommand extends Logging { } def listGroups():

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459840877 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459839177 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459837546 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -46,16 +46,16 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { },

[jira] [Created] (KAFKA-16179) NPE handle ApiVersions during controller failover

2024-01-19 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-16179: --- Summary: NPE handle ApiVersions during controller failover Key: KAFKA-16179 URL: https://issues.apache.org/jira/browse/KAFKA-16179 Project: Kafka

[jira] [Commented] (KAFKA-15826) WorkerSinkTask leaks Consumer if plugin start or stop blocks indefinitely

2024-01-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808804#comment-17808804 ] Greg Harris commented on KAFKA-15826: - The BlockingConnectorTest which was leaking the client in our

[jira] [Assigned] (KAFKA-15826) WorkerSinkTask leaks Consumer if plugin start or stop blocks indefinitely

2024-01-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-15826: --- Assignee: (was: Greg Harris) > WorkerSinkTask leaks Consumer if plugin start or stop

Re: [PR] KAFKA-15827: Prevent KafkaBasedLog subclasses from leaking passed-in clients [kafka]

2024-01-19 Thread via GitHub
gharris1727 merged PR #14763: URL: https://github.com/apache/kafka/pull/14763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15827: Prevent KafkaBasedLog subclasses from leaking passed-in clients [kafka]

2024-01-19 Thread via GitHub
gharris1727 commented on PR #14763: URL: https://github.com/apache/kafka/pull/14763#issuecomment-1901092298 Test failures appear unrelated, and the runtime tests pass locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-01-19 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808801#comment-17808801 ] Philip Nee commented on KAFKA-16178: Seems to be an issue with the RequestState - I wonder if we've

[jira] [Updated] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-01-19 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-16178: Description: {code:java} [2024-01-17 21:34:59,500] INFO [Consumer

[jira] [Updated] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-01-19 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-16178: Description: {code:java} [2024-01-17 21:34:59,500] INFO [Consumer

[jira] [Updated] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-01-19 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-16178: Description: [2024-01-17 21:34:59,500] INFO [Consumer

[jira] [Created] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-01-19 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16178: --- Summary: AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator Key: KAFKA-16178 URL: https://issues.apache.org/jira/browse/KAFKA-16178

Re: [PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-19 Thread via GitHub
C0urante commented on code in PR #15233: URL: https://github.com/apache/kafka/pull/15233#discussion_r1459683206 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java: ## @@ -132,7 +127,6 @@ public void stop() { */ public void cancel() {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459664849 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -21,95 +21,111 @@ import java.util.Optional; Review Comment: If I leave

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459586207 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -21,95 +21,111 @@ import java.util.Optional; Review Comment: Okay I'll

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459585333 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupsOptions.java: ## @@ -34,13 +35,24 @@ public class ListConsumerGroupsOptions extends

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459581595 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -95,9 +95,18 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459544349 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long

[jira] [Assigned] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-16169: -- Assignee: Lianet Magrans > FencedException in commitAsync not propagated without

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459544349 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459539623 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459535683 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459535683 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long

[PR] KAFKA-16171 Fix hybrid mode controller race [kafka]

2024-01-19 Thread via GitHub
mumrah opened a new pull request, #15238: URL: https://github.com/apache/kafka/pull/15238 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459513439 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java: ## @@ -31,7 +31,15 @@ public enum ConsumerGroupState {

[jira] [Resolved] (KAFKA-15811) implement capturing client port information from Socket Server

2024-01-19 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-15811. - Fix Version/s: 3.8.0 Resolution: Fixed merged the PR to trunk. > implement capturing client

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459497325 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java: ## @@ -31,7 +31,15 @@ public enum ConsumerGroupState {

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459509714 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -95,9 +95,18 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest {

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-19 Thread via GitHub
junrao merged PR #15190: URL: https://github.com/apache/kafka/pull/15190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-19 Thread via GitHub
junrao commented on PR #15190: URL: https://github.com/apache/kafka/pull/15190#issuecomment-1900901612 Thanks for triaging the test failures, @apoorvmittal10. Merging the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459497325 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java: ## @@ -31,7 +31,15 @@ public enum ConsumerGroupState {

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459497325 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java: ## @@ -31,7 +31,15 @@ public enum ConsumerGroupState {

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-19 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1459490703 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459486416 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459484761 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459484260 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459483045 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459430540 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459466608 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459434002 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459430540 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-19 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1900804744 Merged to `trunk` and cherry-picked to `3.7` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-19 Thread via GitHub
mjsax merged PR #15217: URL: https://github.com/apache/kafka/pull/15217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
AndrewJSchofield commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459379766 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -433,4 +459,26 @@ public Map matchPattern() { return

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459376549 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -433,4 +459,26 @@ public Map matchPattern() { return matchPattern;

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459368565 ## server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java: ## @@ -919,4 +922,101 @@ public void

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459350997 ## server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java: ## @@ -919,4 +922,101 @@ public void

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on PR #15190: URL: https://github.com/apache/kafka/pull/15190#issuecomment-1900762271 > @apoorvmittal10 : Thanks for the updated PR. LGTM. Are the test failures related? Are they all being tracked? @junrao The tests failures are unrelated and below are the

[jira] [Comment Edited] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-19 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808653#comment-17808653 ] Francois Visconte edited comment on KAFKA-15776 at 1/19/24 4:52 PM:

[jira] [Created] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16176: - Summary: Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest Key: KAFKA-16176 URL:

[jira] [Created] (KAFKA-16177) Flaky test: testBatchSizeZeroNoPartitionNoRecordKey – kafka.api.PlaintextProducerSendTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16177: - Summary: Flaky test: testBatchSizeZeroNoPartitionNoRecordKey – kafka.api.PlaintextProducerSendTest Key: KAFKA-16177 URL: https://issues.apache.org/jira/browse/KAFKA-16177

[jira] [Comment Edited] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-19 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808653#comment-17808653 ] Francois Visconte edited comment on KAFKA-15776 at 1/19/24 4:52 PM:

[jira] [Created] (KAFKA-16175) Flaky test: testAsynchronousAuthorizerAclUpdatesDontBlockRequestThreads – kafka.api.SslAdminIntegrationTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16175: - Summary: Flaky test: testAsynchronousAuthorizerAclUpdatesDontBlockRequestThreads – kafka.api.SslAdminIntegrationTest Key: KAFKA-16175 URL:

[jira] [Created] (KAFKA-16174) Flaky test: testDescribeQuorumStatusSuccessful – org.apache.kafka.tools.MetadataQuorumCommandTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16174: - Summary: Flaky test: testDescribeQuorumStatusSuccessful – org.apache.kafka.tools.MetadataQuorumCommandTest Key: KAFKA-16174 URL:

[jira] [Created] (KAFKA-16173) Flaky test: testTimeoutMetrics – org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16173: - Summary: Flaky test: testTimeoutMetrics – org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest Key: KAFKA-16173 URL:

[jira] [Created] (KAFKA-16172) Flaky test: testProducerConsumerOverrideLowerQuota – kafka.api.UserQuotaTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16172: - Summary: Flaky test: testProducerConsumerOverrideLowerQuota – kafka.api.UserQuotaTest Key: KAFKA-16172 URL: https://issues.apache.org/jira/browse/KAFKA-16172

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-19 Thread via GitHub
jsancio commented on code in PR #15235: URL: https://github.com/apache/kafka/pull/15235#discussion_r1459322086 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -101,6 +101,10 @@ protected LeaderState( * @return the remainingMs before the

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-19 Thread via GitHub
jolshan commented on PR #15183: URL: https://github.com/apache/kafka/pull/15183#issuecomment-1900735439 > we could delete all the pending transactional offsets when a new offset record is replayed. Hmmm does this work for LSO correctly? I know that the consumer offset topic has

[jira] [Commented] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-01-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808735#comment-17808735 ] Lucas Brutschy commented on KAFKA-16169: Sound good! I'd suggest doing it after the interceptor

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-19 Thread via GitHub
jolshan commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1459300270 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -92,30 +117,34 @@ public boolean equals(Object o) {

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-19 Thread via GitHub
kirktrue commented on code in PR #15186: URL: https://github.com/apache/kafka/pull/15186#discussion_r1459293494 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -376,25 +376,21 @@ protected Map prepareCloseFetchSessi final

[PR] KAFKA-16168; Implement GroupCoordinator.onPartitionsDeleted [kafka]

2024-01-19 Thread via GitHub
dajac opened a new pull request, #15237: URL: https://github.com/apache/kafka/pull/15237 WIP - Built on top of https://github.com/apache/kafka/pull/15221. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-19 Thread via GitHub
lucasbru commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1459285186 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -271,6 +283,7 @@ public CompletableFuture

[jira] [Resolved] (KAFKA-16113) AsyncKafkaConsumer: Add missing offset commit metrics

2024-01-19 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-16113. Resolution: Fixed > AsyncKafkaConsumer: Add missing offset commit metrics >

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-19 Thread via GitHub
kirktrue commented on code in PR #15186: URL: https://github.com/apache/kafka/pull/15186#discussion_r1459258946 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -376,25 +376,21 @@ protected Map prepareCloseFetchSessi final

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-19 Thread via GitHub
cadonna commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1459255586 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -271,6 +283,7 @@ public CompletableFuture

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can prevent metadata updates to ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Description: h2. Description During the ZK migration, after KRaft becomes the active

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can lead to controller unavailability for ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Affects Version/s: 3.6.1 3.6.0 3.7.0 > Controller

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can prevent metadata updates to ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Summary: Controller failover during ZK migration can prevent metadata updates to ZK brokers

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can lead to controller unavailability for ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Component/s: controller kraft > Controller failover during ZK migration can

[jira] [Created] (KAFKA-16171) Controller failover during ZK migration can lead to controller unavailability for ZK brokers

2024-01-19 Thread David Arthur (Jira)
David Arthur created KAFKA-16171: Summary: Controller failover during ZK migration can lead to controller unavailability for ZK brokers Key: KAFKA-16171 URL: https://issues.apache.org/jira/browse/KAFKA-16171

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-19 Thread via GitHub
mimaison commented on PR #15235: URL: https://github.com/apache/kafka/pull/15235#issuecomment-1900657870 Yes, this issue was introduced in https://github.com/apache/kafka/commit/37416e1aebae33d01d5059ba906ec8e0e1107284 -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-19 Thread via GitHub
stanislavkozlovski commented on PR #15235: URL: https://github.com/apache/kafka/pull/15235#issuecomment-1900646211 I guess this is a regression from https://issues.apache.org/jira/browse/KAFKA-15489 ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-19 Thread via GitHub
lianetm commented on code in PR #15215: URL: https://github.com/apache/kafka/pull/15215#discussion_r1459204272 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1134,9 +1134,22 @@ private CompletableFuture assignPartitions(

[jira] [Commented] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808701#comment-17808701 ] Lianet Magrans commented on KAFKA-16169: Hey [~lbrutschy], I'm currently working on some fixes

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
mimaison commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459178820 ## core/src/test/scala/unit/kafka/utils/PasswordEncoderTest.scala: ## @@ -19,10 +19,9 @@ package kafka.utils import javax.crypto.SecretKeyFactory - -import

[PR] Note that Java 11 support for broker and tools is deprecated for removal in 4.0 [kafka]

2024-01-19 Thread via GitHub
ijuma opened a new pull request, #15236: URL: https://github.com/apache/kafka/pull/15236 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

Re: [PR] [Kafka-14404] fix overlap of streams-config sections & describe additional parameters [kafka]

2024-01-19 Thread via GitHub
AyoubOm commented on PR #15162: URL: https://github.com/apache/kafka/pull/15162#issuecomment-1900594772 @ableegoldman @mjsax I added a section for `client.id`, the result looks like this: https://github.com/apache/kafka/assets/23745892/9934893b-967d-44a6-842b-51b8b3cd43a8;>

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459169205 ## checkstyle/import-control-core.xml: ## @@ -82,6 +82,7 @@ + Review Comment: nope, I think this was left over from the main pr -- This

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459168180 ## core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala: ## @@ -53,7 +53,7 @@ class LogCleanerManagerTest extends Logging { val logConfig: LogConfig = new

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459167766 ## server/src/main/java/org/apache/kafka/server/config/Defaults.java: ## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459167324 ## server/src/main/java/org/apache/kafka/server/config/Defaults.java: ## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459158610 ## core/src/test/scala/unit/kafka/utils/PasswordEncoderTest.scala: ## @@ -19,10 +19,9 @@ package kafka.utils import javax.crypto.SecretKeyFactory - -import

[jira] [Resolved] (KAFKA-16170) Continuous never ending logs observed when running single node kafka in kraft mode with default KRaft properties in 3.7.0 RC2

2024-01-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-16170. Resolution: Duplicate Duplicate of https://issues.apache.org/jira/browse/KAFKA-16144 >

[jira] [Updated] (KAFKA-15832) Trigger client reconciliation based on manager poll

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15832: --- Description: Currently the reconciliation logic on the client is triggered when a new

[jira] [Updated] (KAFKA-16170) Continuous never ending logs observed when running single node kafka in kraft mode with default KRaft properties in 3.7.0 RC2

2024-01-19 Thread Vedarth Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vedarth Sharma updated KAFKA-16170: --- Summary: Continuous never ending logs observed when running single node kafka in kraft mode

[jira] [Updated] (KAFKA-15832) Trigger client reconciliation based on manager poll

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15832: --- Description: Currently the reconciliation logic on the client is triggered when a new

  1   2   >