dajac commented on code in PR #15211:
URL: https://github.com/apache/kafka/pull/15211#discussion_r1467316594
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -57,10 +57,15 @@ public String toString() {
*/
String
appchemist commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1911621990
@rondagostino Please if you can review and provide the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac merged PR #15259:
URL: https://github.com/apache/kafka/pull/15259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #14615:
URL: https://github.com/apache/kafka/pull/14615#issuecomment-1911583945
@Nickstery , are you still able to address the comments? I'll ask for the
community's help if you are not available. Thanks.
--
This is an automated message from the Apache Git
showuon commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1911567449
Thanks for the contribution, @drawxy !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon merged PR #15220:
URL: https://github.com/apache/kafka/pull/15220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1911563500
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
drawxy commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1911558398
Hi @divijvaidya and @showuon, I have resolved the compilation issue, but
there are still some failed unit test cases, which are not involved by this PR.
Should I mitigate them all? I am
github-actions[bot] commented on PR #14615:
URL: https://github.com/apache/kafka/pull/14615#issuecomment-1911402809
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
dongnuo123 opened a new pull request, #15268:
URL: https://github.com/apache/kafka/pull/15268
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811071#comment-17811071
]
Jorge Esteban Quilcate Otoya commented on KAFKA-15776:
--
Thanks [~showuon]!
Sure, I
[
https://issues.apache.org/jira/browse/KAFKA-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-16192:
---
Description:
[
https://issues.apache.org/jira/browse/KAFKA-16196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-16196:
---
Description:
The Cast transform currently doesn't handle invalid whole value casts
gracefully. A
[
https://issues.apache.org/jira/browse/KAFKA-16196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-16196:
---
Description:
The Cast transform currently doesn't handle invalid whole value casts
gracefully. A
[
https://issues.apache.org/jira/browse/KAFKA-16196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-16196:
---
Description:
The Cast transform currently doesn't handle invalid whole value casts
gracefully. A
Yash Mayya created KAFKA-16196:
--
Summary: Cast transform doesn't handle invalid whole value casts
gracefully
Key: KAFKA-16196
URL: https://issues.apache.org/jira/browse/KAFKA-16196
Project: Kafka
jolshan opened a new pull request, #15266:
URL: https://github.com/apache/kafka/pull/15266
https://issues.apache.org/jira/browse/KAFKA-14417 updated all transactional
APIs to handle retriable errors except for TxnOffsetCommit.
NetworkExceptions have been causing flaky failures in
songnon commented on code in PR #13451:
URL: https://github.com/apache/kafka/pull/13451#discussion_r1436294870
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -1894,10 +1894,16 @@ class KafkaController(val config: KafkaConfig,
val currentAssignment =
CalvinConfluent opened a new pull request, #15265:
URL: https://github.com/apache/kafka/pull/15265
https://issues.apache.org/jira/browse/KAFKA-15585
Add the support for DescribeTopicPartitions API on the client side.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-16122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-16122:
--
Assignee: Justine Olshan
> TransactionsBounceTest -- server disconnected before
showuon commented on PR #15230:
URL: https://github.com/apache/kafka/pull/15230#issuecomment-1911121060
Question: why can't we delete these disappeared(deleted) logs directly? I
think this can only happen when topic deleting while the node is offline. If
so, then deleting them should be
jolshan commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1467019262
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1099,29 +1055,48 @@ private static boolean
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1467026136
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -452,21 +453,38 @@ public Group group(String groupId, long
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1467024681
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -40,6 +42,29 @@ enum GroupType {
public String toString() {
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1467024178
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -40,6 +42,29 @@ enum GroupType {
public String toString() {
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1467019377
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -452,21 +453,38 @@ public Group group(String groupId, long
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1467019377
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -452,21 +453,38 @@ public Group group(String groupId, long
jolshan commented on PR #15221:
URL: https://github.com/apache/kafka/pull/15221#issuecomment-1911033187
Hmmm -- something seems to be up with builds.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/activity?branch=PR-15221
I will retrigger?
--
This is an
jolshan merged PR #15255:
URL: https://github.com/apache/kafka/pull/15255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
OmniaGM commented on PR #15260:
URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910886475
okay we can leave this one as the last pr to merge them together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811018#comment-17811018
]
Chris Egerton commented on KAFKA-10816:
---
Hi [~tombentley], it's been a while since there's been
[
https://issues.apache.org/jira/browse/KAFKA-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-10816:
-
Assignee: Chris Egerton (was: Tom Bentley)
> Connect REST API should have a resource
[
https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811017#comment-17811017
]
Gaurav Narula edited comment on KAFKA-16162 at 1/25/24 7:31 PM:
I think
[
https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811017#comment-17811017
]
Gaurav Narula commented on KAFKA-16162:
---
I think the proposed fix would never result in the
jolshan commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1910847402
I have noticed several day builds for the project. I've alerted the mailing
thread, but will try to do some of my own investigation.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-16193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811003#comment-17811003
]
Greg Harris commented on KAFKA-16193:
-
Hi [~filatov_m] I believe this is a supported use-case, if a
dajac commented on code in PR #15255:
URL: https://github.com/apache/kafka/pull/15255#discussion_r1466772685
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -87,13 +87,7 @@
]},
{ "name": "Assignment", "versions": "0+", "fields":
gaurav-narula commented on code in PR #15232:
URL: https://github.com/apache/kafka/pull/15232#discussion_r1466767964
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1408,6 +1408,7 @@ void handleDirectoriesOffline(
jolshan commented on PR #15257:
URL: https://github.com/apache/kafka/pull/15257#issuecomment-1910743134
Very strange this build has been running for almost a day and the link to it
doesn't work:
clayburn commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-1910737138
> Looks like Jenkins doesn't have permission (by default at least) to write
entries to the ASF Gradle Enterprise Build Cache:
This is correct. The reason for this is that we do
jolshan commented on code in PR #15255:
URL: https://github.com/apache/kafka/pull/15255#discussion_r1466743553
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -87,13 +87,7 @@
]},
{ "name": "Assignment", "versions": "0+",
ijuma commented on PR #15260:
URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910698896
I am ok with whatever approach is easiest. I care more about the end state
(assuming the intermediate state doesn't last for too long).
--
This is an automated message from the Apache
mberndt123 commented on PR #15239:
URL: https://github.com/apache/kafka/pull/15239#issuecomment-1910629710
@divijvaidya
Thank you for your comments, please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1466643378
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -40,6 +42,29 @@ enum GroupType {
public String toString() {
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1466580289
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
DL1231 commented on PR #15211:
URL: https://github.com/apache/kafka/pull/15211#issuecomment-1910449935
Thanks for the suggestion @dajac . I have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1466520246
##
streams/src/main/java/org/apache/kafka/streams/processor/StateStore.java:
##
@@ -165,4 +165,22 @@ default Position getPosition() {
"getPosition is
nicktelford commented on PR #15264:
URL: https://github.com/apache/kafka/pull/15264#issuecomment-1910401911
Note: this is part of KIP-892 Transactional StateStores. It introduces a new
config option that will have no effect until the rest of KIP-892 lands at a
later date.
@cadonna
nicktelford opened a new pull request, #15264:
URL: https://github.com/apache/kafka/pull/15264
This configuration controls the maximum amount of local state store data to
buffer in transaction buffers.
When the total uncommitted data, across all stores and all threads, exceeds
this
nicktelford commented on PR #15137:
URL: https://github.com/apache/kafka/pull/15137#issuecomment-1910399080
> * Is it possible to have a separate PR for the config changes?
@cadonna Yes, in fact I'm working on that as I speak. :grin: It'll be a
little strange to essentially add
gaurav-narula commented on PR #15263:
URL: https://github.com/apache/kafka/pull/15263#issuecomment-1910373586
CC: @OmniaGM @cmccabe @pprovenzano @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gaurav-narula opened a new pull request, #15263:
URL: https://github.com/apache/kafka/pull/15263
In Kraft mode, the broker fails to handle topic recreation correctly with
broken disks. This is because `ReplicaManager` tracks HostedPartitions which
are on an offline disk but it doesn't
nizhikov commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1910366005
Hello @jolshan
Do you have any other questions regarding this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-16003.
Fix Version/s: 3.8.0
Resolution: Fixed
> The znode /config/topics is not updated
mimaison merged PR #15022:
URL: https://github.com/apache/kafka/pull/15022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mannoopj commented on code in PR #14389:
URL: https://github.com/apache/kafka/pull/14389#discussion_r1466452243
##
tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java:
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16194:
---
Component/s: clients
> KafkaConsumer.groupMetadata() should be correct when first records
gaurav-narula commented on PR #15262:
URL: https://github.com/apache/kafka/pull/15262#issuecomment-1910271761
CC: @cmccabe @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
clolov commented on PR #15261:
URL: https://github.com/apache/kafka/pull/15261#issuecomment-1910268608
Heya @lucasbru @divijvaidya and @cadonna - a polite call for review ! There
are only 2 classes left to move to Mockito!
--
This is an automated message from the Apache Git Service.
To
clolov commented on code in PR #15261:
URL: https://github.com/apache/kafka/pull/15261#discussion_r1466405733
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -2358,6 +2354,7 @@ public void
clolov commented on code in PR #15261:
URL: https://github.com/apache/kafka/pull/15261#discussion_r1466405733
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -2358,6 +2354,7 @@ public void
Gaurav Narula created KAFKA-16195:
-
Summary: metadata.log.dir failure shouldn't shutdown broker in ZK
mode
Key: KAFKA-16195
URL: https://issues.apache.org/jira/browse/KAFKA-16195
Project: Kafka
dajac commented on code in PR #15202:
URL: https://github.com/apache/kafka/pull/15202#discussion_r1466381107
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -272,7 +270,35 @@ public void
mimaison commented on PR #15260:
URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910237310
I agree we want to shift `Defaults` into `KafkaConfig` (in Java) but I
wonder if we should keep what we have for now and keep breaking the Scala
`KafkaConfig` down.
It seems the
rykovsi commented on PR #15092:
URL: https://github.com/apache/kafka/pull/15092#issuecomment-1910211282
@hachikuji
can you merge it pls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac closed pull request #15259: KAFKA-15462: Add groupType enum for KIP-848
URL: https://github.com/apache/kafka/pull/15259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dajac merged PR #15205:
URL: https://github.com/apache/kafka/pull/15205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
David Jacot created KAFKA-16194:
---
Summary: KafkaConsumer.groupMetadata() should be correct when
first records are returned
Key: KAFKA-16194
URL: https://issues.apache.org/jira/browse/KAFKA-16194
jlprat commented on code in PR #15252:
URL: https://github.com/apache/kafka/pull/15252#discussion_r1466307064
##
core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala:
##
@@ -17,11 +17,14 @@
package kafka.admin
+
+
Review Comment:
Sorry, these are not needed
OmniaGM commented on code in PR #15158:
URL: https://github.com/apache/kafka/pull/15158#discussion_r1466303341
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -0,0 +1,278 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
OmniaGM commented on PR #15260:
URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910107947
@ijuma, @mimaison can one of you have a look into this pr? This is related
to @ijuma comment here
https://github.com/apache/kafka/pull/15158#pullrequestreview-1836760668
--
This is
OmniaGM opened a new pull request, #15260:
URL: https://github.com/apache/kafka/pull/15260
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
showuon commented on code in PR #15230:
URL: https://github.com/apache/kafka/pull/15230#discussion_r1466280765
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -563,6 +565,18 @@ class LogManager(logDirs: Seq[File],
startupWithConfigOverrides(defaultConfig,
jlprat commented on code in PR #15252:
URL: https://github.com/apache/kafka/pull/15252#discussion_r1466253059
##
core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala:
##
@@ -116,11 +116,10 @@ object ZkSecurityMigrator extends Logging {
try {
run(args)
}
showuon commented on code in PR #15252:
URL: https://github.com/apache/kafka/pull/15252#discussion_r1466239773
##
core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala:
##
@@ -116,11 +116,10 @@ object ZkSecurityMigrator extends Logging {
try {
run(args)
}
cadonna commented on PR #15137:
URL: https://github.com/apache/kafka/pull/15137#issuecomment-1909913075
Some suggestions/questions to split the PR in smaller parts (without having
looked at the PR in much depth):
- Is it possible to have a separate PR for the config changes?
- Is it
jlprat commented on PR #15252:
URL: https://github.com/apache/kafka/pull/15252#issuecomment-1909900403
Failures seem all unrelated to the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nicktelford commented on PR #15137:
URL: https://github.com/apache/kafka/pull/15137#issuecomment-1909852487
> Hey @nicktelford , I'll try to take a look at this here and there and I
can't speak for the Confluent folks, but I have to say it's pretty intimidating
to see a PR with 3000 LOC
[
https://issues.apache.org/jira/browse/KAFKA-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810789#comment-17810789
]
yazgoo commented on KAFKA-10413:
Hello,
One year later with CP 7.5, I still have the issue
Regards
>
[
https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810779#comment-17810779
]
Luke Chen commented on KAFKA-15776:
---
[~jeqo], For [On the timeout configuration semantics] and [On the
mimaison commented on PR #15022:
URL: https://github.com/apache/kafka/pull/15022#issuecomment-1909731266
Thanks @showuon for the review. I'll address the nits in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-7957.
---
Resolution: Fixed
> Flaky Test DynamicBrokerReconfigurationTest#testMetricsReporterUpdate
>
[
https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-7957:
-
Assignee: Mickael Maison
> Flaky Test
dajac commented on PR #15221:
URL: https://github.com/apache/kafka/pull/15221#issuecomment-1909715095
@jolshan @jeffkbkim @rreddy-22 @dongnuo123 Thanks for your comments. I have
addressed all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mimaison merged PR #15147:
URL: https://github.com/apache/kafka/pull/15147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #15221:
URL: https://github.com/apache/kafka/pull/15221#discussion_r1466057301
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -501,13 +521,11 @@ public void testOffsetDeleteWith(
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1466007522
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -40,6 +42,29 @@ enum GroupType {
public String toString() {
87 matches
Mail list logo
