[jira] [Commented] (KAFKA-17169) Add an EndpointsTest suite that test all of the public methods

2024-07-21 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867661#comment-17867661 ] Mason Chen commented on KAFKA-17169: Hi, I'm interested in this issue, can I pick th

Re: [PR] KAFKA-17149: Move ProducerStateManagerTest to storage module [kafka]

2024-07-21 Thread via GitHub
m1a2st commented on PR #16645: URL: https://github.com/apache/kafka/pull/16645#issuecomment-2242148472 @brandboat, Thanks for your reminder, I will rebased lastest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (KAFKA-17174) Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions

2024-07-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867659#comment-17867659 ] Chris Egerton commented on KAFKA-17174: --- I'm not sure this is the right direction

[jira] [Commented] (KAFKA-17174) Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions

2024-07-21 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867658#comment-17867658 ] Dmitry Werner commented on KAFKA-17174: --- [~chia7712] Hello, can I take task? > Mi

[jira] [Created] (KAFKA-17178) Update KTable.transformValues to new Processor API

2024-07-21 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17178: --- Summary: Update KTable.transformValues to new Processor API Key: KAFKA-17178 URL: https://issues.apache.org/jira/browse/KAFKA-17178 Project: Kafka Issu

[jira] [Assigned] (KAFKA-17177) reviewers.py should grep "authors" to offer more candidates of reviewers information

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17177: -- Assignee: Chia Chuan Yu (was: Chia-Ping Tsai) > reviewers.py should grep "authors" t

[jira] [Commented] (KAFKA-17177) reviewers.py should grep "authors" to offer more candidates of reviewers information

2024-07-21 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867653#comment-17867653 ] Chia Chuan Yu commented on KAFKA-17177: --- Hi,[~chia7712]  Can I have this one? Tha

[jira] [Updated] (KAFKA-17177) reviewers.py should grep "authors" to offer more candidates of reviewers information

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17177: --- Summary: reviewers.py should grep "authors" to offer more candidates of reviewers informatio

[jira] [Created] (KAFKA-17177) reviewers.py should include the "authors"

2024-07-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17177: -- Summary: reviewers.py should include the "authors" Key: KAFKA-17177 URL: https://issues.apache.org/jira/browse/KAFKA-17177 Project: Kafka Issue Type: Imp

[jira] [Assigned] (KAFKA-17176) Move FileLock to server-common module

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17176: -- Assignee: Kuan Po Tseng (was: Chia-Ping Tsai) > Move FileLock to server-common modul

Re: [PR] KAFKA-16900 kafka-producer-perf-test reports error when using transaction. [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16646: URL: https://github.com/apache/kafka/pull/16646#discussion_r1685930254 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -330,18 +346,15 @@ static ArgumentParser argParser() { .type(String.class

[jira] [Commented] (KAFKA-17176) Move FileLock to server-common module

2024-07-21 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867648#comment-17867648 ] Kuan Po Tseng commented on KAFKA-17176: --- gentle ping [~chia7712] , may I take over

[jira] [Assigned] (KAFKA-17175) Remove interface `BrokerNode` and `ControllerNode`

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17175: -- Assignee: TengYao Chi (was: Chia-Ping Tsai) > Remove interface `BrokerNode` and `Con

[jira] [Created] (KAFKA-17176) Move FileLock to server-common module

2024-07-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17176: -- Summary: Move FileLock to server-common module Key: KAFKA-17176 URL: https://issues.apache.org/jira/browse/KAFKA-17176 Project: Kafka Issue Type: Sub-tas

[jira] [Commented] (KAFKA-17175) Remove interface `BrokerNode` and `ControllerNode`

2024-07-21 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867647#comment-17867647 ] TengYao Chi commented on KAFKA-17175: - Hi [~chia7712]  If you are not start working

[jira] [Created] (KAFKA-17175) Remove interface `BrokerNode` and `ControllerNode`

2024-07-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17175: -- Summary: Remove interface `BrokerNode` and `ControllerNode` Key: KAFKA-17175 URL: https://issues.apache.org/jira/browse/KAFKA-17175 Project: Kafka Issue

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-07-21 Thread via GitHub
chia7712 merged PR #16610: URL: https://github.com/apache/kafka/pull/16610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16056: Revoking connectors and tasks upon worker poll timeout expiry to prevent duplicate task assignments [kafka]

2024-07-21 Thread via GitHub
vamossagar12 commented on PR #16628: URL: https://github.com/apache/kafka/pull/16628#issuecomment-2241917198 Build got aborted. Closing and reopening the PR to let the build getting triggered again. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] KAFKA-16056: Revoking connectors and tasks upon worker poll timeout expiry to prevent duplicate task assignments [kafka]

2024-07-21 Thread via GitHub
vamossagar12 closed pull request #16628: KAFKA-16056: Revoking connectors and tasks upon worker poll timeout expiry to prevent duplicate task assignments URL: https://github.com/apache/kafka/pull/16628 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16599: URL: https://github.com/apache/kafka/pull/16599#discussion_r1685882826 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -95,98 +88,60 @@ import static org.apache.kafka.clients.cons

[jira] [Updated] (KAFKA-17174) Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17174: --- Description: Connect module has its `EmbeddedKafkaCluster`, so another alternative is to re

[jira] [Updated] (KAFKA-17174) Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17174: --- Description: Connect module has its `EmbeddedKafkaCluster`, so another alternative is to re

[jira] [Created] (KAFKA-17174) Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions

2024-07-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17174: -- Summary: Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions Key: KAFKA-17174 URL: https://issues.apache.org/jira/browse/KAFKA-17174 Project: Kafka

Re: [PR] Kafka-16448: punctuate processing exceptions [kafka]

2024-07-21 Thread via GitHub
loicgreffier commented on PR #16300: URL: https://github.com/apache/kafka/pull/16300#issuecomment-2241810066 @cadonna This PR contains the handling of processing exceptions in `StreamTask#punctuate`: - `StreamsException` are not handled right now. We could include them in the catch block

Re: [PR] KAFKA-16068: Use TestPlugins mechanism in ConnectorValidationIntegrationTest to prevent ERROR-level log spam in unrelated test suites [kafka]

2024-07-21 Thread via GitHub
C0urante commented on code in PR #16647: URL: https://github.com/apache/kafka/pull/16647#discussion_r1685806605 ## connect/runtime/src/test/resources/test-plugins/bad-packaging/META-INF/services/org.apache.kafka.connect.storage.Converter: ## @@ -14,6 +14,7 @@ # limitations und

Re: [PR] KAFKA-16068: Use TestPlugins mechanism in ConnectorValidationIntegrationTest to prevent ERROR-level log spam in unrelated test suites [kafka]

2024-07-21 Thread via GitHub
C0urante commented on code in PR #16647: URL: https://github.com/apache/kafka/pull/16647#discussion_r1685806524 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java: ## @@ -37,13 +36,9 @@ public class PluginScannerTest { -pr

Re: [PR] KAFKA-16068: Use TestPlugins mechanism in ConnectorValidationIntegrationTest to prevent ERROR-level log spam in unrelated test suites [kafka]

2024-07-21 Thread via GitHub
C0urante commented on code in PR #16647: URL: https://github.com/apache/kafka/pull/16647#discussion_r1685806406 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -520,17 +543,6 @@ public byte[] fromConnectHeader(

Re: [PR] KAFKA-16068: Use TestPlugins mechanism in ConnectorValidationIntegrationTest to prevent ERROR-level log spam in unrelated test suites [kafka]

2024-07-21 Thread via GitHub
C0urante commented on PR #16647: URL: https://github.com/apache/kafka/pull/16647#issuecomment-2241763358 @gharris1727 I've been working on de-flaking our Connect and MM2 integration tests lately and realized that this fix would be a nice quality-of-life improvement to help speed up the proc

[PR] KAFKA-16068: Use TestPlugins mechanism in ConnectorValidationIntegrationTest to prevent ERROR-level log spam in unrelated test suites [kafka]

2024-07-21 Thread via GitHub
C0urante opened a new pull request, #16647: URL: https://github.com/apache/kafka/pull/16647 [Jira](https://issues.apache.org/jira/browse/KAFKA-16068) This is based loosely off of the changes in https://github.com/apache/kafka/pull/15642, but with modifications that address some of th

[jira] [Commented] (KAFKA-12679) Rebalancing a restoring or running task may cause directory livelocking with newly created task

2024-07-21 Thread Colt McNealy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867622#comment-17867622 ] Colt McNealy commented on KAFKA-12679: -- [~lucasbru] thanks for the comment and sorr

[jira] [Updated] (KAFKA-17162) DefaultTaskManagerTest may leak AwaitingRunnable thread

2024-07-21 Thread Ao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Li updated KAFKA-17162: -- Description: The `DefaultTaskManagerTest#shouldReturnFromAwaitOnInterruption` will fail with the following pa

Re: [PR] KAFKA-17149: Move ProducerStateManagerTest to storage module [kafka]

2024-07-21 Thread via GitHub
brandboat commented on PR #16645: URL: https://github.com/apache/kafka/pull/16645#issuecomment-2241707304 gentle ping @m1a2st , you may need to rebase to the latest commit, the test file ProducerStateManagerTest.scala has been updated by https://github.com/apache/kafka/commit/94f5a4f63e7a38

[PR] KAFKA-16900 kafka-producer-perf-test reports error when using transaction. [kafka]

2024-07-21 Thread via GitHub
brandboat opened a new pull request, #16646: URL: https://github.com/apache/kafka/pull/16646 related to https://issues.apache.org/jira/browse/KAFKA-16900, Currently, users need to set --transaction-duration-ms to enable transactions in kafka-producer-perf-test, which is not straightfo

[PR] KAFKA-17149: Move ProducerStateManagerTest to storage module [kafka]

2024-07-21 Thread via GitHub
m1a2st opened a new pull request, #16645: URL: https://github.com/apache/kafka/pull/16645 Jira: https://issues.apache.org/jira/browse/KAFKA-17149 move ProducerStateManagerTest to storage module and change to Java code ### Committer Checklist (excluded from commit message) - [ ] V

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-21 Thread via GitHub
m1a2st commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1685761154 ## tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java: ## @@ -239,4 +284,73 @@ public void shouldWorkWithoutTopicOption() throws IOException {

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1685752276 ## tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java: ## @@ -239,4 +284,73 @@ public void shouldWorkWithoutTopicOption() throws IOException

[jira] [Resolved] (KAFKA-17168) The logPrefix of RemoteLogReader/RemoteStorageThreadPool is not propagated correctly

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17168. Fix Version/s: 3.9.0 Resolution: Fixed > The logPrefix of RemoteLogReader/RemoteSto

Re: [PR] KAFKA-17168 The logPrefix of RemoteLogReader/RemoteStorageThreadPool is not propagated correctly [kafka]

2024-07-21 Thread via GitHub
chia7712 merged PR #16642: URL: https://github.com/apache/kafka/pull/16642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16972: Move BrokerTopicMetrics to org.apache.kafka.storage.log.metrics [kafka]

2024-07-21 Thread via GitHub
FrankYang0529 commented on code in PR #16387: URL: https://github.com/apache/kafka/pull/16387#discussion_r1685748324 ## storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-16972: Move BrokerTopicMetrics to org.apache.kafka.storage.log.metrics [kafka]

2024-07-21 Thread via GitHub
FrankYang0529 commented on code in PR #16387: URL: https://github.com/apache/kafka/pull/16387#discussion_r1685748202 ## storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-17021: Migrate AclCommandTest to new test infra [kafka]

2024-07-21 Thread via GitHub
wernerdv commented on PR #16500: URL: https://github.com/apache/kafka/pull/16500#issuecomment-2241619049 @chia7712 all conflicts are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-17021: Migrate AclCommandTest to new test infra [kafka]

2024-07-21 Thread via GitHub
wernerdv commented on code in PR #16500: URL: https://github.com/apache/kafka/pull/16500#discussion_r1685743220 ## core/src/test/java/kafka/admin/AclCommandTest.java: ## @@ -0,0 +1,729 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-21 Thread via GitHub
FrankYang0529 commented on code in PR #16641: URL: https://github.com/apache/kafka/pull/16641#discussion_r1685741713 ## core/src/test/scala/unit/kafka/log/LogManagerTest.scala: ## @@ -949,6 +949,7 @@ class LogManagerTest { appendRecordsToLog(mockTime, logDir1, 0, mockBroker

Re: [PR] KAFKA-16791: Add thread detection to ClusterTestExtensions [kafka]

2024-07-21 Thread via GitHub
FrankYang0529 commented on code in PR #16499: URL: https://github.com/apache/kafka/pull/16499#discussion_r1685740577 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -119,7 +139,27 @@ public Stream provideTestTemplateInvocationContex return gene

Re: [PR] KAFKA-16855 : Based on tiered state of topic, check for tasks [kafka]

2024-07-21 Thread via GitHub
kamalcph commented on code in PR #16615: URL: https://github.com/apache/kafka/pull/16615#discussion_r1685730309 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -433,10 +433,13 @@ private void cacheTopicPartitionIds(TopicIdPartition topicIdPartition) {

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16599: URL: https://github.com/apache/kafka/pull/16599#discussion_r1685723572 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -95,98 +88,60 @@ import static org.apache.kafka.clients.cons

Re: [PR] KAFKA-16972: Move BrokerTopicMetrics to org.apache.kafka.storage.log.metrics [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16387: URL: https://github.com/apache/kafka/pull/16387#discussion_r1685710155 ## storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-16791: Add thread detection to ClusterTestExtensions [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16499: URL: https://github.com/apache/kafka/pull/16499#discussion_r1685709868 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -119,7 +139,27 @@ public Stream provideTestTemplateInvocationContex return generated

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16599: URL: https://github.com/apache/kafka/pull/16599#discussion_r1685709519 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -95,98 +88,60 @@ import static org.apache.kafka.clients.cons

Re: [PR] KAFKA-17021: Migrate AclCommandTest to new test infra [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on PR #16500: URL: https://github.com/apache/kafka/pull/16500#issuecomment-2241561688 @wernerdv could you please fix the conflicts? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-17056 Convert producer state metadata schemas to use generated protocol [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on PR #16592: URL: https://github.com/apache/kafka/pull/16592#issuecomment-2241561603 @brandboat Could you please rebase code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] MINOR: Verify topic deletion for new test infra [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16627: URL: https://github.com/apache/kafka/pull/16627#discussion_r1685705213 ## core/src/test/java/kafka/test/ClusterInstance.java: ## @@ -183,6 +193,67 @@ default Set supportedGroupProtocols() { //---[wait]--

Re: [PR] KAFKA-17104: fix InvalidMessageCrcRecordsPerSec is not updated in validating Legac… [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16558: URL: https://github.com/apache/kafka/pull/16558#discussion_r1685704339 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -574,7 +574,7 @@ private static Optional validateRecord(RecordBatch batch,

[jira] [Resolved] (KAFKA-17082) Replace kafka.utils.LogCaptureAppender with org.apache.kafka.common.utils.LogCaptureAppender

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17082. Fix Version/s: 3.9.0 Resolution: Fixed > Replace kafka.utils.LogCaptureAppender wit

Re: [PR] KAFKA-17082: replace kafka.utils.LogCaptureAppender with org.apache.kafka.common.utils.LogCaptureAppender [kafka]

2024-07-21 Thread via GitHub
chia7712 merged PR #16601: URL: https://github.com/apache/kafka/pull/16601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17153) KafkaMetricsGroup#newGauge should accept functional interface instead of `com.yammer.metrics.core.Gague`

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17153. Fix Version/s: 3.9.0 Resolution: Fixed > KafkaMetricsGroup#newGauge should accept f

Re: [PR] KAFKA-17153 KafkaMetricsGroup#newGauge should accept functional interface instead of `com.yammer.metrics.core.Gague` [kafka]

2024-07-21 Thread via GitHub
chia7712 merged PR #16618: URL: https://github.com/apache/kafka/pull/16618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

2024-07-21 Thread via GitHub
chia7712 commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1685701571 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol

[PR] KAFKA-17038 KIP-919 supports for `alterPartitionReassignments` and `listPartitionReassignments` [kafka]

2024-07-21 Thread via GitHub
brandboat opened a new pull request, #16644: URL: https://github.com/apache/kafka/pull/16644 related to https://issues.apache.org/jira/browse/KAFKA-17038, This is a follow-up after [KIP-919](https://cwiki.apache.org/confluence/display/KAFKA/KIP-919%3A+Allow+AdminClient+to+Talk+Directly+wi

Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]

2024-07-21 Thread via GitHub
wernerdv commented on PR #16620: URL: https://github.com/apache/kafka/pull/16620#issuecomment-2241517600 @chia7712 Hello, can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16056: Revoking connectors and tasks upon worker poll timeout expiry to prevent duplicate task assignments [kafka]

2024-07-21 Thread via GitHub
vamossagar12 commented on PR #16628: URL: https://github.com/apache/kafka/pull/16628#issuecomment-2241507720 > > Can't seem to run ./gradlew :connect:runtime:spotlessApply locally. Let me check this and updatez > > spotless behavior is jre-version-dependent, you can run with JDK11 and

[jira] [Resolved] (KAFKA-17144) Retract v6 of ListGroups RPC added in error

2024-07-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17144. Fix Version/s: 3.9.0 Resolution: Fixed > Retract v6 of ListGroups RPC added in erro

Re: [PR] KAFKA-17144: Retract unimplemented ListGroups v6 added in error [kafka]

2024-07-21 Thread via GitHub
chia7712 merged PR #16635: URL: https://github.com/apache/kafka/pull/16635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache