Re: [PR] MINOR: Bump zstd-jni from 1.5.6-5 to 1.5.6-6 [kafka]

2024-09-23 Thread via GitHub
jlprat merged PR #17253: URL: https://github.com/apache/kafka/pull/17253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Bump zstd-jni from 1.5.6-5 to 1.5.6-6 [kafka]

2024-09-23 Thread via GitHub
jlprat commented on PR #17253: URL: https://github.com/apache/kafka/pull/17253#issuecomment-2370343351 Tests passed on GH CI, and the 2 failures in Jenkins CI were known flaky tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (KAFKA-15896) Flaky test: shouldQuerySpecificStalePartitionStores() – org.apache.kafka.streams.integration.StoreQueryIntegrationTest

2024-09-23 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884128#comment-17884128 ] Josep Prat commented on KAFKA-15896: Another instance: https://ci-builds.apache.org

[jira] [Commented] (KAFKA-16491) Flaky test: randomClusterPerturbationsShouldConverge[rackAwareStrategy=balance_subtopology] – org.apache.kafka.streams.processor.internals.assignment.TaskAssignorConve

2024-09-23 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884129#comment-17884129 ] Josep Prat commented on KAFKA-16491: Another instance https://ci-builds.apache.org/

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-23 Thread via GitHub
lucasbru commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1772726105 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java: ## @@ -90,6 +91,15 @@ public int count() { return count; } +public

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-23 Thread via GitHub
lucasbru commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1772723868 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -462,23 +463,29 @@ public Map prepareCommit() { } } -

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-23 Thread via GitHub
lucasbru commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1772721636 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1820,6 +1820,9 @@ void addRecordsToTasks(final ConsumerRecords records)

[PR] KAFKA-17375: Fix reassignment after segment.bytes changes [kafka]

2024-09-23 Thread via GitHub
tvainika opened a new pull request, #17261: URL: https://github.com/apache/kafka/pull/17261 Remove too late check that prevents partition reassignment if `segment.bytes` has been changed to smaller value than size of existing message. Checks for `segment.bytes` limit should be only handled

Re: [PR] KAFKA-16848: Reverting KRaft migration for "Migrating brokers to KRaft" state is wrong [kafka]

2024-09-23 Thread via GitHub
edgarzubel closed pull request #16279: KAFKA-16848: Reverting KRaft migration for "Migrating brokers to KRaft" state is wrong URL: https://github.com/apache/kafka/pull/16279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-17459: Stablize reassign_partitions_test.py [kafka]

2024-09-23 Thread via GitHub
frankvicky commented on code in PR #17250: URL: https://github.com/apache/kafka/pull/17250#discussion_r1772580034 ## tests/kafkatest/tests/core/reassign_partitions_test.py: ## @@ -176,7 +176,13 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me

[PR] KAFKA-17542: Use actions/labeler for automatic PR labeling - part 2 [kafka]

2024-09-23 Thread via GitHub
TaiJuWu opened a new pull request, #17260: URL: https://github.com/apache/kafka/pull/17260 Jira: https://issues.apache.org/jira/browse/KAFKA-17542 test on: https://github.com/TaiJuWu/kafka/pull/10 ### Committer Checklist (excluded from commit message) - [ ] Verify design and impl

[jira] [Comment Edited] (KAFKA-4566) Can't Symlink to Kafka bins

2024-09-23 Thread Alex Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884103#comment-17884103 ] Alex Russell edited comment on KAFKA-4566 at 9/24/24 4:21 AM: -

[jira] [Commented] (KAFKA-4566) Can't Symlink to Kafka bins

2024-09-23 Thread Alex Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884103#comment-17884103 ] Alex Russell commented on KAFKA-4566: - readlink -f appears to be equivalent on both (

[jira] [Commented] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884099#comment-17884099 ] Chia-Ping Tsai commented on KAFKA-17572: [~chiacyu] I have assigned this Jira to

[jira] [Assigned] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17572: -- Assignee: Chia-Chuan Yu > Clear build scan PR status when re-running the tests >

Re: [PR] KAFKA-17459: Stablize reassign_partitions_test.py [kafka]

2024-09-23 Thread via GitHub
chia7712 commented on code in PR #17250: URL: https://github.com/apache/kafka/pull/17250#discussion_r1772502096 ## tests/kafkatest/tests/core/reassign_partitions_test.py: ## @@ -176,7 +176,13 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me

Re: [PR] KAFKA-16331: remove KafkaClientSupplier from StreamsProducer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17259: URL: https://github.com/apache/kafka/pull/17259#discussion_r1772482294 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -1780,13 +1781,24 @@ public Map getGlobalConsumerConfigs(final String clientId) { * @re

Re: [PR] KAFKA-16331: remove KafkaClientSupplier from StreamsProducer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17259: URL: https://github.com/apache/kafka/pull/17259#discussion_r1772483525 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -304,17 +291,11 @@ void closeAndRemoveTaskProducerIfNeeded(final TaskI

Re: [PR] KAFKA-16331: remove KafkaClientSupplier from StreamsProducer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17259: URL: https://github.com/apache/kafka/pull/17259#discussion_r1772482879 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -282,13 +270,12 @@ private StreamTask createActiveTask(final TaskId ta

Re: [PR] KAFKA-16331: remove KafkaClientSupplier from StreamsProducer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17259: URL: https://github.com/apache/kafka/pull/17259#discussion_r1772483810 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -76,7 +76,6 @@ public class RecordCollectorImpl implements RecordCol

Re: [PR] KAFKA-16331: remove KafkaClientSupplier from StreamsProducer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17259: URL: https://github.com/apache/kafka/pull/17259#discussion_r1772481861 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -58,10 +58,13 @@ class ActiveTaskCreator { private final Time tim

[jira] [Commented] (KAFKA-17590) ReplicaFetcher throw CorruptRecordException

2024-09-23 Thread Fake (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884086#comment-17884086 ] Fake commented on KAFKA-17590: -- Additionally, the producer client has the following excepti

[PR] KAFKA-16331: remove KafkaClientSupplier from StreamsProducer [kafka]

2024-09-23 Thread via GitHub
mjsax opened a new pull request, #17259: URL: https://github.com/apache/kafka/pull/17259 With EOSv1 removed, we don't need to create a producer per task, and thus can simplify the code by removing `KafkaClientSupplier` from the deeply nested `StreamsProducer`, to simplify the code. -- Th

Re: [PR] MINOR: Fix SubscriptionResponseWrapperSerializer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on PR #17205: URL: https://github.com/apache/kafka/pull/17205#issuecomment-2369989314 Thanks for the review @chia7712. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Fix SubscriptionResponseWrapperSerializer [kafka]

2024-09-23 Thread via GitHub
mjsax merged PR #17205: URL: https://github.com/apache/kafka/pull/17205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Fix SubscriptionResponseWrapperSerializer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17205: URL: https://github.com/apache/kafka/pull/17205#discussion_r1772476886 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java: ## @@ -73,68 +69,95 @@ public T deserialize(

Re: [PR] MINOR: Fix SubscriptionResponseWrapperSerializer [kafka]

2024-09-23 Thread via GitHub
mjsax commented on code in PR #17205: URL: https://github.com/apache/kafka/pull/17205#discussion_r1772476702 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java: ## @@ -73,68 +69,95 @@ public T deserialize(

[jira] [Comment Edited] (KAFKA-17590) ReplicaFetcher throw CorruptRecordException

2024-09-23 Thread ChenLin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884078#comment-17884078 ] ChenLin edited comment on KAFKA-17590 at 9/24/24 2:05 AM: -- # SS

[jira] [Commented] (KAFKA-17590) ReplicaFetcher throw CorruptRecordException

2024-09-23 Thread ChenLin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884078#comment-17884078 ] ChenLin commented on KAFKA-17590: - # SSL authentication is not enabled on the Kafka serv

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-23 Thread via GitHub
mumrah commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2369931659 In the [checkout action](https://github.com/actions/checkout) you can specify that you want a full checkout instead of sparse. ``` # Specifies whether to use cone-mode when d

[jira] [Updated] (KAFKA-17581) AsyncKafkaConsumer can't unsubscribe invalid topics

2024-09-23 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17581: -- Component/s: clients consumer > AsyncKafkaConsumer can't unsubscribe invalid topics >

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-23 Thread via GitHub
fonsdant commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2369905530 @mumrah, forgive me if I am being too repetitive or slow to develop. I am trying to achieve a great result to us and Kafka contributors. I was afraid to proceed with merge approach

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-23 Thread via GitHub
kirktrue commented on PR #17244: URL: https://github.com/apache/kafka/pull/17244#issuecomment-2369893861 From the PR description: > If AsyncKafkaConsumer subscribes an invalid topic, the background thread will keep sending MetadataRequest with invalid topic, so background event queue

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2024-09-23 Thread via GitHub
rich-c-shop commented on PR #17099: URL: https://github.com/apache/kafka/pull/17099#issuecomment-2369884620 > continuous-integration/jenkins/pr-merge — This commit has test failures Thanks for reviewing. looks like the test failed in un-related tests. Anything I can help to proceed fo

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772344230 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2305,11 +2307,34 @@ public CompletableFuture updateFeatures( }).thenApply(

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772343326 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3603,13 +3603,16 @@ class KafkaApis(val requestChannel: RequestChannel, def sendResponseCallback(errors

[jira] [Commented] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-23 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884066#comment-17884066 ] Chia-Chuan Yu commented on KAFKA-17572: --- Hi, [~davidarthur] Can I have this one p

[PR] KAFKA-17584: Fix incorrect synonym handling for dynamic log configurations [kafka]

2024-09-23 Thread via GitHub
cmccabe opened a new pull request, #17258: URL: https://github.com/apache/kafka/pull/17258 Several Kafka log configurations in have synonyms. For example, log retention can be configured either by log.retention.ms, or by log.retention.minutes, or by log.retention.hours. There is also a facu

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
junrao commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772320884 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2305,11 +2307,34 @@ public CompletableFuture updateFeatures( }).thenApply(r

[jira] [Updated] (KAFKA-17584) Fix incorrect synonym handling for dynamic log configurations

2024-09-23 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17584: - Summary: Fix incorrect synonym handling for dynamic log configurations (was: Incorrect synonym

[jira] [Updated] (KAFKA-17584) Incorrect synonym handling for dynamic log configurations

2024-09-23 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17584: - Summary: Incorrect synonym handling for dynamic log configurations (was: Changing dynamic confi

Re: [PR] KAFKA-17076: retain last batch in each round of cleaning [kafka]

2024-09-23 Thread via GitHub
junrao commented on code in PR #17193: URL: https://github.com/apache/kafka/pull/17193#discussion_r1772299474 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -623,8 +623,12 @@ private[log] class Cleaner(val id: Int, val groupedSegments = groupSegmentsBySize(log.l

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772275727 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3603,13 +3603,16 @@ class KafkaApis(val requestChannel: RequestChannel, def sendResponseCallback(errors

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772273649 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3603,13 +3603,16 @@ class KafkaApis(val requestChannel: RequestChannel, def sendResponseCallback(errors

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772272543 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2305,11 +2307,34 @@ public CompletableFuture updateFeatures( }).thenApply(

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1772266396 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -174,15 +175,27 @@ ControllerResult> updateFeatures( Map upgradeTypes,

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
junrao commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1771950807 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -241,6 +255,16 @@ private ApiError updateFeature( // Perform additio

[PR] KAFKA-17592: Support for SubscribedTopicsRegex in ConsumerGroupHeartbeat RPC [kafka]

2024-09-23 Thread via GitHub
lianetm opened a new pull request, #17257: URL: https://github.com/apache/kafka/pull/17257 This PR includes: - Bump ConsumerGroupHeartbeatRequest version to include subscribedTopicRegex field - Introduce new error code for InvalidSubscriptionRegex - Bump ConsumerGroupHeartbeatRespo

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-23 Thread via GitHub
lianetm commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1772011078 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -246,7 +252,9 @@ private void process(final Subscripti

[jira] [Commented] (KAFKA-16820) Kafka Broker fails to connect to Kraft Controller with no DNS matching

2024-09-23 Thread Arushi Helms (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884014#comment-17884014 ] Arushi Helms commented on KAFKA-16820: -- Hi [~soarez] [~jlprat]  Circling back on th

[jira] [Commented] (KAFKA-17587) Move test infrastructure out of core

2024-09-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883993#comment-17883993 ] David Arthur commented on KAFKA-17587: -- I started splitting out my prototype branch

Re: [PR] MINOR; Replace gt and lt char with html encoding [kafka]

2024-09-23 Thread via GitHub
jsancio commented on PR #17235: URL: https://github.com/apache/kafka/pull/17235#issuecomment-2369061152 > > I couldn't find anything wrong with that line. Did you mean to link to another line? Or did I miss something? > > `true` -> `true` Thanks @chia7712 . Done. -- This is

Re: [PR] MINOR; Replace gt and lt char with html encoding [kafka]

2024-09-23 Thread via GitHub
chia7712 commented on PR #17235: URL: https://github.com/apache/kafka/pull/17235#issuecomment-2369050800 > I couldn't find anything wrong with that line. Did you mean to link to another line? Or did I miss something? `true` -> `true` -- This is an automated message from the Apache

Re: [PR] MINOR: add a space for kafka.metrics.polling.interval.secs description [kafka]

2024-09-23 Thread via GitHub
m1a2st commented on PR #17256: URL: https://github.com/apache/kafka/pull/17256#issuecomment-2369047651 fix 3.8 version document in this [PR](https://github.com/apache/kafka-site/pull/632) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16308 [3/N]: Introduce feature dependency validation to UpdateFeatures command [kafka]

2024-09-23 Thread via GitHub
jolshan commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1771887394 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2305,11 +2306,23 @@ public CompletableFuture updateFeatures( }).thenApply(

[PR] MINOR: add a space for kafka.metrics.polling.interval.secs [kafka]

2024-09-23 Thread via GitHub
m1a2st opened a new pull request, #17256: URL: https://github.com/apache/kafka/pull/17256 As title, there should be a space between `in` and `kafka.metrics.reporters` words. ![CleanShot 2024-09-24 at 02 16 41](https://github.com/user-attachments/assets/4fed41f2-7fe4-42a1-85e4-d3b466829a6

[jira] [Commented] (KAFKA-17576) Fix all references to kraft/server.properties to use reconfig-server.properties

2024-09-23 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883983#comment-17883983 ] 黃竣陽 commented on KAFKA-17576: - Hello [~jsancio] , If you wouldn't work on this, may I take t

Re: [PR] KAFKA-17367: Share coordinator impl. Added additional tests. [3/N] [kafka]

2024-09-23 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1771835934 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -537,38 +539,322 @@ private static ShareGroupOffset merge(ShareGrou

[jira] [Updated] (KAFKA-17599) Update Consumer Subscription with Current Assignment Before Partition Revocation

2024-09-23 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-17599: - External issue URL: https://github.com/apache/kafka/pull/17255 > Update Consumer Subscription wi

Re: [PR] KAFKA-17367: Share coordinator impl. Added additional tests. [3/N] [kafka]

2024-09-23 Thread via GitHub
AndrewJSchofield commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1771822574 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -537,38 +539,322 @@ private static ShareGroupOffset mer

Re: [PR] Updating consumer subscription object with the latest subscription before "invokePartitionRevoked". [kafka]

2024-09-23 Thread via GitHub
kumarpritam863 commented on PR #17255: URL: https://github.com/apache/kafka/pull/17255#issuecomment-2368913632 @C0urante Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Updating consumer subscription object with the latest subscription before "invokePartitionRevoked". [kafka]

2024-09-23 Thread via GitHub
kumarpritam863 opened a new pull request, #17255: URL: https://github.com/apache/kafka/pull/17255 Summary: Ensure that the Kafka consumer subscription object is updated with the current partition assignment before partition revocation, so that close() method of the sink connector's has t

Re: [PR] MINOR; Replace gt and lt char with html encoding [kafka]

2024-09-23 Thread via GitHub
jsancio commented on PR #17235: URL: https://github.com/apache/kafka/pull/17235#issuecomment-2368903179 Thanks @chia7712 . I fixed those encoding issues. > https://github.com/apache/kafka/blob/trunk/docs/ops.html#L4249 I couldn't find anything wrong with that line. Did you mean to l

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-23 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1771804938 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1471,6 +1487,7 @@ public void unsubscribe() { fetchBuf

[jira] [Resolved] (KAFKA-17471) Speed Up ResetConsumerGroupOffsetTest

2024-09-23 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-17471. - Resolution: Won't Fix > Speed Up ResetConsumerGroupOffsetTest > - > >

[jira] [Commented] (KAFKA-17471) Speed Up ResetConsumerGroupOffsetTest

2024-09-23 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883961#comment-17883961 ] 黃竣陽 commented on KAFKA-17471: - This issue is resolved by https://issues.apache.org/jira/brow

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-23 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1771804938 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1471,6 +1487,7 @@ public void unsubscribe() { fetchBuf

Re: [PR] KAFKA-16959: ConfigCommand should allow to define both `entity-default` and `entity-name` [kafka]

2024-09-23 Thread via GitHub
m1a2st commented on PR #16381: URL: https://github.com/apache/kafka/pull/16381#issuecomment-2368834415 rebase on the trunk, and fix the conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (KAFKA-17599) Update Consumer Subscription with Current Assignment Before Partition Revocation

2024-09-23 Thread Pritam Kumar (Jira)
Pritam Kumar created KAFKA-17599: Summary: Update Consumer Subscription with Current Assignment Before Partition Revocation Key: KAFKA-17599 URL: https://issues.apache.org/jira/browse/KAFKA-17599 Proj

[jira] [Commented] (KAFKA-17590) ReplicaFetcher throw CorruptRecordException

2024-09-23 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883955#comment-17883955 ] Jun Rao commented on KAFKA-17590: - If the on disk data in fine, this might be a network

Re: [PR] MINOR: Fix a race and add JMH bench for HdrHistogram [kafka]

2024-09-23 Thread via GitHub
dimitarndimitrov commented on code in PR #17221: URL: https://github.com/apache/kafka/pull/17221#discussion_r1771776869 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java: ## @@ -172,4 +177,39 @@ public void testHistogramDataRes

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-23 Thread via GitHub
fonsdant commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2368771036 @mumrah, thanks for the explanation. I really appreciate it! :) I will proceed modifying the script to use ref. -- This is an automated message from the Apache Git Service. To re

Re: [PR] KAFKA-17277: [2/2] Add feature dependency command to the storage and the feature command tool [kafka]

2024-09-23 Thread via GitHub
rreddy-22 commented on code in PR #17093: URL: https://github.com/apache/kafka/pull/17093#discussion_r1771746899 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -260,6 +325,21 @@ object StorageTool extends Logging { s"${MetadataVersion.IBP_3_0_IV0}; the defa

Re: [PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-09-23 Thread via GitHub
fonsdant commented on PR #17198: URL: https://github.com/apache/kafka/pull/17198#issuecomment-2368758343 I have removed the references to `transform` from docs. I am wondering if it would be better to replace `transform` with `process`, instead of removing it. I have started to think about

[jira] [Commented] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883942#comment-17883942 ] Chia-Ping Tsai commented on KAFKA-17572: {quote} Maybe we can add a conditional

Re: [PR] KAFKA-17578: Remove partitionRacks from TopicMetadata [kafka]

2024-09-23 Thread via GitHub
dajac commented on PR #17233: URL: https://github.com/apache/kafka/pull/17233#issuecomment-2368724037 @FrankYang0529 There are a few conflicts. Could you please address them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883931#comment-17883931 ] David Arthur commented on KAFKA-17572: -- Yes, setting the status to pending seems li

[jira] [Commented] (KAFKA-17598) Command line validation tool for RE2J regex

2024-09-23 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883917#comment-17883917 ] PoAn Yang commented on KAFKA-17598: --- Hi [~lianetm], I'm interested in this Jira. Could

Re: [PR] KAFKA-17459: Stablize reassign_partitions_test.py [kafka]

2024-09-23 Thread via GitHub
frankvicky commented on code in PR #17250: URL: https://github.com/apache/kafka/pull/17250#discussion_r1771647091 ## tests/kafkatest/tests/core/reassign_partitions_test.py: ## @@ -176,7 +176,10 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me

Re: [PR] KAFKA-17459: Stablize reassign_partitions_test.py [kafka]

2024-09-23 Thread via GitHub
chia7712 commented on code in PR #17250: URL: https://github.com/apache/kafka/pull/17250#discussion_r1771641828 ## tests/kafkatest/tests/core/reassign_partitions_test.py: ## @@ -176,7 +176,10 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me

[PR] KAFKA-16495 Fix flaky TransactionsWithTieredStoreTest#testCommitTransactionTimeout [kafka]

2024-09-23 Thread via GitHub
m1a2st opened a new pull request, #17254: URL: https://github.com/apache/kafka/pull/17254 In this test, I think is the [max.block.ms](https://kafka.apache.org/documentation/#producerconfigs_max.block.ms) is so short for `initTransactions()`, however this test should test that commit fail,

[jira] [Updated] (KAFKA-17591) Consumer protocol subscription regex support

2024-09-23 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17591: --- Labels: kip-848 (was: ) > Consumer protocol subscription regex support > -

[jira] [Created] (KAFKA-17598) Command line validation tool for RE2J regex

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17598: -- Summary: Command line validation tool for RE2J regex Key: KAFKA-17598 URL: https://issues.apache.org/jira/browse/KAFKA-17598 Project: Kafka Issue Type: S

[jira] [Created] (KAFKA-17597) Update OffsetsMetadataManager to consider topics subscribed from regex

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17597: -- Summary: Update OffsetsMetadataManager to consider topics subscribed from regex Key: KAFKA-17597 URL: https://issues.apache.org/jira/browse/KAFKA-17597 Project: K

[jira] [Resolved] (KAFKA-17495) Factor out common setup from server-side assignor benchmarks

2024-09-23 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-17495. - Fix Version/s: 4.0.0 Resolution: Fixed > Factor out common setup from server-side assigno

Re: [PR] KAFKA-17495: Factor out assignor benchmark code into utils class [kafka]

2024-09-23 Thread via GitHub
dajac merged PR #17133: URL: https://github.com/apache/kafka/pull/17133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-23 Thread via GitHub
mumrah commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2368526553 @fonsdant, just updating the ref on the remote (GitHub) would indeed work. In Git, a ref is simply a text file with a SHA in it. Conventionally, tags are immutable since they are typ

[jira] [Created] (KAFKA-17596) Benchmark regex resolution

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17596: -- Summary: Benchmark regex resolution Key: KAFKA-17596 URL: https://issues.apache.org/jira/browse/KAFKA-17596 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17595) Stored regexes refresh to reflect metadata changes

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17595: -- Summary: Stored regexes refresh to reflect metadata changes Key: KAFKA-17595 URL: https://issues.apache.org/jira/browse/KAFKA-17595 Project: Kafka Issue

[jira] [Created] (KAFKA-17594) Integrate resolved regexes in assignment computation

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17594: -- Summary: Integrate resolved regexes in assignment computation Key: KAFKA-17594 URL: https://issues.apache.org/jira/browse/KAFKA-17594 Project: Kafka Issu

[jira] [Created] (KAFKA-17593) Async regex resolution

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17593: -- Summary: Async regex resolution Key: KAFKA-17593 URL: https://issues.apache.org/jira/browse/KAFKA-17593 Project: Kafka Issue Type: Sub-task R

[jira] [Created] (KAFKA-17592) Support for subscription regex in HB RPC

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17592: -- Summary: Support for subscription regex in HB RPC Key: KAFKA-17592 URL: https://issues.apache.org/jira/browse/KAFKA-17592 Project: Kafka Issue Type: Sub-

[jira] [Created] (KAFKA-17591) Consumer protocol subscription regex support

2024-09-23 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17591: -- Summary: Consumer protocol subscription regex support Key: KAFKA-17591 URL: https://issues.apache.org/jira/browse/KAFKA-17591 Project: Kafka Issue Type:

Re: [PR] KAFKA-17574: Allow overriding TestKitNodes baseDirectory [kafka]

2024-09-23 Thread via GitHub
srdo commented on code in PR #17225: URL: https://github.com/apache/kafka/pull/17225#discussion_r1771535619 ## core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java: ## @@ -122,4 +126,25 @@ public void testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {

Re: [PR] KAFKA-17574: Allow overriding TestKitNodes baseDirectory [kafka]

2024-09-23 Thread via GitHub
chia7712 commented on code in PR #17225: URL: https://github.com/apache/kafka/pull/17225#discussion_r1771528836 ## core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java: ## @@ -122,4 +126,25 @@ public void testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {

Re: [PR] KAFKA-17574: Allow overriding TestKitNodes baseDirectory [kafka]

2024-09-23 Thread via GitHub
srdo commented on code in PR #17225: URL: https://github.com/apache/kafka/pull/17225#discussion_r1771522261 ## core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java: ## @@ -122,4 +126,25 @@ public void testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {

Re: [PR] MINOR: Bump zstd-jni from 1.5.6-5 to 1.5.6-6 [kafka]

2024-09-23 Thread via GitHub
olegbonar commented on PR #17253: URL: https://github.com/apache/kafka/pull/17253#issuecomment-2368206551 @jlprat done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-23 Thread via GitHub
FrankYang0529 commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1771374443 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1471,6 +1487,7 @@ public void unsubscribe() { fe

[jira] [Commented] (KAFKA-17590) ReplicaFetcher throw CorruptRecordException

2024-09-23 Thread ChenLin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883876#comment-17883876 ] ChenLin commented on KAFKA-17590: - hi [~junrao] hi [~ijuma],  could you please have a l

Re: [PR] KAFKA-16908: Refactor `QuorumConfig` with `AbstractConfig` [kafka]

2024-09-23 Thread via GitHub
xijiu commented on PR #17231: URL: https://github.com/apache/kafka/pull/17231#issuecomment-2368132282 @chia7712I have modified the code and remove some getter methods from `KafkaConfig`,PTAL -- This is an automated message from the Apache Git Service. To respond to the message, p

  1   2   >