[jira] [Assigned] (KAFKA-19500) kafka-consumer-groups.sh should fail quickly if the partition leader is unavailable

2025-07-14 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangning.li reassigned KAFKA-19500: --- Assignee: kangning.li (was: Chia-Ping Tsai) > kafka-consumer-groups.sh should fail quickly

[jira] [Updated] (KAFKA-19506) Implement dynamic compression type selection and fallback for client telemetry

2025-07-14 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina updated KAFKA-19506: -- Description: Kafka clients currently select the first compression type offered by the broker

Re: [PR] KAFKA-19500: `kafka-consumer-groups.sh` should fail quickly if the partition leader is unavailable [kafka]

2025-07-14 Thread via GitHub
xijiu commented on PR #20168: URL: https://github.com/apache/kafka/pull/20168#issuecomment-3072209689 The all methods which depend on `Admin#listOffsets` are as follows: - offsetsUtils.resetToOffset - offsetsUtils.resetToEarliest - offsetsUtils.resetToLatest - offsetsUtils.re

[PR] KAFKA-19500: `kafka-consumer-groups.sh` should fail quickly if the partition leader is unavailable [kafka]

2025-07-14 Thread via GitHub
xijiu opened a new pull request, #20168: URL: https://github.com/apache/kafka/pull/20168 1. Add check leader missing logic in method `ConsumerGroupCommand.ConsumerGroupService#prepareOffsetsToReset` in order to fail quickly 2. Add some tests -- This is an automated message from the Ap

[jira] [Created] (KAFKA-19506) Implement dynamic compression type selection and fallback for client telemetry

2025-07-14 Thread Kaushik Raina (Jira)
Kaushik Raina created KAFKA-19506: - Summary: Implement dynamic compression type selection and fallback for client telemetry Key: KAFKA-19506 URL: https://issues.apache.org/jira/browse/KAFKA-19506 Proj

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-14 Thread via GitHub
AndrewJSchofield commented on PR #20159: URL: https://github.com/apache/kafka/pull/20159#issuecomment-3072189298 > @AndrewJSchofield Thanks for your comments 🙇‍♂️ I'm new to make a KIP. I have one question! > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Propo

[jira] [Commented] (KAFKA-14915) Option to consume multiple partitions that have their data in remote storage for the target offsets.

2025-07-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005321#comment-18005321 ] Luke Chen commented on KAFKA-14915: --- No, it's too late to get included in v4.1.0. Chan

[jira] [Updated] (KAFKA-14915) Option to consume multiple partitions that have their data in remote storage for the target offsets.

2025-07-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14915: -- Fix Version/s: 4.2.0 (was: 4.1.0) > Option to consume multiple partitions that

[jira] [Updated] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2025-07-14 Thread Rajani Karuturi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajani Karuturi updated KAFKA-12281: Attachment: image-2025-07-15-11-24-19-092.png > Deprecate org.apache.kafka.streams.errors.

[jira] [Commented] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2025-07-14 Thread Rajani Karuturi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005298#comment-18005298 ] Rajani Karuturi commented on KAFKA-12281: - I am able to assign Jira issue but I

Re: [PR] MINOR: Add ShareFetch quota session verification test [kafka]

2025-07-14 Thread via GitHub
sjhajharia commented on PR #20164: URL: https://github.com/apache/kafka/pull/20164#issuecomment-3072058105 Thanks @apoorvmittal10 for the review. I have added a couple of tests as suggested by you - `testHandleShareAcknowledgeRequestQuotaTagsVerification` and `testHandleShareFetchWithAckn

[jira] [Assigned] (KAFKA-12380) Executor in Connect's Worker is not shut down when the worker is

2025-07-14 Thread Rajani Karuturi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajani Karuturi reassigned KAFKA-12380: --- Assignee: Rajani Karuturi > Executor in Connect's Worker is not shut down when the

[jira] [Assigned] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2025-07-14 Thread Rajani Karuturi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajani Karuturi reassigned KAFKA-12281: --- Assignee: Rajani Karuturi (was: Chia-Ping Tsai) > Deprecate org.apache.kafka.strea

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2206425362 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1225,7 +1230,9 @@ private ClusterAndWaitTime waitOnMetadata(String topic, Intege

[jira] [Assigned] (KAFKA-19497) Topic replay code does not handle creation and deletion properly if it occurs in the same batch

2025-07-14 Thread zhu zhe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhu zhe reassigned KAFKA-19497: --- Assignee: zhu zhe (was: Kevin Wu) > Topic replay code does not handle creation and deletion proper

[jira] [Commented] (KAFKA-14915) Option to consume multiple partitions that have their data in remote storage for the target offsets.

2025-07-14 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005290#comment-18005290 ] Kamal Chandraprakash commented on KAFKA-14915: -- [~showuon] [~satish.duggana

Re: [PR] MINOR: Cleanup Connect Module (3/n) [kafka]

2025-07-14 Thread via GitHub
sjhajharia commented on PR #20156: URL: https://github.com/apache/kafka/pull/20156#issuecomment-3071915240 Thanks @m1a2st for the comment. I have addressed the same at all locations where it is possible. Requesting a re-review. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-19357: AsyncConsumer#close hangs during closing because the commitAsync request never completes due to a missing coordinator [kafka]

2025-07-14 Thread via GitHub
Yunyung commented on code in PR #19914: URL: https://github.com/apache/kafka/pull/19914#discussion_r2206245015 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -452,6 +452,34 @@ private void testPosition

Re: [PR] KAFKA-19357: AsyncConsumer#close hangs during closing because the commitAsync request never completes due to a missing coordinator [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #19914: URL: https://github.com/apache/kafka/pull/19914#discussion_r2206233011 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -452,6 +452,34 @@ private void testPositio

[jira] [Resolved] (KAFKA-19459) List internal topics for the user

2025-07-14 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-19459. - Fix Version/s: 4.2.0 Resolution: Fixed > List internal topics for the user >

Re: [PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-14 Thread via GitHub
frankvicky merged PR #20157: URL: https://github.com/apache/kafka/pull/20157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19039: The refresh_collaborators.py script messes .asf.yaml [kafka]

2025-07-14 Thread via GitHub
github-actions[bot] commented on PR #19459: URL: https://github.com/apache/kafka/pull/19459#issuecomment-3071797420 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18874: Fix KRaft controller registration retry on timeout [kafka]

2025-07-14 Thread via GitHub
github-actions[bot] commented on PR #19321: URL: https://github.com/apache/kafka/pull/19321#issuecomment-3071797324 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-19106 : Improve SourceTask commit() hook [kafka]

2025-07-14 Thread via GitHub
github-actions[bot] commented on PR #19418: URL: https://github.com/apache/kafka/pull/19418#issuecomment-3071797383 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-14 Thread via GitHub
frankvicky commented on PR #20157: URL: https://github.com/apache/kafka/pull/20157#issuecomment-3071792117 Fail test is traced by #20167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-19357: AsyncConsumer#close hangs during closing because the commitAsync request never completes due to a missing coordinator [kafka]

2025-07-14 Thread via GitHub
Mirai1129 commented on code in PR #19914: URL: https://github.com/apache/kafka/pull/19914#discussion_r2206219409 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -452,6 +452,34 @@ private void testPositi

Re: [PR] KAFKA-19357: AsyncConsumer#close hangs during closing because the commitAsync request never completes due to a missing coordinator [kafka]

2025-07-14 Thread via GitHub
Mirai1129 commented on code in PR #19914: URL: https://github.com/apache/kafka/pull/19914#discussion_r2206217684 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -452,6 +452,34 @@ private void testPositi

Re: [PR] KAFKA-19070: add taskId to consumer override clientId [kafka]

2025-07-14 Thread via GitHub
github-actions[bot] commented on PR #19382: URL: https://github.com/apache/kafka/pull/19382#issuecomment-3071776801 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-14 Thread via GitHub
zzbennett commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2206027601 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -50,16 +49,16 @@ public class InternalTopicManag

Re: [PR] KAFKA-19471: Enable acknowledgement for a record which could not be deserialized [kafka]

2025-07-14 Thread via GitHub
DL1231 commented on code in PR #20148: URL: https://github.com/apache/kafka/pull/20148#discussion_r2206133813 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetch.java: ## @@ -123,6 +123,25 @@ public void acknowledge(final ConsumerRecord record, Ackno

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071526778 cherry-picked to 4.0 d95857a155943013fe6da5d613b505e6e9688c16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071440642 cherry-picked to 4.1 f35f94b3e619f7a55abc2350f852153323d8f3b9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-19357: AsyncConsumer#close hangs during closing because the commitAsync request never completes due to a missing coordinator [kafka]

2025-07-14 Thread via GitHub
kirktrue commented on code in PR #19914: URL: https://github.com/apache/kafka/pull/19914#discussion_r2206031972 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -452,6 +452,34 @@ private void testPositio

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-14 Thread via GitHub
zzbennett commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2206027601 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -50,16 +49,16 @@ public class InternalTopicManag

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-14 Thread via GitHub
kirktrue commented on code in PR #20134: URL: https://github.com/apache/kafka/pull/20134#discussion_r2206026360 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -579,7 +579,7 @@ public void testConstructorWithNotStringKey() { Conf

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071403259 Merged #20166 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck merged PR #20166: URL: https://github.com/apache/kafka/pull/20166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19842: Fix flaky KafkaStreamsTelemetryIntegrationTest [kafka]

2025-07-14 Thread via GitHub
mjsax merged PR #20147: URL: https://github.com/apache/kafka/pull/20147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19504: Affects Version/s: (was: 4.1.0) > AdminClient creates and adds second metrics reporter

[jira] [Updated] (KAFKA-19357) AsyncConsumer#close hangs during closing because the commitAsync request never completes due to a missing coordinator

2025-07-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19357: -- Component/s: clients consumer > AsyncConsumer#close hangs during closing because the

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-14 Thread via GitHub
zzbennett commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2205958400 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -38,7 +38,7 @@ private EndpointToPartitio

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-14 Thread via GitHub
chickenchickenlove commented on PR #20159: URL: https://github.com/apache/kafka/pull/20159#issuecomment-3071254140 @AndrewJSchofield Thanks for your comments 🙇‍♂️ I'm new to make a KIP. I have one question! https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Pr

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-14 Thread via GitHub
chickenchickenlove commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2205941778 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1225,7 +1230,9 @@ private ClusterAndWaitTime waitOnMetadata(String topi

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-14 Thread via GitHub
chickenchickenlove commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2205941778 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1225,7 +1230,9 @@ private ClusterAndWaitTime waitOnMetadata(String topi

Re: [PR] KAFKA-19505: update mock for UnifiedLog#topicId in ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest [kafka]

2025-07-14 Thread via GitHub
gaurav-narula commented on code in PR #20167: URL: https://github.com/apache/kafka/pull/20167#discussion_r2205938396 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3603,6 +3603,7 @@ class ReplicaManagerTest { val tidp1 = new TopicIdPartition(topic

Re: [PR] MINOR: Refactor LockUtils and improve comments (follow up to KAFKA-19390) [kafka]

2025-07-14 Thread via GitHub
Forest0923 commented on code in PR #20131: URL: https://github.com/apache/kafka/pull/20131#discussion_r2205920723 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -48,7 +47,10 @@ private enum SearchResultType { private static final

Re: [PR] MINOR:Add a description document to batchlength [kafka]

2025-07-14 Thread via GitHub
chia7712 merged PR #20140: URL: https://github.com/apache/kafka/pull/20140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2205875694 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,8 +718,8 @@ private Optional> createPushRequest(ClientTe

[jira] [Updated] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19504: --- Fix Version/s: 4.0.1 4.1.0 > AdminClient creates and adds second metrics

[jira] [Updated] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19504: --- Affects Version/s: 4.0.0 > AdminClient creates and adds second metrics reporter > -

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2205859421 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1225,7 +1230,9 @@ private ClusterAndWaitTime waitOnMetadata(String topic, Intege

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071040441 > > Correct, I've updated the PR comment. The PR does resolve this situation. > > the bug also exists in 4.0 and 4.1, so it would be useful to backport the fix to both active branch

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071024312 > Correct, I've updated the PR comment. The PR does resolve this situation. the bug also exists in 4.0 and 4.1, so it would be useful to backport the fix to both active branches.

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-14 Thread via GitHub
ezhou413 commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3071023008 @chia7712 @kirktrue Could I get a re-review for this PR? The unit test failures in CI seem to be unrelated to my changes. Thanks! cc @mjsax -- This is an automated message from

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071013419 > > Note, this > > issue only exists if telemetry metrics is enabled for the AdminClient > > and it is disabled by default. > > Excuse me, the true issue is the 2x `reporters`

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on PR #20166: URL: https://github.com/apache/kafka/pull/20166#issuecomment-3071003867 > Note, this issue only exists if telemetry metrics is enabled for the AdminClient and it is disabled by default. Excuse me, the true issue is the 2x `reporters` are created,

Re: [PR] KAFKA-19505: update mock for UnifiedLog#topicId in ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #20167: URL: https://github.com/apache/kafka/pull/20167#discussion_r2205794747 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3603,6 +3603,7 @@ class ReplicaManagerTest { val tidp1 = new TopicIdPartition(topicId, t

Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.1IV1 and Use MV to enable ELR [kafka]

2025-07-14 Thread via GitHub
junrao commented on PR #20137: URL: https://github.com/apache/kafka/pull/20137#issuecomment-3070909261 > Regarding the error, I am not sure that a 4.1 release should mention a 4.2 metadata testing version as maximum value, something which is "in the future" and after the 4.1 itself. > In

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on code in PR #20166: URL: https://github.com/apache/kafka/pull/20166#discussion_r2205762340 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -579,10 +579,12 @@ static KafkaAdminClient createInternal(AdminClientConfig config

[jira] [Resolved] (KAFKA-19254) Add generic feature level metric

2025-07-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19254. Resolution: Fixed > Add generic feature level metric > >

Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.1IV1 and Use MV to enable ELR [kafka]

2025-07-14 Thread via GitHub
ppatierno commented on PR #20137: URL: https://github.com/apache/kafka/pull/20137#issuecomment-3070883611 The first part about adding 4.1 was clear as I described in the email. Regarding the error, I am not sure that a 4.1 release should mention a 4.2 metadata testing version as maximum v

Re: [PR] MINOR: Extend Quota Tests for ShareFetch requests [kafka]

2025-07-14 Thread via GitHub
apoorvmittal10 merged PR #20163: URL: https://github.com/apache/kafka/pull/20163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on PR #20021: URL: https://github.com/apache/kafka/pull/20021#issuecomment-3070883099 @kevin-wu24 thanks for your patience. If other reviewers have more comments for this PR, we could address them in the follow-up -- This is an automated message from the Apache G

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-07-14 Thread via GitHub
chia7712 merged PR #20021: URL: https://github.com/apache/kafka/pull/20021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.1IV1 and Use MV to enable ELR [kafka]

2025-07-14 Thread via GitHub
junrao commented on PR #20137: URL: https://github.com/apache/kafka/pull/20137#issuecomment-3070867513 > Maybe I lack some understanding but I don't get how the PR solves the issue related to the exception mentioning "maximum version is 4.2-IV1" (in a 4.1 release) because it's coming from t

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
Yunyung commented on code in PR #20166: URL: https://github.com/apache/kafka/pull/20166#discussion_r2205707666 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -579,10 +579,12 @@ static KafkaAdminClient createInternal(AdminClientConfig config

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck commented on code in PR #20166: URL: https://github.com/apache/kafka/pull/20166#discussion_r2205649675 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -627,9 +627,7 @@ private KafkaAdminClient(AdminClientConfig config, Co

[jira] [Updated] (KAFKA-19505) ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest fails due to random topic-id in mocked log

2025-07-14 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula updated KAFKA-19505: -- Fix Version/s: 4.2.0 > ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest fails due

Re: [PR] KAFKA-19505: update mock for UnifiedLog#topicId in ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest [kafka]

2025-07-14 Thread via GitHub
gaurav-narula commented on PR #20167: URL: https://github.com/apache/kafka/pull/20167#issuecomment-3070685910 CC: @showuon @satishd this is related to #20045 which was merged earlier today -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] KAFKA-19505: update mock for UnifiedLog#topicId in ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest [kafka]

2025-07-14 Thread via GitHub
gaurav-narula opened a new pull request, #20167: URL: https://github.com/apache/kafka/pull/20167 The mocked value for `UnifiedLog#topicId` was incorrectly set up which caused test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.1IV1 and Use MV to enable ELR [kafka]

2025-07-14 Thread via GitHub
ppatierno commented on code in PR #20137: URL: https://github.com/apache/kafka/pull/20137#discussion_r2205627022 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -83,7 +83,9 @@ public void testFromVersionString() { assertEqua

[jira] [Resolved] (KAFKA-19451) Fix flaky test: RemoteIndexCacheTest.testCacheEntryIsDeletedOnRemoval()

2025-07-14 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-19451. - Fix Version/s: 4.2.0 Resolution: Fixed Merged the PR to trunk. > Fix flaky test: RemoteIndexCach

Re: [PR] KAFKA-19451: fix flaky test RemoteIndexCacheTest.testCacheEntryIsDeletedOnRemoval() [kafka]

2025-07-14 Thread via GitHub
junrao merged PR #20085: URL: https://github.com/apache/kafka/pull/20085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Updated] (KAFKA-19505) ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest fails due to random topic-id in mocked log

2025-07-14 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula updated KAFKA-19505: -- Description: {{ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest}} fails in {{tru

[jira] [Assigned] (KAFKA-19505) ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest fails due to random topic-id in mocked log

2025-07-14 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula reassigned KAFKA-19505: - Assignee: Gaurav Narula > ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest

[jira] [Created] (KAFKA-19505) ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest fails due to random topic-id in mocked log

2025-07-14 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-19505: - Summary: ReplicaManagerTest#testMultipleRemoteFetchesInOneFetchRequest fails due to random topic-id in mocked log Key: KAFKA-19505 URL: https://issues.apache.org/jira/browse/KA

Re: [PR] KAFKA-19305 Ensure all image classes are immutable [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #19847: URL: https://github.com/apache/kafka/pull/19847#discussion_r2205596374 ## metadata/src/main/java/org/apache/kafka/image/ClientQuotaImage.java: ## @@ -39,21 +39,11 @@ * * This class is thread-safe. */ -public final class ClientQuotaI

Re: [PR] MINOR: Add ShareFetch quota session verification test [kafka]

2025-07-14 Thread via GitHub
apoorvmittal10 commented on code in PR #20164: URL: https://github.com/apache/kafka/pull/20164#discussion_r2205584011 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -9510,6 +9620,25 @@ class KafkaApisTest extends Logging { requestMetrics, envelope = N

Re: [PR] MINOR: Refactor LockUtils and improve comments (follow up to KAFKA-19390) [kafka]

2025-07-14 Thread via GitHub
chia7712 commented on code in PR #20131: URL: https://github.com/apache/kafka/pull/20131#discussion_r2205585439 ## server-common/src/main/java/org/apache/kafka/server/util/LockUtils.java: ## @@ -115,7 +70,7 @@ public static T inLockThrows(Lock lock, ThrowingSupplie * @th

Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.1IV1 and Use MV to enable ELR [kafka]

2025-07-14 Thread via GitHub
junrao commented on code in PR #20137: URL: https://github.com/apache/kafka/pull/20137#discussion_r2205560889 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -83,7 +83,9 @@ public void testFromVersionString() { assertEquals(

Re: [PR] KAFKA-19504: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
apoorvmittal10 commented on code in PR #20166: URL: https://github.com/apache/kafka/pull/20166#discussion_r2205559646 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -627,9 +627,7 @@ private KafkaAdminClient(AdminClientConfig config,

[jira] [Commented] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005217#comment-18005217 ] Bill Bejeck commented on KAFKA-19504: - PR - https://github.com/apache/kafka/pull/201

Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.1IV1 and Use MV to enable ELR [kafka]

2025-07-14 Thread via GitHub
junrao commented on PR #20137: URL: https://github.com/apache/kafka/pull/20137#issuecomment-3070548698 Also, we need to change `MetadataVersionTest.testFromVersionString()` to add the latest production version for 4.1. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-14 Thread via GitHub
aliehsaeedii commented on PR #20157: URL: https://github.com/apache/kafka/pull/20157#issuecomment-3070530690 Gets approval from me. Thanks @lucliu1108 cc: @frankvicky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] MINOR: Cleanups in coordinator-common/group-coordinator [kafka]

2025-07-14 Thread via GitHub
dongnuo123 commented on code in PR #20097: URL: https://github.com/apache/kafka/pull/20097#discussion_r2205506242 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -219,7 +219,7 @@ public static Map> assignmentFromTopicPartitions( ) {

[PR] KAFKA-19505: Remove unused metrics reporter initialization in KafkaAdminClient [kafka]

2025-07-14 Thread via GitHub
bbejeck opened a new pull request, #20166: URL: https://github.com/apache/kafka/pull/20166 The `AdminClient` adds a telemetry reporter to the metrics reporters list in the constructor. The problem is that the reporter was already added in the `createInternal` method. In the `createInterna

Re: [PR] KAFKA-19471: Enable acknowledgement for a record which could not be deserialized [kafka]

2025-07-14 Thread via GitHub
AndrewJSchofield commented on code in PR #20148: URL: https://github.com/apache/kafka/pull/20148#discussion_r2205460164 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetch.java: ## @@ -123,6 +123,25 @@ public void acknowledge(final ConsumerRecord reco

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-14 Thread via GitHub
AndrewJSchofield commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2205466415 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetadataImage.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apa

[jira] [Commented] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005208#comment-18005208 ] Bill Bejeck commented on KAFKA-19504: - Hi [~isding_l] - thanks for offering, but I h

[jira] [Assigned] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-19504: --- Assignee: Bill Bejeck > AdminClient creates and adds second metrics reporter > ---

[jira] [Comment Edited] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005203#comment-18005203 ] Lan Ding edited comment on KAFKA-19504 at 7/14/25 5:16 PM: --- Hi

[jira] [Commented] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005203#comment-18005203 ] Lan Ding commented on KAFKA-19504: -- Hi[~bbejeck], if you're not working on this, may I

[jira] [Created] (KAFKA-19504) AdminClient creates and adds second metrics reporter

2025-07-14 Thread Bill Bejeck (Jira)
Bill Bejeck created KAFKA-19504: --- Summary: AdminClient creates and adds second metrics reporter Key: KAFKA-19504 URL: https://issues.apache.org/jira/browse/KAFKA-19504 Project: Kafka Issue Typ

Re: [PR] MINOR: Refactor LockUtils and improve comments (follow up to KAFKA-19390) [kafka]

2025-07-14 Thread via GitHub
junrao commented on code in PR #20131: URL: https://github.com/apache/kafka/pull/20131#discussion_r2205387026 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -48,7 +47,10 @@ private enum SearchResultType { private static final Log

Re: [PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-14 Thread via GitHub
aliehsaeedii commented on code in PR #20157: URL: https://github.com/apache/kafka/pull/20157#discussion_r2205389398 ## tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsGroupTest.java: ## @@ -405,11 +405,18 @@ public void testDeleteAllGroupsAfterVersionDowngrade()

[jira] [Resolved] (KAFKA-19452) Fix flaky test: LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments

2025-07-14 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-19452. - Fix Version/s: 4.2.0 Resolution: Fixed merged the PR to trunk > Fix flaky test: > LogRecoveryTe

[jira] [Assigned] (KAFKA-19452) Fix flaky test: LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments

2025-07-14 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reassigned KAFKA-19452: --- Assignee: Rajani Karuturi > Fix flaky test: > LogRecoveryTest.testHWCheckpointWithFailuresMultiple

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-14 Thread via GitHub
junrao merged PR #20121: URL: https://github.com/apache/kafka/pull/20121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Commented] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

2025-07-14 Thread ally heev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005187#comment-18005187 ] ally heev commented on KAFKA-15331: --- I think this is ticket is no longer valid since Z

Re: [PR] WIP: Test against Java 24 [kafka]

2025-07-14 Thread via GitHub
srdo commented on PR #19514: URL: https://github.com/apache/kafka/pull/19514#issuecomment-3070127396 @chia7712 I would, but Spotbugs 4.9.4 has still not released. I'll update this PR as soon as they put out the new version. -- This is an automated message from the Apache Git Service. To r

  1   2   >