pegasas commented on PR #17059:
URL: https://github.com/apache/kafka/pull/17059#issuecomment-2343272830
f
FrankYang0529 commented on code in PR #17075:
URL: https://github.com/apache/kafka/pull/17075#discussion_r1753881144
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/SeekUnvalidatedEvent.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software
mimaison commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1753849319
##
config/kraft/reconfig-server.properties:
##
@@ -0,0 +1,132 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
It's unclear
mimaison commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1753841794
##
docs/ops.html:
##
@@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port
mimaison commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1753837295
##
docs/ops.html:
##
@@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port
mimaison commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1753780968
##
docs/ops.html:
##
@@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port
mimaison commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1753776432
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port
mimaison commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1753754828
##
docs/quickstart.html:
##
@@ -32,8 +32,8 @@
the latest Kafka release and extract it:
-$ tar -xzf
kafka_{{scalaVersion}}-{{fullDotV
AndrewJSchofield commented on code in PR #17046:
URL: https://github.com/apache/kafka/pull/17046#discussion_r1753746159
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -620,6 +699,17 @@ private void deleteAndVerifyGroupConfigValue(Admin client,
omkreddy merged PR #16916:
URL: https://github.com/apache/kafka/pull/16916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #14216:
URL: https://github.com/apache/kafka/pull/14216#issuecomment-2342917872
@lucasbru I open https://issues.apache.org/jira/browse/KAFKA-17520 for
bumping the version. Please let me know if you have any concerns
--
This is an automated message from the Apache
dimitarndimitrov commented on code in PR #16949:
URL: https://github.com/apache/kafka/pull/16949#discussion_r1753395793
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java:
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software F
ShivsundarR closed pull request #17009: KAFKA-17287: Added integration tests
for ShareConsumer
URL: https://github.com/apache/kafka/pull/17009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
chia7712 merged PR #17027:
URL: https://github.com/apache/kafka/pull/17027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #17158:
URL: https://github.com/apache/kafka/pull/17158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #17162:
URL: https://github.com/apache/kafka/pull/17162#issuecomment-2342720223
Should `kafka-merge-pr.py` be included?
https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
--
This is an automated message from the Apache Git Service.
To respond to th
adixitconfluent commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1753171734
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1750,159 +1647,439 @@ public void testAcknowledgeEmptyPartitionCacheMap() {
adixitconfluent commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1753171734
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1750,159 +1647,439 @@ public void testAcknowledgeEmptyPartitionCacheMap() {
frankvicky opened a new pull request, #17164:
URL: https://github.com/apache/kafka/pull/17164
JIRA: [KAFKA-17253](https://issues.apache.org/jira/browse/KAFKA-17253)
> The helper class `Joined` has four getter methods `gracePeriod()`,
`keySerde()`, `valueSerde()` and `otherValueSerde()` wh
chenyulin0719 commented on code in PR #17117:
URL: https://github.com/apache/kafka/pull/17117#discussion_r1753097885
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -85,6 +88,9 @@ static List forKRaftGroupCoordinator() {
m1a2st commented on code in PR #17117:
URL: https://github.com/apache/kafka/pull/17117#discussion_r1753082058
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -85,6 +88,9 @@ static List forKRaftGroupCoordinator() {
M
chenyulin0719 commented on code in PR #17117:
URL: https://github.com/apache/kafka/pull/17117#discussion_r1753077397
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -85,6 +88,9 @@ static List forKRaftGroupCoordinator() {
mjsax opened a new pull request, #17163:
URL: https://github.com/apache/kafka/pull/17163
Implements KIP-1065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
showuon commented on code in PR #17154:
URL: https://github.com/apache/kafka/pull/17154#discussion_r1753034548
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -805,6 +805,10 @@ private Void deleteTypeIfExists(StorageAction delete, Stri
showuon commented on code in PR #17147:
URL: https://github.com/apache/kafka/pull/17147#discussion_r1753049138
##
metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java:
##
@@ -232,6 +232,32 @@ CompletableFuture
enqueueMetadataChangeEventWithFu
showuon commented on code in PR #17154:
URL: https://github.com/apache/kafka/pull/17154#discussion_r1753034548
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -805,6 +805,10 @@ private Void deleteTypeIfExists(StorageAction delete, Stri
mumrah opened a new pull request, #17162:
URL: https://github.com/apache/kafka/pull/17162
Move reviewers.py and approve-workflows.py into committer-tools. Also update
the README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax merged PR #17156:
URL: https://github.com/apache/kafka/pull/17156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on PR #17156:
URL: https://github.com/apache/kafka/pull/17156#issuecomment-2342452600
Thanks for the follow up! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax commented on code in PR #17145:
URL: https://github.com/apache/kafka/pull/17145#discussion_r1753002204
##
streams/src/main/java/org/apache/kafka/streams/kstream/Materialized.java:
##
@@ -53,6 +53,30 @@
* "topicName",
* Materialized.as("queryable-store-name"));
*
mumrah commented on PR #17158:
URL: https://github.com/apache/kafka/pull/17158#issuecomment-2342462002
Small fix @chia7712, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
mumrah merged PR #17153:
URL: https://github.com/apache/kafka/pull/17153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
fonsdant commented on PR #17124:
URL: https://github.com/apache/kafka/pull/17124#issuecomment-2342443806
@mumrah many, many thanks! It have been my first contribution merged! I am
very happy! 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mumrah merged PR #17124:
URL: https://github.com/apache/kafka/pull/17124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mjsax merged PR #17108:
URL: https://github.com/apache/kafka/pull/17108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #16761:
URL: https://github.com/apache/kafka/pull/16761#discussion_r1752975251
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -584,8 +584,8 @@ public StreamsResetterOptions(String[] args) {
.ofType(String.
kirktrue commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1752972613
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1302,6 +1304,42 @@ private void releaseAssignmentAndLeaveGroup(fin
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1752956657
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -65,16 +67,59 @@ protected void maybeThrowAuthFailure(Node node) {
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1752958535
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -65,16 +67,59 @@ protected void maybeThrowAuthFailure(Node node) {
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1752957499
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/FetchEvent.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1752956657
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -65,16 +67,59 @@ protected void maybeThrowAuthFailure(Node node) {
TaiJuWu opened a new pull request, #17161:
URL: https://github.com/apache/kafka/pull/17161
Address KAFKA-17477 comment I missed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
fonsdant commented on code in PR #17124:
URL: https://github.com/apache/kafka/pull/17124#discussion_r1752915169
##
committer-tools/refresh_collaborators.py:
##
@@ -0,0 +1,143 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
fonsdant commented on code in PR #17124:
URL: https://github.com/apache/kafka/pull/17124#discussion_r1752762808
##
committer-tools/refresh_collaborators.py:
##
@@ -0,0 +1,143 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
fonsdant commented on PR #17124:
URL: https://github.com/apache/kafka/pull/17124#issuecomment-2342048718
> @fonsdant Looks like the license checker is failing due to
requirements.txt
https://github.com/apache/kafka/actions/runs/10797389243/job/29948652044?pr=17124#step:6:4792
Fixed!
chia7712 commented on code in PR #17046:
URL: https://github.com/apache/kafka/pull/17046#discussion_r1752703160
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -589,6 +658,16 @@ private void verifyGroupConfig(Admin client, String
groupName, Map config
AndrewJSchofield commented on code in PR #17046:
URL: https://github.com/apache/kafka/pull/17046#discussion_r1752678715
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -589,6 +658,16 @@ private void verifyGroupConfig(Admin client, String
groupName, Ma
cmccabe closed pull request #17143: KAFKA-17492: skip KIP-584 features with
minVersion of 0 in older RPCs
URL: https://github.com/apache/kafka/pull/17143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cmccabe commented on PR #17143:
URL: https://github.com/apache/kafka/pull/17143#issuecomment-2341909995
This was fixed by #17128. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1752608667
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2507,32 +2521,35 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
lianetm commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1752612628
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -65,16 +67,59 @@ protected void maybeThrowAuthFailure(Node node) {
chia7712 commented on PR #17155:
URL: https://github.com/apache/kafka/pull/17155#issuecomment-2341849756
@mumrah thanks for the nice explanation!
> I think this is probably as good as we can do for now. Maybe someday we
can remove the test retrying.
yes, removing the "retry" i
lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1752557956
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2507,32 +2521,35 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
rreddy-22 commented on code in PR #17093:
URL: https://github.com/apache/kafka/pull/17093#discussion_r1752565093
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -260,6 +314,20 @@ object StorageTool extends Logging {
s"${MetadataVersion.IBP_3_0_IV0}; the defa
rreddy-22 commented on code in PR #17093:
URL: https://github.com/apache/kafka/pull/17093#discussion_r1752565093
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -260,6 +314,20 @@ object StorageTool extends Logging {
s"${MetadataVersion.IBP_3_0_IV0}; the defa
cmccabe opened a new pull request, #17159:
URL: https://github.com/apache/kafka/pull/17159
When brokers undergoing ZK migration register with the controller, it should
verify that they have provided a way to contact them via their
inter.broker.listener. Otherwise the migration will fail lat
mumrah opened a new pull request, #17158:
URL: https://github.com/apache/kafka/pull/17158
Gradle will now exit with 1 if any test fails, flaky or not. Update
deflake.yml to handle this new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mumrah commented on PR #17155:
URL: https://github.com/apache/kafka/pull/17155#issuecomment-2341701891
@chia7712 I think I found the issue. Here's an example:
green PR: https://github.com/apache/kafka/pull/17138
green CI:
https://github.com/apache/kafka/actions/runs/10795610027/job
chia7712 commented on code in PR #17156:
URL: https://github.com/apache/kafka/pull/17156#discussion_r1752482246
##
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##
@@ -19,7 +19,9 @@
import org.apache.kafka.streams.processor.api.Processor;
import
chia7712 merged PR #17084:
URL: https://github.com/apache/kafka/pull/17084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
wernerdv opened a new pull request, #17157:
URL: https://github.com/apache/kafka/pull/17157
Based on https://github.com/apache/kafka/pull/13214
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build s
junrao commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1752319003
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -995,6 +1004,9 @@ boolean canAcquireRecords() {
* @return A boolean which indicates whether the
chia7712 commented on code in PR #17108:
URL: https://github.com/apache/kafka/pull/17108#discussion_r1752430411
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -742,9 +742,9 @@ boolean runLoop() {
errorMessage.s
chia7712 commented on code in PR #17129:
URL: https://github.com/apache/kafka/pull/17129#discussion_r1752417980
##
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##
@@ -19,6 +19,10 @@
import org.apache.kafka.streams.processor.api.Processor;
impor
chia7712 commented on PR #17155:
URL: https://github.com/apache/kafka/pull/17155#issuecomment-2341552701
> That is unexpected 🤔. I guess it might have to do with how I uploaded them?
Here's a similar trunk build with flaky failures, but it is not showing as
failed https://ge.apache.org/s/
mumrah commented on code in PR #17124:
URL: https://github.com/apache/kafka/pull/17124#discussion_r1752369135
##
committer-tools/refresh_collaborators.py:
##
@@ -0,0 +1,143 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements
AndrewJSchofield closed pull request #16212: KAFKA-16894: Define group.version=2
URL: https://github.com/apache/kafka/pull/16212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
chia7712 merged PR #17128:
URL: https://github.com/apache/kafka/pull/17128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mumrah commented on PR #17155:
URL: https://github.com/apache/kafka/pull/17155#issuecomment-2341524653
> It shows "2 task failures" and that is caused by the cached error
(produced by flaky)
That is unexpected 🤔. I guess it might have to do with how I uploaded them?
Here's a s
AndrewJSchofield commented on PR #17046:
URL: https://github.com/apache/kafka/pull/17046#issuecomment-2341492069
@chia7712 I wonder if you would be prepared to take a look at this small PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1752324266
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port1
dimitarndimitrov commented on code in PR #16949:
URL: https://github.com/apache/kafka/pull/16949#discussion_r1752320360
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java:
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software F
jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1752319209
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port1
jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1752313033
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port1
jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1752303772
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port1
junrao commented on code in PR #17128:
URL: https://github.com/apache/kafka/pull/17128#discussion_r1752293086
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -48,7 +48,7 @@
]
},
{ "name": "Features", "type": "[]Feature",
- "
jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1752295279
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port1
jolshan commented on PR #17128:
URL: https://github.com/apache/kafka/pull/17128#issuecomment-2341430553
Thanks folks for fixing this 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
chia7712 commented on PR #17128:
URL: https://github.com/apache/kafka/pull/17128#issuecomment-2341287540
The failed tests pass on my local, and following links are the related jira.
The new e2e works on my local. I will merge it to trunk and 3.9 later if no
objections.
https://issue
m1a2st closed pull request #17111: MINOR: simplify import control (only for
display, do not merge)
URL: https://github.com/apache/kafka/pull/17111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
FrankYang0529 commented on code in PR #17075:
URL: https://github.com/apache/kafka/pull/17075#discussion_r1752195658
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/SeekUnvalidatedEvent.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software
chia7712 merged PR #17129:
URL: https://github.com/apache/kafka/pull/17129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #16493:
URL: https://github.com/apache/kafka/pull/16493#issuecomment-2341023476
Hi @chia7712, could you help me review this when you have time? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1752112596
##
docs/ops.html:
##
@@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3
+ controller.quorum.bootstrap.servers=host1:port1
dajac merged PR #16898:
URL: https://github.com/apache/kafka/pull/16898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on PR #17027:
URL: https://github.com/apache/kafka/pull/17027#issuecomment-2340937529
@gongxuanzhang could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 merged PR #17135:
URL: https://github.com/apache/kafka/pull/17135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #17152:
URL: https://github.com/apache/kafka/pull/17152#discussion_r1752023813
##
.github/workflows/ci.yml:
##
@@ -35,6 +35,6 @@ jobs:
with:
gradle-cache-read-only: ${{ github.ref != 'refs/heads/trunk' }}
gradle-cache-write-onl
olegbonar commented on PR #17151:
URL: https://github.com/apache/kafka/pull/17151#issuecomment-2340849317
@mimaison may I ask you to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alikelleci commented on PR #14157:
URL: https://github.com/apache/kafka/pull/14157#issuecomment-2340842708
We recently had a production incident that was related to this issue. We
just cannot make schema changes to our view models, which is a big problem.
Therefore we decided not to use Ka
mumrah opened a new pull request, #17152:
URL: https://github.com/apache/kafka/pull/17152
Trunk builds are run off of "push" events rather than "pull_request". We
were missing some logic in the `is-public-fork` condition that mistakenly
caused some trunk builds to skip the build scan.
--
olegbonar opened a new pull request, #17151:
URL: https://github.com/apache/kafka/pull/17151
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
mumrah merged PR #17071:
URL: https://github.com/apache/kafka/pull/17071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah merged PR #17144:
URL: https://github.com/apache/kafka/pull/17144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on PR #17144:
URL: https://github.com/apache/kafka/pull/17144#issuecomment-2340536697
The `--info` is intentional. It is probably going to be commonly wanted in
the deflake job.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
FrankYang0529 commented on code in PR #17075:
URL: https://github.com/apache/kafka/pull/17075#discussion_r1751803881
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java:
##
@@ -183,6 +186,38 @@ public void testAssignment
adixitconfluent commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1751801277
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -560,88 +588,58 @@ void maybeProcessFetchQueue() {
maybeCom
FrankYang0529 opened a new pull request, #17150:
URL: https://github.com/apache/kafka/pull/17150
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summ
showuon commented on code in PR #17147:
URL: https://github.com/apache/kafka/pull/17147#discussion_r175112
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -519,7 +522,7 @@ public void run() throws Exception {
KRaftM
chia7712 merged PR #17134:
URL: https://github.com/apache/kafka/pull/17134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
901 - 1000 of 10263 matches
Mail list logo
