Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-02-05 Thread via GitHub
dajac merged PR #15152: URL: https://github.com/apache/kafka/pull/15152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-02-02 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1475831326 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1794,6 +1822,10 @@ public void onLoaded() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-31 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1473116357 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1819,6 +1822,10 @@ public void onLoaded() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-31 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1473114805 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -726,6 +726,9 @@ private void removeGroup( Cla

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-31 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1473113934 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1819,6 +1822,10 @@ public void onLoaded() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-31 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1473109613 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -726,6 +726,9 @@ private void removeGroup(

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-31 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1473109228 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1819,6 +1822,10 @@ public void onLoaded() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-30 Thread via GitHub
dajac commented on PR #15152: URL: https://github.com/apache/kafka/pull/15152#issuecomment-1916411947 @rreddy-22 Could you please check the build? It looks like there is a failure related to checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-30 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1470804235 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1106,17 +1106,23 @@ private[group] class GroupCoordinator( } } - def handleLi

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-30 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1470803293 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1106,17 +1106,23 @@ private[group] class GroupCoordinator( } } - def handleListGr

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-30 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1470785323 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1106,17 +1106,20 @@ private[group] class GroupCoordinator( } } - def handleListGr

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-29 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1470555356 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,38 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467690595 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -40,6 +42,29 @@ enum GroupType { public String toString() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467689455 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,38 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467026136 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,38 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467024681 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -40,6 +42,29 @@ enum GroupType { public String toString() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467024178 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -40,6 +42,29 @@ enum GroupType { public String toString() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467019377 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,38 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1467019377 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,38 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1466643378 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -40,6 +42,29 @@ enum GroupType { public String toString() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-25 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1466007522 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -40,6 +42,29 @@ enum GroupType { public String toString() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-24 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1465873433 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-24 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1464856230 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-23 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1464109057 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-22 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1461611749 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459544349 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459544349 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459539623 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459535683 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1459535683 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1458663082 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1458061363 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9616,47 +9618,76 @@ public void testListGroups() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1458058459 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,19 +453,36 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-18 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1457158606 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,19 +453,36 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-12 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1450673490 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-11 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1449170060 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1448205757 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1448203801 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1448101818 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9583,24 +9584,24 @@ public void testHeartbeatDuringRebala

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1448098432 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1105,16 +1105,18 @@ private[group] class GroupCoordinator( } } - def handleLi

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1448087895 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1448087379 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-10 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1447420131 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -622,7 +623,7 @@ private[group] class GroupMetadata(val groupId: String, initialState: GroupSta

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446822116 ## clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java: ## @@ -50,6 +50,10 @@ public ListGroupsRequest build(short version) {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446780228 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446773716 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -633,8 +633,8 @@ class KafkaApisTest extends Logging { val requestData = DescribeQuorumReque

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446771432 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest { @Test def

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446770934 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest { @Test def

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446770934 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest { @Test def

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446767928 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1105,16 +1105,17 @@ private[group] class GroupCoordinator( } } - def handleLi

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446766566 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupType.java: ## @@ -0,0 +1,50 @@ +/* Review Comment: Yes it is, we can consider it part of the admin c

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1445918279 ## clients/src/main/resources/common/message/ListGroupsResponse.json: ## @@ -19,26 +19,33 @@ "name": "ListGroupsResponse", // Version 1 adds the throttle time. /

[PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-08 Thread via GitHub
rreddy-22 opened a new pull request, #15152: URL: https://github.com/apache/kafka/pull/15152 In KIP-848, we introduce the notion of Group Types based on the protocol type that the members in the consumer group use. As of now we support two types of groups: Classic : Members use the c