soarez closed pull request #14516: KAFKA-15514: Metadata records
Replicas->Assignment
URL: https://github.com/apache/kafka/pull/14516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
soarez commented on PR #14516:
URL: https://github.com/apache/kafka/pull/14516#issuecomment-1790795826
Closing this due to the change of plan in #14290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
soarez commented on PR #14516:
URL: https://github.com/apache/kafka/pull/14516#issuecomment-1779020910
Thanks for the review and comments @OmniaGM . Depending on the outcome of
the current discussion in #14290 there may be some bigger changes to this PR,
so I'll wait until that's resolved
OmniaGM commented on PR #14516:
URL: https://github.com/apache/kafka/pull/14516#issuecomment-1776855049
I believe this test is failing due to some changes here
OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368826071
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -128,7 +128,7 @@ class ZkMigrationIntegrationTest {
val underlying =
OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368821203
##
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##
@@ -102,7 +111,7 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends
OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368821203
##
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##
@@ -102,7 +111,7 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends
OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368798048
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -63,6 +63,7 @@ class KRaftMetadataCache(val brokerId: Int) extends
MetadataCache with
soarez opened a new pull request, #14516:
URL: https://github.com/apache/kafka/pull/14516
The new "Assignments" field replaces the "Replicas" field in PartitionRecord
and PartitionChangeRecord.
Depends on #14290 -
[KAFKA-15355](https://issues.apache.org/jira/browse/KAFKA-15355)
