divijvaidya commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1794497529
Hi @mumrah
This PR has introduced flaky tests in the CI. You can find the CI failures
at
jolshan commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1783515553
Hey -- I think this broke the build for java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yyu1993 commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1373996821
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1216,15 +1228,21 @@ class LogManager(logDirs: Seq[File],
mumrah merged PR #14545:
URL: https://github.com/apache/kafka/pull/14545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1781961533
Test failures look unrelated.
https://github.com/apache/kafka/assets/55116/b0eb9cec-76df-4d5e-ab73-dfd2ca4d5978;>
--
This is an automated message from the Apache Git Service.
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1373863647
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1216,15 +1228,21 @@ class LogManager(logDirs: Seq[File],
yyu1993 commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1373695739
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1216,15 +1228,21 @@ class LogManager(logDirs: Seq[File],
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1369368851
##
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##
@@ -47,8 +47,14 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends
cmccabe commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1776180980
oh, and please remove the thing where we log all deleting topic names … if
it’s too much effort, just log the # . We don't want to blow up our log4j files
--
This is an automated
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1369366766
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1369366766
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1367032618
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -265,6 +265,96 @@ class ZkMigrationIntegrationTest {
migrationState =
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366294162
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -146,6 +147,15 @@ void handleTopicsSnapshot(TopicsImage topicsImage,
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366292982
##
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##
@@ -47,8 +47,14 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends
cmccabe commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1771582104
Thanks for the PR, @mumrah ! A very important fix.
Do we need a test of handling a leaderAndIsrRequest that creates stray
partitions, in ReplicaManagerTest?
--
This is an
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366013492
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -146,6 +147,15 @@ void handleTopicsSnapshot(TopicsImage topicsImage,
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366011893
##
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##
@@ -47,8 +47,14 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366010087
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -82,6 +108,10 @@ public LeaderAndIsrRequest build(short version) {
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366008719
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366007724
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366007543
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366008173
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
22 matches
Mail list logo
