mjsax commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1790065635
Thanks for all the review help @xvrl!
Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mjsax merged PR #14618:
URL: https://github.com/apache/kafka/pull/14618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1379585726
##
build.gradle:
##
@@ -295,7 +296,12 @@ subprojects {
}
publications {
mavenJava(MavenPublication) {
- from components.java
+ if
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1789838514
@wcarlson5 @mjsax 16 tests unrelated to the PR are failing. As we have +1
from @xvrl hence can we please merge this PR now. Thanks for the help.
--
This is an automated message f
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1789209541
> one minor suggestion, otherwise LGTM
Thanks @xvrl, I have added the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1378978236
##
build.gradle:
##
@@ -1379,11 +1392,40 @@ project(':clients') {
}
}
- jar {
+ shadowJar {
dependsOn createVersionFile
+// archiveClassifier defines
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1788182563
> jar -tf kafka-clients-3.7.0-SNAPSHOT.jar | grep -v
org/apache/kafka/shaded/ > jar_tf_output
I have updated the build file and below are the results; tldr there is no
chan
xvrl commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1788079703
> @xvrl Please find the details below, AK `trunk` branch build vs `changes`
in PR. Do you think we should relocate `*.proto` files too, didn't do that as I
felt moving classes should be suff
apoorvmittal10 commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375136169
##
build.gradle:
##
@@ -1361,6 +1375,21 @@ project(':clients') {
generator project(':generator')
}
+ shadowJar {
+archiveClassifier = null
Review
apoorvmittal10 commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375136109
##
build.gradle:
##
@@ -1342,6 +1348,14 @@ project(':clients') {
implementation libs.lz4
implementation libs.snappy
implementation libs.slf4jApi
+
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1783642480
> @apoorvmittal10 could we show a diff before/after this change of:
>
> * the pom
> * the content of the jar – excluding
`org/apache/kafka/shaded/com/google/protobuf/` and
apoorvmittal10 commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375136205
##
build.gradle:
##
@@ -1380,7 +1409,9 @@ project(':clients') {
}
jar {
+enabled false
dependsOn createVersionFile
+dependsOn 'shadowJar'
xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375083080
##
build.gradle:
##
@@ -1342,6 +1348,14 @@ project(':clients') {
implementation libs.lz4
implementation libs.snappy
implementation libs.slf4jApi
+implem
xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375082874
##
build.gradle:
##
@@ -1361,6 +1375,21 @@ project(':clients') {
generator project(':generator')
}
+ shadowJar {
+archiveClassifier = null
+// KIP-714:
xvrl commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1783559671
@apoorvmittal10 could we show a diff before/after this change of:
- the pom
- the content of the jar – excluding
`org/apache/kafka/shaded/com/google/protobuf/` and
`org/apache/kafk
xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375080740
##
build.gradle:
##
@@ -1361,6 +1375,21 @@ project(':clients') {
generator project(':generator')
}
+ shadowJar {
+archiveClassifier = null
Review Comment:
xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375080303
##
build.gradle:
##
@@ -1380,7 +1409,9 @@ project(':clients') {
}
jar {
+enabled false
dependsOn createVersionFile
+dependsOn 'shadowJar'
from("$
apoorvmittal10 commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1374381174
##
build.gradle:
##
@@ -295,7 +296,12 @@ subprojects {
}
publications {
mavenJava(MavenPublication) {
- from components.java
+
mjsax commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1374016565
##
build.gradle:
##
@@ -295,7 +296,12 @@ subprojects {
}
publications {
mavenJava(MavenPublication) {
- from components.java
+ if
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1776852841
Build is failing because of flaky tests:
```
5 tests have failed
There are 0 new tests failing, 5 existing failing and 152 skipped.
```
```
Existing
apoorvmittal10 opened a new pull request, #14618:
URL: https://github.com/apache/kafka/pull/14618
The PR comprises of changes to include opentlemetry library as defined in
KIP-714. The libraries are shadowed to prevent conflicts.
```
jar -tf kafka-clients-3.7.0-SNAPSHOT.jar | grep
21 matches
Mail list logo
