Re: [PR] KAFKA-15853: Move metrics configs out of KafkaConfig [kafka]

2024-04-29 Thread via GitHub
chia7712 merged PR #15822: URL: https://github.com/apache/kafka/pull/15822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15853: Move metrics configs out of KafkaConfig [kafka]

2024-04-28 Thread via GitHub
chia7712 commented on PR #15822: URL: https://github.com/apache/kafka/pull/15822#issuecomment-2081560445 ``` [2024-04-28T12:34:14.550Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-15822/core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:1000:26: value KafkaMetricsReporterC

Re: [PR] KAFKA-15853: Move metrics configs out of KafkaConfig [kafka]

2024-04-28 Thread via GitHub
OmniaGM commented on code in PR #15822: URL: https://github.com/apache/kafka/pull/15822#discussion_r1582152852 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -77,7 +78,7 @@ public class CommonClientConfigs { public static final String CL

Re: [PR] KAFKA-15853: Move metrics configs out of KafkaConfig [kafka]

2024-04-28 Thread via GitHub
OmniaGM commented on code in PR #15822: URL: https://github.com/apache/kafka/pull/15822#discussion_r1582144106 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -77,7 +78,7 @@ public class CommonClientConfigs { public static final String CL