apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1555905789
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+/
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1500047932
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+// Visibl
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1500028907
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+/
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1498439741
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+// Visibl
apoorvmittal10 closed pull request #15251: KAFKA-16186: Broker metrics for
client telemetry (KIP-714)
URL: https://github.com/apache/kafka/pull/15251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apoorvmittal10 commented on PR #15251:
URL: https://github.com/apache/kafka/pull/15251#issuecomment-1915703872
> @apoorvmittal10 : Thanks for the updated PR. A few more comments.
Thanks for the review and suggestions. I have addressed the comments.
--
This is an automated message fr
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470310097
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470279663
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -299,8 +332,8 @@ public void
testGetTelemetrySameClientImmediateRetryAfterP
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470278382
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -288,6 +307,9 @@ private ClientMetricsInstance
createClientInstanceAndUpdateCac
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470269365
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470043472
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -288,6 +307,9 @@ private ClientMetricsInstance
createClientInstanceAndUpdateCache(Uuid
AndrewJSchofield commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r146343
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469854621
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -299,8 +332,8 @@ public void
testGetTelemetrySameClientImmediateRetryAfterP
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469851552
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -1023,5 +1177,18 @@ public void
testCacheExpirationTaskCancelledOnInstanceU
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469849574
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469845294
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -288,6 +307,9 @@ private ClientMetricsInstance
createClientInstanceAndUpdateCac
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469843003
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469836415
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469835995
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469798809
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1469784272
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
AndrewJSchofield commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465945556
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465454670
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+// Visibl
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465476918
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+// Visibl
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465492172
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -1023,5 +1177,18 @@ public void
testCacheExpirationTaskCancelledOnInstanceUpdate()
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465474347
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+// Visibl
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465446342
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+// Visibl
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1465497737
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -299,8 +332,8 @@ public void
testGetTelemetrySameClientImmediateRetryAfterPushFail(
AndrewJSchofield commented on PR #15251:
URL: https://github.com/apache/kafka/pull/15251#issuecomment-1907905085
I see that you have a differences from the KIP. It sounds like you're
highlighting situations in which the KIP has small deviations from normal Kafka
practice. I would support ad
AndrewJSchofield commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1464735557
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+
apoorvmittal10 commented on PR #15251:
URL: https://github.com/apache/kafka/pull/15251#issuecomment-1907853039
@AndrewJSchofield @junrao Please if you can review and provide the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
apoorvmittal10 opened a new pull request, #15251:
URL: https://github.com/apache/kafka/pull/15251
The KIP-714 defines broker metrics
[here](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability#KIP714:Clientmetricsandobservability-Metrics)
which shoul
32 matches
Mail list logo
