chia7712 merged PR #15843:
URL: https://github.com/apache/kafka/pull/15843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588449485
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -906,6 +906,7 @@ public long position(TopicPartition partition,
kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588234154
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588233090
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -906,6 +906,7 @@ public long position(TopicPartition partition,
kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588224603
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
lianetm commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1587645917
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
AbstractConsumerTest
chia7712 commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1587003306
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -906,6 +906,7 @@ public long position(TopicPartition partition,
chia7712 commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1586996403
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -906,6 +906,7 @@ public long position(TopicPartition partition,
kirktrue opened a new pull request, #15843:
URL: https://github.com/apache/kafka/pull/15843
The AsyncKafkaConsumer implementation of `position(TopicPartition,
Duration)` was not updating its internal `Timer`, causing it to execute the
loop forever. Adding a call to update the `Timer` at
