chia7712 merged PR #15668:
URL: https://github.com/apache/kafka/pull/15668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1556044180
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlu
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1555109656
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlug
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554997766
##
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##
@@ -77,7 +77,7 @@ public void setup() {
@AfterEach
public void teardown
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554997443
##
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##
@@ -77,7 +77,7 @@ public void setup() {
@AfterEach
public void teardown(
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554964050
##
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##
@@ -76,6 +77,7 @@ public void setup() {
@AfterEach
public void teardown(
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554955481
##
server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java:
##
@@ -59,4 +59,11 @@ public void testReaper() throws Exception {
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554647591
##
server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimerReaper.java:
##
@@ -76,4 +76,17 @@ public void run() {}
reaper.awaitShutdown();
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554644159
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlu
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554626964
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlug
brandboat commented on PR #15668:
URL: https://github.com/apache/kafka/pull/15668#issuecomment-2040977883
> @brandboat nice finding! Should we add the thread prefix to
https://github.com/apache/kafka/blob/a2ee0855ee5e73f3a74555d52294bb4acfd28945/core/src/test/scala/unit/kafka/utils/TestUtils
chia7712 commented on PR #15668:
URL: https://github.com/apache/kafka/pull/15668#issuecomment-2039540752
@brandboat nice finding! Should we add the thread prefix to
https://github.com/apache/kafka/blob/a2ee0855ee5e73f3a74555d52294bb4acfd28945/core/src/test/scala/unit/kafka/utils/TestUtils.sc
brandboat opened a new pull request, #15668:
URL: https://github.com/apache/kafka/pull/15668
related to KAFKA-16477,
After profiling the kafka tests, tons of `client-metrics-reaper` thread not
cleanup after BrokerServer shutdown.
The thread `client-metrics-reaper` comes from
[Cli
13 matches
Mail list logo
