divijvaidya merged PR #15072:
URL: https://github.com/apache/kafka/pull/15072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
divijvaidya commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1887569050
The compilation is successful. This PR doesn't impact any runtime and hence,
tests failing in CI can be ignored.
--
This is an automated message from the Apache Git Service.
To res
divijvaidya commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1887103085
I have rebased from trunk. Apologies that I didn't create a separate commit
which would have made it easier to review the diff. Is there a better way to do
it?
--
This is an automa
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1448816308
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/StandardAuthorizerUpdateBenchmark.java:
##
@@ -59,17 +59,15 @@
@BenchmarkMode(Mode.AverageTime)
@OutputTi
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1448815537
##
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##
@@ -64,11 +64,11 @@ public class MockConsumer implements Consumer {
private fi
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1448815104
##
clients/src/main/java/org/apache/kafka/common/record/LazyDownConversionRecordsSend.java:
##
@@ -36,9 +36,9 @@ public final class LazyDownConversionRecordsSend ex
mimaison commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1442700296
##
clients/src/main/java/org/apache/kafka/common/record/LazyDownConversionRecordsSend.java:
##
@@ -36,9 +36,9 @@ public final class LazyDownConversionRecordsSend exten
vamossagar12 commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1870244078
Thanks @divijvaidya , I think Ismael's point is correct. From what I recall,
the streams final rule also expects the method arguements etc to be final as
well (apart from local varia
divijvaidya commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1870156605
Checkstyle doesn't have a rule [1] available to enforce that fields which
are not changing are marked as final. Hence, I am not changing anything in the
checkstyle here in this PR.
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1436914220
##
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##
@@ -479,7 +479,7 @@ private static class NodeConnectionState {
private f
ijuma commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1869779489
The streams final rule also includes local variables, etc (which is quite
noisy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
divijvaidya commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1869776329
Thank you for the review @vamossagar12 . I didn't know about the checkstyle
rule in streams. I will try & observe if enabling it for other modules leads to
a large number of changes o
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1436615442
##
connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java:
##
@@ -37,13 +37,13 @@
public class SchemaProjector {
-private static Set>
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1436615243
##
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##
@@ -479,7 +479,7 @@ private static class NodeConnectionState {
private f
ijuma commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1436613486
##
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##
@@ -479,7 +479,7 @@ private static class NodeConnectionState {
private final S
vamossagar12 commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1436578781
##
connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java:
##
@@ -37,13 +37,13 @@
public class SchemaProjector {
-private static Set
divijvaidya opened a new pull request, #15072:
URL: https://github.com/apache/kafka/pull/15072
Code cleanup to include `final` keyword where ever required. Detected via
automatic tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
17 matches
Mail list logo
