[GitHub] [kafka] chia7712 opened a new pull request #9013: KAFKA-10044 Deprecate ConsumerConfig#addDeserializerToConfig and Prod…

2020-07-13 Thread GitBox
chia7712 opened a new pull request #9013: URL: https://github.com/apache/kafka/pull/9013 issue: https://issues.apache.org/jira/browse/KAFKA-10044 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[jira] [Updated] (KAFKA-10268) dynamic config like "--delete-config log.retention.ms" is not work

2020-07-13 Thread zhifeng.peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhifeng.peng updated KAFKA-10268: - Description: After I set "log.retention.ms=301000" to clean the data,i use the cmd

[GitHub] [kafka] tombentley commented on pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

2020-07-13 Thread GitBox
tombentley commented on pull request #9007: URL: https://github.com/apache/kafka/pull/9007#issuecomment-657439525 Thats for the review @dajac. I've addressed your comments. This is an automated message from the Apache Git

[jira] [Created] (KAFKA-10268) dynamic config like "--delete-config log.retention.ms" not work

2020-07-13 Thread zhifeng.peng (Jira)
zhifeng.peng created KAFKA-10268: Summary: dynamic config like "--delete-config log.retention.ms" not work Key: KAFKA-10268 URL: https://issues.apache.org/jira/browse/KAFKA-10268 Project: Kafka

[jira] [Updated] (KAFKA-10268) dynamic config like "--delete-config log.retention.ms" is not work

2020-07-13 Thread zhifeng.peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhifeng.peng updated KAFKA-10268: - Summary: dynamic config like "--delete-config log.retention.ms" is not work (was: dynamic

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-07-13 Thread GitBox
mimaison commented on pull request #8921: URL: https://github.com/apache/kafka/pull/8921#issuecomment-657451241 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cmccabe commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests

2020-07-13 Thread GitBox
cmccabe commented on pull request #8948: URL: https://github.com/apache/kafka/pull/8948#issuecomment-657616089 Maybe just transition this over to @rondagostino to see what he thinks This is an automated message from the

[GitHub] [kafka] cmccabe edited a comment on pull request #8916: MINOR; Provide lowest and highest supported versions alongside with the schema in the auto-generated protocol

2020-07-13 Thread GitBox
cmccabe edited a comment on pull request #8916: URL: https://github.com/apache/kafka/pull/8916#issuecomment-657625138 Yeah, this doesn't need a KIP, as @ijuma said. Looking at the use-case here, I'm +1 on this change. LGTM. By the way, #9002 adds the concept of pluggable

[jira] [Commented] (KAFKA-3628) Native Schema Registry in Kafka

2020-07-13 Thread Florian Schneider (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156694#comment-17156694 ] Florian Schneider commented on KAFKA-3628: -- What is the current state of affairs regarding this

[GitHub] [kafka] cmccabe commented on pull request #8916: MINOR; Provide lowest and highest supported versions alongside with the schema in the auto-generated protocol

2020-07-13 Thread GitBox
cmccabe commented on pull request #8916: URL: https://github.com/apache/kafka/pull/8916#issuecomment-657625138 Yeah, this doesn't need a KIP, as @ijuma said. @dajac, sorry if this is a silly question, but did you look at the `lowestSupportedVersion` and `highestSupportedVersion`

[GitHub] [kafka] cmccabe merged pull request #8916: MINOR; Provide lowest and highest supported versions alongside with the schema in the auto-generated protocol

2020-07-13 Thread GitBox
cmccabe merged pull request #8916: URL: https://github.com/apache/kafka/pull/8916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-9381) Javadocs + Scaladocs not published on maven central

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9381: - Fix Version/s: (was: 2.6.0) 2.7.0 > Javadocs + Scaladocs not published on

[jira] [Updated] (KAFKA-10269) AdminClient ListOffsetsResultInfo/timestamp is always -1

2020-07-13 Thread Derek Troy-West (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Troy-West updated KAFKA-10269: Description: When using AdminClient/listOffsets the resulting ListOffsetResultInfos

[jira] [Created] (KAFKA-10269) AdminClient ListOffsetsResultInfo/timestamp is always -1

2020-07-13 Thread Derek Troy-West (Jira)
Derek Troy-West created KAFKA-10269: --- Summary: AdminClient ListOffsetsResultInfo/timestamp is always -1 Key: KAFKA-10269 URL: https://issues.apache.org/jira/browse/KAFKA-10269 Project: Kafka

[GitHub] [kafka] dajac commented on pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-07-13 Thread GitBox
dajac commented on pull request #8672: URL: https://github.com/apache/kafka/pull/8672#issuecomment-657555912 @junrao Thanks for your comments. I just pushed an update which addresses your comments. This is an automated

[jira] [Commented] (KAFKA-10156) Flaky Test SslSelectorTest.testCloseOldestConnection

2020-07-13 Thread Sergei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156720#comment-17156720 ] Sergei commented on KAFKA-10156: Not sure if that's the right way to go to avoid flaky test behavior,

[GitHub] [kafka] cmccabe merged pull request #8998: MINOR; KafkaAdminClient#describeLogDirs should not fail all the futures when only one call fails

2020-07-13 Thread GitBox
cmccabe merged pull request #8998: URL: https://github.com/apache/kafka/pull/8998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on a change in pull request #9002: MINOR: Add ApiMessageTypeGenerator

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9002: URL: https://github.com/apache/kafka/pull/9002#discussion_r453713178 ## File path: generator/src/main/java/org/apache/kafka/message/MessageGenerator.java ## @@ -169,20 +185,20 @@ public static void processDirectories(String

[GitHub] [kafka] junrao commented on pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-07-13 Thread GitBox
junrao commented on pull request #8672: URL: https://github.com/apache/kafka/pull/8672#issuecomment-657627713 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cmccabe commented on pull request #8916: MINOR; Provide lowest and highest supported versions alongside with the schema in the auto-generated protocol

2020-07-13 Thread GitBox
cmccabe commented on pull request #8916: URL: https://github.com/apache/kafka/pull/8916#issuecomment-657627827 I think this is not a duplicate of #7226, since as @dajac said, that one is more about simplying `ApiKeys.java`, whereas @dajac 's use case is for a non-request type.

[jira] [Updated] (KAFKA-9381) Javadocs + Scaladocs not published on maven central

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9381: - Priority: Critical (was: Blocker) > Javadocs + Scaladocs not published on maven central >

[jira] [Updated] (KAFKA-9381) Javadocs + Scaladocs not published on maven central

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9381: - Priority: Blocker (was: Critical) > Javadocs + Scaladocs not published on maven central >

[jira] [Updated] (KAFKA-10270) Add a broker to controller channel manager to redirect AlterConfig

2020-07-13 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10270: Description: Per KIP-590 requirement, we need to have a dedicate communication channel from

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453879092 ## File path: clients/src/main/resources/common/message/RequestHeader.json ## @@ -37,6 +37,9 @@ // Since the client is sending the ApiVersionsRequest

[GitHub] [kafka] kkonstantine commented on pull request #8928: KAFKA-10192: Wait for REST API to become available before testing blocked connectors

2020-07-13 Thread GitBox
kkonstantine commented on pull request #8928: URL: https://github.com/apache/kafka/pull/8928#issuecomment-657751413 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-10143) Can no longer change replication throttle with reassignment tool

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10143: -- Fix Version/s: (was: 2.6.0) > Can no longer change replication throttle with reassignment

[jira] [Commented] (KAFKA-10156) Flaky Test SslSelectorTest.testCloseOldestConnection

2020-07-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156944#comment-17156944 ] Sophie Blee-Goldman commented on KAFKA-10156: - Hey [~serj567], thanks for picking this up!

[jira] [Created] (KAFKA-10270) Add a broker to controller channel manager to redirect AlterConfig

2020-07-13 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10270: --- Summary: Add a broker to controller channel manager to redirect AlterConfig Key: KAFKA-10270 URL: https://issues.apache.org/jira/browse/KAFKA-10270 Project: Kafka

[GitHub] [kafka] kkonstantine commented on pull request #9003: KAFKA-10240: Stop throwing WakeupExceptions during sink task shutdown

2020-07-13 Thread GitBox
kkonstantine commented on pull request #9003: URL: https://github.com/apache/kafka/pull/9003#issuecomment-657714898 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453875212 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java ## @@ -85,11 +89,12 @@ public ApiKeys apiKey() { public RequestHeader

[GitHub] [kafka] cmccabe commented on pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on pull request #9012: URL: https://github.com/apache/kafka/pull/9012#issuecomment-657752269 Thanks, @abbccdda ! I left some comments This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (KAFKA-5722) Refactor ConfigCommand to use the AdminClient

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5722. -- Resolution: Fixed > Refactor ConfigCommand to use the AdminClient >

[jira] [Reopened] (KAFKA-5722) Refactor ConfigCommand to use the AdminClient

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reopened KAFKA-5722: -- > Refactor ConfigCommand to use the AdminClient > - >

[jira] [Commented] (KAFKA-10143) Can no longer change replication throttle with reassignment tool

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156937#comment-17156937 ] Randall Hauch commented on KAFKA-10143: --- Temporarily removed `2.6.0` as the fix version so that we

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453892850 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -131,20 +132,53 @@ private void

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453893460 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -46,9 +51,14 @@ public ListSerializer() {} public

[jira] [Commented] (KAFKA-10246) AbstractProcessorContext topic() throws NullPointerException when modifying a state store within the DSL from a punctuator

2020-07-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156871#comment-17156871 ] John Roesler commented on KAFKA-10246: -- Hi [~pjp1981] , thanks for the report and sorry for the

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-13 Thread GitBox
mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453849419 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2078,6 +2103,11 @@ private void

[GitHub] [kafka] abbccdda commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-13 Thread GitBox
abbccdda commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453856418 ## File path: clients/src/main/resources/common/message/FetchResponse.json ## @@ -47,33 +47,35 @@ "about": "The top level response error code." },

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453877852 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsResponse.java ## @@ -29,7 +29,7 @@ public class AlterConfigsResponse

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453883350 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2425,34 +2427,68 @@ class KafkaApis(val requestChannel: RequestChannel, def

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453884586 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -168,6 +168,8 @@ class KafkaServer(val config: KafkaConfig, time: Time =

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453883350 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2425,34 +2427,68 @@ class KafkaApis(val requestChannel: RequestChannel, def

[GitHub] [kafka] abbccdda commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
abbccdda commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453895767 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -168,6 +168,8 @@ class KafkaServer(val config: KafkaConfig, time: Time =

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453875683 ## File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java ## @@ -186,16 +186,18 @@ ClientRequest newClientRequest(String nodeId,

[GitHub] [kafka] mumrah commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
mumrah commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453815588 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-13 Thread GitBox
hachikuji commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453095731 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -366,225 +368,164 @@ public FetchResponse(Errors error,

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-13 Thread GitBox
mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453846799 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsReader.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-13 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-657739902 @junrao could you trigger system tests again? This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-5722) Refactor ConfigCommand to use the AdminClient

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-5722: - Fix Version/s: (was: 2.6.0) > Refactor ConfigCommand to use the AdminClient >

[jira] [Reopened] (KAFKA-5722) Refactor ConfigCommand to use the AdminClient

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reopened KAFKA-5722: -- > Refactor ConfigCommand to use the AdminClient > - >

[jira] [Resolved] (KAFKA-5722) Refactor ConfigCommand to use the AdminClient

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5722. -- Resolution: Duplicate > Refactor ConfigCommand to use the AdminClient >

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453894509 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs,

[GitHub] [kafka] abbccdda commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
abbccdda commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453895229 ## File path: clients/src/main/resources/common/message/RequestHeader.json ## @@ -37,6 +37,9 @@ // Since the client is sending the ApiVersionsRequest

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453894647 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static public

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453885984 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453886171 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] yeralin edited a comment on pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin edited a comment on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-657756747 Aan I am back!  Sorry for such a long break, was dealing with some personal stuff and work. Pushed a few commits with `null-index-list` and `negative-size`

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-657756747 Aan I am back!  Sorry for such a long break, was dealing with some personal stuff and work. Pushed a few commits with `null-index-list` and `negative-size`

[GitHub] [kafka] yeralin edited a comment on pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin edited a comment on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-657756747 Aan I am back!  Sorry for such a long break, was dealing with some personal stuff and work. Pushed a few commits with `null-index-list` and `negative-size`

[GitHub] [kafka] yeralin edited a comment on pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin edited a comment on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-657756747 Aan I am back!  Sorry for such a long break, was dealing with some personal stuff and work. Pushed a few commits with `null-index-list` and `negative-size`

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453892518 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -131,20 +132,53 @@ private void

[GitHub] [kafka] rondagostino commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests

2020-07-13 Thread GitBox
rondagostino commented on pull request #8948: URL: https://github.com/apache/kafka/pull/8948#issuecomment-657725929 @vinothchandar @cmccabe I've assigned https://issues.apache.org/jira/browse/KAFKA-10258 to me and will deal with `use_zk_connection` there. It would be great if we could

[jira] [Assigned] (KAFKA-10258) Get rid of use_zk_connection flag in kafka.py public methods

2020-07-13 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino reassigned KAFKA-10258: - Assignee: Ron Dagostino > Get rid of use_zk_connection flag in kafka.py public methods

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453876571 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -1199,7 +1199,7 @@ public ClientRequest newClientRequest(String

[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection

2020-07-13 Thread GitBox
cmccabe commented on a change in pull request #9012: URL: https://github.com/apache/kafka/pull/9012#discussion_r453877522 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -75,6 +75,19 @@ public T build() { public

[jira] [Updated] (KAFKA-9653) Duplicate tasks on workers after rebalance

2020-07-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9653: - Fix Version/s: (was: 2.5.1) (was: 2.4.2) (was:

[GitHub] [kafka] chia7712 commented on pull request #9013: KAFKA-10044 Deprecate ConsumerConfig#addDeserializerToConfig and Prod…

2020-07-13 Thread GitBox
chia7712 commented on pull request #9013: URL: https://github.com/apache/kafka/pull/9013#issuecomment-657762742 @abbccdda thanks for reviews! I have addressed your comment. pleas take a look :) This is an automated message

[GitHub] [kafka] abbccdda commented on a change in pull request #9013: KAFKA-10044 Deprecate ConsumerConfig#addDeserializerToConfig and Prod…

2020-07-13 Thread GitBox
abbccdda commented on a change in pull request #9013: URL: https://github.com/apache/kafka/pull/9013#discussion_r453913021 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -492,8 +492,19 @@ private static String parseAcks(String

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r454010650 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java ## @@ -572,16 +572,18 @@ public synchronized void

[jira] [Comment Edited] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-07-13 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157049#comment-17157049 ] Jerry Wei edited comment on KAFKA-10134 at 7/14/20, 12:21 AM: -- [~guozhang],

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-07-13 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157049#comment-17157049 ] Jerry Wei commented on KAFKA-10134: --- [~guozhang], yes, [~seanguo] and I are working on the same issue.

[jira] [Commented] (KAFKA-9350) IllegalStateException when materializing transactional offset commits

2020-07-13 Thread Michael Jaschob (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157063#comment-17157063 ] Michael Jaschob commented on KAFKA-9350: Chiming in here to say I've found the same error in a

[GitHub] [kafka] mjsax commented on pull request #9009: KAFKA-6453: Document how timestamps are computed for aggregations and joins

2020-07-13 Thread GitBox
mjsax commented on pull request #9009: URL: https://github.com/apache/kafka/pull/9009#issuecomment-657815627 Merged to `trunk` and cherry-picked to `2.6` branch. Thanks Jim! This is an automated message from the

[GitHub] [kafka] junrao commented on a change in pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

2020-07-13 Thread GitBox
junrao commented on a change in pull request #8935: URL: https://github.com/apache/kafka/pull/8935#discussion_r454018584 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -139,4 +140,19 @@ class ControllerEventManager(controllerId: Int,

[GitHub] [kafka] junrao merged pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-07-13 Thread GitBox
junrao merged pull request #8672: URL: https://github.com/apache/kafka/pull/8672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10002) Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-07-13 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10002. - Fix Version/s: 2.7.0 Resolution: Fixed merged the PR to trunk > Improve performances of

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r453965142 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -302,21 +312,295 @@ class ConnectionQuotasTest { } //

[GitHub] [kafka] ijuma commented on a change in pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-13 Thread GitBox
ijuma commented on a change in pull request #8979: URL: https://github.com/apache/kafka/pull/8979#discussion_r453974679 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -121,8 +120,8 @@ class DelayedFetch(delayMs: Long, } }

[GitHub] [kafka] splett2 commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

2020-07-13 Thread GitBox
splett2 commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r453980384 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] abbccdda merged pull request #9013: KAFKA-10044 Deprecate ConsumerConfig#addDeserializerToConfig and Prod…

2020-07-13 Thread GitBox
abbccdda merged pull request #9013: URL: https://github.com/apache/kafka/pull/9013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax merged pull request #9009: KAFKA-6453: Document how timestamps are computed for aggregations and joins

2020-07-13 Thread GitBox
mjsax merged pull request #9009: URL: https://github.com/apache/kafka/pull/9009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r453962326 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -302,21 +312,295 @@ class ConnectionQuotasTest { } //

[jira] [Commented] (KAFKA-10269) AdminClient ListOffsetsResultInfo/timestamp is always -1

2020-07-13 Thread Derek Troy-West (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157020#comment-17157020 ] Derek Troy-West commented on KAFKA-10269: - Can I add, if this is a bug I'm happy to diagnose and

[GitHub] [kafka] wicknicks commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

2020-07-13 Thread GitBox
wicknicks commented on pull request #9015: URL: https://github.com/apache/kafka/pull/9015#issuecomment-657904326 @kkonstantine @lbradstreet any thoughts on this PR? thanks in advance! This is an automated message from the

[GitHub] [kafka] jeffkbkim commented on a change in pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

2020-07-13 Thread GitBox
jeffkbkim commented on a change in pull request #8935: URL: https://github.com/apache/kafka/pull/8935#discussion_r454035533 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -139,4 +140,19 @@ class ControllerEventManager(controllerId: Int,

[GitHub] [kafka] kkonstantine merged pull request #9003: KAFKA-10240: Suppress WakeupExceptions during sink task shutdown

2020-07-13 Thread GitBox
kkonstantine merged pull request #9003: URL: https://github.com/apache/kafka/pull/9003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #8928: KAFKA-10192: Wait for REST API to become available before testing blocked connectors in integration tests

2020-07-13 Thread GitBox
kkonstantine commented on pull request #8928: URL: https://github.com/apache/kafka/pull/8928#issuecomment-657958290 This PR affected only integration tests. Merged to `trunk` and `2.6` This is an automated message from the

[GitHub] [kafka] kkonstantine merged pull request #8928: KAFKA-10192: Wait for REST API to become available before testing blocked connectors in integration tests

2020-07-13 Thread GitBox
kkonstantine merged pull request #8928: URL: https://github.com/apache/kafka/pull/8928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-10240) Sink tasks should not throw WakeupException on shutdown

2020-07-13 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10240: --- Fix Version/s: 2.7.0 > Sink tasks should not throw WakeupException on

[jira] [Resolved] (KAFKA-10240) Sink tasks should not throw WakeupException on shutdown

2020-07-13 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10240. Resolution: Fixed > Sink tasks should not throw WakeupException on

[GitHub] [kafka] kkonstantine commented on pull request #9003: KAFKA-10240: Suppress WakeupExceptions during sink task shutdown

2020-07-13 Thread GitBox
kkonstantine commented on pull request #9003: URL: https://github.com/apache/kafka/pull/9003#issuecomment-657952020 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-07-13 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10192: --- Fix Version/s: 2.7.0 2.6.0 > Flaky test

[GitHub] [kafka] lbradstreet commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

2020-07-13 Thread GitBox
lbradstreet commented on pull request #9015: URL: https://github.com/apache/kafka/pull/9015#issuecomment-657966251 Looks good, thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jeffkbkim commented on a change in pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

2020-07-13 Thread GitBox
jeffkbkim commented on a change in pull request #8935: URL: https://github.com/apache/kafka/pull/8935#discussion_r454039899 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -139,4 +140,19 @@ class ControllerEventManager(controllerId: Int,

[jira] [Resolved] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-07-13 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10192. Resolution: Fixed > Flaky test

[GitHub] [kafka] kkonstantine commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

2020-07-13 Thread GitBox
kkonstantine commented on pull request #9015: URL: https://github.com/apache/kafka/pull/9015#issuecomment-657959248 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log