[jira] [Created] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

2021-04-09 Thread Matiss Gutmanis (Jira)
Matiss Gutmanis created KAFKA-12639: --- Summary: AbstractCoordinator ignores backoff timeout when joining the consumer group Key: KAFKA-12639 URL: https://issues.apache.org/jira/browse/KAFKA-12639 Pro

[jira] [Created] (KAFKA-12640) AbstractCoordinator ignores backoff timeout when joining the consumer group

2021-04-09 Thread Matiss Gutmanis (Jira)
Matiss Gutmanis created KAFKA-12640: --- Summary: AbstractCoordinator ignores backoff timeout when joining the consumer group Key: KAFKA-12640 URL: https://issues.apache.org/jira/browse/KAFKA-12640 Pro

[GitHub] [kafka] rajinisivaram commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-04-09 Thread GitBox
rajinisivaram commented on pull request #10427: URL: https://github.com/apache/kafka/pull/10427#issuecomment-816497458 We decided not to support static quotas for request quotas and left these in for compatibility earlier. It seems ok to remove the static quotas for 3.0 and rely on just th

[jira] [Assigned] (KAFKA-12637) Remove deprecated PartitionAssignor interface

2021-04-09 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-12637: -- Assignee: dengziming > Remove deprecated PartitionAssignor interface > --

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-09 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r610326449 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -215,8 +215,8 @@ public void testTw

[jira] [Created] (KAFKA-12641) Clear RemoteLogLeaderEpochState entry when it become empty.

2021-04-09 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-12641: -- Summary: Clear RemoteLogLeaderEpochState entry when it become empty. Key: KAFKA-12641 URL: https://issues.apache.org/jira/browse/KAFKA-12641 Project: Kafka

[jira] [Commented] (KAFKA-12464) Enhance constrained sticky Assign algorithm

2021-04-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317783#comment-17317783 ] Luke Chen commented on KAFKA-12464: --- OK, I was wrong. The final version of PR doesn't

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610454559 ## File path: clients/src/test/java/org/apache/kafka/test/TestUtils.java ## @@ -535,4 +536,46 @@ public static void setFieldValue(Object obj, String fiel

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610454559 ## File path: clients/src/test/java/org/apache/kafka/test/TestUtils.java ## @@ -535,4 +536,46 @@ public static void setFieldValue(Object obj, String fiel

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610462859 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java ## @@ -0,0 +1,172 @@ +/* + * Licen

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610464252 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,309 @@ +/* + * Licensed

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-09 Thread GitBox
showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-816544910 @ableegoldman , I ran multiple times on jenkins and print some debug logs. Please check here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9724/237/testReport/j

[GitHub] [kafka] showuon edited a comment on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-09 Thread GitBox
showuon edited a comment on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-816544910 @ableegoldman , I ran multiple times on jenkins and print some debug logs. Please check here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9724/237/testR

[GitHub] [kafka] showuon edited a comment on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-09 Thread GitBox
showuon edited a comment on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-816544910 @ableegoldman , I ran multiple times on jenkins and print some debug logs. Please check here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9724/237/testR

[GitHub] [kafka] showuon edited a comment on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-09 Thread GitBox
showuon edited a comment on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-816544910 @ableegoldman , I ran multiple times on jenkins and print some debug logs. Please check here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9724/237/testR

[GitHub] [kafka] showuon edited a comment on pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-09 Thread GitBox
showuon edited a comment on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-816544910 @ableegoldman , I ran multiple times on jenkins and print some debug logs. Please check here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9724/237/testR

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610491754 ## File path: clients/src/test/java/org/apache/kafka/test/TestUtils.java ## @@ -535,4 +536,46 @@ public static void setFieldValue(Object obj, String fiel

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610494457 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java ## @@ -0,0 +1,172 @@ +/* + * Licen

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610494694 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,309 @@ +/* + * Licensed

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610517070 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java ## @@ -0,0 +1,172 @@ +/* + * Licen

[GitHub] [kafka] tombentley commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-09 Thread GitBox
tombentley commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610531203 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args) throw

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-04-09 Thread GitBox
dajac commented on pull request #10427: URL: https://github.com/apache/kafka/pull/10427#issuecomment-816623928 @rajinisivaram Thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-04-09 Thread GitBox
dajac commented on pull request #10427: URL: https://github.com/apache/kafka/pull/10427#issuecomment-816624069 I have rebased the PR to fix the conflict in the upgrade notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] lamberken commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-09 Thread GitBox
lamberken commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610562341 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args) throws

[GitHub] [kafka] dajac opened a new pull request #10511: KAFKA-12584; Remove deprecated `Sum` and `Total` classes

2021-04-09 Thread GitBox
dajac opened a new pull request #10511: URL: https://github.com/apache/kafka/pull/10511 `Sum` and `Total` classes were deprecated and replaced by `WindowedSum` and `CumulativeSum` in 2.4. As they are not really supposed to be used by external parties (even if they are part of AK's public A

[GitHub] [kafka] dajac commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-09 Thread GitBox
dajac commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r610581181 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1508,6 +1508,27 @@ default DescribeProducersResult describeProducers(C

[GitHub] [kafka] tombentley commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-09 Thread GitBox
tombentley commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610624115 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args) throw

[GitHub] [kafka] dengziming opened a new pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-09 Thread GitBox
dengziming opened a new pull request #10512: URL: https://github.com/apache/kafka/pull/10512 *More detailed description of your change* 1. Remove PartitionAssignor and related classes, update docs 2. Move unit test 3. fix some related typo *Summary of testing strategy (includ

[GitHub] [kafka] dengziming commented on pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-09 Thread GitBox
dengziming commented on pull request #10512: URL: https://github.com/apache/kafka/pull/10512#issuecomment-816693711 @ableegoldman , Hi, PTAL, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-09 Thread GitBox
showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867 @ableegoldman , please help review this PR. The testLargeAssignmentAndGroupWithUniformSubscription test keeps pretty much the same performance as before, but keep the cod

[GitHub] [kafka] nicolasguyomar opened a new pull request #10513: MINOR : Downgrade log level for safe catch

2021-04-09 Thread GitBox
nicolasguyomar opened a new pull request #10513: URL: https://github.com/apache/kafka/pull/10513 Minor log level downgrade to avoid alarm on ERROR log for a safe catch that could be a WARN -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (KAFKA-12642) Improve Rebalance reason upon metadata change

2021-04-09 Thread Nicolas Guyomar (Jira)
Nicolas Guyomar created KAFKA-12642: --- Summary: Improve Rebalance reason upon metadata change Key: KAFKA-12642 URL: https://issues.apache.org/jira/browse/KAFKA-12642 Project: Kafka Issue Typ

[GitHub] [kafka] lamberken commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-09 Thread GitBox
lamberken commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610672598 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args) throws

[GitHub] [kafka] viktorsomogyi commented on pull request #5858: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-09 Thread GitBox
viktorsomogyi commented on pull request #5858: URL: https://github.com/apache/kafka/pull/5858#issuecomment-816724615 @predatorray yes, feel free to submit a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] lamberken commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-09 Thread GitBox
lamberken commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610679955 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args) throws

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610517070 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java ## @@ -0,0 +1,172 @@ +/* + * Licen

[GitHub] [kafka] satishd commented on pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
satishd commented on pull request #10218: URL: https://github.com/apache/kafka/pull/10218#issuecomment-816736436 Thanks @junrao @kowshik for the comments. Addressed them with the [d12c77a](https://github.com/apache/kafka/pull/10218/commits/d12c77a8f91d15cc9dd8b4c3f664f38c51c033b7). -- Th

[jira] [Assigned] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2021-04-09 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang reassigned KAFKA-12635: -- Assignee: Ning Zhang > Mirrormaker 2 offset sync is incorrect if the target partition is empt

[GitHub] [kafka] tombentley commented on a change in pull request #10499: MINOR: Use the correct label while inspecting the docker images.

2021-04-09 Thread GitBox
tombentley commented on a change in pull request #10499: URL: https://github.com/apache/kafka/pull/10499#discussion_r610704990 ## File path: tests/docker/ducker-ak ## @@ -217,6 +217,8 @@ ask_yes_no() { # $1: The name of the image to build. ducker_build() { local image_na

[jira] [Created] (KAFKA-12643) Kafka Streams 2.7 with Kafka Broker 2.6.x regression: bad timestamp in transform/process (this.context.schedule function)

2021-04-09 Thread David EVANO (Jira)
David EVANO created KAFKA-12643: --- Summary: Kafka Streams 2.7 with Kafka Broker 2.6.x regression: bad timestamp in transform/process (this.context.schedule function) Key: KAFKA-12643 URL: https://issues.apache.org/ji

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-04-09 Thread GitBox
dajac commented on pull request #10427: URL: https://github.com/apache/kafka/pull/10427#issuecomment-816790273 Failed tests are unrelated to this PR. Same tests fail in trunk. I will go ahead and merge this PR. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] dajac merged pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-04-09 Thread GitBox
dajac merged pull request #10427: URL: https://github.com/apache/kafka/pull/10427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610754025 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final K

[jira] [Commented] (KAFKA-12643) Kafka Streams 2.7 with Kafka Broker 2.6.x regression: bad timestamp in transform/process (this.context.schedule function)

2021-04-09 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318116#comment-17318116 ] Guozhang Wang commented on KAFKA-12643: --- Hello [~devano], thanks for reporting thi

[jira] [Resolved] (KAFKA-12591) Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-04-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12591. - Fix Version/s: 3.0.0 Reviewer: Rajini Sivaram Resolution: Fixed > Remove depreca

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610756052 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(

[GitHub] [kafka] tang7526 opened a new pull request #10514: MINOR: Remove deprecated alterConfigs method

2021-04-09 Thread GitBox
tang7526 opened a new pull request #10514: URL: https://github.com/apache/kafka/pull/10514 Remove deprecated alterConfigs method ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] tombentley commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-09 Thread GitBox
tombentley commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r610772613 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -127,15 +122,22 @@ public static void main(String[] args) throw

[GitHub] [kafka] ijuma commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-09 Thread GitBox
ijuma commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-816815944 Thanks. Will we use separate packages for the api vs implementation? We should avoid split packages for the reasons mentioned here: https://www.logicbig.com/tutorials/core-java-tu

[GitHub] [kafka] tang7526 opened a new pull request #10515: MINOR: Remove deprecated checksum method

2021-04-09 Thread GitBox
tang7526 opened a new pull request #10515: URL: https://github.com/apache/kafka/pull/10515 Remove deprecated checksum method ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Ver

[jira] [Commented] (KAFKA-8165) Streams task causes Out Of Memory after connection issues and store restoration

2021-04-09 Thread Di Campo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318130#comment-17318130 ] Di Campo commented on KAFKA-8165: - Thanks A. Sophie. Yes, it was OK to close the ticket.

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-09 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610797015 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,12 +1836,12 @@ private void appendBatch( } private l

[GitHub] [kafka] junrao commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-09 Thread GitBox
junrao commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610809710 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,316 @@ +/* + * Licensed

[jira] [Commented] (KAFKA-12555) Log reason for rolling a segment

2021-04-09 Thread Alexander Daskalov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318172#comment-17318172 ] Alexander Daskalov commented on KAFKA-12555: Actually, looking closer at the

[jira] [Comment Edited] (KAFKA-12555) Log reason for rolling a segment

2021-04-09 Thread Alexander Daskalov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318172#comment-17318172 ] Alexander Daskalov edited comment on KAFKA-12555 at 4/9/21, 5:56 PM: -

[GitHub] [kafka] Comonut opened a new pull request #10516: KAFKA-12555 - Log all reason for rolling a segment

2021-04-09 Thread GitBox
Comonut opened a new pull request #10516: URL: https://github.com/apache/kafka/pull/10516 The original ticket was to debug log the reason for rolling a new log segment. based on LogSegment.shouldRoll, there are 5 conditions for rolling: 1. Segment exceeds max byte size 2. Segme

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318193#comment-17318193 ] Matthias J. Sax commented on KAFKA-12453: - {quote} # Why does the input topic ne

[jira] [Comment Edited] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318193#comment-17318193 ] Matthias J. Sax edited comment on KAFKA-12453 at 4/9/21, 6:24 PM:

[GitHub] [kafka] mjsax commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-09 Thread GitBox
mjsax commented on a change in pull request #10482: URL: https://github.com/apache/kafka/pull/10482#discussion_r610828598 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1031,6 +1032,23 @@ protected StreamsConfig(final Map props,

[GitHub] [kafka] mjsax commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-09 Thread GitBox
mjsax commented on a change in pull request #10482: URL: https://github.com/apache/kafka/pull/10482#discussion_r610829339 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1014,6 +1015,23 @@ protected StreamsConfig(final Map props,

[jira] [Created] (KAFKA-12644) Add Missing Class-Level Javadoc to Decendants of org.apache.kafka.common.errors.ApiException

2021-04-09 Thread Israel Ekpo (Jira)
Israel Ekpo created KAFKA-12644: --- Summary: Add Missing Class-Level Javadoc to Decendants of org.apache.kafka.common.errors.ApiException Key: KAFKA-12644 URL: https://issues.apache.org/jira/browse/KAFKA-12644

[GitHub] [kafka] ableegoldman commented on a change in pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-09 Thread GitBox
ableegoldman commented on a change in pull request #10512: URL: https://github.com/apache/kafka/pull/10512#discussion_r610828209 ## File path: docs/upgrade.html ## @@ -49,8 +49,9 @@ Notable changes in 3 were removed. These methods were not intended to be public API

[jira] [Commented] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

2021-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318202#comment-17318202 ] Matthias J. Sax commented on KAFKA-12566: - [https://github.com/apache/kafka/pull

[GitHub] [kafka] mjsax merged pull request #10495: MINOR: add missing TimeoutException to Producer.send JavaDocs

2021-04-09 Thread GitBox
mjsax merged pull request #10495: URL: https://github.com/apache/kafka/pull/10495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] hachikuji commented on a change in pull request #10510: KAFKA-12607: Test case for resigned state vote granting

2021-04-09 Thread GitBox
hachikuji commented on a change in pull request #10510: URL: https://github.com/apache/kafka/pull/10510#discussion_r610835639 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -137,6 +137,65 @@ public void testRejectVotesFromSameEpochAfterRe

[GitHub] [kafka] mjsax merged pull request #10453: DOCS-7223: Fix left/outer join descriptions in Streams DSL reference topic

2021-04-09 Thread GitBox
mjsax merged pull request #10453: URL: https://github.com/apache/kafka/pull/10453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] hachikuji commented on a change in pull request #10510: KAFKA-12607: Test case for resigned state vote granting

2021-04-09 Thread GitBox
hachikuji commented on a change in pull request #10510: URL: https://github.com/apache/kafka/pull/10510#discussion_r610835639 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -137,6 +137,65 @@ public void testRejectVotesFromSameEpochAfterRe

[GitHub] [kafka] mjsax commented on pull request #10453: DOCS-7223: Fix left/outer join descriptions in Streams DSL reference topic

2021-04-09 Thread GitBox
mjsax commented on pull request #10453: URL: https://github.com/apache/kafka/pull/10453#issuecomment-816884994 Merged to `trunk` and cherry-picked to `2.8` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (KAFKA-12645) KIP-731: Record Rate Limiting for Kafka Connect

2021-04-09 Thread Ryanne Dolan (Jira)
Ryanne Dolan created KAFKA-12645: Summary: KIP-731: Record Rate Limiting for Kafka Connect Key: KAFKA-12645 URL: https://issues.apache.org/jira/browse/KAFKA-12645 Project: Kafka Issue Type: I

[GitHub] [kafka] mjsax commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-04-09 Thread GitBox
mjsax commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r610838558 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[GitHub] [kafka] mjsax merged pull request #10293: KAFKA-12449: Remove deprecated WindowStore#put

2021-04-09 Thread GitBox
mjsax merged pull request #10293: URL: https://github.com/apache/kafka/pull/10293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] mjsax commented on pull request #10293: KAFKA-12449: Remove deprecated WindowStore#put

2021-04-09 Thread GitBox
mjsax commented on pull request #10293: URL: https://github.com/apache/kafka/pull/10293#issuecomment-816888464 Thanks @jeqo! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Resolved] (KAFKA-12449) Remove deprecated WindowStore#put

2021-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12449. - Fix Version/s: 3.0.0 Resolution: Fixed > Remove deprecated WindowStore#put >

[jira] [Updated] (KAFKA-12449) Remove deprecated WindowStore#put

2021-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12449: Parent: KAFKA-12419 Issue Type: Sub-task (was: Task) > Remove deprecated WindowSt

[GitHub] [kafka] mjsax commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-09 Thread GitBox
mjsax commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610849890 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -76,6 +78,35 @@ public void testResetToSpecificOffsetWhe

[GitHub] [kafka] mjsax merged pull request #10423: MINOR website quickstart, fix typo

2021-04-09 Thread GitBox
mjsax merged pull request #10423: URL: https://github.com/apache/kafka/pull/10423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] mjsax commented on pull request #10423: MINOR website quickstart, fix typo

2021-04-09 Thread GitBox
mjsax commented on pull request #10423: URL: https://github.com/apache/kafka/pull/10423#issuecomment-816904214 Thanks @Alee4738! Merged both PRs. (Cherry-picked this one also to `2.8` branch.) -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

2021-04-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318218#comment-17318218 ] Matthias J. Sax commented on KAFKA-12566: - [https://github.com/apache/kafka/pull

[GitHub] [kafka] mjsax merged pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

2021-04-09 Thread GitBox
mjsax merged pull request #10301: URL: https://github.com/apache/kafka/pull/10301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-09 Thread GitBox
kpatelatwork commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610857516 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws Int

[GitHub] [kafka] C0urante commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-09 Thread GitBox
C0urante commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610857776 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws Interru

[jira] [Issue Comment Deleted] (KAFKA-9988) Connect incorrectly logs that task has failed when one takes too long to shutdown

2021-04-09 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-9988: - Comment: was deleted (was: https://github.com/apache/kafka/pull/10503/) > Connect incorrectly lo

[GitHub] [kafka] mjsax commented on pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

2021-04-09 Thread GitBox
mjsax commented on pull request #10301: URL: https://github.com/apache/kafka/pull/10301#issuecomment-816928393 Thanks for the PR @showuon! -- Hope we get this test finally stable! Merged to `trunk` and cherry-picked to `2.8` and `2.7` branches. -- This is an automated message from

[GitHub] [kafka] vvcephei merged pull request #10381: KAFKA-8410: Migrating KStream Stateless operators to new Processor API

2021-04-09 Thread GitBox
vvcephei merged pull request #10381: URL: https://github.com/apache/kafka/pull/10381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-09 Thread GitBox
MarcoLotz commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610877439 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -247,6 +278,32 @@ public void shouldDetermineInterna

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-09 Thread GitBox
MarcoLotz commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610879225 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -76,6 +78,35 @@ public void testResetToSpecificOffse

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610890414 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/KeyAndJoinSide.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610890964 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +246,66 @@ private void assertUniqueStoreN

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891116 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +132,40 @@ final ProcessorGraphN

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891253 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +45,32 @@ private final String oth

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891590 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -92,6 +113,10 @@ public void process(final K k

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891690 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final K

[GitHub] [kafka] MarcoLotz commented on pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-09 Thread GitBox
MarcoLotz commented on pull request #10042: URL: https://github.com/apache/kafka/pull/10042#issuecomment-816957853 updated the PR and rebased with trunk. Build seems to be failing on trunk due to RocksDBTimeOrderedWindowStore.java -- This is an automated message from the Apache Git Servi

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-09 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610893784 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -161,7 +181,7 @@ public void process(final K k

[GitHub] [kafka] mjsax commented on a change in pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-09 Thread GitBox
mjsax commented on a change in pull request #10042: URL: https://github.com/apache/kafka/pull/10042#discussion_r610904483 ## File path: streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java ## @@ -247,6 +278,32 @@ public void shouldDetermineInternalTop

[GitHub] [kafka] jolshan edited a comment on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-04-09 Thread GitBox
jolshan edited a comment on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-814408153 ~currently blocked on https://github.com/apache/kafka/pull/10492 (Need to add topic IDs to the metadata topic for fetching)~ No longer blocked -- This is an aut

[GitHub] [kafka] mjsax opened a new pull request #10517: HOTFIX: delete removed WindowedStore.put() method

2021-04-09 Thread GitBox
mjsax opened a new pull request #10517: URL: https://github.com/apache/kafka/pull/10517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-09 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610908966 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-09 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610910922 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging { //

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-09 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610911015 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1859,15 +1819,15 @@ private void appendBatch( offset

  1   2   >