[GitHub] [kafka] vcrfxia opened a new pull request #11368: KAFKA-13261: Add support for custom partitioners in foreign key joins

vcrfxia opened a new pull request #11368: URL: https://github.com/apache/kafka/pull/11368 Implements KIP-775 for adding Kafka Streams support for foreign key joins on tables with custom partitioners: https://cwiki.apache.org/confluence/display/KAFKA/KIP-775%3A+Custom+partitioners+in+for

[jira] [Created] (KAFKA-13334) ERROR Failed to clean up log for __consumer_offsets

Udaya Kumar created KAFKA-13334: --- Summary: ERROR Failed to clean up log for __consumer_offsets Key: KAFKA-13334 URL: https://issues.apache.org/jira/browse/KAFKA-13334 Project: Kafka Issue Type:

[GitHub] [kafka] lhunyady commented on pull request #11333: KAFKA-13306: Null connector config value passes validation, but fails creation

lhunyady commented on pull request #11333: URL: https://github.com/apache/kafka/pull/11333#issuecomment-929910705 Thanks @C0urante for the feedback, I agree with you and updated the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (KAFKA-13325) kafka system tests stall

[ https://issues.apache.org/jira/browse/KAFKA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421991#comment-17421991 ] Abhijit Mane commented on KAFKA-13325: -- [~chia7712] If you get a chance, would you

[GitHub] [kafka] showuon commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

showuon commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r718240534 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -188,8 +188,9 @@ public AbstractCoordinato

[GitHub] [kafka] showuon commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

showuon commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r718253900 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1069,6 +1074,37 @@ private void maybeAuto

[jira] [Created] (KAFKA-13335) Upgrading connect from 2.7.0 to 2.8.0 causes worker instability

John Gray created KAFKA-13335: - Summary: Upgrading connect from 2.7.0 to 2.8.0 causes worker instability Key: KAFKA-13335 URL: https://issues.apache.org/jira/browse/KAFKA-13335 Project: Kafka Is

[jira] [Updated] (KAFKA-13335) Upgrading connect from 2.7.0 to 2.8.0 causes worker instability

[ https://issues.apache.org/jira/browse/KAFKA-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gray updated KAFKA-13335: -- Description: After recently upgrading our connect cluster to 2.8.0 (via strimzi+Kubernetes, brokers a

[jira] [Updated] (KAFKA-13335) Upgrading connect from 2.7.0 to 2.8.0 causes worker instability

[ https://issues.apache.org/jira/browse/KAFKA-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gray updated KAFKA-13335: -- Description: After recently upgrading our connect cluster to 2.8.0 (via strimzi+Kubernetes, brokers a

[GitHub] [kafka] C0urante opened a new pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante opened a new pull request #11369: URL: https://github.com/apache/kafka/pull/11369 [KAFKA-13327](https://issues.apache.org/jira/browse/KAFKA-13327): Modify preflight validation logic to prevent 500 responses from being returned instead of valid 200 responses with detailed error mes

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718551225 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -344,12 +354,73 @@ public StatusBackingStore stat

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718554974 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -425,7 +439,10 @@ void enrich(ConfigDef newDef)

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718556405 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -499,13 +516,15 @@ ConfigDef getConfigDefFromCon

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718556879 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -499,13 +516,15 @@ ConfigDef getConfigDefFromCon

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718557792 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java ## @@ -70,60 +73,105 @@ "keys, all er

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718558688 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/MonitorableSourceConnector.java ## @@ -114,8 +114,8 @@ public void star

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718559975 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorClientPolicyIntegrationTest.java ## @@ -133,7 +133,7 @@ privat

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r718738299 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -704,11 +704,14 @@ public void sendOffsetsToTransacti

[jira] [Commented] (KAFKA-13332) New pattern-matched topic with more partitions than existing matched topics can crash Kafka Streams

[ https://issues.apache.org/jira/browse/KAFKA-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422287#comment-17422287 ] Guozhang Wang commented on KAFKA-13332: --- Thanks [~ableegoldman]. My first thought

[GitHub] [kafka] guozhangwang commented on pull request #11336: DRAFT: Add currentPosition and times to ProcessorContext

guozhangwang commented on pull request #11336: URL: https://github.com/apache/kafka/pull/11336#issuecomment-930396119 > You're both right about the missing time methods. I'll just send an update to that KIP and send a separate PR. Sounds great! -- This is an automated message from

[jira] [Commented] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422290#comment-17422290 ] Sagar Rao commented on KAFKA-13295: --- [~ableegoldman], yes it does. I wanted to ask the

[jira] [Commented] (KAFKA-13272) KStream offset stuck after brokers outage

[ https://issues.apache.org/jira/browse/KAFKA-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422291#comment-17422291 ] Guozhang Wang commented on KAFKA-13272: --- Regarding the fix: it won't be a trivial

[jira] [Commented] (KAFKA-13286) Revisit Streams State Store and Serde Implementation

[ https://issues.apache.org/jira/browse/KAFKA-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422292#comment-17422292 ] Sagar Rao commented on KAFKA-13286: --- hey [~guozhang], wanted to know is there anything

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-930401248 @showuon , plz review whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang commented on pull request #11364: MINOR: expand logging and improve error message during partition count resolution

guozhangwang commented on pull request #11364: URL: https://github.com/apache/kafka/pull/11364#issuecomment-930401502 LGTM! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] vcrfxia commented on pull request #11368: KAFKA-13261: Add support for custom partitioners in foreign key joins

vcrfxia commented on pull request #11368: URL: https://github.com/apache/kafka/pull/11368#issuecomment-930424575 @mjsax request for review. cc @vvcephei @bellemare @guozhangwang for visibility (comments of course welcome too!) -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-13121) Flaky Test TopicBasedRemoteLogMetadataManagerTest.testNewPartitionUpdates()

[ https://issues.apache.org/jira/browse/KAFKA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422315#comment-17422315 ] Matthias J. Sax commented on KAFKA-13121: - failed again > Flaky Test TopicBased

[GitHub] [kafka] junrao commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

junrao commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r718789940 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords, timeIndex.resiz

[GitHub] [kafka] ccding commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r718814631 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords, timeIndex.resiz

[GitHub] [kafka] junrao commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

junrao commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r718858100 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords, timeIndex.resiz

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718910814 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -173,8 +184,8 @@ class CachedPartition(val topic: String, this.eq(that) |

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718911636 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -173,8 +184,8 @@ class CachedPartition(val topic: String, this.eq(that) |

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718912221 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -378,53 +378,47 @@ class SessionlessFetchContext(val fetchData: util.Map[TopicPar

[GitHub] [kafka] mjsax commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

mjsax commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-930593991 @guozhangwang Should this fix be cherry-picked to `3.0` branch (and the jira be updated with fixed version `3.0.1`?) -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax edited a comment on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

mjsax edited a comment on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-930593991 @guozhangwang Now that `3.0.0` is released, should this fix be cherry-picked to `3.0` branch (and the jira be updated with fixed version `3.0.1`?) -- This is an automated

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r718738299 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -704,11 +704,14 @@ public void sendOffsetsToTransacti

[GitHub] [kafka] guozhangwang commented on a change in pull request #11367: MINOR: Do not copy on range for in-memory shared store in stream stream left/out joins

guozhangwang commented on a change in pull request #11367: URL: https://github.com/apache/kafka/pull/11367#discussion_r718112421 ## File path: gradle.properties ## @@ -20,7 +20,7 @@ group=org.apache.kafka # - tests/kafkatest/__init__.py # - tests/kafkatest/version.py (varia

[GitHub] [kafka] ableegoldman commented on pull request #11215: KAFKA-12994: Migrate TimeWindowsTest to new API

ableegoldman commented on pull request #11215: URL: https://github.com/apache/kafka/pull/11215#issuecomment-929683974 Merged to trunk. Thanks @officialpatterson ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] mjsax commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

mjsax commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-930593991 @guozhangwang Should this fix be cherry-picked to `3.0` branch (and the jira be updated with fixed version `3.0.1`?) -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax edited a comment on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

mjsax edited a comment on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-930593991 @guozhangwang Now that `3.0.0` is released, should this fix be cherry-picked to `3.0` branch (and the jira be updated with fixed version `3.0.1`?) -- This is an automated

[GitHub] [kafka] ableegoldman commented on pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

ableegoldman commented on pull request #11218: URL: https://github.com/apache/kafka/pull/11218#issuecomment-929718737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] ableegoldman merged pull request #11215: KAFKA-12994: Migrate TimeWindowsTest to new API

ableegoldman merged pull request #11215: URL: https://github.com/apache/kafka/pull/11215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-930401248 @showuon , plz review whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mjsax merged pull request #11363: MINOR: remove note on future multi-cluster support of Kafka Streams

mjsax merged pull request #11363: URL: https://github.com/apache/kafka/pull/11363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] guozhangwang commented on pull request #11336: DRAFT: Add currentPosition and times to ProcessorContext

guozhangwang commented on pull request #11336: URL: https://github.com/apache/kafka/pull/11336#issuecomment-930396119 > You're both right about the missing time methods. I'll just send an update to that KIP and send a separate PR. Sounds great! -- This is an automated message from

[GitHub] [kafka] ableegoldman merged pull request #11337: KAFKA-13309: fix InMemorySessionStore#fetch/backwardFetch order issue

ableegoldman merged pull request #11337: URL: https://github.com/apache/kafka/pull/11337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman merged pull request #11365: HOTFIX: fix checkstyle after cherrypick

ableegoldman merged pull request #11365: URL: https://github.com/apache/kafka/pull/11365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ccding commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r718814631 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords, timeIndex.resiz

[GitHub] [kafka] lhunyady commented on pull request #11333: KAFKA-13306: Null connector config value passes validation, but fails creation

lhunyady commented on pull request #11333: URL: https://github.com/apache/kafka/pull/11333#issuecomment-929910705 Thanks @C0urante for the feedback, I agree with you and updated the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] guozhangwang commented on pull request #11364: MINOR: expand logging and improve error message during partition count resolution

guozhangwang commented on pull request #11364: URL: https://github.com/apache/kafka/pull/11364#issuecomment-930401502 LGTM! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] junrao commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

junrao commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r718789940 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords, timeIndex.resiz

[GitHub] [kafka] vcrfxia commented on pull request #11368: KAFKA-13261: Add support for custom partitioners in foreign key joins

vcrfxia commented on pull request #11368: URL: https://github.com/apache/kafka/pull/11368#issuecomment-930424575 @mjsax request for review. cc @vvcephei @bellemare @guozhangwang for visibility (comments of course welcome too!) -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on a change in pull request #11367: MINOR: Do not copy on range for in-memory shared store in stream stream left/out joins

mjsax commented on a change in pull request #11367: URL: https://github.com/apache/kafka/pull/11367#discussion_r718176753 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/ListValueStoreTest.java ## @@ -136,8 +138,9 @@ public void shouldGetAllNonDele

[GitHub] [kafka] C0urante commented on a change in pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

C0urante commented on a change in pull request #11369: URL: https://github.com/apache/kafka/pull/11369#discussion_r718551225 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -344,12 +354,73 @@ public StatusBackingStore stat

[GitHub] [kafka] junrao commented on a change in pull request #11058: KAFKA-12802 Added a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker

junrao commented on a change in pull request #11058: URL: https://github.com/apache/kafka/pull/11058#discussion_r717821546 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java ## @@ -120,6 +171,37 @@ public void run() {

[GitHub] [kafka] ableegoldman merged pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

ableegoldman merged pull request #11218: URL: https://github.com/apache/kafka/pull/11218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] showuon commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

showuon commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r718240534 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -188,8 +188,9 @@ public AbstractCoordinato

[GitHub] [kafka] ableegoldman merged pull request #11076: KAFKA-12486: Enforce Rebalance when a TaskCorruptedException is throw…

ableegoldman merged pull request #11076: URL: https://github.com/apache/kafka/pull/11076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman commented on pull request #11364: MINOR: expand logging and improve error message during partition count resolution

ableegoldman commented on pull request #11364: URL: https://github.com/apache/kafka/pull/11364#issuecomment-929670722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] ableegoldman commented on pull request #11337: KAFKA-13309: fix InMemorySessionStore#fetch/backwardFetch order issue

ableegoldman commented on pull request #11337: URL: https://github.com/apache/kafka/pull/11337#issuecomment-929733880 Merged to trunk and cherrypicked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] ableegoldman merged pull request #11366: HOTFIX: add import to fix checkstyle

ableegoldman merged pull request #11366: URL: https://github.com/apache/kafka/pull/11366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718910814 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -173,8 +184,8 @@ class CachedPartition(val topic: String, this.eq(that) |

[GitHub] [kafka] mjsax commented on pull request #11363: MINOR: remove note on future multi-cluster support of Kafka Streams

mjsax commented on pull request #11363: URL: https://github.com/apache/kafka/pull/11363#issuecomment-929869884 Merged to `trunk` and cherry-picked to `3.0` and `2.8` branches. Follow up PR for web-page: https://github.com/apache/kafka-site/pull/376 (call for review @bbejeck) -- Th

[GitHub] [kafka] ableegoldman merged pull request #11364: MINOR: expand logging and improve error message during partition count resolution

ableegoldman merged pull request #11364: URL: https://github.com/apache/kafka/pull/11364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Commented] (KAFKA-13326) Add multi-cluster support to Kafka Streams

[ https://issues.apache.org/jira/browse/KAFKA-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422484#comment-17422484 ] Guangyuan Wang commented on KAFKA-13326: [~bchen225242] Thank you very much for

[jira] [Comment Edited] (KAFKA-13326) Add multi-cluster support to Kafka Streams

[ https://issues.apache.org/jira/browse/KAFKA-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422484#comment-17422484 ] Guangyuan Wang edited comment on KAFKA-13326 at 9/30/21, 1:26 AM:

[jira] [Comment Edited] (KAFKA-13326) Add multi-cluster support to Kafka Streams

[ https://issues.apache.org/jira/browse/KAFKA-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422484#comment-17422484 ] Guangyuan Wang edited comment on KAFKA-13326 at 9/30/21, 1:26 AM:

[jira] [Created] (KAFKA-13336) Migrate StreamsBuilder class to interface with factory method on KafkaStreams

A. Sophie Blee-Goldman created KAFKA-13336: -- Summary: Migrate StreamsBuilder class to interface with factory method on KafkaStreams Key: KAFKA-13336 URL: https://issues.apache.org/jira/browse/KAFKA-13336

[jira] [Commented] (KAFKA-12957) Refactor Streams Logical Plan Generation

[ https://issues.apache.org/jira/browse/KAFKA-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422488#comment-17422488 ] A. Sophie Blee-Goldman commented on KAFKA-12957: Hey [~sagarrao], I wrot

[jira] [Updated] (KAFKA-13336) Migrate StreamsBuilder class to interface with factory method on KafkaStreams

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13336: --- Description: In order to refactor and improve the streams physical plan gene

[jira] [Commented] (KAFKA-13336) Migrate StreamsBuilder class to interface with factory method on KafkaStreams

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422494#comment-17422494 ] Luke Chen commented on KAFKA-13336: --- [~ableegoldman], this is exactly what I proposed

[jira] [Commented] (KAFKA-13336) Migrate StreamsBuilder class to interface with factory method on KafkaStreams

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422504#comment-17422504 ] A. Sophie Blee-Goldman commented on KAFKA-13336: The Topology/InternalTo

[jira] [Commented] (KAFKA-13336) Migrate StreamsBuilder class to interface with factory method on KafkaStreams

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422505#comment-17422505 ] A. Sophie Blee-Goldman commented on KAFKA-13336: [~showuon] Nice! I hadn

[GitHub] [kafka] showuon commented on a change in pull request #11367: MINOR: Do not copy on range for in-memory shared store in stream stream left/out joins

showuon commented on a change in pull request #11367: URL: https://github.com/apache/kafka/pull/11367#discussion_r719028387 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -311,7 +314,25 @@ private void assertUniqueStor

[jira] [Updated] (KAFKA-13336) Migrate StreamsBuilder/Topology class to interfaces and move Topology parameter from KafkaStreams constructor to #start

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13336: --- Summary: Migrate StreamsBuilder/Topology class to interfaces and move Topolo

[jira] [Updated] (KAFKA-13336) Migrate StreamsBuilder/Topology class to interfaces and move Topology parameter from KafkaStreams constructor to #start

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13336: --- Description: In order to refactor and improve the streams physical plan gene