Re: [PR] KAFKA-14133: Replace Easymock with Mockito in StreamsProducerTest, TopologyMetadataTest & GlobalStateStoreProviderTest [kafka]

2023-10-10 Thread via GitHub
bachmanity1 commented on PR #14410: URL: https://github.com/apache/kafka/pull/14410#issuecomment-1754552042 @clolov @yashmayya kind reminder for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Fix docs for ReplicationBytes(Out|In)PerSec metrics [kafka]

2023-10-10 Thread via GitHub
bachmanity1 commented on PR #14228: URL: https://github.com/apache/kafka/pull/14228#issuecomment-1754554650 @mimaison @ijuma kind reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Assigned] (KAFKA-15568) Use incrementalAlterConfigs to update the dynamic config of broker in ConfigCommand tool

2023-10-10 Thread Aman Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Singh reassigned KAFKA-15568: -- Assignee: Aman Singh > Use incrementalAlterConfigs to update the dynamic config of broker in

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-10 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1351723672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-10 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1351723672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-10 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1351723672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] KAFKA-14927: Add validation to be config keys in ConfigCommand tool [kafka]

2023-10-10 Thread via GitHub
omkreddy merged PR #14514: URL: https://github.com/apache/kafka/pull/14514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14927) Dynamic configs not validated when using kafka-configs and --add-config-file

2023-10-10 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-14927. --- Fix Version/s: 3.7.0 Assignee: Aman Singh (was: José Armando García Sancio) Resoluti

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-10 Thread via GitHub
fvaleri commented on code in PR #14484: URL: https://github.com/apache/kafka/pull/14484#discussion_r1351855793 ## docs/upgrade.html: ## @@ -144,8 +144,10 @@ Upgrading KRaft-based cl ./bin/kafka-features.sh upgrade --metadata 3.5 -

[jira] [Commented] (KAFKA-15461) Add integration test for the ListGroup API

2023-10-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773605#comment-17773605 ] David Jacot commented on KAFKA-15461: - Hey [~zhaohaidao], are you still interested b

Re: [PR] KAFKA-14133: Move MeteredTimestampedKeyValueStoreTest, ReadOnlyWindowStoreFacadeTest and TimestampedWindowStoreBuilderTest to Mockito [kafka]

2023-10-10 Thread via GitHub
divijvaidya commented on PR #14412: URL: https://github.com/apache/kafka/pull/14412#issuecomment-1754761430 @clolov can you please fix the checkstyle failures so that the CI is successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1351957160 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -106,7 +107,8 @@ void validateOffsetFetch( /** * Returns true if the gr

Re: [PR] KAFKA-14684 Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskThreadedTest [kafka]

2023-10-10 Thread via GitHub
clolov commented on code in PR #14505: URL: https://github.com/apache/kafka/pull/14505#discussion_r1352038137 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskThreadedTest.java: ## @@ -409,309 +430,266 @@ public void testAssignmentPauseResume() thr

[jira] [Resolved] (KAFKA-15382) Replace EasyMock with Mockito for KStreamTransformValuesTest

2023-10-10 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-15382. --- Resolution: Duplicate Closing this ticket in favour of https://issues.apache.org/jira/brows

[jira] [Resolved] (KAFKA-15383) Replace EasyMock with Mockito for KTableImplTest

2023-10-10 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-15383. --- Resolution: Duplicate Closing this ticket in favour of https://issues.apache.org/jira/brows

[jira] [Resolved] (KAFKA-15384) Replace EasyMock with Mockito for KTableTransformValuesTest

2023-10-10 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-15384. --- Resolution: Fixed Closing this ticket in favour of https://issues.apache.org/jira/browse/KA

[jira] [Resolved] (KAFKA-15385) Replace EasyMock with Mockito for AbstractStreamTest

2023-10-10 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-15385. --- Resolution: Duplicate Closing this in favour of https://issues.apache.org/jira/browse/KAFKA-

Re: [PR] KAFKA-15536:Dynamically resize remoteIndexCache [kafka]

2023-10-10 Thread via GitHub
divijvaidya commented on code in PR #14511: URL: https://github.com/apache/kafka/pull/14511#discussion_r1352082129 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -137,15 +138,8 @@ public RemoteIndexCache(long maxSize, RemoteStorageMa

Re: [PR] Kafka 12317: Relax non-null key requirement in Kafka Streams [kafka]

2023-10-10 Thread via GitHub
florin-akermann commented on code in PR #14174: URL: https://github.com/apache/kafka/pull/14174#discussion_r1352140220 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamJoinWindow.java: ## @@ -51,8 +51,8 @@ public void init(final ProcessorContext context

Re: [PR] Kafka 12317: Relax non-null key requirement in Kafka Streams [kafka]

2023-10-10 Thread via GitHub
florin-akermann commented on code in PR #14174: URL: https://github.com/apache/kafka/pull/14174#discussion_r1352231502 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -124,17 +124,20 @@ public void init(final ProcessorContext co

Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
jeel2420 commented on code in PR #14483: URL: https://github.com/apache/kafka/pull/14483#discussion_r1352268556 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -169,7 +169,16 @@ public Cache internalCache() { public void remove(U

Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
jeel2420 commented on code in PR #14483: URL: https://github.com/apache/kafka/pull/14483#discussion_r1352269114 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -134,7 +134,7 @@ public RemoteIndexCache(int maxSize, RemoteStorageManager

Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
jeel2420 commented on code in PR #14483: URL: https://github.com/apache/kafka/pull/14483#discussion_r1347129743 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -281,14 +282,8 @@ class RemoteIndexCacheTest { // no expired entries yet asser

[jira] [Created] (KAFKA-15570) Add unit tests for MemoryConfigBackingStore

2023-10-10 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-15570: -- Summary: Add unit tests for MemoryConfigBackingStore Key: KAFKA-15570 URL: https://issues.apache.org/jira/browse/KAFKA-15570 Project: Kafka Issue Type: Test

[PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
yashmayya opened a new pull request, #14518: URL: https://github.com/apache/kafka/pull/14518 - https://issues.apache.org/jira/browse/KAFKA-15570 - Currently, the [MemoryConfigBackingStore](https://github.com/apache/kafka/blob/6e164bb9ace3ea7a1a9542904d1a01c9fd3a1b48/connect/runtime/src/ma

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
yashmayya commented on PR #14518: URL: https://github.com/apache/kafka/pull/14518#issuecomment-1755155655 @C0urante would you be able to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-10 Thread Levani Kokhreidze (Jira)
Levani Kokhreidze created KAFKA-15571: - Summary: StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended Key: KAFKA-15571 UR

[jira] [Assigned] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-10 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze reassigned KAFKA-15571: - Assignee: Levani Kokhreidze > StateRestoreListener#onRestoreSuspended is never

[PR] StateRestoreListener#onRestoreSuspended is never called because wrapp…er DelegatingStateRestoreListener doesn't implement onRestoreSuspended [kafka]

2023-10-10 Thread via GitHub
lkokhreidze opened a new pull request, #14519: URL: https://github.com/apache/kafka/pull/14519 With https://issues.apache.org/jira/browse/KAFKA-10575 `StateRestoreListener#onRestoreSuspended` was added. But local tests show that it is never called because `DelegatingStateRestoreListener` wa

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2023-10-10 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1755428479 Hi @mimaison, thanks for the reply. We were referring to older Jenkins file before the support was disabled on Power, No specific reason to use nested stage fields. If any

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-10 Thread via GitHub
lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1755442563 Thanks @cadonna I will continue working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-10 Thread via GitHub
msn-tldr commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1352576812 ## clients/src/main/resources/common/message/ProduceResponse.json: ## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for detai

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1352612988 ## clients/src/main/resources/common/message/ProduceResponse.json: ## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for details.

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1352614826 ## clients/src/main/resources/common/message/ProduceResponse.json: ## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for details.

[jira] [Updated] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-10 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-15571: -- Description: With https://issues.apache.org/jira/browse/KAFKA-10575 `StateRestoreListe

[jira] [Created] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
Lucian Ilie created KAFKA-15572: --- Summary: Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs Key: KAFKA-15572 URL: https://issues.apache.org/jira/browse/KAFKA-

Re: [PR] KAFKA-15465: Don't throw if MirrorMaker not authorized to create topics. [kafka]

2023-10-10 Thread via GitHub
OmniaGM commented on PR #14388: URL: https://github.com/apache/kafka/pull/14388#issuecomment-1755573422 @mimaison or @C0urante can one of you review this pr, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-14596: Move TopicCommand to tools [kafka]

2023-10-10 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1755578715 @mimaison fixed the compilation issue. I spotted another one with Java21 and fixed it as well. -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Attachment: kafka-alter-log-dir-nosuchfileexception.log > Race condition between future log dir ro

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using ba

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Affects Version/s: 3.0.0 (was: 3.3.1) (was: 3

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm closed pull request #14413: KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements URL: https://github.com/apache/kafka/pull/14413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm opened a new pull request, #14413: URL: https://github.com/apache/kafka/pull/14413 This PR includes: - changes for error handling, leaving responsibility in the heartbeatManager and exposing only the functionality for when the state needs to be updated (on successful HB, on f

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm commented on PR #14413: URL: https://github.com/apache/kafka/pull/14413#issuecomment-1755659746 Hey @dajac , this ready for review now, including trunk latest changes. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15355: Message schema changes [kafka]

2023-10-10 Thread via GitHub
clolov commented on PR #14290: URL: https://github.com/apache/kafka/pull/14290#issuecomment-1755706472 I am putting myself as a reviewer because I would like to keep up to date with these changes. I will aim to provide my review tomorrow! -- This is an automated message from the Apache Gi

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
jeffkbkim commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1352815096 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,46 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-10 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1352848836 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-10 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1352848836 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[PR] Update HEADER [kafka]

2023-10-10 Thread via GitHub
adikarthik opened a new pull request, #14520: URL: https://github.com/apache/kafka/pull/14520 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1352874538 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1352875373 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -19,56 +19,91 @@ import org.apache.kafka.common.message.Consum

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1352876691 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -21,53 +21,76 @@ import java.util.Optional; /** - * Manages gro

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1352876631 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1352879009 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManager.java: ## @@ -16,13 +16,48 @@ */ package org.apache.kafka.clients.consumer.intern

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1352882295 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -21,53 +21,76 @@ import java.util.Optional; /** - * Manages gro

[jira] [Updated] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2023-10-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15573: -- Description: When the group member's assignment changes and partitions are revoked and auto-commit is

[jira] [Created] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2023-10-10 Thread Kirk True (Jira)
Kirk True created KAFKA-15573: - Summary: Implement auto-commit on partition assignment revocation Key: KAFKA-15573 URL: https://issues.apache.org/jira/browse/KAFKA-15573 Project: Kafka Issue Type

[jira] [Created] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Kirk True (Jira)
Kirk True created KAFKA-15574: - Summary: Integrate partition assignment reconciliation with heartbeat request manager Key: KAFKA-15574 URL: https://issues.apache.org/jira/browse/KAFKA-15574 Project: Kafka

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15574: -- Description: This task is to call the partition assignment reconciler from the heartbeat request manag

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-10 Thread via GitHub
rbaddam commented on PR #14504: URL: https://github.com/apache/kafka/pull/14504#issuecomment-1755866839 To address your concern about the specificity of the solution, I will create Interfaces/subclasses of KerberosPrincipalBuilder and SSLPrincipalBuilder to handle different types of princip

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1353015059 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1353024844 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-10 Thread via GitHub
jeffkbkim commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1755898146 not sure what this error is from ``` > Task :streams:compileJava /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14417/streams/src/main/java/org/apache/kafka/str

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to call the partition assignment reconciler from the heartbeat re

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to call the partition assignment reconciler from the heartbeat re

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to call the partition assignment reconciler from the heartbeat re

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1353033902 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -540,6 +545,8 @@ class RemoteIndexCacheTest { "Failed to mark cache entry for c

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1353033902 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -540,6 +545,8 @@ class RemoteIndexCacheTest { "Failed to mark cache entry for c

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353043290 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -117,4 +119,16 @@ void validateOffsetFetch( * @param records The list of

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353044716 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -91,6 +91,27 @@ public class GroupCoordinatorConfig { *

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045205 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -91,6 +91,27 @@ public class GroupCoordinatorConfig { *

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045293 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -117,4 +119,16 @@ void validateOffsetFetch( * @param records The list of rec

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045452 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -91,6 +91,27 @@ public class GroupCoordinatorConfig { *

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353048258 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -417,6 +441,39 @@ public CoordinatorResult deleteOffsets(

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353053689 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetExpirationConditionImpl.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353055183 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public OffsetFetchResponseData.OffsetFetchRe

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353056783 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public OffsetFetchResponseData.OffsetFetchRe

[PR] Backport kafka 15415 [kafka]

2023-10-10 Thread via GitHub
msn-tldr opened a new pull request, #14521: URL: https://github.com/apache/kafka/pull/14521 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-10 Thread via GitHub
kirktrue closed pull request #13528: KAFKA-14879: Update system tests to use latest versions URL: https://github.com/apache/kafka/pull/13528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader (#… [kafka]

2023-10-10 Thread via GitHub
msn-tldr opened a new pull request, #14522: URL: https://github.com/apache/kafka/pull/14522 …14384) This PR backports https://github.com/apache/kafka/pull/14384 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit

Re: [PR] Backport kafka 15415 [kafka]

2023-10-10 Thread via GitHub
msn-tldr closed pull request #14521: Backport kafka 15415 URL: https://github.com/apache/kafka/pull/14521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1755953000 This appears to be taken up by someone else, but they're doing it in a more automated/dynamic manner, which is better anyway. -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-10 Thread via GitHub
jolshan commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1755954984 Sorry I must have missed this ping. :( My bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR - KAFKA-15550: Validation for negative target times in offsetsForTimes [kafka]

2023-10-10 Thread via GitHub
lianetm commented on PR #14503: URL: https://github.com/apache/kafka/pull/14503#issuecomment-1756011144 hey @cadonna, @lucasbru. This is a very small PR adding a missing API validation to the new consumer `offsetsForTimes` functionality. It also includes some improved comments for the `

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2023-10-10 Thread via GitHub
lihaosky commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1353117588 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -436,6 +436,239 @@ public void testRightNonJoinedRecordsAre

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1353179173 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -180,19 +180,19 @@ CompletableFuture sendAutoCommit(final Map offse

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-10 Thread Yi Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Ding updated KAFKA-15548: Labels: consumer-threading-refactor kip- (was: consumer-threading-refactor) > Handling close() properly >

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-10 Thread Yi Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Ding updated KAFKA-15548: Labels: consumer-threading-refactor kip-848 kip-848-client-support kip-848-preview (was: consumer-threadi

[jira] [Updated] (KAFKA-15534) Propagate client response time when timeout to the request handler

2023-10-10 Thread Yi Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Ding updated KAFKA-15534: Labels: consumer-threading-refactor kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was: cons

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-10 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15548: --- Labels: consumer-threading-refactor kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1353232858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -180,19 +180,19 @@ CompletableFuture sendAutoCommit(final Map o

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-10 Thread via GitHub
lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1756120126 Hi @cadonna, I've added an integration test. It seemed the safest way to test out the new functionality. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [MINOR] More image replay test cases [kafka]

2023-10-10 Thread via GitHub
rondagostino commented on PR #14206: URL: https://github.com/apache/kafka/pull/14206#issuecomment-1756151303 @ahuang98 I still saw lots of test failures, and when I checked them locally I actually was able to reproduce the below failures. Can you take a look to see if you also agree these

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-10 Thread via GitHub
plazma-prizma commented on code in PR #14491: URL: https://github.com/apache/kafka/pull/14491#discussion_r1353388791 ## clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java: ## @@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder createPrincipalBuilde

  1   2   >