[PR] Added ACLs authorizer change during migration [kafka]

2024-02-07 Thread via GitHub
ppatierno opened a new pull request, #15333: URL: https://github.com/apache/kafka/pull/15333 This trivial PR makes clear when it's the right time to switch from `AclAuthorizer` to `StandardAuthorizer` during the migration process. -- This is an automated message from the Apache Git

Re: [PR] Added ACLs authorizer change during migration [kafka]

2024-02-07 Thread via GitHub
ppatierno commented on PR #15333: URL: https://github.com/apache/kafka/pull/15333#issuecomment-1931670721 @showuon can you take a look at this one please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Added ACLs authorizer change during migration [kafka]

2024-02-07 Thread via GitHub
showuon commented on PR #15333: URL: https://github.com/apache/kafka/pull/15333#issuecomment-1931695656 @cmccabe @mumrah , do you want to have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16231: Update consumer_test.py to support KIP-848’s group protocol config [kafka]

2024-02-07 Thread via GitHub
lucasbru commented on PR #15330: URL: https://github.com/apache/kafka/pull/15330#issuecomment-1931603191 looks good. As you said, we shouldn't merge this yet as long as some are not passing. Could we follow a similar approach as with the integration tests, enable the ones that are passing,

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-02-07 Thread via GitHub
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1931723005 I updated the [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Support+Compression+Level) based on [Jun's

Re: [PR] KAFKA-16037: Update VerifiableConsumer to support KIP-848’s group protocol config [kafka]

2024-02-07 Thread via GitHub
lucasbru merged PR #15325: URL: https://github.com/apache/kafka/pull/15325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-07 Thread via GitHub
dajac commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1481205214 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -127,8 +127,16 @@ public void onSuccessfulAttempt(final long currentTimeMs)

Re: [PR] Additional fix on the rollback migration documentation [kafka]

2024-02-07 Thread via GitHub
showuon commented on code in PR #15317: URL: https://github.com/apache/kafka/pull/15317#discussion_r1481224501 ## docs/ops.html: ## @@ -4054,16 +4054,19 @@ Reverting to ZooKeeper mode During the Migration - It is important to perform

Re: [PR] Additional fix on the rollback migration documentation [kafka]

2024-02-07 Thread via GitHub
ppatierno commented on code in PR #15317: URL: https://github.com/apache/kafka/pull/15317#discussion_r1481244856 ## docs/ops.html: ## @@ -4054,16 +4054,19 @@ Reverting to ZooKeeper mode During the Migration - It is important to perform

Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-07 Thread via GitHub
lucasbru commented on code in PR #15334: URL: https://github.com/apache/kafka/pull/15334#discussion_r1481228908 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1378,6 +1377,14 @@ class PlaintextConsumerTest extends BaseConsumerTest { //

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-07 Thread via GitHub
dajac commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1481015399 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -37,7 +39,10 @@ public class ConsumerGroupListing { * @param

Re: [PR] KAFKA-16230: Update verifiable_consumer.py to support KIP-848’s group protocol config [kafka]

2024-02-07 Thread via GitHub
lucasbru commented on code in PR #15328: URL: https://github.com/apache/kafka/pull/15328#discussion_r1481140116 ## tests/kafkatest/version.py: ## @@ -263,3 +263,7 @@ def get_version(node=None): V_3_6_0 = KafkaVersion("3.6.0") V_3_6_1 = KafkaVersion("3.6.1") LATEST_3_6 =

[PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-07 Thread via GitHub
lucasbru opened a new pull request, #15334: URL: https://github.com/apache/kafka/pull/15334 The main bug causing this test to fail as described in the ticket was already fixed. The test is still flaky if unchanged, because in the new consumer, the assignment can change in between

Re: [PR] KAFKA-8721: Kafka metrics improvements [kafka]

2024-02-07 Thread via GitHub
anilkulkarnisk commented on PR #7121: URL: https://github.com/apache/kafka/pull/7121#issuecomment-1931809665 Metircs-core library file is being used in Kafka already reached End Of Life, The version of metics-core 4.1.12.1_EOL, and metrics-code 2.2.0_EOL May I know in which

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1481322702 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1279,7 +1281,6 @@ class UnifiedLog(@volatile var logStartOffset: Long, if

[jira] [Commented] (KAFKA-13292) InvalidPidMappingException: The producer attempted to use a producer id which is not currently assigned to its transactional id

2024-02-07 Thread ewolfman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815268#comment-17815268 ] ewolfman commented on KAFKA-13292: -- Hi [~mjsax]  We are using kafka-clients:3.4.1 and

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-02-07 Thread via GitHub
mimaison commented on code in PR #13817: URL: https://github.com/apache/kafka/pull/13817#discussion_r1481254113 ## Jenkinsfile: ## @@ -174,6 +183,28 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 21' } } + +

[jira] [Updated] (KAFKA-16226) Java client: Performance regression in Trogdor benchmark with high partition counts

2024-02-07 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula updated KAFKA-16226: -- Description: h1. Background

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-07 Thread via GitHub
jlprat commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1481430316 ## tests/kafkatest/services/console_consumer.py: ## @@ -21,7 +21,7 @@ from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin from

[jira] [Updated] (KAFKA-15824) SubscriptionState's maybeValidatePositionForCurrentLeader should handle partition which isn't subscribed yet

2024-02-07 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula updated KAFKA-15824: -- Description: As can be maybeValidatePositionForCurrentLeader doesn't check if

[jira] [Created] (KAFKA-16233) Review auto-commit continuously committing when no progress

2024-02-07 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16233: -- Summary: Review auto-commit continuously committing when no progress Key: KAFKA-16233 URL: https://issues.apache.org/jira/browse/KAFKA-16233 Project: Kafka

[jira] [Updated] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-02-07 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16224: --- Description: Current logic for auto-committing offsets when partitions are revoked will

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481555805 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4821,8 +4911,10 @@ private Map handleAssignment(final Map assignment

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481560896 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2210,6 +2210,9 @@ public void shouldComputeOffsetSumForStandbyTask()

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481561392 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2332,19 +2335,12 @@ public void

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481561763 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2399,7 +2393,8 @@ public void

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-07 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1481455003 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -647,27 +647,27 @@ private long batchReady(boolean exhausted,

[jira] [Updated] (KAFKA-15824) SubscriptionState's maybeValidatePositionForCurrentLeader should handle partition which isn't subscribed yet

2024-02-07 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula updated KAFKA-15824: -- Description: As can be

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-07 Thread via GitHub
clolov commented on PR #15213: URL: https://github.com/apache/kafka/pull/15213#issuecomment-1932149971 Heya @showuon @kamalcph @satishd, I hope I have addressed the latest comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481556951 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2332,19 +2335,12 @@ public void

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481557433 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2369,12 +2366,9 @@ public void closeClean() { }

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-07 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1481455003 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -647,27 +647,27 @@ private long batchReady(boolean exhausted,

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-02-07 Thread via GitHub
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850506417 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -188,6 +190,12 @@ public class ProducerConfig extends AbstractConfig {

[jira] [Updated] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-02-07 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula updated KAFKA-16234: -- Description: With [KAFKA-16157|https://github.com/apache/kafka/pull/15263] we made changes

[jira] [Updated] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-02-07 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula updated KAFKA-16234: -- Description: With [KAFKA-16157|https://github.com/apache/kafka/pull/15263] we made changes

[jira] [Assigned] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-02-07 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula reassigned KAFKA-16234: - Assignee: Omnia Ibrahim > Log directory failure re-creates partitions in another

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-07 Thread via GitHub
satishd commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1481778242 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1300,18 +1301,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

[jira] [Created] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-02-07 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-16234: - Summary: Log directory failure re-creates partitions in another logdir automatically Key: KAFKA-16234 URL: https://issues.apache.org/jira/browse/KAFKA-16234

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15261: URL: https://github.com/apache/kafka/pull/15261#discussion_r1481566534 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2016,13 +2015,14 @@ public void

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 2 [kafka]

2024-02-07 Thread via GitHub
clolov commented on PR #15261: URL: https://github.com/apache/kafka/pull/15261#issuecomment-1932183121 Heya @cadonna, apologies for the delay. I am not certain I fully understand the comments, so I wanted to confirm before making changes. The purpose of this pull request is to just migrate

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-07 Thread via GitHub
msn-tldr commented on PR #15323: URL: https://github.com/apache/kafka/pull/15323#issuecomment-1932366816 @hachikuji There are unrelated test failures on Jenkins run. Further looking at history of failed tests, they have been failing from before.

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-07 Thread via GitHub
jeqo commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1932429115 @jolshan sure! I just added it  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-15467) Kafka broker returns offset out of range for topic/partitions on restart from unclean shutdown

2024-02-07 Thread Steve Jacobs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815385#comment-17815385 ] Steve Jacobs commented on KAFKA-15467: -- The way to reproduce this is an unclean shutdown of the

[jira] [Commented] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-02-07 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815403#comment-17815403 ] Gaurav Narula commented on KAFKA-16234: --- Perhaps a way to solve this would be to determine if a

[jira] [Updated] (KAFKA-14920) Address timeouts and out of order sequences

2024-02-07 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14920: --- Description: KAFKA-14844 showed the destructive nature of a timeout on the first produce

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-07 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1482012622 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -68,48 +97,44 @@ public boolean isSimpleConsumerGroup() { } /**

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-02-07 Thread via GitHub
gharris1727 commented on code in PR #14995: URL: https://github.com/apache/kafka/pull/14995#discussion_r1481872234 ## clients/src/test/java/org/apache/kafka/common/config/provider/MockFileConfigProvider.java: ## @@ -42,10 +43,12 @@ public void configure(Map configs) {

Re: [PR] MINOR Fix a case where not all ACLs for a given resource are written to ZK [kafka]

2024-02-07 Thread via GitHub
cmccabe commented on PR #15327: URL: https://github.com/apache/kafka/pull/15327#issuecomment-193270 Thanks, @mumrah . It looks good. One comment: it seems like any error log being issued should fail any junit test, unless it’s expected, right? -- This is an automated message from the

Re: [PR] KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (2/3) [kafka]

2024-02-07 Thread via GitHub
gharris1727 commented on code in PR #15313: URL: https://github.com/apache/kafka/pull/15313#discussion_r1481920004 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java: ## @@ -343,6 +354,103 @@ public void testShutdown() throws

[PR] KAFKA-16234: Add topicId to Partition constructor [kafka]

2024-02-07 Thread via GitHub
OmniaGM opened a new pull request, #15335: URL: https://github.com/apache/kafka/pull/15335 This pr fixes the bug created by #15263 which caused topic partition to be recreated whenever the original log dir is offline. I believe the bug #15263 was trying to fix is more rare to happened

[jira] [Updated] (KAFKA-16233) Review auto-commit continuously committing when no progress

2024-02-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16233: -- Labels: consumer-threading-refactor (was: ) > Review auto-commit continuously committing when no

Re: [PR] mention IdentityReplicationPolicy in ops docs [kafka]

2024-02-07 Thread via GitHub
mimaison commented on PR #10983: URL: https://github.com/apache/kafka/pull/10983#issuecomment-1932493933 @showuon I pushed a commit to tweak this section. Can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15670: add "inter.broker.listener.name" config in KRaft controller config [kafka]

2024-02-07 Thread via GitHub
mimaison commented on code in PR #14631: URL: https://github.com/apache/kafka/pull/14631#discussion_r1481826420 ## docs/ops.html: ## @@ -3819,6 +3819,12 @@ Provisioning the KRaft controller quorum # ZooKeeper client configuration zookeeper.connect=localhost:2181 +# The

Re: [PR] streams-scala: remove collections-compat dependency when on Scala 2.13 [kafka]

2024-02-07 Thread via GitHub
mberndt123 commented on PR #15239: URL: https://github.com/apache/kafka/pull/15239#issuecomment-1932541985 > Do we want to remove it from streams only or also for core? I've tried that and thought it worked because of a silly mistake that I made. But `core` actually needs it, so it

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-07 Thread via GitHub
hachikuji commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1481854476 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -647,27 +647,27 @@ private long batchReady(boolean exhausted,

[jira] [Commented] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-02-07 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815397#comment-17815397 ] Gaurav Narula commented on KAFKA-16234: --- This gets trickier because {{LogManager::loadLog}} reads

[PR] [No review] Repro kafka-16217 [kafka]

2024-02-07 Thread via GitHub
CalvinConfluent opened a new pull request, #15336: URL: https://github.com/apache/kafka/pull/15336 A UT to repro the bug in https://issues.apache.org/jira/browse/KAFKA-16217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-07 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815402#comment-17815402 ] Calvin Liu commented on KAFKA-16217: [~kirktrue] I have a UT which simulate the close issue

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-07 Thread via GitHub
hachikuji commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1481936087 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -647,27 +647,27 @@ private long batchReady(boolean exhausted,

[jira] [Commented] (KAFKA-13292) InvalidPidMappingException: The producer attempted to use a producer id which is not currently assigned to its transactional id

2024-02-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815404#comment-17815404 ] Matthias J. Sax commented on KAFKA-13292: - Sounds like a question about Spring... For a plain

[jira] [Created] (KAFKA-16235) auto commit still causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION

2024-02-07 Thread Ryan Leslie (Jira)
Ryan Leslie created KAFKA-16235: --- Summary: auto commit still causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION Key: KAFKA-16235 URL: https://issues.apache.org/jira/browse/KAFKA-16235 Project:

[jira] [Commented] (KAFKA-16235) auto commit still causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION

2024-02-07 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815407#comment-17815407 ] Ryan Leslie commented on KAFKA-16235: - Linked related JIRAs. > auto commit still causes delays due

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-07 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1481994449 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -64,28 +64,89 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { val

[jira] [Updated] (KAFKA-15824) SubscriptionState's maybeValidatePositionForCurrentLeader should handle partition which isn't subscribed yet

2024-02-07 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula updated KAFKA-15824: -- Description: As can be

[jira] [Updated] (KAFKA-15824) SubscriptionState's maybeValidatePositionForCurrentLeader should handle partition which isn't subscribed yet

2024-02-07 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula updated KAFKA-15824: -- Description: As can be

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-07 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1481455003 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -647,27 +647,27 @@ private long batchReady(boolean exhausted,

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-07 Thread via GitHub
clolov commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1481540437 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1300,18 +1301,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

[jira] [Assigned] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-02-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16178: - Assignee: Lianet Magrans (was: Philip Nee) > AsyncKafkaConsumer doesn't retry joining the

[jira] [Assigned] (KAFKA-16156) System test failing for new consumer on endOffsets with negative timestamps

2024-02-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16156: - Assignee: Philip Nee > System test failing for new consumer on endOffsets with negative

[PR] Global state store restore custom processor [kafka]

2024-02-07 Thread via GitHub
wcarlson5 opened a new pull request, #15337: URL: https://github.com/apache/kafka/pull/15337 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-16055: Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders [kafka]

2024-02-07 Thread via GitHub
ableegoldman commented on PR #15121: URL: https://github.com/apache/kafka/pull/15121#issuecomment-1932890035 Merged to trunk. Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16055: Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders [kafka]

2024-02-07 Thread via GitHub
ableegoldman merged PR #15121: URL: https://github.com/apache/kafka/pull/15121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-16055) Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders

2024-02-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-16055: -- Assignee: Kohei Nozaki > Thread unsafe use of HashMap stored in

[jira] [Assigned] (KAFKA-16055) Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders

2024-02-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-16055: -- Assignee: Kohei Nozaki (was: Kohei Nozaki) > Thread unsafe use of

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-07 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1482112413 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -21,14 +21,16 @@ import java.util.Optional; import

[jira] [Closed] (KAFKA-15592) Member does not need to always try to join a group when a groupId is configured

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15592. --- > Member does not need to always try to join a group when a groupId is > configured >

[jira] [Closed] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15573. --- > Implement auto-commit on partition assignment revocation >

[jira] [Closed] (KAFKA-15631) Do not send new heartbeat request while another one in-flight

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15631. --- > Do not send new heartbeat request while another one in-flight >

[jira] [Closed] (KAFKA-15543) Send HB request right after reconciliation completes

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15543. --- > Send HB request right after reconciliation completes >

[jira] [Closed] (KAFKA-15515) Remove duplicated integration tests for new consumer

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15515. --- > Remove duplicated integration tests for new consumer >

[jira] [Closed] (KAFKA-15539) Client should stop fetching while partitions being revoked

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15539. --- > Client should stop fetching while partitions being revoked >

[jira] [Updated] (KAFKA-15651) Investigate auto commit guarantees during Consumer.assign()

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15651: Fix Version/s: (was: 3.7.0) > Investigate auto commit guarantees during

[jira] [Updated] (KAFKA-15515) Remove duplicated integration tests for new consumer

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15515: Fix Version/s: (was: 3.7.0) > Remove duplicated integration tests for new

[jira] [Updated] (KAFKA-15592) Member does not need to always try to join a group when a groupId is configured

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15592: Fix Version/s: (was: 3.7.0) > Member does not need to always try to join a

[jira] [Updated] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15573: Fix Version/s: (was: 3.7.0) > Implement auto-commit on partition assignment

[jira] [Updated] (KAFKA-15694) New integration tests to have full coverage for preview

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15694: Fix Version/s: (was: 3.7.0) > New integration tests to have full coverage for

[jira] [Updated] (KAFKA-15540) Handle heartbeat and revocation when consumer leaves group

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15540: Fix Version/s: (was: 3.7.0) > Handle heartbeat and revocation when consumer

[jira] [Updated] (KAFKA-15631) Do not send new heartbeat request while another one in-flight

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15631: Fix Version/s: (was: 3.7.0) > Do not send new heartbeat request while another

[jira] [Updated] (KAFKA-15539) Client should stop fetching while partitions being revoked

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15539: Fix Version/s: (was: 3.7.0) > Client should stop fetching while partitions

[jira] [Updated] (KAFKA-15543) Send HB request right after reconciliation completes

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15543: Fix Version/s: (was: 3.7.0) > Send HB request right after reconciliation

[jira] [Assigned] (KAFKA-16001) Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder

2024-02-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16001: - Assignee: (was: Kirk True) > Migrate ConsumerNetworkThreadTest away from

Re: [PR] MINOR: Fix some MetadataDelta handling issues during ZK migration [kafka]

2024-02-07 Thread via GitHub
cmccabe merged PR #15327: URL: https://github.com/apache/kafka/pull/15327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-07 Thread via GitHub
jolshan commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1932990160 Also @jeqo -- just curious which java version were you running? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-07 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1482157827 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -18,44 +18,47 @@ package kafka.admin import joptsimple.OptionException import

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-07 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1482168707 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -187,16 +197,69 @@ object ConsumerGroupCommand extends Logging { } def listGroups():

[jira] [Closed] (KAFKA-15840) Correct initialization of ConsumerGroupHeartbeat by client

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-15840. --- > Correct initialization of ConsumerGroupHeartbeat by client >

[jira] [Commented] (KAFKA-16121) Partition reassignments in ZK migration dual write mode stalled until leader epoch incremented

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815421#comment-17815421 ] Stanislav Kozlovski commented on KAFKA-16121: - Marked as closed in order to be able to build

[jira] [Closed] (KAFKA-16121) Partition reassignments in ZK migration dual write mode stalled until leader epoch incremented

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski closed KAFKA-16121. --- > Partition reassignments in ZK migration dual write mode stalled until leader > epoch

[jira] [Updated] (KAFKA-15694) New integration tests to have full coverage for preview

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15694: Description: These are to fix bugs discovered during PR reviews but not tests.  

[jira] [Updated] (KAFKA-15840) Correct initialization of ConsumerGroupHeartbeat by client

2024-02-07 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-15840: Fix Version/s: (was: 3.7.0) > Correct initialization of

  1   2   >