[
https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823067#comment-17823067
]
Roland Sommer commented on KAFKA-15330:
---
After the release of kafka 3.7 I reran the migration
cadonna commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975956880
> There is a `1` missing. :) I meant #13897
Ah, OK. Now it makes sense! Let me have a look!
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975962915
From a quick look, both PRs seem to do the same. I will try to have a look
into this PR this week.
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on code in PR #15254:
URL: https://github.com/apache/kafka/pull/15254#discussion_r1510774397
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -2403,15 +2383,18 @@ public void
AyoubOm commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1976087470
> Thanks for the PR! Overall LGTM, but we should add a unit test for the
newly added sensor.
Thanks @mjsax for your review. I added tests of the dropped record sensor (I
believed
cadonna commented on PR #15361:
URL: https://github.com/apache/kafka/pull/15361#issuecomment-1976090927
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cadonna merged PR #15361:
URL: https://github.com/apache/kafka/pull/15361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
testn commented on PR #15402:
URL: https://github.com/apache/kafka/pull/15402#issuecomment-1976121691
@divijvaidya seem like the build is orange!
https://github.com/apache/kafka/assets/445123/552aca8e-a9c3-406c-9333-7d1e928190d3;>
--
This is an automated message from the
cadonna commented on PR #15449:
URL: https://github.com/apache/kafka/pull/15449#issuecomment-1976189411
FYI: to run only this test on Jenkins, you can replace target `test` with
`streams:test` and add `--tests EosV2UpgradeIntegrationTest` to the arguments
in method `doTest()` in the
clolov commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1976222841
I will have a look today, thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
KevinZTW closed pull request #15461: KAFKA-16310: ListOffsets doesn't report
the offset with maxTimestamp anymore
URL: https://github.com/apache/kafka/pull/15461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
KevinZTW commented on PR #15461:
URL: https://github.com/apache/kafka/pull/15461#issuecomment-1976256564
@showuon much thanks for helping me look into this! Base on the information
on the Jira ticket, It seems that there are other developers already found the
root cause and going to submit
dajac opened a new pull request, #15462:
URL: https://github.com/apache/kafka/pull/15462
There are a few cases in the group coordinator service where we want to read
from or write to each of the known coordinators (each of __consumer_offsets
partitions). The current implementation needs to
dajac commented on PR #15462:
URL: https://github.com/apache/kafka/pull/15462#issuecomment-1976262999
@OmniaGM Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on PR #15461:
URL: https://github.com/apache/kafka/pull/15461#issuecomment-1976165637
This is not an easy one. I need more time to dig into it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cadonna commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1510930206
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -177,7 +177,7 @@ private void process(final
OmniaGM commented on code in PR #15457:
URL: https://github.com/apache/kafka/pull/15457#discussion_r1510969600
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) {
}
OmniaGM commented on code in PR #15457:
URL: https://github.com/apache/kafka/pull/15457#discussion_r1510981252
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) {
}
hni61223 commented on code in PR #15450:
URL: https://github.com/apache/kafka/pull/15450#discussion_r1510985119
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -677,4 +692,20 @@ object KafkaMetadataLog extends Logging {
Snapshots.deleteIfExists(logDir,
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1510987276
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##
@@ -495,6 +496,16 @@ public void subscribe(Pattern pattern) {
chia7712 merged PR #15388:
URL: https://github.com/apache/kafka/pull/15388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15388:
URL: https://github.com/apache/kafka/pull/15388#issuecomment-1976383921
@appchemist thanks for the survey and contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cadonna merged PR #15426:
URL: https://github.com/apache/kafka/pull/15426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15458:
URL: https://github.com/apache/kafka/pull/15458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1511059328
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823151#comment-17823151
]
Luke Chen commented on KAFKA-16310:
---
Thanks! Please let us know when the PR is open.
> ListOffsets
[
https://issues.apache.org/jira/browse/KAFKA-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-16318:
--
Assignee: Johnny Hsu
> Add javadoc to KafkaMetric
> --
>
>
soarez commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1511125756
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2790,7 +2791,6 @@ class ReplicaManager(val config: KafkaConfig,
// is unavailable. This is
chia7712 commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1976451937
@appchemist nice catch. could you share the context of why it gets unused ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16310:
-
Assignee: (was: Cheng-Kai, Zhang)
> ListOffsets doesn't report the offset with
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16310:
--
Priority: Blocker (was: Minor)
> ListOffsets doesn't report the offset with maxTimestamp anymore
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16310:
--
Description:
Updated: This is confirmed a regression issue in v3.7.0.
The impact of this issue is
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16310:
--
Fix Version/s: 3.7.1
> ListOffsets doesn't report the offset with maxTimestamp anymore
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823174#comment-17823174
]
Chia-Ping Tsai commented on KAFKA-16310:
[~ijuma] thanks for feedback. good to know we are on
Chia-Ping Tsai created KAFKA-16324:
--
Summary: Move BrokerApiVersionsCommand to tools
Key: KAFKA-16324
URL: https://issues.apache.org/jira/browse/KAFKA-16324
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-16324:
-
Assignee: PoAn Yang
> Move BrokerApiVersionsCommand to tools
>
[
https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823180#comment-17823180
]
Chia-Ping Tsai commented on KAFKA-14577:
[~mimaison] Maybe we can rewrite the code by java
johnnychhsu opened a new pull request, #15463:
URL: https://github.com/apache/kafka/pull/15463
## Context
The test testRemoteFetchExpiresPerSecMetric is failing in CI, however it
succeeds locally. I can not reproduce this failure in local.
## Solution
This is still WIP,
[
https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823186#comment-17823186
]
Chia-Ping Tsai commented on KAFKA-14577:
[~mimaison] you are right. it seems 4.0 is the only way
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823189#comment-17823189
]
Mickael Maison commented on KAFKA-16324:
I don't think we want to move that tool. We had a KIP
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823192#comment-17823192
]
Mickael Maison commented on KAFKA-16324:
If you want to help out this effort, there are a bunch
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823197#comment-17823197
]
Chia-Ping Tsai commented on KAFKA-16324:
[~mimaison] thanks for sharing context.
{quote}
Since
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823199#comment-17823199
]
Chia-Ping Tsai commented on KAFKA-16324:
{quote}
If you want to help out this effort, there are
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823200#comment-17823200
]
Mickael Maison commented on KAFKA-16324:
Ahah, glad you see you back!
> Move
[
https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823200#comment-17823200
]
Mickael Maison edited comment on KAFKA-16324 at 3/4/24 1:54 PM:
Ahah,
johnnychhsu opened a new pull request, #15464:
URL: https://github.com/apache/kafka/pull/15464
## Context
An issue in the component "GroovyEngine.execute" of jline-groovy versions
through 3.24.1 allows attackers to cause an OOM (OutofMemory) error. Please
refer to [this
gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1511199142
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
VictorvandenHoven commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1976647985
> @VictorvandenHoven -- it seems
`KStreamKStreamIntegrationTest.shouldOuterJoin` fails consistently. Can you
take a look?
Ouch, didn't test that one.
Apparently,
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823205#comment-17823205
]
Ismael Juma commented on KAFKA-16310:
-
By the way, the bug attribution doesn't seem completely
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823205#comment-17823205
]
Ismael Juma edited comment on KAFKA-16310 at 3/4/24 2:13 PM:
-
By the way,
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1511231627
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
lucasbru commented on code in PR #15437:
URL: https://github.com/apache/kafka/pull/15437#discussion_r1511245829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -792,8 +801,8 @@ public void commitAsync(Map offsets, OffsetCo
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823205#comment-17823205
]
Ismael Juma edited comment on KAFKA-16310 at 3/4/24 2:23 PM:
-
By the way,
lucasbru commented on code in PR #15437:
URL: https://github.com/apache/kafka/pull/15437#discussion_r1511245201
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -567,6 +568,28 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823208#comment-17823208
]
Ismael Juma commented on KAFKA-16310:
-
More recent changes to LogValidator:
[
https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823209#comment-17823209
]
Frank Grimes commented on KAFKA-10582:
--
Is this somehow related to (or better yet fixed by)
lucasbru commented on PR #15437:
URL: https://github.com/apache/kafka/pull/15437#issuecomment-1976699674
Hi @philipnee
> Hi @lucasbru - Thanks for the PR. I think it would be good to test if all
commit API throws the fenced exception. I believe async commit has already been
tested,
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976703092
@nizhikov thanks for taking over this big issue. I'd like to give a review.
However, it is a bit huge. Is it possible to split this PR into small PRs by
the "command" of
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976721113
Hello @chia7712
Yes.
There are two separate PR's that moves tests of command to `tools`:
https://github.com/apache/kafka/pull/15365 - pretty small (+200, -100)
Ayoub Omari created KAFKA-16343:
---
Summary: Improve tests of streams foreignkey package
Key: KAFKA-16343
URL: https://issues.apache.org/jira/browse/KAFKA-16343
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16342:
-
Assignee: Luke Chen
> Fix compressed records
> --
>
> Key:
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823460#comment-17823460
]
Luke Chen commented on KAFKA-16310:
---
Created 2 sub-tasks for compressed and un-compressed records.
>
mjsax merged PR #15395:
URL: https://github.com/apache/kafka/pull/15395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1977704070
Looking into the test, we create `new
KafkaStreams(builder.build(streamsConfig), streamsConfig)`, but we don't pass
in the mock time object. So KS creates it's own `Time` object, so it's
[
https://issues.apache.org/jira/browse/KAFKA-16340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16340:
-
Description:
设置 remote.log.metadata.topic.replication.factor 是无效的
{code:java}
broker.id=1
[
https://issues.apache.org/jira/browse/KAFKA-16340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16340:
-
Description:
Setting remote.log.metadata .topic.replication.factor is invalid
{code:java}
[
https://issues.apache.org/jira/browse/KAFKA-15706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823401#comment-17823401
]
CJ Hillbrand commented on KAFKA-15706:
--
My first work item, so if needed quicker please comment and
[
https://issues.apache.org/jira/browse/KAFKA-15706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
CJ Hillbrand reassigned KAFKA-15706:
Assignee: CJ Hillbrand
> KRaft support in DynamicBrokerReconfigurationTest
>
CalvinConfluent commented on PR #15470:
URL: https://github.com/apache/kafka/pull/15470#issuecomment-1977980848
As discussed offline, we decided not to implement the pagination handling in
this ticket. Here is the load-all-in-memory version to the
https://github.com/apache/kafka/pull/15265
Luke Chen created KAFKA-16342:
-
Summary: Fix compressed records
Key: KAFKA-16342
URL: https://issues.apache.org/jira/browse/KAFKA-16342
Project: Kafka
Issue Type: Sub-task
Reporter:
Luke Chen created KAFKA-16341:
-
Summary: Fix un-compressed records
Key: KAFKA-16341
URL: https://issues.apache.org/jira/browse/KAFKA-16341
Project: Kafka
Issue Type: Sub-task
nizhikov commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1978121311
Hello @chia7712
I checked CI results and failures seems unrelated to changes for me.
--
This is an automated message from the Apache Git Service.
To respond to the message,
nizhikov commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1978120545
Hello @chia7712
I checked CI results and failures seems unrelated to changes for me.
--
This is an automated message from the Apache Git Service.
To respond to the message,
AyoubOm commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1978135956
> > Another point, I think there are some missing tests in the
foreignkeyjoin package, and problems in naming a test class. For example,
ForeignTableJoinProcessorSupplierTest is not
gharris1727 opened a new pull request, #15469:
URL: https://github.com/apache/kafka/pull/15469
The Values class has checkstyle suppressions for NPathComplexity,
MethodLength, CyclomaticComplexity, and JavaNCSS. Rather than suppressing these
problems, we should refactor the oversize methods
gharris1727 commented on PR #15469:
URL: https://github.com/apache/kafka/pull/15469#issuecomment-1977794542
Benchmark | Before ns/op | Before Error | After ns/op | After Error | Speedup
-- | -- | -- | -- | -- | --
ValuesBenchmark.testConvertToBoolean | 124.038 | 0.319 | 71.448 | 2.258
mjsax commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1977688896
> Another point, I think there are some missing tests in the foreignkeyjoin
package, and problems in naming a test class. For example,
ForeignTableJoinProcessorSupplierTest is not testing
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1511957999
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -494,6 +501,14 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16340:
-
Description:
Setting remote.log.metadata.topic.replication.factor is invalid
{code:java}
github-actions[bot] commented on PR #14597:
URL: https://github.com/apache/kafka/pull/14597#issuecomment-1977907333
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #14795:
URL: https://github.com/apache/kafka/pull/14795#issuecomment-1977907234
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #14788:
URL: https://github.com/apache/kafka/pull/14788#issuecomment-1977907254
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
gharris1727 commented on PR #15399:
URL: https://github.com/apache/kafka/pull/15399#issuecomment-1977694440
Test failures appear unrelated, and the tests pass for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gharris1727 merged PR #15399:
URL: https://github.com/apache/kafka/pull/15399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1511998434
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##
@@ -438,13 +438,13 @@ public void testOrdering() {
Jianbin Chen created KAFKA-16340:
Summary: Replication factor: 3 larger than available brokers: 1.
Key: KAFKA-16340
URL: https://issues.apache.org/jira/browse/KAFKA-16340
Project: Kafka
CalvinConfluent opened a new pull request, #15470:
URL: https://github.com/apache/kafka/pull/15470
https://issues.apache.org/jira/browse/KAFKA-15585
Add the support for DescribeTopicPartitions API on the client side.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-14747.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> FK join should record discarded
mjsax commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1977692891
Also, thanks for the PR! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
splett2 commented on code in PR #15454:
URL: https://github.com/apache/kafka/pull/15454#discussion_r1511954682
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -80,10 +81,9 @@ class AddPartitionsToTxnManager(
topicPartitions: Seq[TopicPartition],
pedoc closed pull request #15456: kafka-connect configuration file uses UTF-8
character set.
URL: https://github.com/apache/kafka/pull/15456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pedoc commented on PR #15456:
URL: https://github.com/apache/kafka/pull/15456#issuecomment-1977791945
> And unfortunately, even though ASCII is a subset of UTF-8, ISO-8859-1 is
not, so this is a backwards-incompatible change.
Thank you for your clarification, I am very sorry that I
[
https://issues.apache.org/jira/browse/KAFKA-16340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16340:
-
Description:
I'm having trouble setting remote.log.metadata.topic.replication.factor to be
appchemist commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1976754065
@chia7712 Thanks for review!
`controlPlaneRequestProcessor` in `BrokerServer` isn't initialized.
The `controlPlaneRequestProcessor` is only referenced within the `shutdown`
ijuma commented on code in PR #15424:
URL: https://github.com/apache/kafka/pull/15424#discussion_r1511284102
##
build.gradle:
##
@@ -2333,6 +2333,8 @@ project(':streams:streams-scala') {
testImplementation libs.junitJupiter
testImplementation libs.easymock
+
[
https://issues.apache.org/jira/browse/KAFKA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823253#comment-17823253
]
Owen C.H. Leung commented on KAFKA-16325:
-
FYI: https://github.com/apache/kafka/pull/15466
>
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511471141
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511492912
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511503172
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976795668
Hello @mimaison @jolshan @showuon
I split PR even more and now all three PR's for a command test seems pretty
small.
Please, take a look if you have spare cycles.
#15365
1 - 100 of 215 matches
Mail list logo
