[GitHub] [kafka] zhaohaidao opened a new pull request #8665: KAFKA-9984 Should fail the subscription when pattern is empty

2020-05-13 Thread GitBox
zhaohaidao opened a new pull request #8665: URL: https://github.com/apache/kafka/pull/8665 Ticket: KAFKA-9984 It indicates a configuration error when consumer subscribes an empty pattern: ``` [Consumer ... ] Subscribed to pattern: '' ``` The

[GitHub] [kafka] showuon commented on pull request #8623: MINOR: Update the documentations

2020-05-13 Thread GitBox
showuon commented on pull request #8623: URL: https://github.com/apache/kafka/pull/8623#issuecomment-628403219 Hi @kkonstantine , could you please review this small PR? Thanks. This is an automated message from the Apache

[GitHub] [kafka] vvcephei commented on a change in pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8662: URL: https://github.com/apache/kafka/pull/8662#discussion_r424712060 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java ## @@ -105,6 +109,7 @@ public static String

[GitHub] [kafka] chia7712 commented on a change in pull request #8663: KAFKA-9985: Sink connector may exhaust broker when writing in DLQ

2020-05-13 Thread GitBox
chia7712 commented on a change in pull request #8663: URL: https://github.com/apache/kafka/pull/8663#discussion_r424860254 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java ## @@ -96,6 +101,25 @@ public static void

[jira] [Commented] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

2020-05-13 Thread Andre Price (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106865#comment-17106865 ] Andre Price commented on KAFKA-9981: Not sure if related but I think I'm seeing issues where task

[GitHub] [kafka] chia7712 commented on a change in pull request #8663: KAFKA-9985: Sink connector may exhaust broker when writing in DLQ

2020-05-13 Thread GitBox
chia7712 commented on a change in pull request #8663: URL: https://github.com/apache/kafka/pull/8663#discussion_r424859533 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java ## @@ -108,6 +132,20 @@ public static boolean

[jira] [Commented] (KAFKA-9989) StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task

2020-05-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106864#comment-17106864 ] Sophie Blee-Goldman commented on KAFKA-9989: Yeah that looks like the

[GitHub] [kafka] chia7712 commented on a change in pull request #8663: KAFKA-9985: Sink connector may exhaust broker when writing in DLQ

2020-05-13 Thread GitBox
chia7712 commented on a change in pull request #8663: URL: https://github.com/apache/kafka/pull/8663#discussion_r424859533 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java ## @@ -108,6 +132,20 @@ public static boolean

[jira] [Assigned] (KAFKA-9984) Should fail the subscription when pattern is empty

2020-05-13 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-9984: -- Assignee: HaiyuanZhao > Should fail the subscription when pattern is empty >

[jira] [Commented] (KAFKA-9984) Should fail the subscription when pattern is empty

2020-05-13 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106857#comment-17106857 ] Boyang Chen commented on KAFKA-9984: [~guozhang] Thanks! > Should fail the subscription when pattern

[jira] [Commented] (KAFKA-9989) StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task

2020-05-13 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106853#comment-17106853 ] Boyang Chen commented on KAFKA-9989: Looks like it is determined by the assignor: (the latest added

[jira] [Commented] (KAFKA-9617) Replica Fetcher can mark partition as failed when max.message.bytes is changed

2020-05-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106843#comment-17106843 ] Chia-Ping Tsai commented on KAFKA-9617: --- [https://github.com/apache/kafka/pull/8659] > Replica

[jira] [Commented] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106832#comment-17106832 ] Sophie Blee-Goldman commented on KAFKA-9987: Pseudo-code sketch of the algorithm: {{C_f :=

[GitHub] [kafka] abbccdda closed pull request #7172: (DO NOT MERGE) Kip 447 condensed POC

2020-05-13 Thread GitBox
abbccdda closed pull request #7172: URL: https://github.com/apache/kafka/pull/7172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] abbccdda closed pull request #7676: DEBUG: add partition empty check

2020-05-13 Thread GitBox
abbccdda closed pull request #7676: URL: https://github.com/apache/kafka/pull/7676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] abbccdda closed pull request #7179: MINOR: improve StreamsBrokerDownResilienceTest debuggability

2020-05-13 Thread GitBox
abbccdda closed pull request #7179: URL: https://github.com/apache/kafka/pull/7179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424830762 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ConstrainedPrioritySet.java ## @@ -16,77 +16,58 @@ */

[GitHub] [kafka] d8tltanc commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-05-13 Thread GitBox
d8tltanc commented on pull request #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-628340161 Latest dev branch builds here (REMOVE_SYSTEM_4): https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3943/

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424825641 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ConstrainedPrioritySet.java ## @@ -16,77 +16,58 @@ */

[jira] [Created] (KAFKA-9991) Flaky Test KTableSourceTopicRestartIntegrationTest.shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosAlphaEnabled

2020-05-13 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-9991: -- Summary: Flaky Test KTableSourceTopicRestartIntegrationTest.shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosAlphaEnabled Key: KAFKA-9991 URL:

[jira] [Resolved] (KAFKA-9688) kafka-topic.sh should show KIP-455 adding and removing replicas

2020-05-13 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-9688. - Fix Version/s: 2.5.0 Reviewer: Colin McCabe Resolution: Fixed > kafka-topic.sh

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424822166 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java ## @@ -236,16 +233,17 @@

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424821641 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovementTest.java ## @@ -35,262 +44,161 @@ import static

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424820836 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -53,75 +67,94 @@ private static

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424819838 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -53,75 +67,94 @@ private static

[GitHub] [kafka] ableegoldman commented on pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
ableegoldman commented on pull request #8662: URL: https://github.com/apache/kafka/pull/8662#issuecomment-628329507 Nooo `EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]` still had one failure on the Java 8 build  But it failed on a different line which

[GitHub] [kafka] mjsax commented on pull request #6792: KAFKA 8311 : Augment the error message to let user change `default.api.timeout.ms`

2020-05-13 Thread GitBox
mjsax commented on pull request #6792: URL: https://github.com/apache/kafka/pull/6792#issuecomment-628323776 @clearpal7 @abbccdda Just cleaning up my old backlog. Do you still want to get this in? PR would need a rebase.

[GitHub] [kafka] mjsax commented on pull request #6617: MINOR: Allow scripts to be symlinked

2020-05-13 Thread GitBox
mjsax commented on pull request #6617: URL: https://github.com/apache/kafka/pull/6617#issuecomment-628323063 Closing this PR due to inactivity. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax closed pull request #6617: MINOR: Allow scripts to be symlinked

2020-05-13 Thread GitBox
mjsax closed pull request #6617: URL: https://github.com/apache/kafka/pull/6617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax merged pull request #6656: MINOR: Add option to rebuild source for system tests

2020-05-13 Thread GitBox
mjsax merged pull request #6656: URL: https://github.com/apache/kafka/pull/6656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9987: --- Description: In 

[jira] [Updated] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9987: --- Summary: Improve sticky partition assignor algorithm (was: Add new cooperative

[jira] [Resolved] (KAFKA-9850) Move KStream#repartition operator validation during Topology build process

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9850. Fix Version/s: 2.6.0 Resolution: Fixed > Move KStream#repartition operator

[GitHub] [kafka] mjsax merged pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-13 Thread GitBox
mjsax merged pull request #8550: URL: https://github.com/apache/kafka/pull/8550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-13 Thread GitBox
mjsax commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-628317830 Thanks for the PR @zhaohaidao! Merged to `trunk`. This is an automated message from the Apache Git Service. To

[jira] [Resolved] (KAFKA-9465) Enclose consumer call with catching InvalidOffsetException

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9465. Resolution: Not A Problem This was fixed implicitly via some code refactoring. > Enclose

[GitHub] [kafka] mjsax closed pull request #8001: KAFKA-9465: Enclose consumer call with catching InvalidOffsetException

2020-05-13 Thread GitBox
mjsax closed pull request #8001: URL: https://github.com/apache/kafka/pull/8001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8001: KAFKA-9465: Enclose consumer call with catching InvalidOffsetException

2020-05-13 Thread GitBox
mjsax commented on pull request #8001: URL: https://github.com/apache/kafka/pull/8001#issuecomment-628316756 Thanks @guozhangwang. I resolve the Jira ticket. Closing this PR. This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #8049: MINOR: Added missing default serdes to the streams.scala.Serdes

2020-05-13 Thread GitBox
mjsax commented on a change in pull request #8049: URL: https://github.com/apache/kafka/pull/8049#discussion_r424805332 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -30,12 +32,15 @@ object Serdes { implicit def

[GitHub] [kafka] mjsax commented on pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates

2020-05-13 Thread GitBox
mjsax commented on pull request #8637: URL: https://github.com/apache/kafka/pull/8637#issuecomment-628315503 @bbejeck Wondering if there are any backward incompatibility concerns? Can you explain why this change is safe? For #8504 there would be an exception before and thus it was broken

[GitHub] [kafka] mjsax commented on pull request #8558: KAFKA-8611 / KIP-221 documentation

2020-05-13 Thread GitBox
mjsax commented on pull request #8558: URL: https://github.com/apache/kafka/pull/8558#issuecomment-628314584 @lkokhreidze Did PR shows a conflict. Can you rebase it? Btw: did you see the follow up question on the mailing list?

[GitHub] [kafka] soondenana edited a comment on pull request #8068: MINOR: Update to Gradle 4.10.3

2020-05-13 Thread GitBox
soondenana edited a comment on pull request #8068: URL: https://github.com/apache/kafka/pull/8068#issuecomment-628308978 Closing PR as this doesn't fix issue. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] soondenana commented on pull request #8068: MINOR: Update to Gradle 4.10.3

2020-05-13 Thread GitBox
soondenana commented on pull request #8068: URL: https://github.com/apache/kafka/pull/8068#issuecomment-628308978 Issue is now fixed by release team by adding JVM flags for this. This PR is no longer needed. Closing. This

[GitHub] [kafka] soondenana closed pull request #8068: MINOR: Update to Gradle 4.10.3

2020-05-13 Thread GitBox
soondenana closed pull request #8068: URL: https://github.com/apache/kafka/pull/8068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-9989) StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task

2020-05-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106744#comment-17106744 ] Sophie Blee-Goldman commented on KAFKA-9989: Yeah it would be good to dive into why this is

[GitHub] [kafka] guozhangwang commented on a change in pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-13 Thread GitBox
guozhangwang commented on a change in pull request #8661: URL: https://github.com/apache/kafka/pull/8661#discussion_r424796625 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -248,17 +243,6 @@ void

[GitHub] [kafka] rgroothuijsen opened a new pull request #8664: KAFKA-9716: Clarify meaning of compression rate metrics

2020-05-13 Thread GitBox
rgroothuijsen opened a new pull request #8664: URL: https://github.com/apache/kafka/pull/8664 There is some confusion over the compression rate metrics, as the meaning of the value isn't clearly stated in the metric description. In this case, it was assumed that a higher compression rate

[jira] [Assigned] (KAFKA-9716) Values of compression-rate and compression-rate-avg are misleading

2020-05-13 Thread Rens Groothuijsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rens Groothuijsen reassigned KAFKA-9716: Assignee: Rens Groothuijsen > Values of compression-rate and compression-rate-avg

[GitHub] [kafka] ijuma commented on pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-05-13 Thread GitBox
ijuma commented on pull request #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-628301206 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-9554) Define the SPI for Tiered Storage framework

2020-05-13 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-9554: - Assignee: Satish Duggana > Define the SPI for Tiered Storage framework >

[jira] [Created] (KAFKA-9990) Supporting transactions in tiered storage

2020-05-13 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-9990: - Summary: Supporting transactions in tiered storage Key: KAFKA-9990 URL: https://issues.apache.org/jira/browse/KAFKA-9990 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-9989) StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106731#comment-17106731 ] Matthias J. Sax commented on KAFKA-9989: Seems like an issue in rebalancing itself? Shouldn't we

[jira] [Updated] (KAFKA-9989) StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9989: --- Component/s: system tests streams >

[GitHub] [kafka] mjsax commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-13 Thread GitBox
mjsax commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r424758763 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -396,33 +396,52 @@ Connecting Processors and State Stores// and the WordCountProcessor

[GitHub] [kafka] lbradstreet commented on pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-05-13 Thread GitBox
lbradstreet commented on pull request #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-628293868 @ijuma the updated PR should compile OK. I removed the change to make SystemTime package private as it seems to be used in other tooling now.

[GitHub] [kafka] ableegoldman commented on a change in pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8661: URL: https://github.com/apache/kafka/pull/8661#discussion_r424771783 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -248,17 +243,6 @@ void

[jira] [Created] (KAFKA-9989) StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task

2020-05-13 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-9989: -- Summary: StreamsUpgradeTest.test_metadata_upgrade could not guarantee all processor gets assigned task Key: KAFKA-9989 URL: https://issues.apache.org/jira/browse/KAFKA-9989

[GitHub] [kafka] cmccabe merged pull request #8556: MINOR: Add a duplicate() method to Message classes

2020-05-13 Thread GitBox
cmccabe merged pull request #8556: URL: https://github.com/apache/kafka/pull/8556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-13 Thread GitBox
guozhangwang commented on a change in pull request #8661: URL: https://github.com/apache/kafka/pull/8661#discussion_r424761219 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -248,17 +243,6 @@ void

[GitHub] [kafka] mjsax commented on pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
mjsax commented on pull request #8662: URL: https://github.com/apache/kafka/pull/8662#issuecomment-628272802 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
mjsax commented on pull request #8662: URL: https://github.com/apache/kafka/pull/8662#issuecomment-628272606 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424758127 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java ## @@ -236,16 +233,17 @@

[jira] [Commented] (KAFKA-9659) Kafka Streams / Consumer configured for static membership fails on "fatal exception: group.instance.id gets fenced"

2020-05-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106699#comment-17106699 ] Guozhang Wang commented on KAFKA-9659: -- Hi [~lkokhreidze] Could you try out the latest trunk for

[GitHub] [kafka] mjsax commented on pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
mjsax commented on pull request #8662: URL: https://github.com/apache/kafka/pull/8662#issuecomment-628265887 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (KAFKA-9966) Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9966. Fix Version/s: 2.6.0 Resolution: Fixed > Flaky Test

[jira] [Commented] (KAFKA-9966) Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106689#comment-17106689 ] Matthias J. Sax commented on KAFKA-9966: Also related: 

[jira] [Assigned] (KAFKA-9966) Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9966: -- Assignee: Sophie Blee-Goldman (was: Matthias J. Sax) > Flaky Test

[GitHub] [kafka] ableegoldman commented on a change in pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8662: URL: https://github.com/apache/kafka/pull/8662#discussion_r424751772 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1862,6 +1866,35 @@ public

[GitHub] [kafka] mjsax merged pull request #8648: KAFKA-9966: add internal assignment listener to stabilize eos-beta upgrade test

2020-05-13 Thread GitBox
mjsax merged pull request #8648: URL: https://github.com/apache/kafka/pull/8648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
mjsax commented on pull request #8662: URL: https://github.com/apache/kafka/pull/8662#issuecomment-628263949 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8662: HOTFIX: skip listOffsets request for newly created changelog topics

2020-05-13 Thread GitBox
mjsax commented on a change in pull request #8662: URL: https://github.com/apache/kafka/pull/8662#discussion_r424750958 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1862,6 +1866,35 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424729806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ConstrainedPrioritySet.java ## @@ -16,77 +16,58 @@ */

[GitHub] [kafka] junrao commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-05-13 Thread GitBox
junrao commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-628258485 @andrewchoi5 : Thanks for finding this issue. We fixed https://issues.apache.org/jira/browse/KAFKA-9932 recently. So, the `fetchLogConfig` from ZK method is called rarely during

[GitHub] [kafka] ijuma commented on pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-05-13 Thread GitBox
ijuma commented on pull request #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-628251072 @lbradstreet Compile errors: > 12:38:04

[jira] [Updated] (KAFKA-9988) Connect incorrectly reports task has failed when task takes too long to shutdown

2020-05-13 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya updated KAFKA-9988: - Affects Version/s: 2.5.1 2.4.2 2.3.2

[GitHub] [kafka] vvcephei commented on pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on pull request #8588: URL: https://github.com/apache/kafka/pull/8588#issuecomment-628236334 It looks like the test failures were unrelated (because they were all different), some known flaky: java

[jira] [Updated] (KAFKA-9988) Log incorrectly reports task has failed when task takes too long to shutdown

2020-05-13 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya updated KAFKA-9988: - Description: If the OffsetStorageReader is closed while the task is trying to shutdown,

[jira] [Updated] (KAFKA-9988) Connect incorrectly reports task has failed when task takes too long to shutdown

2020-05-13 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya updated KAFKA-9988: - Summary: Connect incorrectly reports task has failed when task takes too long to

[jira] [Created] (KAFKA-9988) Log incorrectly reports task has failed when task takes too long to shutdown

2020-05-13 Thread Sanjana Kaundinya (Jira)
Sanjana Kaundinya created KAFKA-9988: Summary: Log incorrectly reports task has failed when task takes too long to shutdown Key: KAFKA-9988 URL: https://issues.apache.org/jira/browse/KAFKA-9988

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424718290 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java ## @@ -75,4 +94,303 @@ static

[GitHub] [kafka] apovzner commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-13 Thread GitBox
apovzner commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-628234920 @dajac Thanks for your very thorough review. I addressed all your comments. This is an automated message from

[GitHub] [kafka] apovzner commented on a change in pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-13 Thread GitBox
apovzner commented on a change in pull request #8650: URL: https://github.com/apache/kafka/pull/8650#discussion_r424707495 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] apovzner commented on a change in pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-13 Thread GitBox
apovzner commented on a change in pull request #8650: URL: https://github.com/apache/kafka/pull/8650#discussion_r424706138 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-05-13 Thread GitBox
hachikuji commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-628204174 @andrewchoi5 Just want to make sure I understand the problem. The scenario is that we lose the zk session while handling a LeaderAndIsr request. Current LeaderAndIsr handling

[GitHub] [kafka] ijuma commented on pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-05-13 Thread GitBox
ijuma commented on pull request #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-628200880 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] lbradstreet commented on pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-05-13 Thread GitBox
lbradstreet commented on pull request #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-628192600 @ijuma can this be merged? This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-3184) Add Checkpoint for In-memory State Store

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106558#comment-17106558 ] Matthias J. Sax commented on KAFKA-3184: I am personally not sure how useful "local

[jira] [Resolved] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2020-05-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9897. -- Resolution: Fixed > Flaky Test

[jira] [Commented] (KAFKA-9984) Should fail the subscription when pattern is empty

2020-05-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106549#comment-17106549 ] Guozhang Wang commented on KAFKA-9984: -- Sounds good to me :) > Should fail the subscription when

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106548#comment-17106548 ] Matthias J. Sax commented on KAFKA-9897: Sure. We can always reopen again if necessary. What what

[jira] [Updated] (KAFKA-9984) Should fail the subscription when pattern is empty

2020-05-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9984: --- Component/s: (was: streams) > Should fail the subscription when pattern is empty >

[jira] [Comment Edited] (KAFKA-9982) [kafka-connect] Source connector does not guarantee at least once delivery

2020-05-13 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105942#comment-17105942 ] Chris Egerton edited comment on KAFKA-9982 at 5/13/20, 6:10 PM: The

[jira] [Commented] (KAFKA-9659) Kafka Streams / Consumer configured for static membership fails on "fatal exception: group.instance.id gets fenced"

2020-05-13 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106528#comment-17106528 ] Levani Kokhreidze commented on KAFKA-9659: -- Hi [~guozhang] Just fyi - we've experienced this

[jira] [Commented] (KAFKA-9927) Add support for varint types to message generator

2020-05-13 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106465#comment-17106465 ] Tom Bentley commented on KAFKA-9927: [~hachikuji] I've implemented this

[jira] [Updated] (KAFKA-9987) Add new cooperative assignor optimized for constant-subscription group

2020-05-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9987: --- Summary: Add new cooperative assignor optimized for constant-subscription group

[jira] [Created] (KAFKA-9987) Add new cooperative assignor optimized for constant-subscription. group

2020-05-13 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-9987: -- Summary: Add new cooperative assignor optimized for constant-subscription. group Key: KAFKA-9987 URL: https://issues.apache.org/jira/browse/KAFKA-9987

[jira] [Resolved] (KAFKA-8989) Embedded broker could not be reached in unit test

2020-05-13 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-8989. Resolution: Won't Fix > Embedded broker could not be reached in unit test >

[jira] [Commented] (KAFKA-8989) Embedded broker could not be reached in unit test

2020-05-13 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106430#comment-17106430 ] Boyang Chen commented on KAFKA-8989: Lost track, will close. > Embedded broker could not be reached

[jira] [Resolved] (KAFKA-9798) Flaky test: org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses

2020-05-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9798. -- Resolution: Not A Problem > Flaky test: >

[jira] [Assigned] (KAFKA-9927) Add support for varint types to message generator

2020-05-13 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-9927: -- Assignee: Tom Bentley > Add support for varint types to message generator >

  1   2   >