[GitHub] [kafka] chia7712 opened a new pull request #9401: KAFKA-9628 Replace Produce request with automated protocol

2020-10-08 Thread GitBox
chia7712 opened a new pull request #9401: URL: https://github.com/apache/kafka/pull/9401 issue: https://issues.apache.org/jira/browse/KAFKA-9628 this PR is a part of KAFKA-9628. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] chia7712 commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

2020-10-08 Thread GitBox
chia7712 commented on pull request #9400: URL: https://github.com/apache/kafka/pull/9400#issuecomment-705984805 Is ```allowList``` more suitable to replace ```whiteList```? This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-9628) Replace Produce request/response with automated protocol

2020-10-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210629#comment-17210629 ] Chia-Ping Tsai commented on KAFKA-9628: --- > I've reassigned it to you, go for it thanks! I will

[GitHub] [kafka] xvrl opened a new pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

2020-10-08 Thread GitBox
xvrl opened a new pull request #9400: URL: https://github.com/apache/kafka/pull/9400 rename internal classes and methods for KIP-629 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-08 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-705979334 @hachikuji @dajac Could you take a look? This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (KAFKA-10590) Whole kafka node hungs when one node goes down.

2020-10-08 Thread sandeep p (Jira)
sandeep p created KAFKA-10590: - Summary: Whole kafka node hungs when one node goes down. Key: KAFKA-10590 URL: https://issues.apache.org/jira/browse/KAFKA-10590 Project: Kafka Issue Type: Bug

[jira] [Comment Edited] (KAFKA-9726) LegacyReplicationPolicy for MM2 to mimic MM1

2020-10-08 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210367#comment-17210367 ] Ivan Yurchenko edited comment on KAFKA-9726 at 10/9/20, 4:35 AM: -

[jira] [Commented] (KAFKA-10555) Improve client state machine

2020-10-08 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210606#comment-17210606 ] Sophie Blee-Goldman commented on KAFKA-10555: - > This, it won't be possible to add new

[GitHub] [kafka] guozhangwang commented on pull request #9352: KAFKA-10533; KafkaRaftClient should flush log after appends

2020-10-08 Thread GitBox
guozhangwang commented on pull request #9352: URL: https://github.com/apache/kafka/pull/9352#issuecomment-705954882 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Assigned] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté reassigned KAFKA-10573: - Assignee: Xavier Léauté > Rename connect transform configs for KIP-629 >

[GitHub] [kafka] xvrl commented on a change in pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-08 Thread GitBox
xvrl commented on a change in pull request #9367: URL: https://github.com/apache/kafka/pull/9367#discussion_r502167123 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Resolved] (KAFKA-10571) Replace occurrences of blackout with backoff for KIP-629

2020-10-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté resolved KAFKA-10571. --- Resolution: Fixed > Replace occurrences of blackout with backoff for KIP-629 >

[GitHub] [kafka] huxihx opened a new pull request #9399: KAFKA-10584:IndexSearchType should use sealed trait instead of Enumeration

2020-10-08 Thread GitBox
huxihx opened a new pull request #9399: URL: https://github.com/apache/kafka/pull/9399 https://issues.apache.org/jira/browse/KAFKA-10584 In Scala, we prefer sealed traits over Enumeration since the former gives you exhaustiveness checking. With Scala Enumeration, you don't get a

[jira] [Assigned] (KAFKA-10584) IndexSearchType should use sealed trait instead of Enumeration

2020-10-08 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx reassigned KAFKA-10584: -- Assignee: huxihx > IndexSearchType should use sealed trait instead of Enumeration >

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-08 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502092508 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1242,7 +1314,56 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-08 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502092158 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-08 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502091435 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-08 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502091323 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -409,6 +409,67 @@ class ConnectionQuotasTest {

[GitHub] [kafka] gwenshap closed pull request #9398: MINOR update comments and docs to be gender-neutral

2020-10-08 Thread GitBox
gwenshap closed pull request #9398: URL: https://github.com/apache/kafka/pull/9398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-08 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502086777 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1242,7 +1314,56 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-08 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502084924 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] gwenshap commented on a change in pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-08 Thread GitBox
gwenshap commented on a change in pull request #9367: URL: https://github.com/apache/kafka/pull/9367#discussion_r502083707 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] gwenshap commented on a change in pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-08 Thread GitBox
gwenshap commented on a change in pull request #9367: URL: https://github.com/apache/kafka/pull/9367#discussion_r502082826 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r502078584 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -782,7 +782,7 @@ class LogTest { } // Retain snapshots for the last

[GitHub] [kafka] guozhangwang commented on a change in pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-08 Thread GitBox
guozhangwang commented on a change in pull request #9396: URL: https://github.com/apache/kafka/pull/9396#discussion_r502067124 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java ## @@ -0,0 +1,494 @@ +/* + * Licensed

[GitHub] [kafka] xvrl opened a new pull request #9398: MINOR update comments and docs to be gender-neutral

2020-10-08 Thread GitBox
xvrl opened a new pull request #9398: URL: https://github.com/apache/kafka/pull/9398 cc @gwenshap This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] gwenshap closed pull request #9366: KAFKA-10571 Replace blackout with backoff for KIP-629

2020-10-08 Thread GitBox
gwenshap closed pull request #9366: URL: https://github.com/apache/kafka/pull/9366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] xvrl commented on pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-08 Thread GitBox
xvrl commented on pull request #9367: URL: https://github.com/apache/kafka/pull/9367#issuecomment-705863610 jdk8 test failures appear unrelated This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-08 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r502052730 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -483,7 +485,7 @@ public void

[jira] [Commented] (KAFKA-7447) Consumer offsets lost during leadership rebalance after bringing node back from clean shutdown

2020-10-08 Thread Lauren McDonald (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210472#comment-17210472 ] Lauren McDonald commented on KAFKA-7447: We are on version 2.3.* and saw this issue multiple

[GitHub] [kafka] junrao commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
junrao commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r502023899 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -782,7 +782,7 @@ class LogTest { } // Retain snapshots for the last 2

[jira] [Commented] (KAFKA-7447) Consumer offsets lost during leadership rebalance after bringing node back from clean shutdown

2020-10-08 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210470#comment-17210470 ] James Cheng commented on KAFKA-7447: Hi. The consensus seems to be that this was fixed in

[GitHub] [kafka] cmccabe commented on pull request #9390: MINOR: Implement ApiError#equals and hashCode

2020-10-08 Thread GitBox
cmccabe commented on pull request #9390: URL: https://github.com/apache/kafka/pull/9390#issuecomment-705828611 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] cmccabe commented on pull request #9390: MINOR: Implement ApiError#equals and hashCode

2020-10-08 Thread GitBox
cmccabe commented on pull request #9390: URL: https://github.com/apache/kafka/pull/9390#issuecomment-705826094 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-9628) Replace Produce request/response with automated protocol

2020-10-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210441#comment-17210441 ] Mickael Maison commented on KAFKA-9628: --- [~chia7712] I've reassigned it to you, go for it >

[jira] [Assigned] (KAFKA-9628) Replace Produce request/response with automated protocol

2020-10-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-9628: - Assignee: Chia-Ping Tsai (was: Mickael Maison) > Replace Produce request/response with

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501979388 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -1226,6 +1225,104 @@ class LogTest { assertEquals(retainedLastSeqOpt,

[GitHub] [kafka] gardnervickers commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-705786361 @junrao I think that `Log.takeProducerSnapshot` is being used for testing in a few places in `LogTest`, though my IDE does not pick that up for some reason.

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501970716 ## File path: core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala ## @@ -834,6 +834,40 @@ class ProducerStateManagerTest {

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501968249 ## File path: core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala ## @@ -834,6 +834,40 @@ class ProducerStateManagerTest {

[jira] [Commented] (KAFKA-7334) Suggest changing config for state.dir in case of FileNotFoundException

2020-10-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210410#comment-17210410 ] Matthias J. Sax commented on KAFKA-7334: [~vladimir_shadrin] I added you to the list of

[jira] [Assigned] (KAFKA-7334) Suggest changing config for state.dir in case of FileNotFoundException

2020-10-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-7334: -- Assignee: Vladimir > Suggest changing config for state.dir in case of

[GitHub] [kafka] mjsax commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-08 Thread GitBox
mjsax commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705772843 Thanks for the PR @voffcheg109! Merged to `trunk` and cherry-picked to `2.7` branch. This is an automated

[GitHub] [kafka] mjsax merged pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-08 Thread GitBox
mjsax merged pull request #9380: URL: https://github.com/apache/kafka/pull/9380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501957800 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -1226,6 +1225,104 @@ class LogTest { assertEquals(retainedLastSeqOpt,

[GitHub] [kafka] lct45 commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-08 Thread GitBox
lct45 commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501956905 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -483,7 +485,7 @@ public void

[GitHub] [kafka] efeg commented on pull request #9397: KAFKA-10583: Add documentation on the thread-safety of KafkaAdminClient.

2020-10-08 Thread GitBox
efeg commented on pull request #9397: URL: https://github.com/apache/kafka/pull/9397#issuecomment-705765230 @cmccabe Do you think you might be able to take a look at this PR? This is an automated message from the Apache Git

[GitHub] [kafka] efeg opened a new pull request #9397: KAFKA-10583: Add documentation on the thread-safety of KafkaAdminClient.

2020-10-08 Thread GitBox
efeg opened a new pull request #9397: URL: https://github.com/apache/kafka/pull/9397 Other than a Stack Overflow comment (see https://stackoverflow.com/a/61738065) by Colin Patrick McCabe (@cmccabe ) and a proposed design note on KIP-117 wiki, there is no source that verifies the

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501944185 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -496,6 +491,53 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501942512 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -653,36 +697,44 @@ class ProducerStateManager(val topicPartition:

[jira] [Commented] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2020-10-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210386#comment-17210386 ] Matthias J. Sax commented on KAFKA-10585: - [~dongjin] – please assign the ticket to yourself if

[jira] [Updated] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2020-10-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10585: Priority: Minor (was: Major) > Kafka Streams should clean up the state store directory

[jira] [Updated] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2020-10-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10585: Issue Type: Improvement (was: Bug) > Kafka Streams should clean up the state store

[jira] [Updated] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2020-10-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10585: -- Labels: newbie++ (was: ) > Kafka Streams should clean up the state store directory from

[GitHub] [kafka] vvcephei commented on a change in pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-08 Thread GitBox
vvcephei commented on a change in pull request #9396: URL: https://github.com/apache/kafka/pull/9396#discussion_r501891955 ## File path: checkstyle/suppressions.xml ## @@ -194,13 +194,13 @@ files=".*[/\\]streams[/\\].*test[/\\].*.java"/> +

[GitHub] [kafka] junrao commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
junrao commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-705727027 Also, it seems that Log.takeProducerSnapshot() no longer used? This is an automated message from the Apache Git

[jira] [Resolved] (KAFKA-10271) Performance regression while fetching a key from a single partition

2020-10-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10271. --- Fix Version/s: (was: 2.5.2) 2.7.0 Resolution: Fixed >

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-08 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-705723421 Cherry-picked to 2.6 as well. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei opened a new pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-08 Thread GitBox
vvcephei opened a new pull request #9396: URL: https://github.com/apache/kafka/pull/9396 Implements KIP-478 for the test-utils module: * adds mocks of the new ProcessorContext and StateStoreContext * adds tests that all stores and store builders are usable with the new mock * adds

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-08 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-705707869 Test passed, merged to trunk. Thanks @dima5rr for your great contribution! This is an automated

[GitHub] [kafka] guozhangwang merged pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-08 Thread GitBox
guozhangwang merged pull request #9020: URL: https://github.com/apache/kafka/pull/9020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] junrao removed a comment on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-08 Thread GitBox
junrao removed a comment on pull request #9393: URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092 In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-08 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501876646 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfoTest.java ## @@ -59,6 +60,7 @@ );

[GitHub] [kafka] junrao merged pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-08 Thread GitBox
junrao merged pull request #9393: URL: https://github.com/apache/kafka/pull/9393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] junrao commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-08 Thread GitBox
junrao commented on pull request #9393: URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092 In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-08 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501875691 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java ## @@ -286,7 +286,8 @@

[GitHub] [kafka] ivanyu opened a new pull request #9395: KAFKA-9726: Add LegacyReplicationPolicy for MM2

2020-10-08 Thread GitBox
ivanyu opened a new pull request #9395: URL: https://github.com/apache/kafka/pull/9395 This commit adds a new replication policy for MirrorMaker 2, `LegacyReplicationPolicy`. This policy imitates MirrorMaker 1 behavior of not renaming replicated topics. The exception is made for

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-08 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501873791 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-08 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501868835 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final

[GitHub] [kafka] junrao commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
junrao commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501325705 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -496,6 +491,53 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] ableegoldman commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-08 Thread GitBox
ableegoldman commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705689770 Tests passed, should be good to merge @mjsax . Btw the 2.7 branch was just cut so this should be cherrypicked back to 2.7.

[GitHub] [kafka] lct45 commented on pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-08 Thread GitBox
lct45 commented on pull request #9383: URL: https://github.com/apache/kafka/pull/9383#issuecomment-705688523 System tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4204/ This is an automated message

[jira] [Created] (KAFKA-10589) Rename kafka-replica-verification CLI command line arguments for KIP-629

2020-10-08 Thread Jira
Xavier Léauté created KAFKA-10589: - Summary: Rename kafka-replica-verification CLI command line arguments for KIP-629 Key: KAFKA-10589 URL: https://issues.apache.org/jira/browse/KAFKA-10589 Project:

[jira] [Created] (KAFKA-10588) Rename kafka-console-consumer CLI command line arguments for KIP-629

2020-10-08 Thread Jira
Xavier Léauté created KAFKA-10588: - Summary: Rename kafka-console-consumer CLI command line arguments for KIP-629 Key: KAFKA-10588 URL: https://issues.apache.org/jira/browse/KAFKA-10588 Project:

[jira] [Created] (KAFKA-10587) Rename kafka-mirror-maker CLI command line arguments for KIP-629

2020-10-08 Thread Jira
Xavier Léauté created KAFKA-10587: - Summary: Rename kafka-mirror-maker CLI command line arguments for KIP-629 Key: KAFKA-10587 URL: https://issues.apache.org/jira/browse/KAFKA-10587 Project: Kafka

[jira] [Updated] (KAFKA-9679) Mock consumer should behave consistent with actual consumer

2020-10-08 Thread Sheikh Araf (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sheikh Araf updated KAFKA-9679: --- Attachment: (was: image.png) > Mock consumer should behave consistent with actual consumer >

[jira] [Updated] (KAFKA-9679) Mock consumer should behave consistent with actual consumer

2020-10-08 Thread Sheikh Araf (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sheikh Araf updated KAFKA-9679: --- Attachment: image.png > Mock consumer should behave consistent with actual consumer >

[GitHub] [kafka] xvrl commented on pull request #9366: KAFKA-10571 Replace blackout with backoff for KIP-629

2020-10-08 Thread GitBox
xvrl commented on pull request #9366: URL: https://github.com/apache/kafka/pull/9366#issuecomment-705676790 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2020-10-08 Thread Rohan Desai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210308#comment-17210308 ] Rohan Desai commented on KAFKA-10585: - Yes, this is a good summary. > Kafka Streams should clean up

[GitHub] [kafka] cadonna commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-08 Thread GitBox
cadonna commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501802252 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -617,7 +619,19 @@ public void

[GitHub] [kafka] cadonna commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-08 Thread GitBox
cadonna commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501793433 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final

[GitHub] [kafka] mimaison merged pull request #9271: MINOR: correct package of LinuxIoMetricsCollector

2020-10-08 Thread GitBox
mimaison merged pull request #9271: URL: https://github.com/apache/kafka/pull/9271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mimaison commented on pull request #9271: MINOR: correct package of LinuxIoMetricsCollector

2020-10-08 Thread GitBox
mimaison commented on pull request #9271: URL: https://github.com/apache/kafka/pull/9271#issuecomment-705628291 Test failures are not related and passed locally, merging This is an automated message from the Apache Git

[GitHub] [kafka] acmck closed pull request #9394: Fully automate dev setup with Gitpod

2020-10-08 Thread GitBox
acmck closed pull request #9394: URL: https://github.com/apache/kafka/pull/9394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] acmck opened a new pull request #9394: Fully automate dev setup with Gitpod

2020-10-08 Thread GitBox
acmck opened a new pull request #9394: URL: https://github.com/apache/kafka/pull/9394 This commit implements a fully-automated development setup using Gitpod.io, an online IDE for GitLab, GitHub, and Bitbucket that enables Dev-Environments-As-Code. This makes it easy for anyone to

[jira] [Commented] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2020-10-08 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210251#comment-17210251 ] Dongjin Lee commented on KAFKA-10585: - I inspected this issue a little bit. You mean, all

[jira] [Created] (KAFKA-10586) MirrorMaker 2.0 REST support

2020-10-08 Thread Daniel Urban (Jira)
Daniel Urban created KAFKA-10586: Summary: MirrorMaker 2.0 REST support Key: KAFKA-10586 URL: https://issues.apache.org/jira/browse/KAFKA-10586 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] mimaison merged pull request #9296: MINOR: remove unused scala files from core module

2020-10-08 Thread GitBox
mimaison merged pull request #9296: URL: https://github.com/apache/kafka/pull/9296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] C0urante commented on pull request #9375: KAFKA-10574: Fix infinite loop in Values::parseString

2020-10-08 Thread GitBox
C0urante commented on pull request #9375: URL: https://github.com/apache/kafka/pull/9375#issuecomment-705596382 Hi @rhauch @kkonstantine, this PR has been approved, all merge conflicts have been resolved, and every build is green. Would it be possible to merge sometime soon so that it can

[GitHub] [kafka] shadikajevand commented on pull request #9359: kafka-10273 Connect Converters should produce actionable error messages

2020-10-08 Thread GitBox
shadikajevand commented on pull request #9359: URL: https://github.com/apache/kafka/pull/9359#issuecomment-705566435 Hi @rhauch I am working on convertKey(...) and convertValue(...) methods for WorkerSourceTask. I'm throwing a DataException in these two methods when an exception occures.

[GitHub] [kafka] vvcephei commented on pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-08 Thread GitBox
vvcephei commented on pull request #9139: URL: https://github.com/apache/kafka/pull/9139#issuecomment-705564790 cherry-picked to 2.7. Thanks @jeqo ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mimaison commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-08 Thread GitBox
mimaison commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-705563795 @scanterog `testClusterConfigProperties()` seems to be failing now. Can you fix it before I take a look at the PR? ```

[GitHub] [kafka] vvcephei merged pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-08 Thread GitBox
vvcephei merged pull request #9139: URL: https://github.com/apache/kafka/pull/9139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-08 Thread GitBox
vvcephei commented on pull request #9139: URL: https://github.com/apache/kafka/pull/9139#issuecomment-705556429 Ok, it's merged. I'm waiting on permission from Bill before cherry-picking to 2.7 This is an automated message

[GitHub] [kafka] rondagostino commented on pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-08 Thread GitBox
rondagostino commented on pull request #9378: URL: https://github.com/apache/kafka/pull/9378#issuecomment-705552615 Rebased onto trunk despite lack of conflicts due to Python 3 for system tests being merged. This is an

[GitHub] [kafka] chia7712 commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-08 Thread GitBox
chia7712 commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-705551760 > This feature is just being released in 2.7 and will itself be mentioned in the release notes, so a separate ticket for this issue seems unnecessary to me. I just worry

[GitHub] [kafka] mumrah merged pull request #9307: MINOR: Backported changes to ClientUtils.resolve tests to 2.4

2020-10-08 Thread GitBox
mumrah merged pull request #9307: URL: https://github.com/apache/kafka/pull/9307 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rondagostino commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-08 Thread GitBox
rondagostino commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-705531979 This feature is just being released in 2.7 and will itself be mentioned in the release notes, so a separate ticket for this issue seems unnecessary to me.

[GitHub] [kafka] tombentley commented on pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-10-08 Thread GitBox
tombentley commented on pull request #9365: URL: https://github.com/apache/kafka/pull/9365#issuecomment-705503807 @rajinisivaram @omkreddy did you have any thoughts about this? What I've done here isn't exactly pretty, but it was the simplest thing I could think of which would remove the

[GitHub] [kafka] voffcheg109 commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-08 Thread GitBox
voffcheg109 commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705464097 @mjsax, I've fixed by your comments. This is an automated message from the Apache Git Service. To respond to

  1   2   >