ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501876646
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfoTest.java
##########
@@ -59,6 +60,7 @@
);
private final static String IGNORED_USER_ENDPOINT =
"ignoredUserEndpoint:80";
+ private static final byte[] IGNORED_UNIQUE_FIELD = Bytes.EMPTY;
Review comment:
nit: let's use `new byte[1]` for this to make sure it's actually being
ignored when it should be (since apparently it won't notice if you just pass in
empty bytes for this field on a version < 8)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
