iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440153281
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1340,6 +1346,10 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
kamalcph commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440146317
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1340,6 +1346,10 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1874937679
> LGTM, thanks for the patch!
>
> This patch handles the FETCH request for previously compacted topic
segments uploaded to remote storage. We also have to go through the
>
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440133601
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440126550
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2065,6 +2066,11 @@ public Optional
fetchRemoteLogSegmentMetadata(TopicPar
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440116425
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1340,6 +1346,10 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440115636
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1340,6 +1346,10 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440115636
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1340,6 +1346,10 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
[
https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802024#comment-17802024
]
Satish Duggana commented on KAFKA-16073:
We discussed one possible solution is to address it by
kamalcph commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440097317
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
kamalcph commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1440089289
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1340,6 +1346,10 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
wernerdv commented on code in PR #15086:
URL: https://github.com/apache/kafka/pull/15086#discussion_r1440092493
##
core/src/test/scala/integration/kafka/api/GroupCoordinatorIntegrationTest.scala:
##
@@ -33,18 +34,21 @@ class GroupCoordinatorIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-16070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
johndoe reassigned KAFKA-16070:
---
Assignee: johndoe
> Extract the setReadOnly method into Headers
>
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phuc Hong Tran reassigned KAFKA-15561:
--
Assignee: Phuc Hong Tran
> Client support for new SubscriptionPattern based
[
https://issues.apache.org/jira/browse/KAFKA-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phuc Hong Tran reassigned KAFKA-15682:
--
Assignee: Phuc Hong Tran
> Ensure internal remote log metadata topic does not expire
[
https://issues.apache.org/jira/browse/KAFKA-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phuc Hong Tran resolved KAFKA-16034.
Resolution: Fixed
> AsyncKafkaConsumer will get Invalid Request error when trying to
[
https://issues.apache.org/jira/browse/KAFKA-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802013#comment-17802013
]
Phuc Hong Tran commented on KAFKA-16034:
[~pnee] PlainTextConsumerTest isn't failing with any
ashwinpankaj commented on code in PR #15101:
URL: https://github.com/apache/kafka/pull/15101#discussion_r1440041522
##
core/src/test/java/kafka/test/junit/LeakTestingExtension.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
ashwinpankaj commented on code in PR #15101:
URL: https://github.com/apache/kafka/pull/15101#discussion_r1440041522
##
core/src/test/java/kafka/test/junit/LeakTestingExtension.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
github-actions[bot] commented on PR #14423:
URL: https://github.com/apache/kafka/pull/14423#issuecomment-1874810052
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802000#comment-17802000
]
hzh0425 commented on KAFKA-16073:
-
ping [~satish.duggana]， When you are free, please help to see if
[
https://issues.apache.org/jira/browse/KAFKA-14510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jimmy Wang reassigned KAFKA-14510:
--
Assignee: Jimmy Wang
> Extend DescribeConfigs API to support group configs
>
jolshan commented on PR #15108:
URL: https://github.com/apache/kafka/pull/15108#issuecomment-1874744763
Do we know why sometimes we get interrupted? I think this is a useful change
though, when I zoomed out for a month the failures were more frequent.
jolshan commented on code in PR #15086:
URL: https://github.com/apache/kafka/pull/15086#discussion_r1439990671
##
core/src/test/scala/integration/kafka/api/GroupCoordinatorIntegrationTest.scala:
##
@@ -33,18 +34,21 @@ class GroupCoordinatorIntegrationTest extends
jolshan commented on PR #15086:
URL: https://github.com/apache/kafka/pull/15086#issuecomment-1874741304
`testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec(String).quorum=kraft
PASSED`
Looks like it is passing on all builds.
拾
--
This is an automated message from
jolshan commented on PR #15099:
URL: https://github.com/apache/kafka/pull/15099#issuecomment-1874738065
@divijvaidya did you accidentally include the KafkaApisTest change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1874737282
Thanks @MikeEdgar looks like the test is fixed. I'll run the build again to
make sure there aren't any other related tests failing.
--
This is an automated message from the Apache Git
ableegoldman merged PR #15073:
URL: https://github.com/apache/kafka/pull/15073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #15073:
URL: https://github.com/apache/kafka/pull/15073#issuecomment-1874668715
Test failures are unrelated, merging to trunk and will cherrypick to 3.7 cc
@stanislavkozlovski
--
This is an automated message from the Apache Git Service.
To respond to the
metao1 opened a new pull request, #15110:
URL: https://github.com/apache/kafka/pull/15110
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
[
https://issues.apache.org/jira/browse/KAFKA-16076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mehrdad Karami updated KAFKA-16076:
---
Description:
In RestClient class, httpRequest is being called with different threads. An
Mehrdad Karami created KAFKA-16076:
--
Summary: RestClient Interrupting the thread in case of
InterruptedException
Key: KAFKA-16076
URL: https://issues.apache.org/jira/browse/KAFKA-16076
Project:
ableegoldman commented on code in PR #15088:
URL: https://github.com/apache/kafka/pull/15088#discussion_r1439872897
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1229,10 +1229,21 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-16025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801927#comment-17801927
]
A. Sophie Blee-Goldman commented on KAFKA-16025:
Nice find and writeup of the race
gharris1727 closed pull request #15008: MINOR: Prototype: Measure CI slowness
URL: https://github.com/apache/kafka/pull/15008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-16055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801924#comment-17801924
]
A. Sophie Blee-Goldman commented on KAFKA-16055:
See this discussion on the user
[
https://issues.apache.org/jira/browse/KAFKA-16055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-16055:
---
Labels: newbie newbie++ (was: )
> Thread unsafe use of HashMap stored in
Jakub Scholz created KAFKA-16075:
Summary: TLS configuration not validated in KRaft controller-only
nodes
Key: KAFKA-16075
URL: https://issues.apache.org/jira/browse/KAFKA-16075
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801921#comment-17801921
]
Philip Nee commented on KAFKA-16034:
Hi [~phuctran] - I think the issue might already been fixed.
philipnee commented on code in PR #15020:
URL: https://github.com/apache/kafka/pull/15020#discussion_r1439651419
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -70,8 +70,10 @@ protected void maybeThrowAuthFailure(Node node)
ijuma commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-1874508632
I guess one way would be to enable the cache only for CI & trunk by default
at first. Then we could manually enable the cache locally and for one PR to
test the behavior. If it all looks
ijuma commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-1874507122
Could we do a test with a new branch (not trunk) where we validate the
behavior before we roll it out to everyone else?
--
This is an automated message from the Apache Git Service.
To
nicktelford commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-1874500874
Hi @divijvaidya , this enables the _remote_ build cache, which allows
different machines to share the cached output of tasks.
Thanks for the links to the builds, I haven't had
divijvaidya merged PR #15104:
URL: https://github.com/apache/kafka/pull/15104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #15104:
URL: https://github.com/apache/kafka/pull/15104#issuecomment-1874493514
The test failures not in classes that use MiniKdc which is changed in this
PR. The only test that uses kdc and fails is
`SaslScramSslEndToEndAuthorizationTest` but it is successful
divijvaidya commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-1874483500
Hey @nicktelford , you don't need committer permissions to look at ASF
gradle. Try using this link: https://ge.apache.org, it should be publicly
accessible.
For this PR,
[
https://issues.apache.org/jira/browse/KAFKA-16051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801909#comment-17801909
]
Greg Harris commented on KAFKA-16051:
-
I added permissions for you on Jira, and assigned the ticket
[
https://issues.apache.org/jira/browse/KAFKA-16051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-16051:
---
Assignee: Octavian Ciubotaru
> Deadlock on connector initialization
>
gharris1727 commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1439665912
##
clients/src/test/java/org/apache/kafka/common/config/provider/FileConfigProviderTest.java:
##
@@ -98,8 +117,91 @@ public void testServiceLoaderDiscovery() {
[
https://issues.apache.org/jira/browse/KAFKA-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801904#comment-17801904
]
Almog Gavra commented on KAFKA-16046:
-
https://github.com/apache/kafka/pull/15073
> Stream Stream
[
https://issues.apache.org/jira/browse/KAFKA-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Almog Gavra reopened KAFKA-16046:
-
> Stream Stream Joins fail after restoration with deserialization exceptions
>
ableegoldman commented on PR #14949:
URL: https://github.com/apache/kafka/pull/14949#issuecomment-1874410202
Merged to trunk and cherrypicked to 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman merged PR #14949:
URL: https://github.com/apache/kafka/pull/14949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #14949:
URL: https://github.com/apache/kafka/pull/14949#issuecomment-1874406419
FYI @agavra try to always fill out a PR description, even if it's super
short/simple, so we have something for the commit message. I'll just make it up
for this case but going
ableegoldman commented on PR #14949:
URL: https://github.com/apache/kafka/pull/14949#issuecomment-1874405243
Ok this has dragged on for long enough, I'm just going to merge this even
though we haven't gotten a single individual run without any build failures,
because (a) we have at least
mimaison commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1439616708
##
clients/src/test/java/org/apache/kafka/common/config/provider/DirectoryConfigProviderTest.java:
##
@@ -43,36 +49,36 @@ public class DirectoryConfigProviderTest {
gharris1727 commented on PR #14771:
URL: https://github.com/apache/kafka/pull/14771#issuecomment-1874318692
@divijvaidya Thanks for the review. I applied your suggestion. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jolshan commented on PR #15093:
URL: https://github.com/apache/kafka/pull/15093#issuecomment-1874304438
Thanks folks for fixing this stuff :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15816:
Description:
There are a few tests which leak network sockets due to small typos in the
tests
lucasbru commented on PR #15073:
URL: https://github.com/apache/kafka/pull/15073#issuecomment-1874248887
@stanislavkozlovski @mjsax This is a blocker issue for 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vamossagar12 commented on PR #14955:
URL: https://github.com/apache/kafka/pull/14955#issuecomment-1874218869
@divijvaidya , do you mind taking a look at this one? Once the checkstyles
are fixed, It looks good to go from my side (will approve once the changes are
made).
--
This is an
vamossagar12 commented on code in PR #14955:
URL: https://github.com/apache/kafka/pull/14955#discussion_r1439583795
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1014,7 +1014,9 @@ synchronized public DescribeLogDirsResult
lucasbru merged PR #15096:
URL: https://github.com/apache/kafka/pull/15096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax merged PR #15102:
URL: https://github.com/apache/kafka/pull/15102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-16059:
-
Fix Version/s: 3.7.0
3.8.0
> Fix leak of ExpirationReaper-1-AlterAcls
[
https://issues.apache.org/jira/browse/KAFKA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801817#comment-17801817
]
Kamal Chandraprakash commented on KAFKA-15777:
--
[~isding_l]
This task require a KIP as we
[
https://issues.apache.org/jira/browse/KAFKA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-15777:
-
Labels: kip (was: )
> Configurable remote fetch bytes per partition from
nicktelford commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-1874134447
I don't have access to the ASF Gradle Enterprise, so a committer will need
to verify that this works as intended.
--
This is an automated message from the Apache Git Service.
To
nicktelford opened a new pull request, #15109:
URL: https://github.com/apache/kafka/pull/15109
We enable the remote build cache, hosted by the ASF Gradle Enterprise
instance.
We only cache tasks during builds on `trunk`, to ensure that pushes to PRs
always re-run all Tasks needed by
divijvaidya merged PR #15093:
URL: https://github.com/apache/kafka/pull/15093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #15093:
URL: https://github.com/apache/kafka/pull/15093#issuecomment-1874131838
The test changed in this PR is successful -
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15093/3/testReport/kafka.server/ControllerApisTest/
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801811#comment-17801811
]
Phuc Hong Tran commented on KAFKA-16034:
[~pnee], I don't think reset HeartbeatState is enough
jamespfaulkner commented on code in PR #14955:
URL: https://github.com/apache/kafka/pull/14955#discussion_r1439519451
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1014,7 +1014,9 @@ synchronized public DescribeLogDirsResult
iit2009060 commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1874100254
@clolov Can we merge the request ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801803#comment-17801803
]
Lan Ding commented on KAFKA-15777:
--
hi [~ckamal], could I pick this up?
> Configurable remote fetch
DL1231 opened a new pull request, #15108:
URL: https://github.com/apache/kafka/pull/15108
Test fails 2% of the time.
https://ge.apache.org/scans/tests?search.timeZoneId=Europe/Berlin=kafka.log.remote.RemoteIndexCacheTest=testClose()
This test should be modified to test
clolov commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1439460528
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
clolov commented on code in PR #15106:
URL: https://github.com/apache/kafka/pull/15106#discussion_r1439447074
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##
@@ -642,11 +645,12 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lan Ding reassigned KAFKA-15206:
Assignee: Lan Ding
> Flaky test RemoteIndexCacheTest.testClose()
>
DL1231 opened a new pull request, #15107:
URL: https://github.com/apache/kafka/pull/15107
I was reading about producer and found a couple of code style
inconsistencies. This PR fixes them.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
lucasbru commented on code in PR #15106:
URL: https://github.com/apache/kafka/pull/15106#discussion_r1439431364
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##
@@ -642,11 +645,12 @@ public void
clolov opened a new pull request, #15106:
URL: https://github.com/apache/kafka/pull/15106
This pull request takes a similar approach to how TaskManagerTest is being
migrated to Mockito mock by mock for easier reviews.
--
This is an automated message from the Apache Git Service.
To
divijvaidya merged PR #14929:
URL: https://github.com/apache/kafka/pull/14929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #14929:
URL: https://github.com/apache/kafka/pull/14929#issuecomment-1873974414
There are flaky tests in CI but the test changed in this PR is successful:
showuon commented on PR #15101:
URL: https://github.com/apache/kafka/pull/15101#issuecomment-1873956404
@wernerdv , thanks for the smart way to detect the thread leaking!
For now, only `core` module will introduce thousands of test errors. We need
to fix all the thread leaking before
wernerdv commented on PR #15101:
URL: https://github.com/apache/kafka/pull/15101#issuecomment-1873949674
@divijvaidya Thanks for the reply. Now extension runs only for modules that:
`testImplementation project(':core')`
Is this expected behavior or does it require improvement?
--
nicktelford commented on PR #15105:
URL: https://github.com/apache/kafka/pull/15105#issuecomment-1873934211
@cadonna @mjsax @ableegoldman @lucasbru @wcarlson5 @bbejeck @vvcephei
@guozhangwang
This is part of KIP-892, and has been broken out into a separate PR to
reduce the review
nicktelford opened a new pull request, #15105:
URL: https://github.com/apache/kafka/pull/15105
To support future use-cases that use different strategies for accessing
RocksDB, we need to de-couple the RocksDB access strategy from the Column
Family access strategy.
To do this, we now
tinaselenge commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1439373207
##
clients/src/test/java/org/apache/kafka/common/config/provider/DirectoryConfigProviderTest.java:
##
@@ -83,27 +89,27 @@ public void close() throws IOException {
tinaselenge commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1439364385
##
clients/src/test/java/org/apache/kafka/common/config/provider/FileConfigProviderTest.java:
##
@@ -98,8 +117,91 @@ public void testServiceLoaderDiscovery() {
[
https://issues.apache.org/jira/browse/KAFKA-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801744#comment-17801744
]
Divij Vaidya commented on KAFKA-16074:
--
https://github.com/apache/kafka/pull/15077
> Fix thread
Divij Vaidya created KAFKA-16074:
Summary: Fix thread leaks in ReplicaManagerTest
Key: KAFKA-16074
URL: https://issues.apache.org/jira/browse/KAFKA-16074
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-16072:
-
Fix Version/s: 3.8.0
> Create Junit 5 extension to detect thread leak
>
divijvaidya commented on PR #15101:
URL: https://github.com/apache/kafka/pull/15101#issuecomment-1873898677
Thank you for the change @wernerdv . As a next step, we need to fix the
leaks that were detected by this PR before merging this. I already know of at
least two PRs that will help:
divijvaidya commented on PR #15093:
URL: https://github.com/apache/kafka/pull/15093#issuecomment-1873868215
Thank you for the review @showuon. I believe I have fixed all indentation
problems now.
--
This is an automated message from the Apache Git Service.
To respond to the message,
divijvaidya merged PR #14798:
URL: https://github.com/apache/kafka/pull/14798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #15096:
URL: https://github.com/apache/kafka/pull/15096#issuecomment-1873828040
> I do not completely understand how the consumer subscription can reflect
the topic deletion while Streams has still references to the deleted topic. The
update to the subscription
showuon commented on code in PR #15093:
URL: https://github.com/apache/kafka/pull/15093#discussion_r1439274094
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2055,8 +2058,8 @@ class KafkaApisTest {
responseCallback.capture(),
showuon commented on code in PR #15093:
URL: https://github.com/apache/kafka/pull/15093#discussion_r1439274094
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2055,8 +2058,8 @@ class KafkaApisTest {
responseCallback.capture(),
showuon commented on code in PR #15093:
URL: https://github.com/apache/kafka/pull/15093#discussion_r1439274938
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2410,8 +2413,8 @@ class KafkaApisTest {
responseCallback.capture(),
1 - 100 of 101 matches
Mail list logo
