Re: [josm-dev] License Change Plugin slows down drawing

2012-01-11 Thread Paul Hartmann
On 01/10/2012 11:23 PM, Frederik Ramm wrote: Hi, whenver a license change layer is active and you have lots of objects loaded, JOSM becomes noticeably slower. I could use a little help here. Since many of you have tweaked JOSM's drawing performance in the past, maybe you only need to

[josm-dev] License Change Plugin slows down drawing

2012-01-10 Thread Frederik Ramm
Hi, whenver a license change layer is active and you have lots of objects loaded, JOSM becomes noticeably slower. I could use a little help here. Since many of you have tweaked JOSM's drawing performance in the past, maybe you only need to take a quick look at this drawing code

Re: [josm-dev] License change plugin

2011-07-07 Thread Frederik Ramm
Hi, On 07/02/11 14:50, Stephan Knauss wrote: The doCheck() in BasicLicenseCheck is in my opinion not right regarding nodes that have no tags. As all information these nodes carry is their existence and coordinates I see no reason why any other status than the one of the last editor of that node

Re: [josm-dev] License change plugin

2011-07-07 Thread Dirk Stöcker
On Thu, 7 Jul 2011, Frederik Ramm wrote: On 07/02/11 14:50, Stephan Knauss wrote: The doCheck() in BasicLicenseCheck is in my opinion not right regarding nodes that have no tags. As all information these nodes carry is their existence and coordinates I see no reason why any other status

Re: [josm-dev] License change plugin

2011-07-07 Thread Stephan Knauss
Hello Dirk, On 07.07.2011 14:49, Dirk Stöcker wrote: That would be wrong. I'm not sure if he described it that way, but the condition must be: * no tags of previous editors are included in the current node (which is true for untagged nodes) and * the position of the node is different. I think

Re: [josm-dev] License change plugin

2011-07-07 Thread Frederik Ramm
Hi, Stephan Knauss wrote: Am I right to assume that without inspecting the full history of a node we can not know what caused the new version? Yes. And looking and the full history is always an expensive operation, hence the plugin relies on the wtfe.gryph.de service and that, in turn, has

Re: [josm-dev] License change plugin

2011-07-07 Thread Stephan Knauss
On 07.07.2011 23:16, Frederik Ramm wrote: * All versions of an element are clean, so the whole element is considered clean (green). I think that clean elements should not be marked at all. Clean is the default; no action is required on a clean element. Yes, in some areas this is already the

Re: [josm-dev] License change plugin

2011-07-07 Thread Frederik Ramm
Hi, Stephan Knauss wrote: For the undecided there is still hope. About 100 user agree each day. http://ni.kwsn.net/~toby/OSM/license_count.html The declined, too, can still redecide, and at least we have a sign of life from them whereas for the undecided we don't even know if they still

Re: [josm-dev] License change plugin

2011-07-04 Thread Jo
I downloaded v4201, but I can't seem to find this licensing plugin in the list of plugins. I'd like to experiment with it. Do I need to add another repository or install it manually, somehow? Jo 2011/7/3 Willi wil...@gmx.de Frederik Ramm [mailto:frede...@remote.org] wrote at 2. July 2011 23:11

Re: [josm-dev] License change plugin

2011-07-02 Thread Dirk Stöcker
On Sat, 2 Jul 2011, Frederik Ramm wrote: The plugin still has a bug where newly created objects are flagged as problematic, but other than that it would be good to be released to the public (given that Potlatch meanwhile has the same functionality - and we don't want to fall behind, do we ;)

Re: [josm-dev] License change plugin

2011-07-02 Thread Stephan Knauss
Hi Frederik, On 02.07.2011 16:12, Frederik Ramm wrote: The tool is doing background data requests. It should provide some feedback to the user regarding this. It shouldn't be doing background data requests, only send a request when you explicitly ask for it. Yes, but then the request is

Re: [josm-dev] License change plugin

2011-07-02 Thread Frederik Ramm
Hi, Stephan Knauss wrote: It shouldn't be doing background data requests, only send a request when you explicitly ask for it. Yes, but then the request is running asynchronous in the background. There is no visible user feedback the request is still running. If your server has problems and

Re: [josm-dev] License change plugin

2011-07-02 Thread Paul Hartmann
On 07/02/2011 06:11 PM, Frederik Ramm wrote: Maybe we should do away with the distinction between non-agreeing and undecided users; anyone who is still undecided today is probably very likely to be unreachable and thus this would be a clear data loss. There are imports, where the license

Re: [josm-dev] License change plugin

2011-07-02 Thread Willi
Frederik Ramm [mailto:frede...@remote.org] wrote at 2. July 2011 23:11 Maybe we should just rename stuff in the interface then: red = first version created by non-agreeing user, orange = first version created by undecided user, yellow = later version created by non-agreeing or undecided

Re: [josm-dev] License change plugin

2011-07-01 Thread Frederik Ramm
Hi, Frederik Ramm wrote: I have just committed a first alpha of a license change plugin (svn.openstreetmap.org/applications/editors/josm/plugins/licensechange). The plugin still has a bug where newly created objects are flagged as problematic, but other than that it would be good to be

[josm-dev] License change plugin

2011-05-06 Thread Frederik Ramm
Devs, I have just committed a first alpha of a license change plugin (svn.openstreetmap.org/applications/editors/josm/plugins/licensechange). It is a blatant rip-off of the validator plugin and works much like it, only that instead of data errors it checks for license change agreement by

Re: [josm-dev] License change plugin

2011-05-06 Thread Dermot McNally
On 6 May 2011 22:55, Frederik Ramm frede...@remote.org wrote:   I have just committed a first alpha of a license change plugin (svn.openstreetmap.org/applications/editors/josm/plugins/licensechange). Great! This is a tool I've wanted for quite a while. It seems to be doing what it's supposed