Re: ReviewBoard and our workflow

2014-09-11 Thread Frank Mueller
For switching to a new tool and a new workflow I would like to not simply discuss it in a somehow undefined way together with subjunctive terms (Everybody should now ...) here via mail. Please lets fix the workflow in a how-to-contribute.md in juju/doc/contributions, so that we easily can point

Re: ReviewBoard and our workflow

2014-09-11 Thread Eric Snow
. Otherwise I'll do it. Hi Frank, I was planning on updating https://github.com/juju/juju/blob/master/CONTRIBUTING.md once I felt comfortable with how reviewboard fit into our workflow. Do you think something in juju/doc/contributions, which perhaps elaborates on the info in CONTRIBUTING.md, would

Re: ReviewBoard and our workflow

2014-09-11 Thread Frank Mueller
​Hi Eric, I was planning on updating https://github.com/juju/juju/blob/master/CONTRIBUTING.md once I felt comfortable with how reviewboard fit into our workflow. Do you think something in juju/doc/contributions, which perhaps elaborates on the info in CONTRIBUTING.md, would be a worthy

Re: ReviewBoard and our workflow

2014-09-10 Thread Menno Smits
Thanks Eric! I've used Reviewboard at a previous job and I'm fairly sure that it aligns better with the way the Juju Core team likes to work than Github's review features. Two questions: 1. Is this what we're supposed to be doing from right now? 2. I'm pretty sure some configuration of the rbt

Re: ReviewBoard and our workflow

2014-09-10 Thread Eric Snow
On Wed, Sep 10, 2014 at 3:34 PM, Menno Smits menno.sm...@canonical.com wrote: Thanks Eric! I've used Reviewboard at a previous job and I'm fairly sure that it aligns better with the way the Juju Core team likes to work than Github's review features. Two questions: 1. Is this what we're