Running CI tests locally.

2015-05-19 Thread Jesse Meek
Hi All, tl;dr bash script to run CI deploy job locally: https://github.com/waigani/juju-scripts/blob/master/ci.sh During the last sprint I showed a script which checks out the CI tools and runs the tests locally. The link to the script and slides have been in the sprint notes doc. As a few

bugs, fixes and targeting Juju versions

2015-05-04 Thread Jesse Meek
Hi All, tl;dr `git diff --no-prefix master diff.patch; patch -p0 diff.patch` is useful for landing bug fixes in different versions of juju. As a lot of us are currently bug hunting and needing to land fixes in multiple versions of Juju, I thought I'd share my process of doing that (maybe

Re: bugs, fixes and targeting Juju versions

2015-05-04 Thread Jesse Meek
should be made for 1.24 and the cherry picked onto a branch made from master. On 5 May 2015 at 13:15, Tim Penhey tim.pen...@canonical.com mailto:tim.pen...@canonical.com wrote: git cherry-pick does this as a git command. Tim On 05/05/15 13:03, Jesse Meek wrote: Hi All

Re: previously valid amazon environment now invalid?

2015-04-28 Thread Jesse Meek
Hi Nate, I looked into your bug. The default value for control-bucket was not being set. Here's a PR to fix: http://reviews.vapour.ws/r/1512/ Cheers, Jess On 29/04/15 06:41, Nate Finch wrote: No one seems to be answering my actual question. That error message seems new. Is it? Either

Re: Reviewboard - dependant branches

2014-12-17 Thread Jesse Meek
On 18/12/14 03:01, John Weldon wrote: Can someone remind me of the process for proposing branches that depend on another branch that is still in review? I know it's been discussed here and on irc before, but I don't recall the specifics. I think that the steps are: 1. Just propose the

Could someone double check this please

2014-11-26 Thread Jesse Meek
After upgrading from 1.20.12-trusty-amd64 to master (commit 2807fed7fad5619079c98ea105674d8a724d2e66), all unit logs continually spew errors similar to the following: // ~/.juju/local/log/unit-mysql-0.log 2014-11-26 09:09:07 ERROR juju.worker runner.go:219 exited uniter: failed to initialize

It's Friday, results are in on spaces issue

2014-11-20 Thread Jesse Meek
http://reviews.vapour.ws/r/509/ -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: It's Friday, results are in on spaces issue

2014-11-20 Thread Jesse Meek
of this issue/discussion. On 21/11/14 09:40, Tim Penhey wrote: I'm +1 on dropping it. On 21/11/14 09:29, Nate Finch wrote: Oh come on. I thought there was agreement to just drop this? On Thu, Nov 20, 2014 at 3:26 PM, Jesse Meek jesse.m...@canonical.com mailto:jesse.m...@canonical.com wrote: http

Too space, or not two space

2014-11-18 Thread Jesse Meek
I'm coming across double spaces after a full stop in comments. Some consider this an error, others an intentional style that makes the comment cleaner to read. Yes, it's a minor point but in the name of consistency and avoiding future review ping pong on the issue, I'm calling for a vote:

Re: Too space, or not two space

2014-11-18 Thread Jesse Meek
of the rule, I can’t stop you. But per­sonal taste doesn’t make the rule evap­o­rate. It’s like say­ing “I don’t like how sub­junc­tive-mood verbs sound, so I’m never go­ing to use them.” On Wed, Nov 19, 2014 at 11:10 AM, Jesse Meek jesse.m...@canonical.com wrote: I'm coming across double spaces after

reviewboard - most recent diff by default?

2014-10-27 Thread Jesse Meek
Is possible and preferable to show the most recent diff by default? -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Is ReviewBoard a good thing?

2014-09-20 Thread Jesse Meek
On 20/09/14 02:34, Eric Snow wrote: On Thu, Sep 18, 2014 at 6:19 PM, Jesse Meek jesse.m...@canonical.com wrote: We moved to GitHub in the hope of lowering the bar to contributors outside the team. GitHub is *the* platform and process for open source software. This was the logic behind the move

Is ReviewBoard a good thing?

2014-09-18 Thread Jesse Meek
We moved to GitHub in the hope of lowering the bar to contributors outside the team. GitHub is *the* platform and process for open source software. This was the logic behind the move. It was deemed to have the most mindshare and we sacrificed our prefered platform and process to be part of

Testing the API server

2014-09-11 Thread Jesse Meek
Hi List, The API server client tests have a new suite, serverSuite, which allow you to test the api server methods without having to go through the api client. This is how to use it: // old way func (s *clientSuite) TestSomething(c *gc.C) { ... // calls via api/client err :=

Re: Copyright information in headers

2014-09-03 Thread Jesse Meek
I've been asking for updates in my reviews. I'm happy to stop if the consensus is we don't need to. Once we get an agreement on policy, let's put it in the style guide. On 04/09/14 09:55, Gustavo Niemeyer wrote: I suggest not updating it. Updates on the same line will conflict, and cause

And now for my next trick ...

2014-07-16 Thread Jesse Meek
After checking the import grouping I became curious as to what else I could check. So, while on holiday, I wrote another script to check if errors are being discarded. It uses the ast package to check for both assignment statements, where a value of type error is being assigned to a variable

And now for my next trick ...

2014-07-16 Thread Jesse Meek
After checking the import grouping I became curious as to what else I could check. So, while on holiday, I wrote another script to check if errors are being discarded. It uses the ast package to check for both assignment statements, where a value of type error is being assigned to a variable

Re: Thoughts to keep in mind for Code Review

2014-06-24 Thread Jesse Meek
+1 on annotations. Would a tag be useful to disambiguate from comments intended to stay in the PR? On 25/06/14 16:20, John Meinel wrote: An interesting article from IBM: http://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ There is a pretty strong bias

jujubot build #

2014-06-12 Thread Jesse Meek
Would it be much work to get the jujubot to report the build number when it accepts a merge request? i.e. Status: merge request accepted. Build#:125, Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju Would it be something that others would find useful? -- Juju-dev mailing list

$ juju switch --format

2014-06-05 Thread Jesse Meek
I have a branch proposed that displays extra environment information when the --format flag is used with switch e.g: $ juju switch local --format yaml environ-name: local previous-environ-name: ec2 state-servers: - example.com - kremvax.ru username: joe There is some debate over this.

add dependencies step to github readme?

2014-06-03 Thread Jesse Meek
After running: go get -v github.com/juju/core/... I got: ../../github.com/juju/core/testing/imports.go:17: undefined: github.com/juju/testing.FindImports which was resolved by updating my dependencies with godeps. Shouldn't we add godeps -u dependencies.tsv as a step in the readme? --

moving bzr wip branch to git

2014-06-03 Thread Jesse Meek
So the command that worked for me (thanks for the help Tim) was: ~/go/src/github.com/juju/juju$ (cd ~/go/src/launchpad.net/juju-core bzr diff --color=never -r ancestor::parent) | patch -p0 --merge -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: