Re: [PATCH] repository 'latest changes': truncate first line to avoid table bleed

2015-02-19 Thread Thomas De Schampheleire
On Thu, Feb 19, 2015 at 5:01 PM, Mads Kiilerich wrote: > On 02/19/2015 01:36 PM, Thomas De Schampheleire wrote: >> >> For commit messages with the first line being very long, the 'latest >> changes' >> table on the repository overview page can 'bleed', so that the commit >> number >> overlaps with

[PATCH v2] repository summary: avoid table bleed on long commit messages

2015-02-19 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire # Date 1424381993 -3600 # Thu Feb 19 22:39:53 2015 +0100 # Node ID f5897d3eddf183efb8a9ea1ab29f2d2792936840 # Parent 1619d9ebc1b9b40379c192ddb45e5802ecfb8f2b repository summary: avoid table bleed on long commit messages For commit messages

Re: pull requests: variable names

2015-02-19 Thread Nick Coghlan
On 20 February 2015 at 01:47, Mads Kiilerich wrote: > > [Bitbucket do not show a diff from the ancestor. They try to do an in memory > merge and show the diff from the target/destination head, often with > unreadable conflict markers. I don't like that.] > > /Mads Atlassian actually posted a nice

Re: Commits from Unity to mainline

2015-02-19 Thread Nick Coghlan
On 19 February 2015 at 23:47, Thomas De Schampheleire wrote: > Of all the tools we have looked at (Crucible, Phabricator, > CodeCollaborator, reviewboard, Kallithea), only Kallithea properly > supports per-commit review, with a mercurial backend. Per-commit reviews are one of my favourite feature

Re: [PATCH] repository 'latest changes': truncate first line to avoid table bleed

2015-02-19 Thread Mads Kiilerich
On 02/19/2015 01:36 PM, Thomas De Schampheleire wrote: For commit messages with the first line being very long, the 'latest changes' table on the repository overview page can 'bleed', so that the commit number overlaps with the commit status. Commit 15cb8156b10d732cf39b37a88c656894621c0f54 chang

Re: pull requests: variable names

2015-02-19 Thread Mads Kiilerich
On 02/19/2015 01:32 PM, Thomas De Schampheleire wrote: On Thu, Feb 19, 2015 at 11:07 AM, Nick Coghlan wrote: On 17 February 2015 at 13:13, Mads Kiilerich wrote: On 02/14/2015 09:36 PM, Thomas De Schampheleire wrote: Hi, In the pull request code (both controllers and templates) I find the va

Re: pull requests: variable names

2015-02-19 Thread Mads Kiilerich
On 02/19/2015 11:07 AM, Nick Coghlan wrote: - c.cs_repo: what does 'cs' stand for here? This could become src_repo 'cs' is for changesets, referring to the side where the changes happened. I think the advantage of the current naming is that it refers to what it _is_ not to what we might happ

Re: Commits from Unity to mainline

2015-02-19 Thread Thomas De Schampheleire
On Thu, Feb 19, 2015 at 1:59 PM, Mads Kiilerich wrote: > On 02/19/2015 11:13 AM, Nick Coghlan wrote: >> >> On 18 February 2015 at 13:14, Mads Kiilerich wrote: >>> >>> What do others say; would you like to have the "don't add repo owner as >>> reviewer in all PRs" change in Kallithea? >> >> While

Re: Commits from Unity to mainline

2015-02-19 Thread Mads Kiilerich
On 02/19/2015 11:13 AM, Nick Coghlan wrote: On 18 February 2015 at 13:14, Mads Kiilerich wrote: What do others say; would you like to have the "don't add repo owner as reviewer in all PRs" change in Kallithea? While we're still in the early stages of a comparison between Kallithea & Phabricato

[PATCH] repository 'latest changes': truncate first line to avoid table bleed

2015-02-19 Thread Thomas De Schampheleire
For commit messages with the first line being very long, the 'latest changes' table on the repository overview page can 'bleed', so that the commit number overlaps with the commit status. Commit 15cb8156b10d732cf39b37a88c656894621c0f54 changed the initial truncate on 50 characters to a chop at the

Re: pull requests: variable names

2015-02-19 Thread Thomas De Schampheleire
On Thu, Feb 19, 2015 at 11:07 AM, Nick Coghlan wrote: > On 17 February 2015 at 13:13, Mads Kiilerich wrote: >> On 02/14/2015 09:36 PM, Thomas De Schampheleire wrote: >>> >>> Hi, >>> >>> In the pull request code (both controllers and templates) I find the >>> variable names non-intuitive and it is

Re: Kallithea internals overview

2015-02-19 Thread Nick Coghlan
On 19 February 2015 at 13:21, Mads Kiilerich wrote: >>> bcrypt: password hashing > > > This area is weird. On windows we don't use bcrypt but just hash the > password. Weird that it use different and compatible methods on different > platforms. Bad that windows use an insecure method (can be attac

Re: Commits from Unity to mainline

2015-02-19 Thread Nick Coghlan
On 18 February 2015 at 13:14, Mads Kiilerich wrote: > What do others say; would you like to have the "don't add repo owner as > reviewer in all PRs" change in Kallithea? While we're still in the early stages of a comparison between Kallithea & Phabricator, I suspect this would be useful if I end

Re: pull requests: variable names

2015-02-19 Thread Nick Coghlan
On 17 February 2015 at 13:13, Mads Kiilerich wrote: > On 02/14/2015 09:36 PM, Thomas De Schampheleire wrote: >> >> Hi, >> >> In the pull request code (both controllers and templates) I find the >> variable names non-intuitive and it is therefore harder to make >> changes. > > > I have tried to mak