Re: [PATCH 1 of 1 v2] login: preserve GET arguments throughout login redirection (issue #104)

On June 4, 2015 6:55:30 PM CEST, Mads Kiilerich wrote: >On 05/31/2015 01:41 PM, Thomas De Schampheleire wrote: >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1432065035 -7200 >> # Tue May 19 21:50:35 2015 +0200 >> # Node ID 20bf71e

Re: Making pytest the standard test suite (instead of nose)

Hi Brianna, all, On Tue, Jun 2, 2015 at 6:34 PM, Thomas De Schampheleire wrote: > On June 2, 2015 4:10:19 PM CEST, Brianna Laugher > wrote: >>On 31 May 2015 at 12:57, Thomas De Schampheleire >>>> wrote: >> >>> Hi, >>> >>> I've b

Re: [PATCH 2 of 6 v2] helpers: add automatic logging to Flash

Hi Mads, Seems I never replied to this feedback... On Tue, May 12, 2015 at 2:46 AM, Mads Kiilerich wrote: > On 05/10/2015 08:22 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1427573281 -3600 >> #

Re: Making pytest the standard test suite (instead of nose)

On Thu, Jun 4, 2015 at 10:53 PM, Brianna Laugher wrote: > ...And you don't get failures from running > KALLITHEA_WHOOSH_TEST_DISABLE=1 KALLITHEA_NO_TMP_PATH=1 nosetests > kallithea/tests/functional/ > ? Because I do. > > Ran 383 tests in 125.998s > FAILED (SKIP=5, errors=10, failures=19) > > I put

Re: Making pytest the standard test suite (instead of nose)

On Fri, Jun 5, 2015 at 9:46 PM, Thomas De Schampheleire wrote: > On Thu, Jun 4, 2015 at 10:53 PM, Brianna Laugher > wrote: >> ...And you don't get failures from running >> KALLITHEA_WHOOSH_TEST_DISABLE=1 KALLITHEA_NO_TMP_PATH=1 nosetests >> kallithea/tests/

Re: Making pytest the standard test suite (instead of nose)

On June 6, 2015 7:29:23 AM CEST, Andrew Shadura wrote: >Hello, > >On Tue, 2 Jun 2015 08:49:28 +0200 >Andrew Shadura wrote: > >> > I've been using pytest for a while now, and think we should >consider >> > making it the default test suite instead of nose. > >> Meanwhile, neither nose nor pytest wo

Re: [PATCH 1 of 1 v2] login: preserve GET arguments throughout login redirection (issue #104)

On Sat, Jun 6, 2015 at 10:28 PM, Mads Kiilerich wrote: > On 06/04/2015 07:40 PM, Thomas De Schampheleire wrote: >> >> On June 4, 2015 6:55:30 PM CEST, Mads Kiilerich >> wrote: >>> >>> On 05/31/2015 01:41 PM, Thomas De Schampheleire wrote: >>>&

[PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

# HG changeset patch # User Thomas De Schampheleire # Date 1432734170 -7200 # Wed May 27 15:42:50 2015 +0200 # Node ID d63188974baec38503601ef0efd33a75711280a2 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 comments: remove dysfunctional comment bubble on compare and file views (issue

[PATCH] style: prefer Lucida Console over Consolas font

# HG changeset patch # User Thomas De Schampheleire # Date 1432739913 -7200 # Wed May 27 17:18:33 2015 +0200 # Node ID 42feaacb78feecb2a07a3ca19db6cf7ace3fd4c1 # Parent d63188974baec38503601ef0efd33a75711280a2 style: prefer Lucida Console over Consolas font The letter l and the number 1

[PATCH 2 of 2 v3] changeset: reduce log level of stack trace on innocent exceptions

# HG changeset patch # User Thomas De Schampheleire # Date 1434003494 -7200 # Thu Jun 11 08:18:14 2015 +0200 # Node ID a0f1f38814a3c323488a3faa8fbd975e583aa7c5 # Parent 4f3f6762ad6403b42919b61912bd234ad9a488ec changeset: reduce log level of stack trace on innocent exceptions When the user

[PATCH 1 of 2 v3] helpers: add automatic logging of Flash messages shown to users

# HG changeset patch # User Thomas De Schampheleire # Date 1427573281 -3600 # Sat Mar 28 21:08:01 2015 +0100 # Node ID 4f3f6762ad6403b42919b61912bd234ad9a488ec # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 helpers: add automatic logging of Flash messages shown to users Log all messages

[PATCH] notification: use Sender and From header to clarify comment and pull request mails

dditionally, add the changeset/pullrequest description in the subject. [Thomas De Schampheleire: - extend commit message - update after threading requirements described in commit 8d45a14d3191 ] diff --git a/kallithea/lib/celerylib/tasks.py b/kallithea/lib/celerylib/tasks.py --- a/kallithea/li

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

On June 12, 2015 11:41:30 PM CEST, Mads Kiilerich wrote: >On 06/12/2015 09:09 PM, Thomas De Schampheleire wrote: >> # HG changeset patch >> # User Cedric De Herdt >> # Date 1434135934 -7200 >> # Fri Jun 12 21:05:34 2015 +0200 >> # Node ID c9c5310da1771baed04

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

On June 12, 2015 11:45:31 PM CEST, Mads Kiilerich wrote: >On 06/11/2015 10:59 AM, Thomas De Schampheleire wrote: >> # HG changeset patch >> # User Thomas De Schampheleire > >> # Date 1432734170 -7200 >> # Wed May 27 15:42:50 2015 +0200 >> # Node ID d631

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

On June 13, 2015 11:05:09 AM CEST, Mads Kiilerich wrote: >On 06/13/2015 08:41 AM, Thomas De Schampheleire wrote: > >On 06/13/2015 08:41 AM, Thomas De Schampheleire wrote: >> On June 12, 2015 11:41:30 PM CEST, Mads Kiilerich > wrote: >>> On 06/12/2015 09:09 PM, Th

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

Hi Mads, On Fri, Jun 12, 2015 at 11:41 PM, Mads Kiilerich wrote: > On 06/12/2015 09:09 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Cedric De Herdt >> # Date 1434135934 -7200 >> # Fri Jun 12

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

On Mon, Jun 15, 2015 at 2:10 PM, Mads Kiilerich wrote: > On 06/14/2015 09:05 PM, Thomas De Schampheleire wrote: >> >> Hi Mads, >> >> On Fri, Jun 12, 2015 at 11:41 PM, Mads Kiilerich >> wrote: >>> >>> Anyway, how about a first patch that re

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

On Tue, Jun 16, 2015 at 8:31 PM, Jan Heylen wrote: > # HG changeset patch > # User Jan Heylen > # Date 1434479490 -7200 > # Tue Jun 16 20:31:30 2015 +0200 > # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 > # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 > backout "pullrequests: don't

[PATCH] pullrequests: detect invalid reviewers and raise HTTPBadRequest

# HG changeset patch # User Thomas De Schampheleire # Date 1434282495 -7200 # Sun Jun 14 13:48:15 2015 +0200 # Node ID ad0534276417535724301a0c84ced272940456c1 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 pullrequests: detect invalid reviewers and raise HTTPBadRequest Normally, the

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

On Wed, Jun 17, 2015 at 7:40 AM, Jan Heylen wrote: > What I also wanted to say is that the original change is most probably > not the issue, it just triggers an underlying issue... > > What I observed: > our kallithea repo: > * the issue is still seen on the tip of the default branch > * the issue

[PATCH] routing: remove dysfunctional route to pullrequest copy_update

# HG changeset patch # User Thomas De Schampheleire # Date 1434540240 -7200 # Wed Jun 17 13:24:00 2015 +0200 # Node ID 65b5afb58a7b32b57c711c0ee3dc0fe949d5ec56 # Parent 5fb4e6f884cec710b34736756d4eadaa53dd51d0 routing: remove dysfunctional route to pullrequest copy_update Commit

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

On Wed, Jun 17, 2015 at 1:23 AM, Mads Kiilerich wrote: > On 06/13/2015 08:46 AM, Thomas De Schampheleire wrote: >> >> On June 12, 2015 11:45:31 PM CEST, Mads Kiilerich >> wrote: >>> >>> On 06/11/2015 10:59 AM, Thomas De Schampheleire wrote: >>>&

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

On Wed, Jun 17, 2015 at 12:27 AM, Mads Kiilerich wrote: > On 06/15/2015 04:23 PM, Thomas De Schampheleire wrote: >> >> On Mon, Jun 15, 2015 at 2:10 PM, Mads Kiilerich >> wrote: >>> >>> On 06/14/2015 09:05 PM, Thomas De Schampheleire wrote: >>>>

[PATCH v2] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

# HG changeset patch # User Thomas De Schampheleire # Date 1434609967 -7200 # Thu Jun 18 08:46:07 2015 +0200 # Node ID 8edae8d388db2ba77e68abc95f4db954b396e9cc # Parent 5fb4e6f884cec710b34736756d4eadaa53dd51d0 comments: remove dysfunctional comment bubble on compare and file views (issue

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

On Wed, Jun 17, 2015 at 9:39 PM, Thomas De Schampheleire wrote: > On Wed, Jun 17, 2015 at 1:23 AM, Mads Kiilerich wrote: >> On 06/13/2015 08:46 AM, Thomas De Schampheleire wrote: >>> >>> On June 12, 2015 11:45:31 PM CEST, Mads Kiilerich >>> wrote: >>

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

On Thu, Jun 18, 2015 at 3:50 PM, Mads Kiilerich wrote: > On 06/17/2015 10:02 PM, Thomas De Schampheleire wrote: >> >> On Wed, Jun 17, 2015 at 12:27 AM, Mads Kiilerich >> wrote: >>> >>> On 06/15/2015 04:23 PM, Thomas De Schampheleire wrote: >>

Re: Talk on Kallithea at OSCON

On June 18, 2015 11:09:48 PM CEST, Mads Kiilerich wrote: >On 06/04/2015 03:04 PM, Bradley M. Kuhn wrote: >> I am writing to let you all know that my talk on Kallithea was >accepted >> at OSCON: >> >http://www.oscon.com/open-source-2015/public/schedule/detail/42015 >> >> Some of you saw an earl

[PATCH 1 of 2] pullrequest: warn for duplication of reviewer handling with base.js

# HG changeset patch # User Thomas De Schampheleire # Date 1434721227 -7200 # Fri Jun 19 15:40:27 2015 +0200 # Node ID ea284e51ec2eb80cbf3d3552798b9a060d1746b1 # Parent a7ac467edbf5b71b4198f3e0e6b543c3fbb8cc47 pullrequest: warn for duplication of reviewer handling with base.js diff --git a

[PATCH 2 of 2] pullrequest: when adding a reviewer, show full name only

# HG changeset patch # User Thomas De Schampheleire # Date 1434721370 -7200 # Fri Jun 19 15:42:50 2015 +0200 # Node ID 90e982b6bca805a574f6dc7f7535169d827ea3fa # Parent ea284e51ec2eb80cbf3d3552798b9a060d1746b1 pullrequest: when adding a reviewer, show full name only Existing reviewers are

[PATCH 0 of 7] tests: remove hardcoded strings defined symbolically in kallithea/tests/__init__.py

Some trivial cleanups related to hardcoded strings in tests. ___ kallithea-general mailing list kallithea-general@sfconservancy.org http://lists.sfconservancy.org/mailman/listinfo/kallithea-general

[PATCH 5 of 7] tests: remove hardcoded test passwords

# HG changeset patch # User Thomas De Schampheleire # Date 1434830216 -7200 # Sat Jun 20 21:56:56 2015 +0200 # Node ID 95518c56b04c78511c7e003b6a02337e32d7c8e0 # Parent 359e871608759bf729ad8378be00f3a3bf677942 tests: remove hardcoded test passwords diff --git a/kallithea/tests/functional

[PATCH 4 of 7] tests: remove hardcoded test e-mail addresses

# HG changeset patch # User Thomas De Schampheleire # Date 1434832304 -7200 # Sat Jun 20 22:31:44 2015 +0200 # Node ID 359e871608759bf729ad8378be00f3a3bf677942 # Parent 087a949ad8b7d7ecd5416d5fca89ec2953f33eaf tests: remove hardcoded test e-mail addresses diff --git a/kallithea/tests

[PATCH 1 of 7] tests: remove hardcoded test_admin username

# HG changeset patch # User Thomas De Schampheleire # Date 1434829259 -7200 # Sat Jun 20 21:40:59 2015 +0200 # Node ID af8e9af347d94a8b996d9c649a4267d585dc3745 # Parent a7ac467edbf5b71b4198f3e0e6b543c3fbb8cc47 tests: remove hardcoded test_admin username diff --git a/kallithea/tests

[PATCH 2 of 7] tests: remove hardcoded test_regular2 username

# HG changeset patch # User Thomas De Schampheleire # Date 1434829395 -7200 # Sat Jun 20 21:43:15 2015 +0200 # Node ID f60ea96cc104a334e336e03c38c3d99b86f7f1a6 # Parent af8e9af347d94a8b996d9c649a4267d585dc3745 tests: remove hardcoded test_regular2 username diff --git a/kallithea/tests

[PATCH 6 of 7] tests: remove hardcoded reference to HG_REPO

# HG changeset patch # User Thomas De Schampheleire # Date 1434830876 -7200 # Sat Jun 20 22:07:56 2015 +0200 # Node ID 63ba8bff3323c303944c1fef9cf57eecd49890fa # Parent 95518c56b04c78511c7e003b6a02337e32d7c8e0 tests: remove hardcoded reference to HG_REPO diff --git a/kallithea/tests

[PATCH 3 of 7] tests: remove hardcoded test_regular username

# HG changeset patch # User Thomas De Schampheleire # Date 1434832009 -7200 # Sat Jun 20 22:26:49 2015 +0200 # Node ID 087a949ad8b7d7ecd5416d5fca89ec2953f33eaf # Parent f60ea96cc104a334e336e03c38c3d99b86f7f1a6 tests: remove hardcoded test_regular username diff --git a/kallithea/tests

[PATCH 7 of 7] tests: remove hardcoded reference to GIT_REPO

# HG changeset patch # User Thomas De Schampheleire # Date 1434831005 -7200 # Sat Jun 20 22:10:05 2015 +0200 # Node ID 153ef33bf4ee2d0067825618e1c0f53f37b3d071 # Parent 63ba8bff3323c303944c1fef9cf57eecd49890fa tests: remove hardcoded reference to GIT_REPO diff --git a/kallithea/tests

Re: [PATCH 0 of 7] tests: remove hardcoded strings defined symbolically in kallithea/tests/__init__.py

On Sat, Jun 20, 2015 at 11:50 PM, Mads Kiilerich wrote: > On 06/20/2015 10:37 PM, Thomas De Schampheleire wrote: >> >> Some trivial cleanups related to hardcoded strings in tests. > > > I think another school of thought is that tests should be as simple, static > a

Spurious test failure: test_create_notification

Hi, I'm seeing a spurious test failure on test_create_notification. Repeating the test makes it succeed. Is anyone seeing the same? Any ideas on the cause? I'm only starting to see this recently, so it must be caused by a. a test change b. switch to py.test (didn't try with nosetest yet) kalli

Re: Spurious test failure: test_create_notification

Hi, On Mon, Jun 22, 2015 at 9:59 AM, Thomas De Schampheleire wrote: > Hi, > > I'm seeing a spurious test failure on test_create_notification. > Repeating the test makes it succeed. > > Is anyone seeing the same? Any ideas on the cause? > > I'm only starting t

Re: Spurious test failure: test_create_notification

On Mon, Jun 22, 2015 at 12:19 PM, Thomas De Schampheleire wrote: > Hi, > > > On Mon, Jun 22, 2015 at 9:59 AM, Thomas De Schampheleire > wrote: >> Hi, >> >> I'm seeing a spurious test failure on test_create_notification. >> Repeating the test makes it s

[PATCH] tests: improve robustness of notifications tests

# HG changeset patch # User Thomas De Schampheleire # Date 1434977761 -7200 # Mon Jun 22 14:56:01 2015 +0200 # Node ID bba51160f25cb009bbc411d962532c2249716cb8 # Parent 9a23b444a7fefe5b67e57a42d26343787d992874 tests: improve robustness of notifications tests The notifications tests make

[PATCH 1 of 2] model: check for invalid users centrally

# HG changeset patch # User Thomas De Schampheleire # Date 1434984724 -7200 # Mon Jun 22 16:52:04 2015 +0200 # Node ID 68032f8bd7f52c676bb5143a03b0dfd5df242f0c # Parent 7303d0035d82a20f93df1c78b3358403b7ff9827 model: check for invalid users centrally Commit

[PATCH 2 of 2] pullrequest: internally use username iso userid when adding reviewers

# HG changeset patch # User Thomas De Schampheleire # Date 1434744060 -7200 # Fri Jun 19 22:01:00 2015 +0200 # Node ID 0e58e20f94d3a3fbb84f588397c2def50dd3b35d # Parent 68032f8bd7f52c676bb5143a03b0dfd5df242f0c pullrequest: internally use username iso userid when adding reviewers When using

Re: Spurious test failure: test_create_notification

On June 22, 2015 1:21:08 PM CEST, Mads Kiilerich wrote: >On 06/22/2015 12:19 PM, Thomas De Schampheleire wrote: >> Hi, >> >> >> On Mon, Jun 22, 2015 at 9:59 AM, Thomas De Schampheleire >> wrote: >>> Hi, >>> >>> I'm seeing a spu

Re: [PATCH 1 of 2] model: check for invalid users centrally

On Mon, Jun 22, 2015 at 7:05 PM, Mads Kiilerich wrote: > On 06/22/2015 06:45 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1434984724 -7200 >> # Mon Jun 22 16:52:04 2015 +0200 >> # Node ID 6

Re: [PATCH 2 of 2] pullrequest: internally use username iso userid when adding reviewers

On Mon, Jun 22, 2015 at 7:21 PM, Mads Kiilerich wrote: > On 06/22/2015 06:45 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1434744060 -7200 >> # Fri Jun 19 22:01:00 2015 +0200 >> # Node ID 0

Re: [PATCH 1 of 2] model: check for invalid users centrally

On Tue, Jun 23, 2015 at 3:59 PM, Mads Kiilerich wrote: > On 06/22/2015 10:09 PM, Thomas De Schampheleire wrote: >> >> On Mon, Jun 22, 2015 at 7:05 PM, Mads Kiilerich >> wrote: >>> >>> On 06/22/2015 06:45 PM, Thomas De Schampheleire wrote: >>>&

[PATCH 2 of 4] user: fall back to username in full_name_and_username if no name set

# HG changeset patch # User Thomas De Schampheleire # Date 1435084091 -7200 # Tue Jun 23 20:28:11 2015 +0200 # Node ID 20f661572d9e67ada5021a9a660f2bf4c9ad6920 # Parent 0bd7300d815257423acca7984472d207676008cb user: fall back to username in full_name_and_username if no name set

[PATCH 3 of 4] pullrequest: re-add username when adding reviewers

# HG changeset patch # User Thomas De Schampheleire # Date 1435087755 -7200 # Tue Jun 23 21:29:15 2015 +0200 # Node ID b609779e357e262092c323bc63eebd569e9e1f36 # Parent 20f661572d9e67ada5021a9a660f2bf4c9ad6920 pullrequest: re-add username when adding reviewers Commit 90e982b6bca8 removed

[PATCH 4 of 4] autocomplete: consistently show 'username (Full Name)'

# HG changeset patch # User Thomas De Schampheleire # Date 1435088059 -7200 # Tue Jun 23 21:34:19 2015 +0200 # Node ID 08fff816a576b4a6a70499d2d40e8ee516db83d4 # Parent b609779e357e262092c323bc63eebd569e9e1f36 autocomplete: consistently show 'username (Full Name)' There are

[PATCH 1 of 4] user: rename property username_and_name into full_name_and_username

# HG changeset patch # User Thomas De Schampheleire # Date 1435083793 -7200 # Tue Jun 23 20:23:13 2015 +0200 # Node ID 0bd7300d815257423acca7984472d207676008cb # Parent 7303d0035d82a20f93df1c78b3358403b7ff9827 user: rename property username_and_name into full_name_and_username In analogy

Re: [PATCH 4 of 4] autocomplete: consistently show 'username (Full Name)'

On June 23, 2015 10:00:00 PM CEST, Thomas De Schampheleire wrote: ># HG changeset patch ># User Thomas De Schampheleire ># Date 1435088059 -7200 ># Tue Jun 23 21:34:19 2015 +0200 ># Node ID 08fff816a576b4a6a70499d2d40e8ee516db83d4 ># Parent b609779e357e262092c323

Re: [PATCH 4 of 4] autocomplete: consistently show 'username (Full Name)'

On June 24, 2015 5:45:23 PM CEST, Mads Kiilerich wrote: >On 06/24/2015 05:15 PM, Thomas De Schampheleire wrote: >> On June 23, 2015 10:00:00 PM CEST, Thomas De Schampheleire > wrote: >>> # HG changeset patch >>> # User Thomas De Schampheleire >>> # Date 14

[PATCH 01 of 19] autocomplete: remove dead code

# HG changeset patch # User Thomas De Schampheleire # Date 1435174346 -7200 # Wed Jun 24 21:32:26 2015 +0200 # Node ID 16fff695ace152d8f165b033980678a68e60822c # Parent 03dd2a5776400d58670071530910f7526d13d259 autocomplete: remove dead code The three blocks of autocomplete code are clearly

[PATCH 00 of 19] autocomplete cleanup / user name displaying

As discussed before, here is a thorough cleanup of the autocomplete JavaScript code, as preliminary for a rationalization of the way user names are displayed... This does not yet include the removal of all explicit uses of user.lastname in places that really should be using full_name, because it r

[PATCH 03 of 19] autocomplete: factor out matchGroups function

# HG changeset patch # User Thomas De Schampheleire # Date 1435259175 -7200 # Thu Jun 25 21:06:15 2015 +0200 # Node ID fca74929123428f02ade6d63c3f368368128619d # Parent 29390aec8d12021642c13741a57da8901be9a9a4 autocomplete: factor out matchGroups function diff --git a/kallithea/public/js

[PATCH 04 of 19] autocomplete: factor out highlightMatch function

# HG changeset patch # User Thomas De Schampheleire # Date 1435259401 -7200 # Thu Jun 25 21:10:01 2015 +0200 # Node ID e929bdac2f7c78849cb649279dfe93ae4761f52c # Parent fca74929123428f02ade6d63c3f368368128619d autocomplete: factor out highlightMatch function diff --git a/kallithea/public

[PATCH 02 of 19] autocomplete: factor out matchUsers function

# HG changeset patch # User Thomas De Schampheleire # Date 1435162968 -7200 # Wed Jun 24 18:22:48 2015 +0200 # Node ID 29390aec8d12021642c13741a57da8901be9a9a4 # Parent 16fff695ace152d8f165b033980678a68e60822c autocomplete: factor out matchUsers function diff --git a/kallithea/public/js

[PATCH 06 of 19] autocomplete: increase reuse of gravatar logic

# HG changeset patch # User Thomas De Schampheleire # Date 1435261054 -7200 # Thu Jun 25 21:37:34 2015 +0200 # Node ID 2bc67e169d2f80e67d9e32df023e4133d8049948 # Parent c3e99ca8affe70759f62658cdbc248eda297ae8f autocomplete: increase reuse of gravatar logic By splitting autocompleteGravatar

[PATCH 05 of 19] autocomplete: factor out _gravatar function

# HG changeset patch # User Thomas De Schampheleire # Date 1435259746 -7200 # Thu Jun 25 21:15:46 2015 +0200 # Node ID c3e99ca8affe70759f62658cdbc248eda297ae8f # Parent e929bdac2f7c78849cb649279dfe93ae4761f52c autocomplete: factor out _gravatar function (including rename of input arguments

[PATCH 14 of 19] autocomplete: misc cleanup

# HG changeset patch # User Thomas De Schampheleire # Date 1435692456 -7200 # Tue Jun 30 21:27:36 2015 +0200 # Node ID 88065e9e70e233fc2232ffeeaafadaee2698b766 # Parent f1d674589538cbf1c6d066b203016009d7c679b2 autocomplete: misc cleanup Some miscellaneous changes that didn't really f

[PATCH 17 of 19] user: fall back to username in full_name_and_username if no name set

# HG changeset patch # User Thomas De Schampheleire # Date 1435084091 -7200 # Tue Jun 23 20:28:11 2015 +0200 # Node ID 678e992671c1591c2a0afd4e181aa36909401654 # Parent c30928f2b0243029ebc3d14063da33a6f1d1313f user: fall back to username in full_name_and_username if no name set diff --git

[PATCH 11 of 19] autocomplete: remove redundant specification of responseSchema

# HG changeset patch # User Thomas De Schampheleire # Date 1435679709 -7200 # Tue Jun 30 17:55:09 2015 +0200 # Node ID 00a21b2c96879db000cb598df11d9671766869c2 # Parent 3d214cd2fdd8b6c24cd147127283a3ffe7bdc0de autocomplete: remove redundant specification of responseSchema

[PATCH 13 of 19] autocomplete: fix completion of repository owner

# HG changeset patch # User Thomas De Schampheleire # Date 1435592559 -7200 # Mon Jun 29 17:42:39 2015 +0200 # Node ID f1d674589538cbf1c6d066b203016009d7c679b2 # Parent 2d3ead418f13410650da664144462a54a0312163 autocomplete: fix completion of repository owner The owner field of a repository

[PATCH 08 of 19] autocomplete: clean up handlers for itemSelectEvent

# HG changeset patch # User Thomas De Schampheleire # Date 1435349220 -7200 # Fri Jun 26 22:07:00 2015 +0200 # Node ID 98519504e88827b408447efcb9ea01ca270a7b0b # Parent 623155b700e275d039d1a9065f272dc6fa4fb569 autocomplete: clean up handlers for itemSelectEvent The handlers that execute

[PATCH 16 of 19] user: show 'Firstname Lastname (username)'

# HG changeset patch # User Mads Kiilerich # Date 1435695184 -7200 # Tue Jun 30 22:13:04 2015 +0200 # Node ID c30928f2b0243029ebc3d14063da33a6f1d1313f # Parent 5ba77a9c9e3b7a309adb6a2d2b0e6aab1b303b75 user: show 'Firstname Lastname (username)' Additionally, clarify both full_name_or_usernam

[PATCH 12 of 19] autocomplete: introduce function to set up basic autocomplete functionality

# HG changeset patch # User Thomas De Schampheleire # Date 1435679620 -7200 # Tue Jun 30 17:53:40 2015 +0200 # Node ID 2d3ead418f13410650da664144462a54a0312163 # Parent 00a21b2c96879db000cb598df11d9671766869c2 autocomplete: introduce function to set up basic autocomplete functionality To

[PATCH 19 of 19] autocomplete: consistently show 'username (Full Name)'

# HG changeset patch # User Thomas De Schampheleire # Date 1435696257 -7200 # Tue Jun 30 22:30:57 2015 +0200 # Node ID b0620802d61a9a7b9bf4442ad0204ee8f8f53725 # Parent 1b989931c539d2ef2160eb9d2b5734d9c711d5ca autocomplete: consistently show 'username (Full Name)' diff --git a

[PATCH 15 of 19] user: rename property username_and_name into full_name_and_username

# HG changeset patch # User Thomas De Schampheleire # Date 1435083793 -7200 # Tue Jun 23 20:23:13 2015 +0200 # Node ID 5ba77a9c9e3b7a309adb6a2d2b0e6aab1b303b75 # Parent 88065e9e70e233fc2232ffeeaafadaee2698b766 user: rename property username_and_name into full_name_and_username In analogy

[PATCH 09 of 19] autocomplete: remove leftover 'cache' in PullRequestAutocomplete

# HG changeset patch # User Thomas De Schampheleire # Date 1435349533 -7200 # Fri Jun 26 22:12:13 2015 +0200 # Node ID d6d25547fc3ffc050212e5b4ec2c04478c6ebc03 # Parent 98519504e88827b408447efcb9ea01ca270a7b0b autocomplete: remove leftover 'cache' in PullRequestAutocomplete The c

[PATCH 18 of 19] pullrequest: re-add username when adding reviewers

# HG changeset patch # User Thomas De Schampheleire # Date 1435087755 -7200 # Tue Jun 23 21:29:15 2015 +0200 # Node ID 1b989931c539d2ef2160eb9d2b5734d9c711d5ca # Parent 678e992671c1591c2a0afd4e181aa36909401654 pullrequest: re-add username when adding reviewers Commit 90e982b6bca8 removed

[PATCH 07 of 19] autocomplete: factor out formatResult function

# HG changeset patch # User Thomas De Schampheleire # Date 1435261603 -7200 # Thu Jun 25 21:46:43 2015 +0200 # Node ID 623155b700e275d039d1a9065f272dc6fa4fb569 # Parent 2bc67e169d2f80e67d9e32df023e4133d8049948 autocomplete: factor out formatResult function Note: remove an irrelevant

[PATCH 10 of 19] autocomplete: remove redundant return in MembersAutoComplete

# HG changeset patch # User Thomas De Schampheleire # Date 1435349622 -7200 # Fri Jun 26 22:13:42 2015 +0200 # Node ID 3d214cd2fdd8b6c24cd147127283a3ffe7bdc0de # Parent d6d25547fc3ffc050212e5b4ec2c04478c6ebc03 autocomplete: remove redundant return in MembersAutoComplete Nobody is using

[PATCH] tests: hide database setup queries with pytest

# HG changeset patch # User Thomas De Schampheleire # Date 1435831639 -7200 # Thu Jul 02 12:07:19 2015 +0200 # Node ID a71b7c1c0efa80456ed9e85dcbba9990eaec154f # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 tests: hide database setup queries with pytest Unlike nosetest, pytest would

[PATCH 2 of 5] e-mail: send comment and pullrequest mails with the author's name in From

# HG changeset patch # User Thomas De Schampheleire # Date 1436471455 -7200 # Thu Jul 09 21:50:55 2015 +0200 # Node ID 95c18c5fdb59f2d985e2cd8ac6db093cb3e5f884 # Parent c22a219636b830bac4b6125b306f6c8506f81d99 e-mail: send comment and pullrequest mails with the author's name in From W

[PATCH 1 of 5] e-mail: describe and clarify e-mail settings in the ini file

# HG changeset patch # User Thomas De Schampheleire # Date 1436644666 -7200 # Sat Jul 11 21:57:46 2015 +0200 # Node ID c22a219636b830bac4b6125b306f6c8506f81d99 # Parent 4a3708db60aef76020f4fefacf861ee830abc564 e-mail: describe and clarify e-mail settings in the ini file Add some

[PATCH 3 of 5] e-mail: allow specifying a different noreply e-mail than app_email_from

# HG changeset patch # User Thomas De Schampheleire # Date 1436729808 -7200 # Sun Jul 12 21:36:48 2015 +0200 # Node ID bdca2f365e3feb81ba7329b8f42eada6a342a811 # Parent 95c18c5fdb59f2d985e2cd8ac6db093cb3e5f884 e-mail: allow specifying a different noreply e-mail than app_email_from The

[PATCH 5 of 5] e-mail: move branch information close to repository in mail subjects

# HG changeset patch # User Thomas De Schampheleire # Date 1436472369 -7200 # Thu Jul 09 22:06:09 2015 +0200 # Node ID fb662c5f01053122694080716216a6985c8b54f6 # Parent 46d77b6a81fb27aa9b7f247fed5138f1125ec019 e-mail: move branch information close to repository in mail subjects Move the

[PATCH 4 of 5] e-mail: remove user and add relevant title to subject of e-mails

# HG changeset patch # User Thomas De Schampheleire # Date 1436473046 -7200 # Thu Jul 09 22:17:26 2015 +0200 # Node ID 46d77b6a81fb27aa9b7f247fed5138f1125ec019 # Parent bdca2f365e3feb81ba7329b8f42eada6a342a811 e-mail: remove user and add relevant title to subject of e-mails For comment and

Re: [PATCH] tests: hide database setup queries with pytest

On Mon, Jul 13, 2015 at 7:52 PM, Mads Kiilerich wrote: > On 07/11/2015 09:06 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1435831639 -7200 >> # Thu Jul 02 12:07:19 2015 +0200 >> # Node ID a

Re: [PATCH 1 of 5] e-mail: describe and clarify e-mail settings in the ini file

On Mon, Jul 13, 2015 at 8:19 PM, Mads Kiilerich wrote: > On 07/13/2015 10:45 AM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1436644666 -7200 >> # Sat Jul 11 21:57:46 2015 +0200 >> # Node ID c

Re: [PATCH 2 of 5] e-mail: send comment and pullrequest mails with the author's name in From

On Mon, Jul 13, 2015 at 9:02 PM, Mads Kiilerich wrote: > On 07/13/2015 10:45 AM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1436471455 -7200 >> # Thu Jul 09 21:50:55 2015 +0200 >> # Node ID 9

Re: [PATCH 08 of 19] autocomplete: clean up handlers for itemSelectEvent

On Tue, Jul 14, 2015 at 12:57 PM, Mads Kiilerich wrote: > On 06/30/2015 10:43 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1435349220 -7200 >> # Fri Jun 26 22:07:00 2015 +0200 >> # Node ID 9

Re: [PATCH 08 of 19] autocomplete: clean up handlers for itemSelectEvent

On Tue, Jul 14, 2015 at 3:28 PM, Mads Kiilerich wrote: > On 07/14/2015 01:36 PM, Thomas De Schampheleire wrote: >> >> On Tue, Jul 14, 2015 at 12:57 PM, Mads Kiilerich >> wrote: >>> >>> On 06/30/2015 10:43 PM, Thomas De Schampheleire wrote: >>>&

Re: [PATCH 13 of 19] autocomplete: fix completion of repository owner

On July 16, 2015 8:35:13 PM CEST, Mads Kiilerich wrote: >On 07/16/2015 06:43 PM, Mads Kiilerich wrote: >> On Tue, Jun 30, 2015 at 10:43 PM, Thomas De Schampheleire >> mailto:patrickdeping...@gmail.com>> >wrote: >> >> # HG changeset patch &

[meta] Sending pullrequest and/or issue notifications from Bitbucket to the mailing list

Hi, Currently, the Kallithea mailing list does not receive e-mails when new pull requests for Kallithea are created on Bitbucket, nor when comments are added to such pullrequests, nor when issues are created or commented on. In my opinion, to grow a healthy Kallithea community, this should be cha

Re: [PATCH 13 of 19] autocomplete: fix completion of repository owner

On Thu, Jul 16, 2015 at 8:35 PM, Mads Kiilerich wrote: > On 07/16/2015 06:43 PM, Mads Kiilerich wrote: > > On Tue, Jun 30, 2015 at 10:43 PM, Thomas De Schampheleire > wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1435592559

Re: [PATCH 13 of 19] autocomplete: fix completion of repository owner

On Mon, Jul 20, 2015 at 3:17 PM, Mads Kiilerich wrote: > On 07/20/2015 02:00 PM, Thomas De Schampheleire wrote: >> >> On Thu, Jul 16, 2015 at 8:35 PM, Mads Kiilerich >> wrote: >>> >>> On 07/16/2015 06:43 PM, Mads Kiilerich wrote: >>> >>>

Re: [meta] Sending pullrequest and/or issue notifications from Bitbucket to the mailing list

On Mon, Jul 20, 2015 at 11:56 PM, Mads Kiilerich wrote: > On 07/18/2015 10:04 PM, Thomas De Schampheleire wrote: >> >> Currently, the Kallithea mailing list does not receive e-mails when >> new pull requests for Kallithea are created on Bitbucket, nor when >>

[PATCH 0 of 8] e-mail: initial cleanup/documentation

This is a first part of e-mail setting related cleanup, as driven by the feedback on my other e-mail setting related changes. This series does not change behavior, but rather documents and changes display of information on the admin page. This series, in particular the commit adding documentation

[PATCH 2 of 8] admin: e-mail: remove display of SMTP password

# HG changeset patch # User Thomas De Schampheleire # Date 1437508363 -7200 # Tue Jul 21 21:52:43 2015 +0200 # Node ID f219f0a41f57655dd2125c9371db9ee1ac217a4b # Parent 27fbaba10257132c1087a3dc7f7c2bdfd4b5ab9e admin: e-mail: remove display of SMTP password It is quite useless, and in a way

[PATCH 1 of 8] admin: remap/rescan: fix alignment of button

# HG changeset patch # User Thomas De Schampheleire # Date 1437594124 -7200 # Wed Jul 22 21:42:04 2015 +0200 # Node ID 27fbaba10257132c1087a3dc7f7c2bdfd4b5ab9e # Parent 82faecc2132459bf0ba2717f2178ce6b3672e268 admin: remap/rescan: fix alignment of button The 'Rescan repositories&#x

[PATCH 4 of 8] admin: e-mail: display settings as read-only input fields

# HG changeset patch # User Thomas De Schampheleire # Date 1437509310 -7200 # Tue Jul 21 22:08:30 2015 +0200 # Node ID c8e5401db62afbfe417a35b10189bf85aff97726 # Parent 07fc479b91cef2b8f6240d1b64baabdf3caebdc0 admin: e-mail: display settings as read-only input fields Using a definition

[PATCH 8 of 8] e-mail: clarify that smtp_use_ssl defaults to false

# HG changeset patch # User Thomas De Schampheleire # Date 1437061421 -7200 # Thu Jul 16 17:43:41 2015 +0200 # Node ID 5073d54eaac76411f8ab281892f58f4946d69334 # Parent c024931198851143a30a4e218bbc9d7ff70927e1 e-mail: clarify that smtp_use_ssl defaults to false Commented settings in

[PATCH 6 of 8] e-mail: remove unused setting error_message from ini files

# HG changeset patch # User Thomas De Schampheleire # Date 1437026960 -7200 # Thu Jul 16 08:09:20 2015 +0200 # Node ID f7b9681ad240d1ddd831f117b312cf24f67e33c5 # Parent be74730111dac1a1f1fcd51a274ae5b5a7a5f540 e-mail: remove unused setting error_message from ini files The ini files and

[PATCH 7 of 8] e-mail: add documentation about configuration settings to ini files

# HG changeset patch # User Thomas De Schampheleire # Date 1437061235 -7200 # Thu Jul 16 17:40:35 2015 +0200 # Node ID c024931198851143a30a4e218bbc9d7ff70927e1 # Parent f7b9681ad240d1ddd831f117b312cf24f67e33c5 e-mail: add documentation about configuration settings to ini files diff --git a

[PATCH 5 of 8] admin: e-mail: clarify e-mail settings a bit more

# HG changeset patch # User Thomas De Schampheleire # Date 1437593297 -7200 # Wed Jul 22 21:28:17 2015 +0200 # Node ID be74730111dac1a1f1fcd51a274ae5b5a7a5f540 # Parent c8e5401db62afbfe417a35b10189bf85aff97726 admin: e-mail: clarify e-mail settings a bit more Add some clarification to the

[PATCH 3 of 8] admin: e-mail: simplify list of settings to display

# HG changeset patch # User Thomas De Schampheleire # Date 1437508498 -7200 # Tue Jul 21 21:54:58 2015 +0200 # Node ID 07fc479b91cef2b8f6240d1b64baabdf3caebdc0 # Parent f219f0a41f57655dd2125c9371db9ee1ac217a4b admin: e-mail: simplify list of settings to display By centralizing the

Re: [PATCH 2 of 8] admin: e-mail: remove display of SMTP password

On Thu, Jul 23, 2015 at 2:11 PM, Mads Kiilerich wrote: > On 07/22/2015 09:50 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1437508363 -7200 >> # Tue Jul 21 21:52:43 2015 +0200 >> # Node ID f

<    1   2   3   4   5   6   7   8   9   10   >