Re: [kbuild] [regulator:topic/da9211 1/1] drivers/regulator/da9211-regulator.c:268 da9211_regulator_init() warn: variable dereferenced before check 'chip-pdata' (see line 260)

2014-07-15 Thread Dan Carpenter
= (chip-pdata-init_data[i]); Just delete it then. That way the code will make sense and be consistent. regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

[kbuild] [tty:tty-next 68/69] drivers/tty/serial/serial_core.c:2621 uart_add_one_port() warn: double check that we're allocating correct size: 4 vs 16

2014-07-22 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next head: aef9a7bd9b676f797dd5cefd43deb30d36b976a9 commit: 266dcff03eed0050b6af11aaf2a61ab837d7ba3f [68/69] Serial: allow port drivers to have a default attribute group New smatch warnings:

[kbuild] [jbarnes:fd-fences 1/1] drivers/gpu/drm/i915/i915_fence.c:308 i915_gem_fence_ioctl() warn: possible memory leak of 'intel_fence'

2014-07-22 Thread Dan Carpenter
[ mopping up remaining warnings from when I was on vacation -dan ] tree: git://people.freedesktop.org/~jbarnes/linux fd-fences head: 8291fca8b24b71f1db17126c71b2bff91f22aa0f commit: 8291fca8b24b71f1db17126c71b2bff91f22aa0f [1/1] drm/i915: add fence ioctl v2

Re: [kbuild] [gpio:for-next 14/19] drivers/gpio/gpiolib-sysfs.c:817:7-11: ERROR: iterator variable bound on line 816 cannot be NULL

2014-07-23 Thread Dan Carpenter
, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

Re: [kbuild] [ubifs:master 18/23] drivers/mtd/ubi/block.c:508 ubiblock_resize() error: potentially dereferencing uninitialized 'dev'.

2014-07-31 Thread Dan Carpenter
I sent this one earlier this morning. regards, dan carpenter On Thu, Jul 31, 2014 at 09:28:26PM +0800, kbuild test robot wrote: TO: Richard Weinberger rich...@nod.at CC: Artem Bityutskiy artem.bityuts...@linux.intel.com CC: Ezequiel Garcia ezequiel.gar...@free-electrons.com tree: git

[kbuild] [next:master 8911/10000] sound/soc/fsl/fsl_asrc.c:250 fsl_asrc_config_pair() warn: variable dereferenced before check 'config' (see line 243)

2014-08-01 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5c159783e8086645dd7aa42e35c531ad0e8dd16d commit: 3117bb3109dc223e186302f5dc8ce9ed04adca90 [8911/1] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers sound/soc/fsl/fsl_asrc.c:250

Re: [kbuild] [net-next:master 1495/1511] drivers/net/ethernet/intel/i40e/i40e_fcoe.c:268 i40e_fcoe_ddp_put() warn: variable dereferenced before check 'fcoe' (see line 266)

2014-08-04 Thread Dan Carpenter
On Mon, Aug 04, 2014 at 10:05:53PM +, Dev, Vasu wrote: -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Monday, August 04, 2014 1:37 AM To: kbu...@01.org; Dev, Vasu Cc: Brown, Aaron F; Dan Carpenter Subject: [net-next:master 1495/1511

[kbuild] [iio:testing 5/11] drivers/iio/industrialio-buffer.c:954 iio_buffer_add_demux() error: not allocating enough data 20 vs 4

2014-08-07 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing head: 889c558095e96312d81b4084567c11a52b285393 commit: cbe88bcc8ec2f7d6739ea67d7c91517139f0a491 [5/11] iio: buffer: Coalesce adjacent demux table entries drivers/iio/industrialio-buffer.c:954 iio_buffer_add_demux()

[kbuild] [ath6kl:ath-next-test 32/40] drivers/net/wireless/ath/ath10k/pci.c:380 ath10k_pci_rx_replenish() warn: mod_timer() takes an absolute time not an offset.

2014-08-13 Thread Dan Carpenter
tree: git://github.com/kvalo/ath ath-next-test head: e63c7722823dee72ffa92864ed91d40fd0b99e7b commit: c791269b6b9e8ae262be6483a0e5b4625060474f [32/40] ath10k: rework posting pci rx buffers drivers/net/wireless/ath/ath10k/pci.c:380 ath10k_pci_rx_replenish() warn: mod_timer() takes an

[kbuild] [drm-intel:topic/core-stuff 10/17] drivers/gpu/drm/drm_modeset_lock.c:84 __drm_modeset_lock_all() warn: possible memory leak of 'ctx'

2014-08-13 Thread Dan Carpenter
tree: git://anongit.freedesktop.org/drm-intel topic/core-stuff head: b35a82dbefb67f733eb4aec91d0ecf72f5539129 commit: cb597bb3a2fbfc871cc1c703fb330d247bd21394 [10/17] drm: trylock modest locking for fbdev panics drivers/gpu/drm/drm_modeset_lock.c:84 __drm_modeset_lock_all() warn: possible

[kbuild] [next:master 12185/12354] drivers/platform/x86/ideapad-laptop.c:459:13: sparse: duplicate const

2014-08-16 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 0c6cb5aa41fb3be49a7fc9dd39c695e392650e56 commit: 8f98742556ba706a176100b9705bc6b989fbd695 [12185/12354] ideapad-laptop: Constify DMI table and other r/o variables reproduce: make C=1 CF=-D__CHECK_ENDIAN__

[kbuild] [next:master 980/1325] drivers/staging/lustre/lustre/mdc/mdc_locks.c:866 mdc_enqueue() error: potentially dereferencing uninitialized 'req'.

2014-08-18 Thread Dan Carpenter
[ This one is my bad. I said that req didn't need to be initialized but it does. Sorry. -dan ] tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f68f82364938548b58b51d4b926642b0a3cf4c27 commit: ab909585b813193bb45f52367c1e7d056e33cfa9 [980/1325]

[kbuild] [input:next 499/499] drivers/input/misc/drv260x.c:563 drv260x_probe() warn: was intended here instead of ||?

2014-08-19 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next head: 1d3e3ba4b51e309608c1eba680031007ba877826 commit: 1d3e3ba4b51e309608c1eba680031007ba877826 [499/499] Input: drv260x - add TI drv260x haptics driver drivers/input/misc/drv260x.c:563 drv260x_probe() warn: was

Re: [kbuild] [socfpga-nex:master-ltc-regulator 4/10] drivers/tty/newhaven_lcd.c:145:36-37: WARNING: Use ARRAY_SIZE

2014-08-25 Thread Dan Carpenter
On Sun, Aug 24, 2014 at 09:47:40AM +0200, Julia Lawall wrote: Both look reasonable. The attachments were lost. I've attached them. The missing NULL terminator seems especially important. regards, dan carpenter From: Fengguang Wu fengguang...@intel.com Subject: [PATCH] fix coccinelle

[kbuild] [net-next:master 1/47] drivers/net/hyperv/netvsc.c:1108 netvsc_device_add() error: we previously assumed 'net_device' could be null (see line 1057)

2014-08-26 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a3d1214688d5259a200414def4d38f1e4531febd commit: f90251c8a6d06ed8b072a2a0f13c4b8a6d0cb222 [1/47] hyperv: Increase the buffer length for netvsc_channel_cb() drivers/net/hyperv/netvsc.c:1108 netvsc_device_add()

[kbuild] [drm-intel:drm-intel-next-queued 177/195] drivers/gpu/drm/i915/i915_gpu_error.c:1031 i915_gem_record_rings() error: we previously assumed 'request-ctx' could be null (see line 992)

2014-08-27 Thread Dan Carpenter
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: c1f7ab8c9a7b09f4ed6499904298ddf1c67b1764 commit: 4ecbdf4dfc537cd9ed53b4cb77e0c48dd6daa620 [177/195] drm/i915/bdw: Make sure error capture keeps working with Execlists drivers/gpu/drm/i915/i915_gpu_error.c:1031

[kbuild] [next:master 2131/2422] kernel/sys.c:1888 prctl_set_mm_map() warn: maybe return -EFAULT instead of the bytes remaining?

2014-08-27 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: d05446ae2128064a4bb8f74c84f6901ffb5c94bc commit: 802d335c0f7f1a1867bf59814c55970a71b10413 [2131/2422] prctl: PR_SET_MM -- introduce PR_SET_MM_MAP operation kernel/sys.c:1888 prctl_set_mm_map() warn: maybe

Re: [kbuild] [next:master 2131/2422] kernel/sys.c:1888 prctl_set_mm_map() warn: maybe return -EFAULT instead of the bytes remaining?

2014-08-27 Thread Dan Carpenter
; } regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

[kbuild] [wireless-next:master 78/80] drivers/net/wireless/ath/ath9k/channel.c:362 ath_chanctx_event() error: we previously assumed 'vif' could be null (see line 315)

2014-08-28 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master head: 6a5d088a923854569e20eac4f3f569926d5911ec commit: 878066e745b54578409ea765cfc718fcd99a4802 [78/80] ath9k: Add more debug statements for channel context New smatch warnings:

[kbuild] [block:for-3.18/core 4/16] fs/nfs/direct.c:225 nfs_direct_IO() warn: impossible condition '(rw == (0 | (1 31))) = (0-2147483647, 18446744071562067968-u64max == 2147483648)'

2014-08-28 Thread Dan Carpenter
[ Huh... This is an odd one. At first I thought it was a bug in Smatch and then I wondered why Fengguang's scripts blame Martin but it turns out the tools are correct. Adding __REQ_INTEGRITY means that rw can never equal KERNEL_READ because the negative INT_MIN gets sign expanded to

[kbuild] [block:for-3.18/core 11/17] drivers/scsi/sd_dif.c:277 sd_dif_config_host() warn: variable dereferenced before check 'sdkp' (see line 242)

2014-08-28 Thread Dan Carpenter
tree: git://git.kernel.dk/linux-block.git for-3.18/core head: b96dc4f1418142bff3cb037dc11ec5ffa390a9b3 commit: 4c600ab779694eea6eee16478df41ab50437518e [11/17] block: Add a disk flag to block integrity profile drivers/scsi/sd_dif.c:277 sd_dif_config_host() warn: variable dereferenced before

Re: [kbuild] [block:for-3.18/core 4/16] fs/nfs/direct.c:225 nfs_direct_IO() warn: impossible condition '(rw == (0 | (1 31))) = (0-2147483647, 18446744071562067968-u64max == 2147483648)'

2014-08-29 Thread Dan Carpenter
On Fri, Aug 29, 2014 at 10:59:08AM -0400, Martin K. Petersen wrote: Dan == Dan Carpenter dan.carpen...@oracle.com writes: Dan [ Huh... This is an odd one. At first I thought it was a bug in Dan Smatch and then I wondered why Fengguang's scripts blame Martin but Dan it turns out the tools

Re: [kbuild] [staging:staging-next 284/325] drivers/staging/bcm/Bcmchar.c:961 bcm_char_ioctl_buffer_download_start() warn: inconsistent returns sem:ad-NVMRdmWrmLock: locked (943 [(-16)]) unlocked (9

2014-09-01 Thread Dan Carpenter
Not a new warning. Just renaming the locks. regards, dan carpenter On Sun, Aug 31, 2014 at 04:15:36AM +0800, kbuild test robot wrote: TO: Matthias Beyer m...@beyermatthias.de CC: Greg Kroah-Hartman gre...@linuxfoundation.org tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh

[kbuild] [staging:staging-next 461/473] drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced before check 'pDevice' (see line 1021)

2014-09-01 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: f25884839e7e8de72b3c0da518900f5915b7c4b1 commit: 70afb8e5037a97d7294955531395b65e225c98e1 [461/473] staging: vt6655: remove multiple instances of driver loading. New smatch warnings:

[kbuild] [kees:lsm/stacking 4/4] security/smack/smack_lsm.c:457 smack_sb_kern_mount() error: potentially dereferencing uninitialized 'isp'.

2014-09-03 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git lsm/stacking head: a1811bedacca7afc4f41741401eeaa003d22d6bb commit: a1811bedacca7afc4f41741401eeaa003d22d6bb [4/4] LSM: Stop allocating inode-i_security security/smack/smack_lsm.c:457 smack_sb_kern_mount() error: potentially

[kbuild] [sound-unstable:master 15036/15056] sound/core/pcm_native.c:806 snd_pcm_action_mutex() error: double unlock 'mutex:substream-self_group.mutex'

2014-09-03 Thread Dan Carpenter
[ It's not immediately clear to me that we intended to drop the lock if someone else is holding it. If so maybe this should have a comment? -dan ] tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git master head: 33a8b5de23c78c47e2e0791118e836e75f3e175a commit:

[kbuild] [jlayton:locks-3.19 44/47] fs/cifs/file.c:1198 cifs_push_posix_locks() warn: inconsistent returns spin_lock:inode-i_lock: locked (1192 [s32min-s32max]) unlocked (1192 [0])

2014-09-04 Thread Dan Carpenter
[ It looks like a stray spin_unlock(inode-i_lock); was left behind by mistake. -dan ] tree: git://git.samba.org/jlayton/linux locks-3.19 head: d9212689e0732acf5a0b94083c1319ee4f396a15 commit: 35c20cc874547c97d0c5abd315caef5bb52c056b [44/47] cifs: convert it to use file_lock_context New

[kbuild] [bluetooth:master 75/78] net/bluetooth/smp.c:1182 smp_conn_security() warn: variable dereferenced before check 'conn' (see line 1174)

2014-09-05 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master head: 2c87f4732acc5dc46a0b7e4e7529ca49804b97f1 commit: 473b6ffa78aa307b59612384b84cddf13ffa77b3 [75/78] Bluetooth: Fix locking of the SMP context net/bluetooth/smp.c:1182 smp_conn_security() warn:

[kbuild] [regulator:topic/isl9305 5/5] drivers/regulator/isl9305.c:202 isl9305_i2c_probe() error: buffer overflow 'pdata-init_data' 3 = 3

2014-09-08 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git topic/isl9305 head: dec38b5ce6a9edb406c60c2670b26a1a4262fdb9 commit: dec38b5ce6a9edb406c60c2670b26a1a4262fdb9 [5/5] regulator: isl9305: Add Intersil ISL9305/H driver drivers/regulator/isl9305.c:202 isl9305_i2c_probe()

[kbuild] [regulator:topic/tps65217 1/1] drivers/regulator/tps65217-regulator.c:248 tps65217_regulator_probe() error: we previously assumed 'pdata' could be null (see line 243)

2014-09-08 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git topic/tps65217 head: 81baf9fe0243a4450d738676ccf99d325460c748 commit: 81baf9fe0243a4450d738676ccf99d325460c748 [1/1] regulator: tps65217: Remove spurious platform data check drivers/regulator/tps65217-regulator.c:248

[kbuild] [nfc-next:master 42/43] drivers/nfc/trf7970a.c:876 trf7970a_irq() warn: inconsistent returns mutex:trf-lock: locked (836 [s32min-(-1), 1-s32max], 849 [s32min-(-1), 1-s32max]) unlocked (744

2014-09-08 Thread Dan Carpenter
[ The New Smatch warning format for this looks like: CHECK drivers/nfc/trf7970a.c drivers/nfc/trf7970a.c:810 trf7970a_irq() warn: passing zero to 'ERR_PTR' drivers/nfc/trf7970a.c:876 trf7970a_irq() warn: inconsistent returns 'mutex:trf-lock'. Locked on: line 836 line 849

[kbuild] [devfreq:for-chanwoo 1/5] drivers/devfreq/devfreq-event.c:85:1-7: preceding lock on line 57

2014-09-08 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq for-chanwoo head: 3a85940e803da22f5fedc64871c5f065802057b5 commit: 52d1ab5e8580ce084c1c312e15a1025662d12c30 [1/5] devfreq: Add new devfreq_event class to provide basic data for devfreq governor

[kbuild] [vireshk:cpufreq/governor-fixes 2/2] drivers/cpufreq/cpufreq.c:938:34: sparse: odd constant _Bool cast (5 becomes 1)

2014-09-08 Thread Dan Carpenter
tree: git://git.linaro.org/people/vireshk/linux cpufreq/governor-fixes head: 250686bfdbb183a9d798b071d32972b65d35c915 commit: 250686bfdbb183a9d798b071d32972b65d35c915 [2/2] cpufreq: Track governor-state with 'policy-governor_state' reproduce: make C=1 CF=-D__CHECK_ENDIAN__

[kbuild] [dhowells-fs:modsign-pkcs7 10/13] crypto/asymmetric_keys/pkcs7_trust.c:90 pkcs7_validate_trust_one() error: we previously assumed 'x509' could be null (see line 43)

2014-09-09 Thread Dan Carpenter
[ My guess is the pr_err() should print last-index instead of x509-index? - dan ] tree: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs modsign-pkcs7 head: 1148a967cac3bcea81a6910660ddb6cda7b067d4 commit: 7f2d0d9924b26de3f059972a01cc55fbafb24956 [10/13] PKCS#7: Handle

Re: [kbuild] [arm-integrator:realview-dt 1/6] drivers/leds/leds-syscon.c:74:27-28: syscon_match is not NULL terminated at line 74

2014-09-10 Thread Dan Carpenter
On Wed, Sep 10, 2014 at 03:55:37PM +0200, Julia Lawall wrote: Needs attention. The attachment was lost. regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

Re: [kbuild] [platform-drivers-x86:testing 8/8] drivers/platform/x86/toshiba_acpi.c:1352 toshiba_touchpad_store() warn: was intended here instead of ||?

2014-09-10 Thread Dan Carpenter
On Wed, Sep 10, 2014 at 07:59:17AM -0700, Darren Hart wrote: On 9/10/14, 0:12, Dan Carpenter dan.carpen...@oracle.com wrote: tree: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git testing head: 58e642de0a6fba870c2bba86f3e92c68df1fd42e commit

[kbuild] [amirv:for-netdev 324/327] drivers/infiniband/hw/mlx5/qp.c:3160 mlx5_ib_create_dct() error: potentially dereferencing uninitialized 'dev'.

2014-09-11 Thread Dan Carpenter
tree: git://flatbed.openfabrics.org/~amirv/linux.git for-netdev head: 1c1627f7007590393b4d090ff08133b7b5005a0d commit: 6cc37e98d61a056d96d8c3a1e7b3826d022e2eba [324/327] IB/mlx5: Add DC transport support [topic: 3.17-series] drivers/infiniband/hw/mlx5/qp.c:3160 mlx5_ib_create_dct() error:

[kbuild] [amirv:for-netdev 323/327] drivers/infiniband/core/uverbs_cmd.c:3561:15: sparse: memset with byte count of 0

2014-09-11 Thread Dan Carpenter
[ Oddly enough sizeof(resp) *is* zero. -dan ] tree: git://flatbed.openfabrics.org/~amirv/linux.git for-netdev head: 1c1627f7007590393b4d090ff08133b7b5005a0d commit: 229a74d98862e6b8cc639885292e01940f57225a [323/327] IB/core: Add DC transport support [topic: 3.17-series] reproduce: #

[kbuild] [microblaze:xnext/usb 1/1] drivers/usb/gadget/udc/udc-xilinx.c:1162 xudc_ep_dequeue() warn: inconsistent returns spin_lock:udc-lock: locked (1157 [(-22)]) unlocked (1162 [0])

2014-09-11 Thread Dan Carpenter
tree: git://git.monstr.eu/linux-2.6-microblaze xnext/usb head: f95408d41cf2967aceb604e737a8ce646988a366 commit: f95408d41cf2967aceb604e737a8ce646988a366 [1/1] usb: gadget: Add xilinx usb2 device support drivers/usb/gadget/udc/udc-xilinx.c:1162 xudc_ep_dequeue() warn: inconsistent returns

[kbuild] [net-next:master 184/193] net/sched/cls_tcindex.c:244 tcindex_set_parms() error: not allocating enough data 40 vs 4

2014-09-15 Thread Dan Carpenter
[ Also I was wondering if you could take a look at: net/sched/cls_tcindex.c:259 tcindex_set_parms() warn: missing error code here? 'kmemdup()' failed. 255 if (p-perfect) { 256 cp-perfect = kmemdup(p-perfect, 257

[kbuild] [net-next:master 625/646] net/sched/cls_cgroup.c:130 cls_cgroup_change() warn: possible memory leak of 'new'

2014-09-15 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 54996b529ab70ca1d6f40677cd2698c4f7127e87 commit: c7953ef23042b7c4fc2be5ecdd216aacff6df5eb [625/646] net: sched: cls_cgroup use RCU net/sched/cls_cgroup.c:130 cls_cgroup_change() warn: possible memory leak of

[kbuild] [net-next:master 182/193] net/sched/cls_fw.c:279 fw_change() error: we previously assumed 'pfp' could be null (see line 274)

2014-09-15 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: b25bd2515ea32cf5ddd5fd5a2a93b8c9dd875e4f commit: e35a8ee5993ba81fd6c092f6827458c60406255b [182/193] net: sched: fw use RCU net/sched/cls_fw.c:279 fw_change() error: we previously assumed 'pfp' could be null

[kbuild] [wireless-next:master 81/102] drivers/net/wireless/mwifiex/scan.c:943 mwifiex_config_scan() error: we previously assumed 'user_scan_in' could be null (see line 839)

2014-09-15 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master head: 1030f9fe65602465a89beaa05c3343cf9fd68a88 commit: cb91be87e12c079fcf25069a21123756c0931dd6 [81/102] mwifiex: bring in scan channel gap feature drivers/net/wireless/mwifiex/scan.c:943

Re: [kbuild] [nfc-next:master 42/63] drivers/nfc/trf7970a.c:836:5-11: preceding lock on line 740

2014-09-19 Thread Dan Carpenter
lock on line 1599 I'm not sure what these messages are trying to tell me. Any hints? There is a return on line 836 which didn't release the lock from line 740. regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org

[kbuild] [pm:bleeding-edge 107/110] drivers/acpi/sbs.c:441:28: sparse: dubious: !x y

2014-09-25 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge head: 3b2a67026846080f7ee251e8984ed8f414137ca8 commit: 3031cddea633ea5328162d3d712a582e4205dbed [107/110] ACPI / SBS: Don't assume the existence of an SBS charger reproduce: # apt-get install sparse git

[kbuild] [mmotm:master 57/427] fs/ocfs2/journal.c:2204:9: sparse: context imbalance in 'ocfs2_recover_orphans' - different lock contexts for basic block

2014-09-26 Thread Dan Carpenter
tree: git://git.cmpxchg.org/linux-mmotm.git master head: 065f1d86a58cc88249cd8371b29a57c97483753a commit: 8a09937cacc099da21313223443237cbc84d5876 [57/427] ocfs2: add orphan recovery types in ocfs2_recover_orphans reproduce: # apt-get install sparse git checkout

Re: [kbuild] [target:for-next 41/41] drivers/vhost/scsi.c:1411:1-7: preceding lock on line 1345

2014-10-10 Thread Dan Carpenter
On Thu, Oct 09, 2014 at 01:51:00PM +0300, Dan Carpenter wrote: 21828596 drivers/vhost/scsi.c Nicholas Bellinger 2014-10-08 1370 ret = configfs_depend_item(se_tpg-se_tpg_tfo-tf_subsys, 21828596 drivers/vhost/scsi.c Nicholas Bellinger 2014-10-08 1371

[kbuild] [asoc:topic/intel 26/28] sound/soc/intel/sst-firmware.c:675:2-8: preceding lock on line 636

2014-10-22 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel head: cd51c82524fffc47ca6566532bcc6cf37b4902de commit: 1715b5408ce98002a0ed5dc6349105133826f3f0 [26/28] ASoC: Intel: update scratch allocator to use generic block allocator

[kbuild] [ulf.hansson-mmc:next 96/99] drivers/mmc/host/toshsd.c:389 toshsd_irq() error: we previously assumed 'host-cmd' could be null (see line 349)

2014-11-12 Thread Dan Carpenter
tree: https://git.linaro.org/people/ulf.hansson/mmc next head: edd9918aa24ccee14f80d0c6e87e89b59223e807 commit: 36b2de044cdf3e3dfc2402a48008aa5ef0849a2b [96/99] mmc: add Toshiba PCI SD controller driver drivers/mmc/host/toshsd.c:389 toshsd_irq() error: we previously assumed 'host-cmd' could

[kbuild] [slave-dma:for-linus 1/37] drivers/dma/at_xdmac.c:933 at_xdmac_tx_status() warn: inconsistent returns 'spin_lock:atchan-lock'.

2014-11-12 Thread Dan Carpenter
[ missing unlock on line 902 - dan] tree: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git for-linus head: 0005e0d58cee6b4c48416a44619df24214aa8670 commit: e1f7c9eee70730d7e6ec77f7ecc76f936e262cf0 [1/37] dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller

Re: [kbuild] [next:master 5753/6487] drivers/spi/spidev.c:583 spidev_release() warn: variable dereferenced before check 'spidev-spi' (see line 579)

2014-11-13 Thread Dan Carpenter
I reported this one earlier. regards, dan carpenter On Thu, Nov 13, 2014 at 04:24:12PM +0800, kbuild test robot wrote: TO: Mark Brown broo...@kernel.org tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: bbdef57970d5e1887de755474ff1562baa17ef11

Re: [kbuild] fs/overlayfs/super.c:367 ovl_lookup() error: passing non negative 2147383647 to ERR_PTR

2014-11-13 Thread Dan Carpenter
systems. I'll keep on messing with it though to see if I can figure out how this happened. regards, dan carpenter On Thu, Nov 13, 2014 at 06:15:28AM +0800, kbuild test robot wrote: TO: Miklos Szeredi mszer...@suse.cz tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

Re: [kbuild] fs/overlayfs/super.c:367 ovl_lookup() error: passing non negative 2147383647 to ERR_PTR

2014-11-13 Thread Dan Carpenter
we'll see how that goes and I will try to be careful. :) regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

Re: [kbuild] [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings (fwd)

2014-11-13 Thread Dan Carpenter
, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

Re: [kbuild] [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings (fwd)

2014-11-13 Thread Dan Carpenter
, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild

Re: [kbuild] [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings (fwd)

2014-11-13 Thread Dan Carpenter
On Thu, Nov 13, 2014 at 09:20:16PM +0800, Fengguang Wu wrote: I'm a robot, after all. ;) Heh. One time I was credited to as: Reported-by: The Intel Backend And I had to tell them that I might be a backend, but I work for Oracle. regards, dan carpenter

[kbuild] [next:master 125/6487] drivers/net/wireless/ath/ath10k/wmi.c:3170 ath10k_wmi_start_scan_verify() warn: this array is probably non-NULL. 'arg-ie'

2014-11-13 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: bbdef57970d5e1887de755474ff1562baa17ef11 commit: a6aa5da3029670816b3eb9358bc1a63f2e2564fb [125/6487] ath10k: re-work scan start command building drivers/net/wireless/ath/ath10k/wmi.c:3170

Re: [kbuild] [next:master 2788/6487] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:1073 brcmf_ops_sdio_probe() error: we previously assumed 'sdiodev-pdata' could be null (see line 1064)

2014-11-13 Thread Dan Carpenter
I reported this one earlier. regards, dan carpenter On Thu, Nov 13, 2014 at 10:08:36PM +0800, kbuild test robot wrote: TO: Hante Meuleman meule...@broadcom.com CC: John W. Linville linvi...@tuxdriver.com CC: Arend van Spriel ar...@broadcom.com tree: git://git.kernel.org/pub/scm/linux

Re: [kbuild] [next:master 200/6487] drivers/net/wireless/ath/ath10k/debug.c:1195 ath10k_debug_get_et_strings() error: __builtin_memcpy() '*ath10k_gstrings_stats' too small (32 vs 1472)

2014-11-13 Thread Dan Carpenter
This one is sort of a false positive. The code works. I feel like it should be written: memcpy(data, ath10k_gstrings_stats, sizeof(ath10k_gstrings_stats)); But that's a style issue rather than a bug. regards, dan carpenter On Thu, Nov 13, 2014 at 10:04:33PM +0800, kbuild test robot

Re: [kbuild] [next:master 1093/6788] net/mac80211/rc80211_minstrel_ht.c:255 minstrel_ht_sort_best_tp_rates() error: buffer overflow 'tp_list' 2 = 3

2014-11-17 Thread Dan Carpenter
On Mon, Nov 17, 2014 at 06:23:58PM +0800, Fengguang Wu wrote: On Mon, Nov 17, 2014 at 12:56:08PM +0300, Dan Carpenter wrote: On Mon, Nov 17, 2014 at 05:32:33PM +0800, Fengguang Wu wrote: On Mon, Nov 17, 2014 at 11:36:37AM +0300, Dan Carpenter wrote: Fengguang, this seems to be a very old

[kbuild] [ath6kl:ath-next-test 10/13] drivers/net/wireless/ath/ath10k/debug.c:1100 ath10k_mem_value_write() warn: maybe return -EFAULT instead of the bytes remaining?

2014-11-24 Thread Dan Carpenter
tree: git://github.com/kvalo/ath ath-next-test head: acb3cfda39e56f641e0d84fdea04c290c107c36d commit: ab39b15d893c9b77389d452bcd57d8ff9875032c [10/13] ath10k: Add the target register access and memory dump debugfs interface New smatch warnings: drivers/net/wireless/ath/ath10k/debug.c:1100

Re: [kbuild] [ux500:tb-st-spi 4/7] drivers/nfc/st95hf/st95hf.c:669 st95hf_irq_handler() error: we previously assumed 'stcontext' could be null (see line 665)

2014-11-24 Thread Dan Carpenter
It's bad code, but it's deliberate. regards, dan carpenter On Fri, Nov 21, 2014 at 02:57:03AM +0800, kbuild test robot wrote: TO: Lee Jones lee.jo...@linaro.org tree: https://git.linaro.org/people/ljones/linux-3.0-ux500.git tb-st-spi head: d83034f9b016df748567f53725f20124453eecbb

[kbuild] [dhowells-fs:modsign-pkcs7 2/5] crypto/asymmetric_keys/x509_public_key.c:119 x509_request_asymmetric_key() warn: variable dereferenced before check 'id' (see line 75)

2014-11-24 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs modsign-pkcs7 head: e74cbea099d4753be170c746e93f7a3587c4f02d commit: 7087c095c7ecc4eebcd4acfd36a7752e5339d026 [2/5] X.509: Support X.509 lookup by Issuer+Serial form AuthorityKeyIdentifier

[kbuild] [char-misc:kdbus 12/13] ipc/kdbus/handle.c:736 handle_ep_ioctl_connected() warn: maybe return -EFAULT instead of the bytes remaining?

2014-11-24 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git kdbus head: d064b29b452333d0e0ed6b9d2fc96b6e3917b1d7 commit: 0311aa1370e08cf0bf799a5f6e7ea29297cc3bdd [12/13] kdbus: add Makefile, Kconfig and MAINTAINERS entry ipc/kdbus/handle.c:736 handle_ep_ioctl_connected() warn:

[kbuild] [asoc:topic/intel 61/64] sound/soc/intel/sst/sst_acpi.c:228 sst_acpi_find_machine() warn: this array is probably non-NULL. 'mach-codec_id'

2014-11-24 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel head: 996cc8494d663cb03c5ec23ced0e09e4bcd845de commit: 336cfbb05edf7b122ea927dad6c746608723eb25 [61/64] ASoC: Intel: mrfld- add ACPI module sound/soc/intel/sst/sst_acpi.c:228 sst_acpi_find_machine() warn: this

Re: [kbuild] [ath6kl:ath-next-test 10/13] drivers/net/wireless/ath/ath10k/debug.c:1100 ath10k_mem_value_write() warn: maybe return -EFAULT instead of the bytes remaining?

2014-11-24 Thread Dan Carpenter
; goto err_free_copy; } Yes. Although normally people write these like: if (copy_from_user(buf, user_buf, count)) { ret = -EFAULT; goto err_free_copy; } regards, dan carpenter ___ kbuild mailing

Re: [kbuild] [hch-scsi-queue:drivers-for-3.19 159/180] drivers/scsi/esp_scsi.c:2322 scsi_esp_register() warn: impossible condition '(esp-num_tags = 256) = (0-255 = 256)'

2014-11-26 Thread Dan Carpenter
Of course this is real, but the sanity check is harmless. Linus was annoyed by people removing harmless sanity checks like this. regards, dan carpenter On Wed, Nov 26, 2014 at 04:07:35AM +0800, kbuild test robot wrote: TO: Hannes Reinecke h...@suse.de CC: Christoph Hellwig h...@lst.de tree

[kbuild] [hch-scsi-queue:drivers-for-3.19 180/180] drivers/scsi/scsi_debug.c:3063 resp_comp_write() warn: possible memory leak of 'arr'

2014-11-26 Thread Dan Carpenter
[ Move the allocation after the sanity checks? - dan ] tree: git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.19 head: 38d5c8336e60bf6e53a1da9586befe82fa75171b commit: 38d5c8336e60bf6e53a1da9586befe82fa75171b [180/180] scsi_debug: add Report supported opcodes+tmfs; Compare and

Re: [kbuild] [ext4:dev 15/21] fs/ext4/extents_status.c:1049 __es_shrink() warn: inconsistent returns 'write_lock:ei-i_es_lock'.

2014-11-26 Thread Dan Carpenter
False positive in Smatch. I was missing the _raw_write_unlock() function, I've added it and will push soon. regards, dan carpenter On Wed, Nov 26, 2014 at 05:13:26AM +0800, kbuild test robot wrote: TO: Zheng Liu wenqing...@taobao.com CC: Theodore Ts'o ty...@mit.edu CC: Jan Kara j...@suse.cz

Re: [kbuild] [next:master 6668/9040] drivers/usb/gadget/udc/bdc/bdc_ep.c:193 ep_bd_list_alloc() warn: possible memory leak of 'bd_table'

2014-11-26 Thread Dan Carpenter
I reported these already. regards, dan carpenter On Wed, Nov 26, 2014 at 06:04:01AM +0800, kbuild test robot wrote: TO: Ashwini Pahuja ashwini.li...@gmail.com CC: Felipe Balbi ba...@ti.com tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head

Re: [kbuild] [rw:fastmap_upgrade2 24/41] drivers/mtd/ubi/fastmap.c:1413 ubi_update_fastmap() error: buffer overflow 'old_fm-e' 32 = 32

2014-11-26 Thread Dan Carpenter
False positive. regards, dan carpenter On Wed, Nov 26, 2014 at 07:32:52AM +0800, kbuild test robot wrote: TO: Richard Weinberger rich...@nod.at tree: git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc.git fastmap_upgrade2 head: 1335c6aa4073429ab1f7f48976b47032b78ba337 commit

[kbuild] [net:master 18/18] drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:275 stmmac_pltfr_probe() warn: variable dereferenced before check 'plat_dat' (see line 269)

2014-11-26 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 571dcfde23712b92e45a126f415d9424af0c2886 commit: 571dcfde23712b92e45a126f415d9424af0c2886 [18/18] stmmac: platform: fix default values of the filter bins setting

[kbuild] [staging:staging-next 1159/1285] drivers/staging/vt6655/rf.c:930 RFbSetPower() error: buffer overflow 'priv-abyCCKPwrTbl' 15 = 56

2014-12-01 Thread Dan Carpenter
[ The renaming made the kbuild scripts think this is a new bug when it's old. Oh well. It still might be worth fixing. -dan ] tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: aa9d9be96d33d97488e1bdf13a144931a3fce08e commit:

Re: [kbuild] [vhost:vhost-next 47/52] drivers/char/virtio_console.c:1644 handle_control_message() error: we previously assumed 'port' could be null (see line 1617)

2014-12-02 Thread Dan Carpenter
False positive. regards, dan carpenter On Tue, Dec 02, 2014 at 12:21:29AM +0800, kbuild test robot wrote: TO: Michael S. Tsirkin m...@redhat.com tree: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-next head: c9a21e033bc57d6c34474730680bf2d6a3d036fe commit

[kbuild] [nfc-next:master 18/38] net/nfc/nci/ntf.c:487 nci_store_general_bytes_nfc_dep() error: __builtin_memcpy() '(ntf-activation_params.poll_nfc_dep.atr_res[15])' too small (47 vs 48)

2014-12-02 Thread Dan Carpenter
+ NFC_ATR_RES_GT_OFFSET, ndev-remote_gb_len); break; } But it still has the off-by-one bug, of course. regards, dan carpenter a99903ec Julien Lefrique 2014-10-21 489 + NFC_ATR_RES_GT_OFFSET), a99903ec

[kbuild] [target:for-next 42/63] drivers/infiniband/ulp/isert/ib_isert.c:862 isert_np_cma_handler() warn: missing break? reassigning 'isert_np-np_cm_id'

2014-12-02 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next head: 5ad7c8c97972ab9046d83048db4c3d71a1cb2bcb commit: bcf5944542d89af893fadd8a5fa160c8b713c174 [42/63] iser-target: Handle ADDR_CHANGE event for listener cm_id New smatch warnings:

[kbuild] [net-next:master 1269/1276] drivers/net/ethernet/rocker/rocker.c:1021 rocker_port_set_enable() warn: should '1 rocker_port-lport' be a 64 bit type?

2014-12-02 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: cbc24658baac5ca96d20d4a6ca9a8c41581a6e63 commit: 4b8ac9660af07be6f6602b523929793eed314997 [1269/1276] rocker: introduce rocker switch driver drivers/net/ethernet/rocker/rocker.c:1021 rocker_port_set_enable()

[kbuild] [next:master 10155/10387] drivers/gpu/drm/i915/i915_gem.c:4874 i915_gem_init() warn: inconsistent returns 'mutex:dev-struct_mutex'.

2014-12-02 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e85db7e77c6801b854864ee65c264be164dd02c1 commit: 372ee59699d9704086dadb084209542d10e28851 [10155/10387] drm/i915: Only init engines once New smatch warnings: drivers/gpu/drm/i915/i915_gem.c:4874

Re: [kbuild] [net-next:master 1271/1277] drivers/net/ethernet/rocker/rocker.c:3078 rocker_port_fdb() warn: passing freed memory 'fdb'

2014-12-03 Thread Dan Carpenter
False positives. regards, dan carpenter On Wed, Dec 03, 2014 at 03:28:58PM +0800, kbuild test robot wrote: TO: Scott Feldman sfel...@gmail.com CC: Jiri Pirko j...@resnulli.us tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head

[kbuild] [vireshk2:thermal/cpu-cooling-fixes-v2 17/26] drivers/thermal/cpu_cooling.c:445 __cpufreq_cooling_register() warn: possible memory leak of 'cpufreq_dev'

2014-12-03 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git thermal/cpu-cooling-fixes-v2 head: 21e01abf4ec62501f6ffc4dd6096563de6351101 commit: 5232c1a51357b9258a02b8ca4252b7614059f19d [17/26] thermal: cpu_cooling: initialize 'cpufreq_val' on registration

Re: [kbuild] [ux500:buildtest 3/4] drivers/video/backlight/lp855x_bl.c:421 lp855x_probe() error: we previously assumed 'lp-pdata' could be null (see line 415)

2014-12-03 Thread Dan Carpenter
False positive. Because CONFIG_OF is turned off so we're using this: #else static int lp855x_parse_dt(struct lp855x *lp) { return -EINVAL; } #endif It's probably going to take a year before I get around to fixing these sorts of issues. regards, dan carpenter On Wed, Dec 03, 2014 at 05

Re: [kbuild] [patch] dell-laptop: fix kbd_timeout handling

2014-12-04 Thread Dan Carpenter
On Tue, Dec 02, 2014 at 11:33:25PM -0800, Darren Hart wrote: Dan, any objection to Pali rolling this into another revision? No problem, that's fine. regards, dan carpenter ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman

[kbuild] drivers/nfc/st21nfcb/ndlc.c:296:1-6: WARNING: invalid free of devm_ allocated data

2014-12-04 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3a18ca061311f2f1ee9c44012f89c7436d392117 commit: 35630df68d6030daf12dde12ed07bbe26324e6ac NFC: st21nfcb: Add driver for STMicroelectronics ST21NFCB NFC chip drivers/nfc/st21nfcb/ndlc.c:296:1-6: WARNING:

[kbuild] [next:master 5834/10887] drivers/gpu/drm/drm_mipi_dsi.c:281 mipi_dsi_create_packet() warn: variable dereferenced before check 'msg' (see line 279)

2014-12-05 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 1ca7c606de868d172afb4eb65e04e290dbdb51ff commit: a52879e8d7cbeed69be5e54c69701e5edea8cc00 [5834/10887] drm/dsi: Add message to packet translator drivers/gpu/drm/drm_mipi_dsi.c:281 mipi_dsi_create_packet()

[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'

2014-12-06 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git master head: e6c97234d1b18d4751671df15d52e29daa8a7ba8 commit: e6c97234d1b18d4751671df15d52e29daa8a7ba8 [16/16] i40e: Reduce stack in i40e_dbg_dump_desc New smatch warnings:

[kbuild] [net-next:master 1345/1380] net/tipc/name_table.c:980 tipc_purge_publications() error: double lock 'spin_lock:seq-lock'

2014-12-08 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: bc6aaa14e11304b629ae8b0c0c71737cf24114b7 commit: fb9962f3cefeba8c5addc96dceb8bc360062ab50 [1345/1380] tipc: ensure all name sequences are properly protected with its lock net/tipc/name_table.c:980

[kbuild] [net-next:master 1404/1409] drivers/net/ethernet/chelsio/cxgb4vf/t4vf_hw.c:489 t4_bar2_sge_qregs() warn: should '(qid qpp_shift) page_shift' be a 64 bit type?

2014-12-10 Thread Dan Carpenter
[ It's weird to have a 64 bit offset into anything but the code is very consistent about this. The comments mention that often the values are less that PAGE_SIZE. My guess is that the type should be changed to u32, but if we don't do that, then we should at least silence the static

Re: [kbuild] [next:master 11322/11577] drivers/input/touchscreen/elants_i2c.c:877 elants_i2c_irq() warn: missing break? reassigning 'ts-state'

2014-12-10 Thread Dan Carpenter
This is a false positive. On Wed, Dec 10, 2014 at 02:36:50AM +0800, kbuild test robot wrote: 66aee900 Scott Liu 2014-11-19 861/* fall through */ Smatch should eventually be updated to grep for the fall through comments... regards, dan carpenter

Re: [kbuild] [drm-intel:topic/core-stuff 32/37] drivers/gpu/drm/drm_crtc.c:4472 drm_mode_crtc_set_gamma_size() warn: double check that we're allocating correct size: 2 vs 6

2014-12-10 Thread Dan Carpenter
On Wed, Dec 10, 2014 at 03:53:30PM +0100, Daniel Vetter wrote: On Wed, Dec 10, 2014 at 3:03 PM, Dan Carpenter dan.carpen...@oracle.com wrote: From a style prespective this should be: crtc-gamma_store = kcalloc(gamma_size * 3, sizeof(uint16_t

Re: [kbuild] [next:master 11322/11577] drivers/input/touchscreen/elants_i2c.c:877 elants_i2c_irq() warn: missing break? reassigning 'ts-state'

2014-12-10 Thread Dan Carpenter
On Wed, Dec 10, 2014 at 01:59:01PM -0800, Fengguang Wu wrote: On Wed, Dec 10, 2014 at 01:24:10PM +0300, Dan Carpenter wrote: This is a false positive. On Wed, Dec 10, 2014 at 02:36:50AM +0800, kbuild test robot wrote: 66aee900 Scott Liu 2014-11-19 861/* fall through

Re: [kbuild] [daniel.lezcano:chromebook2 10152/10189] drivers/input/touchscreen/atmel_mxt_ts.c:1592 mxt_get_object_table() warn: assigning (-2) to unsigned variable 'data-num_touchids'

2014-12-13 Thread Dan Carpenter
So long as we trust the firmware to give good data then this code is fine. regards, dan carpenter On Sat, Dec 13, 2014 at 12:10:16AM +0800, kbuild test robot wrote: TO: Nick Dyer nick.d...@itdev.co.uk CC: Kevin Hilman khil...@linaro.org CC: Javier Martinez Canillas javier.marti

[kbuild] [tixy:tracking-armlt-gator 1/6] drivers/gator/gator_events_perf_pmu.c:241 __start() warn: returning -1 instead of -ENOMEM is sloppy

2014-12-16 Thread Dan Carpenter
tree: https://git.linaro.org/people/tixy/kernel tracking-armlt-gator head: 9b552ac355654e1fdd504f4b84b57c971084d83e commit: a7bdf015d9043286f35de13eb11f54f64f2af143 [1/6] gator: Version 5.20 drivers/gator/gator_events_perf_pmu.c:241 __start() warn: returning -1 instead of -ENOMEM is sloppy

[kbuild] [tixy:integration-linaro-vexpress64 24/644] drivers/input/evdev.c:390 evdev_release() warn: passing freed memory 'client'

2014-12-16 Thread Dan Carpenter
tree: https://git.linaro.org/people/tixy/kernel integration-linaro-vexpress64 head: 767452a1ba48d05ee26d47c5a5ce1f6d6589495c commit: 6e71fda4b35e9b8b4f2f009b9d2b70214ea2db3a [24/644] Input: evdev - Add ioctl to block suspend while event queue is not empty. drivers/input/evdev.c:390

[kbuild] [tixy:integration-linaro-vexpress64 138/644] net/netfilter/xt_IDLETIMER.c:131 idletimer_tg_show() error: we previously assumed 'timer' could be null (see line 122)

2014-12-16 Thread Dan Carpenter
tree: https://git.linaro.org/people/tixy/kernel integration-linaro-vexpress64 head: 767452a1ba48d05ee26d47c5a5ce1f6d6589495c commit: 1062f9781924f211b3f55b8d830ea3e489f5bab4 [138/644] netfilter: xt_IDLETIMER: Add new netlink msg type net/netfilter/xt_IDLETIMER.c:131 idletimer_tg_show()

[kbuild] [tixy:integration-linaro-vexpress64 282/644] drivers/video/adf/adf_fbdev.c:139 adf_modeinfo_to_fb_videomode() warn: suspicious bitop condition

2014-12-16 Thread Dan Carpenter
tree: https://git.linaro.org/people/tixy/kernel integration-linaro-vexpress64 head: 767452a1ba48d05ee26d47c5a5ce1f6d6589495c commit: a1eadbd034a44e33191e5eefb1ca21f818bc0d43 [282/644] video: adf: add fbdev compatibility helper drivers/video/adf/adf_fbdev.c:139 adf_modeinfo_to_fb_videomode()

Re: [kbuild] drivers/mailbox/pcc.c:119 pcc_mbox_request_channel() error: 'chan' dereferencing possible ERR_PTR()

2014-12-17 Thread Dan Carpenter
I reported this one earlier. regards, dan carpenter On Wed, Dec 17, 2014 at 06:05:20AM +0800, kbuild test robot wrote: TO: Ashwin Chaugule ashwin.chaug...@linaro.org CC: Jassi Brar jaswinder.si...@linaro.org tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

[kbuild] [mac80211-next:master 14/18] net/mac80211/mlme.c:4235 ieee80211_prep_connection() error: we previously assumed 'new_sta' could be null (see line 4232)

2014-12-17 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 59c9880de7bcb0be8660405040917bb47a8300fc commit: 1b104407afcc67d9f430d505a7b5f7b11e6b2d59 [14/18] mac80211: Fix ignored HT override configurations net/mac80211/mlme.c:4235 ieee80211_prep_connection()

Re: [kbuild] [peterz-queue:perf/core 34/45] kernel/events/core.c:4365 perf_mmap_close() error: double unlock 'mutex:event-mmap_mutex'

2015-02-05 Thread Dan Carpenter
The locking check sucks. I need to re-write it. regards, dan carpenter On Tue, Feb 03, 2015 at 10:47:55PM +0800, kbuild test robot wrote: TO: Peter Zijlstra pet...@infradead.org CC: Alexander Shishkin alexander.shish...@linux.intel.com tree: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [kbuild] [nfc-next:master 6/17] net/nfc/nci/hci.c:254 nci_hci_cmd_received() warn: assigning (-128) to unsigned variable 'status'

2015-02-05 Thread Dan Carpenter
The warning is correct-ish but the code is ok. regards, dan carpenter On Wed, Feb 04, 2015 at 05:20:27PM +0800, kbuild test robot wrote: TO: Christophe Ricard christophe.ric...@gmail.com CC: Samuel Ortiz sa...@linux.intel.com tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc

Re: [kbuild] [target:for-next 19/19] drivers/vhost/scsi.c:2139 vhost_scsi_make_tpg() warn: impossible condition '(tpgt (~0)) = (0-u32max u32max)'

2015-02-05 Thread Dan Carpenter
I sent a fix for this because it is a memory corruption bug and I am too selfish to share author credit on those. regards, dan carpenter On Tue, Feb 03, 2015 at 03:20:25PM +0800, kbuild test robot wrote: TO: Nicholas Bellinger n...@linux-iscsi.org tree: git://git.kernel.org/pub/scm/linux

<    1   2   3   4   5   6   7   8   9   10   >