[valgrind] [Bug 352395] Please provide SVN revision info in --version -v

https://bugs.kde.org/show_bug.cgi?id=352395 Philippe Waroquiers changed: What|Removed |Added Resolution|--- |FIXED

[valgrind] [Bug 352395] Please provide SVN revision info in --version -v

https://bugs.kde.org/show_bug.cgi?id=352395 Philippe Waroquiers changed: What|Removed |Added Summary|Please provide SVN revision |Please

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #29 from Austin English --- (In reply to Philippe Waroquiers from comment #28) > Strange that the git-svn version does not show a M(odified) marker. Yeah, I noticed that too. I'll try to remember to file a bug

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #28 from Philippe Waroquiers --- (In reply to Austin English from comment #27) > (In reply to Austin English from comment #26) > > Created attachment 102512 [details] > > try 10, extra sanity checks > > > >

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #27 from Austin English --- (In reply to Austin English from comment #26) > Created attachment 102512 [details] > try 10, extra sanity checks > > try 9 works for me, but I put some extra sanity checks in. In

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #26 from Austin English --- Created attachment 102512 --> https://bugs.kde.org/attachment.cgi?id=102512=edit try 10, extra sanity checks try 9 works for me, but I put some extra sanity checks in. In theory,

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Philippe Waroquiers changed: What|Removed |Added Attachment #102479|0 |1

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #24 from Philippe Waroquiers --- Created attachment 102509 --> https://bugs.kde.org/attachment.cgi?id=102509=edit try 8 : some additional fixes. -- You are receiving this mail because: You are watching all

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #23 from Philippe Waroquiers --- I have done: svn propset svn:executable ON auxprogs/make_or_upd_vgversion_h used shellcheck, which told me to put $1 between quotes, which I did and fixed the syntax error.

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #22 from Austin English --- (In reply to Ivo Raisr from comment #20) > Patch #6 seems to be working well. I tested it on Solaris, inside SVN tree, > outside and after 'make dist'. > > In addition to the last

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #21 from Ivo Raisr --- There is also online tool at: http://www.shellcheck.net/ However it did not catch the problem with mismatched then... -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #20 from Ivo Raisr --- Patch #6 seems to be working well. I tested it on Solaris, inside SVN tree, outside and after 'make dist'. In addition to the last comment by Austin, please change also:

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Bart Van Assche changed: What|Removed |Added CC||bvanass...@acm.org ---

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #18 from Philippe Waroquiers --- Created attachment 102479 --> https://bugs.kde.org/attachment.cgi?id=102479=edit try7 : fix syntax error in the git extract version bash -n is not reporting any syntax error

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Philippe Waroquiers changed: What|Removed |Added Attachment #102468|0 |1

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #17 from Austin English --- (In reply to Philippe Waroquiers from comment #16) > Created attachment 102468 [details] > try 6 : modified to have vgversion.h also handled as part of make dist > > Changed compared to

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Philippe Waroquiers changed: What|Removed |Added Attachment #102375|0 |1

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Ivo Raisr changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #14 from Philippe Waroquiers --- (In reply to Austin English from comment #13) > (In reply to Austin English from comment #12) > > How commonly are tarballs created/used for random SVN revisions rather than >

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #13 from Austin English --- (In reply to Austin English from comment #12) > How commonly are tarballs created/used for random SVN revisions rather than > releases? > > To be frank, I'm not very experienced with

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #12 from Austin English --- How commonly are tarballs created/used for random SVN revisions rather than releases? To be frank, I'm not very experienced with makefiles, and the current changes have already been a

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #11 from Philippe Waroquiers --- (In reply to austinengl...@gmail.com from comment #10) > (In reply to Ivo Raisr from comment #7) > > What happens (and what is the version) if this is run not inside a SVN/GIT

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #10 from austinengl...@gmail.com --- (In reply to Ivo Raisr from comment #7) > I had a look and overall it looks pretty good. > However 'pushd/popd' is a bash'ism and won't work in other shells. > Please can you try

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 austinengl...@gmail.com changed: What|Removed |Added Attachment #101951|0 |1 is

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #8 from Philippe Waroquiers --- Note also that we should avoid modifying vgversion.h each time we call make, as otherwise this will imply to recompile the including file(s). So, what we need is a command

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Ivo Raisr changed: What|Removed |Added CC||iv...@ivosh.net --- Comment #7

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #6 from austinengl...@gmail.com --- Created attachment 102288 --> https://bugs.kde.org/attachment.cgi?id=102288=edit try 4, run from make instead of configure Makefiles are not my specialty, so comments welcome.

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 Philippe Waroquiers changed: What|Removed |Added CC|

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 austinengl...@gmail.com changed: What|Removed |Added Attachment #94574|0 |1 is

[valgrind] [Bug 352395] Please provide SVN revision info in --version

https://bugs.kde.org/show_bug.cgi?id=352395 --- Comment #3 from austinengl...@gmail.com --- Created attachment 101947 --> https://bugs.kde.org/attachment.cgi?id=101947=edit try 2 This only shows svn info if -v/--verbose is given. Need to find a way to avoid