Created: kdepimlibs_include_dirs

Hello, Yesterday we created the KDEPIMLIBS_INCLUDE_DIRS definition in kdepimlibs. This one resolves compilation errors if: - CamelCase headers are used and - the kdepimlibs installation prefix is not the same as the kdelibs one. That also means that both KDEPIMLIBS_INCLUDE_DIR and

KDE/kdepimlibs

SVN commit 966746 by cgiboudeaux: As mentioned by Alex when KDEPIMLIBS_INCLUDE_DIRS was created, installing the kdepimlibs CamelCase headers in the same dir as the kdelibs ones is not a good idea. (different package - different dir). They will now be installed in include/KDEPIMLIBS. CCMAIL:

Re: KDE/kdepimlibs

On Monday 11 May 2009 22:59:15 Alexander Neundorf wrote: Are you sure you want to install the to all-uppercase include/KDEPIMLIBS/ and not maybe include/KDEPimLibs/ (or KDEPIMLibs/ or KdepimLibs/ ) ? This would look more friendly IMHO. I'd rather have KDEPIMLibs then. I'll change that right

Re: KDE/kdepimlibs

On Tuesday 12 May 2009 19:31:41 Andreas Pakulat wrote: As asked by Pino (just to make sure that this doesn't get lost as I've discussed with him a bit different things): Why is this done at all? All the headers in kdepimlibs are namespaced with the relevant libraries inside

Re: KDE/kdepimlibs

On Monday 11 May 2009 22:21:27 Christophe Giboudeaux wrote: SVN commit 966746 by cgiboudeaux: As mentioned by Alex when KDEPIMLIBS_INCLUDE_DIRS was created, installing the kdepimlibs CamelCase headers in the same dir as the kdelibs ones is not a good idea. (different package - different dir

Re: [Kde-pim] KdePimlibs overriding CMAKE_MODULE_PATH

On Sunday 07 June 2009 01:39:21 Alex Merry wrote: In KdepimLibsConfig.cmake.in, which is used to generate a file included when you do find_package(KdepibLibs), the KdepimLibs cmake module directory (typically the same as the KDE cmake module directory) is added to the front of

Re: [Kde-pim] KdePimlibs overriding CMAKE_MODULE_PATH

On Sunday 07 June 2009 11:13:15 Christophe Giboudeaux wrote: On Sunday 07 June 2009 01:39:21 Alex Merry wrote: The correct solution is deleting FindLibKNotificationItem-1.cmake from your installation dir. *and your CMakeCache.txt. There's a quick way to check

Re: [PATCH] akonadi can't be built in kdesupport

On Saturday 13 June 2009 00:49:57 Matthew Woehlke wrote: Slightly over-dramatic, but... I've gotten tired of having to bootstrap kdesupport because akonadi thinks it doesn't exist inside of there. I don't think this used to happen, but for some time it has been impossible to build (or even

Re: [PATCH] akonadi can't be built in kdesupport

On Saturday 13 June 2009 01:44:08 Matthew Woehlke wrote: Christophe Giboudeaux wrote: On Saturday 13 June 2009 00:49:57 Matthew Woehlke wrote: But I can tell you what happens. FindSoprano tries to read ${SOPRANO_INCLUDE}/soprano/version.h, which doesn't exist. It then has *a cmake error

Re: [Kde-pim] KdePimlibs overriding CMAKE_MODULE_PATH

On Sunday 07 June 2009 12:23:20 Alex Merry wrote: On Sunday 07 June 2009 10:13:15 Christophe Giboudeaux wrote: OK, I thought I'd checked that, but I misread the cmake file. Nonetheless, I don't think requiring KdepimLibs should prepend the KDE installation directory to CMAKE_MODULE_PATH

Re: [PATCH] akonadi can't be built in kdesupport

On Monday 15 June 2009 11:24:36 David Faure wrote: On Saturday 13 June 2009, Christophe Giboudeaux wrote: This file is generated and is in ${KDESupport_BINARY_DIR}/soprano/soprano. Generated? Maybe that's why the regex-read fails, if the file hasn't been generated yet? Well, looking

Re: [PATCH] akonadi can't be built in kdesupport

On Monday 15 June 2009 20:23:13 Alexander Neundorf wrote: On Saturday 13 June 2009, Christophe Giboudeaux wrote: On Saturday 13 June 2009 00:49:57 Matthew Woehlke wrote: Slightly over-dramatic, but... I've gotten tired of having to bootstrap kdesupport because akonadi thinks

Re: KDE/kdelibs/cmake/modules

On Sunday 05 July 2009 22:38:43 Alexander Neundorf wrote: I just checked and found that this did not happen. Please add a FindKdepim.cmake which aborts with message(FATAL_ERROR ... ) with a useful error message. Please add this also in 4.3 branch. This is a source incompatible change, and

Re: KdePimlibs overriding CMAKE_MODULE_PATH

Hi, On Monday 15 June 2009 20:08:14 Alexander Neundorf wrote: Some general notes: -modifying CMAKE_MODULE_PATH is only necessary for installed cmake modules -every installed cmake module (at least from kdelibs) has to be kept compatible at least until the end of KDE4, -so in general, we

Re: KdePimlibs overriding CMAKE_MODULE_PATH

On Wednesday 15 July 2009 22:59:20 Alexander Neundorf wrote: I would say so. At least completely removing set(CMAKE_MODULE_PATH ... ) is a source incompatible change, since then the using application is required to add the KDEPIMLIBS_MODULE_DIR to CMAKE_MODULE_PATH, otherwise it doesn't

Re: KDE/kdevelop/languages/cpp/tests

On Saturday 18 July 2009 11:50:43 Andreas Pakulat wrote: On 18.07.09 03:01:31, Aleix Pol wrote: hi, I've hit a problem when compiling a KDevelop test using gold. If we use the usual ld it works fine but with gold it requires all the libraries to be specified. As for what Andreas told me,

RFC: do not overwrite customs CMake flags

Hello, When building any module which includes KDE4Internals, the custom CMake flags are overwritten by the ones in this file which doesn't seem correct. Example: If I set : export CMAKE_CXX_FLAGS_DEBUGFULL=-ggdb3 -fno-inline or use -DCMAKE_CXX_FLAGS_DEBUGFULL; at compile time, these flags

Re: Problem with dependencies

Hi, On Tuesday 27 October 2009 16:42:26 Michael Jansen wrote: Hi Because of some qt problem i had to deactivate Nepomuk. It is a optional dependency in kdebase/runtime. Specifying -DWITH_Nepomuk=0 worked (I have nepomuk compiled. onto2vocab... just crashes on execution). It is only on

[Patch] Fix SharedDesktopOntologies.cmake

Hi, Here is a testcase and a simple fix for SharedDesktopOntologies.cmake: testcase: find_package(KDE4) include(KDE4Defaults) find_package(SharedDesktopOntologies 1.0) #Version 1.0 doesn't exist. What cmake does: - opens FindSharedDesktopOntologies.cmake and start looking for

Re: overriding CMAKE_MODULE_PATH

Hi, Le 16/08/2010 12:20, Michael Jansen a écrit : Because it is the right thing to do. The first line overriding it is just plain wrong imho. 1. CMAKE_MODULE_PATH is documented in cmake at the same level as CMAKE_PREFIX_PATH as a variable that changes behaviour. Which means a user can and

Re: Please review: cmake check for Cagibi

Hi, Le 23/08/2010 21:53, Friedrich W. H. Kossebau a écrit : Hi, following up to my and your emails on How to test for a D-Bus run-time dependency? last tuesday here please find and then comment on my proposal to test for the existance of cagibi during the build, so there is some hint at

Re: Please review: cmake check for Cagibi

Hi, Le 24/08/2010 21:31, Friedrich W. H. Kossebau a écrit : Mardi, le 24 août 2010, à 21:23, vous avez écrit: On Tuesday 24 August 2010, Friedrich W. H. Kossebau wrote: Mardi, le 24 août 2010, à 20:40, vous avez écrit: So okay to commit the attached patch, both to trunk and 4.5 branch?

Re: Automatic recording of required packages...

Hi, Le 31/10/2010 13:40, Alexander Neundorf a écrit : So I enhanced this a bit more, which resulted in FindPackageLog.txt-required. Maybe you see the problem, basically all packages are listed as OPTIONAL, while I guess not all of them are optional. The problem is our macro

Re: Please test: [CMake] CMake 2.8.4-rc1 ready for testing!

Hi, On Tuesday 18 January 2011 21:58:24 Alexander Neundorf wrote: So please, give this release candidate a good try, and let me know if something fails. Quick feedback. Thanks for finally turning off the verbose makefile when using the codeblock generator. I didn't notice any regression

kdebase-runtime unreachable on cdash.org ?

Hi, For whatever reason, the kdebase-runtime project is unreachable on my.cdash.org. the CTestConfig file submits the build reports to my.cdash.org/submit.php?project=kdebase-runtime sucessfully but I can't reach http://my.cdash.org/index.php?project=kdebase-runtime (I only get a 'You

[kde-runtime/KDE/4.7] /: Really fix the bin location.

Git commit 291810af8773d1d1f6feebed3d7b7ca0f558c268 by Christophe Giboudeaux. Committed on 24/10/2011 at 19:24. Pushed by cgiboudeaux into branch 'KDE/4.7'. Really fix the bin location. KDE4_BIN_INSTALL_DIR is the kdelibs binary dir which may be different than the kde-runtime one. CCMAIL

Issue with cmake 2.8.6 set_source_files_properties

Hi, I'd like to get rid of the FindQt4.cmake we have in Akonadi in order to use the QT_USE_IMPORTED_TARGETS option but I encounter a build issue without it. in server/CMakeLists.txt, there's this line: set_source_files_properties(src/nepomuk/org.kde.nepomuk.QueryService.xml PROPERTIES INCLUDE

Re: Re: Issue with cmake 2.8.6 set_source_files_properties

On Sunday 13 November 2011 23:58:18 Andreas Pakulat wrote: On 13.11.11 23:01:46, Christophe Giboudeaux wrote: Hi, I'd like to get rid of the FindQt4.cmake we have in Akonadi in order to use the QT_USE_IMPORTED_TARGETS option but I encounter a build issue without it. You can't

Re: The CMake situation in frameworks

Hi, On Friday 25 November 2011 02:24:55 Stephen Kelly wrote: == Communicating build parameters between modules == Some people don't want to set custom parameters for certain install directories and have those locations picked up by other depending modules. Eg, if a custom value is set for

Re: kdebase-runtime unreachable on cdash.org ?

On Thursday 20 October 2011 00:07:43 Christophe Giboudeaux wrote: Hi, For whatever reason, the kdebase-runtime project is unreachable on my.cdash.org. the CTestConfig file submits the build reports to my.cdash.org/submit.php?project=kdebase-runtime sucessfully but I can't reach http

Re: Review Request: Add option to control PAM support

On Jan. 29, 2012, 4:42 p.m., Alexander Neundorf wrote: The change in FindPAM.cmake is wrong. FindPAM.cmake does not care whether WITH_PAM is TRUE or not, when called, it will search PAM. If WITH_PAM is disabled, FindPAM.cmake will not be executed, and additionally all PAM_*

Re: Review Request: Add option to control PAM support

. ConfigureChecks.cmake http://git.reviewboard.kde.org/r/103818/#comment8508 This change is also not needed. the cmake/modules dir is already included by the main CMakeLists.txt - Christophe Giboudeaux On Feb. 2, 2012, 11:28 a.m., Michael Palimaka wrote

Re: Review Request: Add option to control PAM support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103818/#review10317 --- Ship it! - Christophe Giboudeaux On Feb. 3, 2012, 12:59 p.m

Required packages are wrongly reported by feature_summary

Hi, While working on kdepimlibs, I found a feature_summary behaviour that looks quite confusing (using 2.8.7). Short testcase: project(test) cmake_minimum_required(VERSION 2.8.7 FATAL_ERROR) include(FeatureSummary) find_package(KDE4 REQUIRED) feature_summary(WHAT ALL) which reports: -- The

Re: Required packages are wrongly reported by feature_summary

On Saturday 11 February 2012 17:32:36 Alexander Neundorf wrote: No, of course not. I'll have a look, this looks like a bug. Thanks, the output looks better now (I'm using the 'next' branch). I still see some report issue when the module name doesn't match the _FOUND variable name.

Re: Required packages are wrongly reported by feature_summary

On Friday 17 February 2012 15:55:15 Christophe Giboudeaux wrote: On Saturday 11 February 2012 17:32:36 Alexander Neundorf wrote: No, of course not. I'll have a look, this looks like a bug. Thanks, the output looks better now (I'm using the 'next' branch). I still see some report issue

Re: extra-cmake-modules installs into versionned dir

On Wednesday 22 February 2012 18:33:02 Alexander Neundorf wrote: On Tuesday 21 February 2012, Christophe Giboudeaux wrote: On Monday 20 February 2012 19:38:37 Sune Vuorela wrote: On Saturday 18 February 2012 18:45:54 Alexander Neundorf wrote: On Saturday 18 February 2012, David Faure

Re: Fwd: [CMake] CMake 2.8.9 available for download

On Friday 10 August 2012 20:11:24 Alexander Neundorf wrote: -- Forwarded Message -- Subject: [CMake] CMake 2.8.9 available for download Date: Thursday 09 August 2012, 23:17:04 From: David Cole david.c...@kitware.com To: cm...@cmake.org On behalf of myself, Ken, Bill,

Re: [kdelibs/KDE/4.10] cmake/modules: CMake: remove files now coming with cmake 2.8.8

Hi, On Tuesday 30 October 2012 20:18:15 Alex Neundorf wrote: Git commit 903ce6b2ee9bc09cabfb5ca36d82d50db986c7a6 by Alex Neundorf. Committed on 27/10/2012 at 16:59. Pushed by neundorf into branch 'KDE/4.10'. CMake: remove files now coming with cmake 2.8.8 It seems these are the only

Re: [kdelibs/KDE/4.10] cmake/modules: CMake: remove files now coming with cmake 2.8.8

On Wednesday 31 October 2012 15:20:00 Christophe Giboudeaux wrote: Hi, On Tuesday 30 October 2012 20:18:15 Alex Neundorf wrote: Git commit 903ce6b2ee9bc09cabfb5ca36d82d50db986c7a6 by Alex Neundorf. Committed on 27/10/2012 at 16:59. Pushed by neundorf into branch 'KDE/4.10'. CMake

Re: Boost detection failure with CMake 2.8.8

On Monday 03 December 2012 22:09:35 Alexander Neundorf wrote: On Friday 30 November 2012, Christophe Giboudeaux wrote: Hi, We're getting some reports about kdepimlibs and the Boost detection with CMake 2.8.8. The issue cannot be reproduced with 2.8.10.2. CMakeLists.txt: project

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

Hi, On Thursday 20 December 2012 14:12:17 Yury G. Kudryashov wrote: Ben Cooksley wrote: On Thu, Dec 20, 2012 at 9:02 PM, Andreas Pakulat ap...@gmx.de wrote: Hi, Hi, On Thu, Dec 20, 2012 at 1:11 AM, Ben Cooksley bcooks...@kde.org wrote: Git commit

Review Request: Fix the PopplerQt4 detection when using set_package_properties

) cmake_minimum_required(VERSION 2.8.9) find_package(KDE4 REQUIRED) include(KDE4Defaults) find_package(PopplerQt4 MODULE) set_package_properties(PopplerQt4 PROPERTIES TYPE REQUIRED) feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES) works with this patch Thanks, Christophe Giboudeaux

Review Request: Port kdelibs to feature_summary

solid/solid/CMakeLists.txt b7dcc97 sonnet/plugins/CMakeLists.txt 9d69005 Diff: http://git.reviewboard.kde.org/r/108002/diff/ Testing --- No issue detected. CMake detects the same dependencies as before. Thanks, Christophe Giboudeaux ___ Kde

Re: Review Request: Port kdelibs to feature_summary

Hi, On Monday 31 December 2012 11:54:22 David Faure wrote: Hi Christophe, This creates a nice set of conflicts in frameworks. [...] Can you do git merge origin/master in a frameworks checkout and fix the conflicts? Done, please double check if all still builds Christophe

Re: Review Request 108516: Do not hardcode site-packages for the python libdir.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26029 --- Ship it! Looks good, Thanks ! - Christophe Giboudeaux

Re: Review Request 108516: Do not hardcode site-packages for the python libdir.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26030 --- Ship it! Looks good, Thanks ! - Christophe Giboudeaux

Review Request 108701: Find libgfortran if it's installed in custom prefixes

tarball. Thanks, Christophe Giboudeaux ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 108701: Find libgfortran if it's installed in custom prefixes

--- Tested successfully with the 4.10 tarball. Thanks, Christophe Giboudeaux ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 110319: drop bodega cmake finder and use cmake config instead

://git.reviewboard.kde.org/r/110319/#comment23927 You may use set_and_check instead of set - Christophe Giboudeaux On May 6, 2013, 9:06 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: CMake 2.8.11 Released!

On Friday 17 May 2013 11:09:11 Robert Maynard wrote: On behalf of myself, Ken, Bill, Brad, David, Alex, Eike, Steve, Eric, Zach, Ben and the rest of the CMake team from all around the world, we are pleased to announce that CMake 2.8.11 is now available for download at:

Re: CMake 2.8.11 Released!

On Monday 20 May 2013 11:18:57 Christophe Giboudeaux wrote: On Friday 17 May 2013 11:09:11 Robert Maynard wrote: On behalf of myself, Ken, Bill, Brad, David, Alex, Eike, Steve, Eric, Zach, Ben and the rest of the CMake team from all around the world, we are pleased to announce that CMake

Re: Review Request 112448: FindSamba add PkgConfig fallback

() find_path(SAMBA_INCLUDE_DIR NAMES libsmbclient.h HINTS ${PC_SAMBA_INCLUDEDIR}) find_library(SAMBA_LIBRARIES NAMES smbclient HINTS ${PC_SAMBA_LIBDIR}) - Christophe Giboudeaux On Sept. 2, 2013, 1:04 p.m., Mark Gaiser wrote

Re: Review Request 112448: FindSamba add PkgConfig fallback

On Monday 09 September 2013 21:37:37 Stephen Kelly wrote: Stephen Kelly wrote: Christophe Giboudeaux wrote: find_library(SAMBA_LIBRARIES NAMES smbclient HINTS ${PC_SAMBA_LIBDIR}) This should be _LIBRARY, not _LIBRARIES. Followed by: set(SAMBA_LIBRARIES ${SAMBA_LIBRARY}) The patch

Re: [kdeplasma-addons] /: only have one call to project() it's all the same project and it causes variables to get overwritten

On Monday 09 March 2015 15:47:08 Jonathan Riddell wrote: Git commit 45bc8242e586d1a5372d9da49b3368561d651ab9 by Jonathan Riddell. Committed on 09/03/2015 at 15:46. Pushed by jriddell into branch 'master'. only have one call to project() it's all the same project and it causes variables to

Re: [Digikam-devel] [Kde-pim] Akonadi Contact library: Targets not properly exported

On samedi 9 avril 2016 08:53:51 CEST Ben Cooksley wrote: > On Sat, Apr 9, 2016 at 12:38 AM, Gilles Caulier > > wrote: > > Hi Scarlet, > > Hi GIlles, PIM developers, > > > -#include > > +#include > > > > This patch sound like a wrong way to handle frameworks header.

Re: [Kde-pim] Akonadi Contact library: Targets not properly exported

On mercredi 30 mars 2016 20:19:29 CEST Ben Cooksley wrote: > On Tue, Mar 29, 2016 at 10:46 PM, Sandro Knauß wrote: > > Those are the header generation and installation routines - which do > indeed look. > What is missing in this case is the include path specification for the >

D7253: Add build-flatpak target if there is a flatpak recipe around

cgiboudeaux added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:361 > +function(_find_json_recipe json_recipe) > +execute_process(COMMAND git ls-files *org.kde.*.json > +OUTPUT_VARIABLE json find_package(Git) if(Git_FOUND) execute_process(COMMAND GIT_EXECUTABLE...

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux Cc: #frameworks, #build_system

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

cgiboudeaux added a comment. Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

cgiboudeaux added a comment. In https://phabricator.kde.org/D7198#134234, @cgiboudeaux wrote: > Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 (+ https://phabricator.kde.org/R240:ef01c93637e1840ee701673970a371c011e36a40) REPOSITORY R240

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added a comment. -1. They don't match the ECM coding style and code quality (doc, license, endif(), pkgconfig...) And : > kdelibs4support/cmake/modules/FindGLIB2.cmake > ecm/attic/modules/FindGLIB2.cmake These two are there for legacy purpose. >

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added inline comments. INLINE COMMENTS > FindGLIB2.cmake:10 > +# True if the GLib2 library is available > +# ``GLIB2_INCLUDE_DIR`` > +# The GLib2 include directory Call it GLIB2_INCLUDE_DIRS. > FindGLIB2.cmake:43 > +# > +# For details see the accompanying

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added a comment. Looks good. What's your migration plan ? if you don't want to bump the ECM requirements for applications looking for pulseaudio, you have to set some compatibility/deprecated vars (eg: kmix uses uppercase variables) INLINE COMMENTS > FindPulseAudio.cmake:109

D8780: Try `llvm-config` to find `libclang`

cgiboudeaux added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:212 > +libclang_LIBRARY > +clang > +PATH ${LLVM_LIBDIR} NAMES clang clang-3.8 clang-3.9 and remove the lines 234-239 > FindPythonModuleGeneration.cmake:213 > +

D8998: Add FindSeccomp to find-modules

cgiboudeaux added a comment. Mostly good. Last question : is the version important ? If yes, please add an additional way to get the version if Seccomp_VERSION is empty. (you can parse seccomp.h to find it, look at the other Find*.cmake modules for examples) INLINE COMMENTS >

D8998: Add FindSeccomp to find-modules

cgiboudeaux added inline comments. INLINE COMMENTS > FindSeccomp.cmake:12 > +# The seccomp include directories > +# ``Seccomp_LIBRARIES`` > +# The seccomp libraries for linking so, what about naming your variables Seccomp_LIBRARIES and Seccomp_INCLUDE_DIRS in the file ? >

Frameworks and pkgconfig files

Hello, in https://bugs.kde.org/386933, the bug reporter mentions the pkgconfig file name shall match the library one. Do we have a policy about the pkgconfig stuff ? Only a couple frameworks install such files with different scheme (Baloo (uppercase B), libKF5Attica (library name),

D9056: Add the description tag to the generated pkgconfig files

cgiboudeaux created this revision. cgiboudeaux added reviewers: dfaure, apol. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY pkgconfig complains when the .pc file doesn't have a description.

D9056: Add the description tag to the generated pkgconfig files

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fd60f2b893d0: Add the description tag to the generated pkgconfig files (authored by cgiboudeaux). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

cgiboudeaux added a comment. In https://phabricator.kde.org/D9299#179032, @kfunk wrote: > If we'd name this file somewhat less generic then it could be even installed by default, no? > > I had the scheme of the QNX setup script in my mind:

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

cgiboudeaux added a comment. In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote: > In https://phabricator.kde.org/D9299#179032, @kfunk wrote: > > > If we'd name this file somewhat less generic then it could be even installed by default, no? > > > > I had the scheme

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

cgiboudeaux added a comment. +1. Please add the missing documentation about this new option. INLINE COMMENTS > apol wrote in KDEInstallDirs.cmake:700-704 > Usually isn't necessary as you get the libraries through the rpath. I can add > it though. It won't harm and solve potential issues if

D8780: Try `llvm-config` to find `libclang`

cgiboudeaux added inline comments. INLINE COMMENTS > turbov wrote in FindPythonModuleGeneration.cmake:212 > What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0??? > > I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to > 5.0 available)... installing

D8780: Try `llvm-config` to find `libclang`

cgiboudeaux added inline comments. INLINE COMMENTS > turbov wrote in FindPythonModuleGeneration.cmake:213 > Why `HINTS` is "better"?? As for me this is not a "hint" -- at this point we > know exactly the correct libdir location... it is why I use `PATH`...

D8777: restore old behaviour of FindPulseAudio

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c02178fa380c: restore old behaviour of FindPulseAudio (authored by jhirte, committed by cgiboudeaux). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D8790: Add FindSasl2.cmake to ECM

cgiboudeaux added a project: KDE PIM. cgiboudeaux added a reviewer: KDE PIM. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8790 To: cgiboudeaux, #kde_pim Cc: #frameworks, #build_system, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

D8790: Add FindSasl2.cmake to ECM

cgiboudeaux created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY We have copies of this module in several PIM repositories (kdepim-runtime, kldap, kimap, libksieve...).

D8777: restore old behaviour of FindPulseAudio

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Please commit after fixing the last issue. INLINE COMMENTS > FindPulseAudio.cmake:123 > > -mark_as_advanced(PulseAudio_INCLUDE_DIRS PulseAudio_INCLUDE_DIR > -

D8777: restore old behaviour of FindPulseAudio

cgiboudeaux added a comment. you also need set(PULSEAUDIO_FOUND "${PulseAudio_FOUND}"). You then have to move the compat variables below "find_package_handle_standard_args". Please also fix the mark_as_advanced() line to match the renamed vars. REPOSITORY R240 Extra CMake Modules

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added a comment. In https://phabricator.kde.org/D7823#164474, @cgiboudeaux wrote: > Don't forget to create .rst files in doc/find-module and change 'Since 5.39.0' to 'Since 5.40.0' '5.41.0', sorry REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. No news from the ECM maintainer, please push. Don't forget to create .rst files in doc/find-module and change 'Since 5.39.0' to 'Since 5.40.0' REPOSITORY R240 Extra CMake

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. +1. Tested with a few repo without noticing any regression. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D8660 To:

D8281: Allow to use IcoTool for Windows icons

cgiboudeaux added inline comments. INLINE COMMENTS > FindIcoTool.cmake:1 > +# Copyright 2017 Vincent Pinon > +include(${CMAKE_CURRENT_LIST_DIR}/ECMFindModuleHelpersStub.cmake) This module doesn't have any license and doesn't provide any doc. > FindIcoTool.cmake:3 >

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added a comment. In https://phabricator.kde.org/D7823#164880, @marten wrote: > In https://phabricator.kde.org/D7823#164879, @cfeck wrote: > > > Are the copies in the attic directory still needed for compatibility reasons, or can they get removed? > > > No needed by

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. -1 this will not work for anyone. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol Cc: cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#174856, @dfaure wrote: > Well, it's just a hint. If it's not found there, no harm done. But yeah, at least the paths for most distros could be there, to be fair ;) > > For OpenSuSE no change needed, it's in /usr/bin.

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:700-704 > +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS > +export XDG_CONFIG_DIRS=${KDE_INSTALL_FULL_CONFDIR}:$XDG_CONFIG_DIRS > +export PATH=${KDE_INSTALL_FULL_BINDIR}:$PATH > +export

D12867: Fix minor documentation typos

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks. Please use the GIT_SILENT keyword for typo fixes. REPOSITORY R240 Extra CMake Modules BRANCH doc_typos (branched from master) REVISION DETAIL

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux added a comment. Please update the doc above. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux added a comment. Thanks. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux added a comment. Thanks, just remove the trailing space before the 2 closing parenthesis. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D10166 (branched from master) REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid, cgiboudeaux Cc: kde-frameworks-devel,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D10166 (branched from master) REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem,

D13698: Improve ECMAddAppIconMacro.

cgiboudeaux added inline comments. INLINE COMMENTS > vpinon wrote in FindIcoTool.cmake:1 > Hello, > FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure > I can really claim the copyright. > In any case, I would choose the same license as all other ECM files (among >

D13698: Improve ECMAddAppIconMacro.

cgiboudeaux added inline comments. INLINE COMMENTS > FindIcoTool.cmake:1 > +# Copyright 2017 Vincent Pinon > + - Missing doc - Missing license > ECMAddAppIcon.cmake:70 > > + > > #= extra line that shouldn't be

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#186638, @asturmlechner wrote: > Can we move forward with this? ECM provides ECMQueryQmake.cmake. you can try eg: include("${ECM_MODULE_DIR}/ECMQueryQmake.cmake") then calling query_qmake(qt_binaries_dir

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#198423, @asturmlechner wrote: > Want me to fix FindQtWaylandScanner.cmake in the same way? Sure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol,

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10201 To: asturmlechner, #frameworks, #build_system, cgiboudeaux Cc:

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux added a comment. These flags are not in the Clang warnings (list for each version here: https://github.com/Barro/compiler-warnings) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid Cc: cgiboudeaux, dhaumann, #frameworks,

  1   2   3   >