[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. In https://phabricator.kde.org/D3850#72081, @kfunk wrote: > In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > > > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like a

D5866: ecm_qt_declare_logging_category(): more unique include guard for header

elvisangelaccio added a comment. What about `#pragma once`? Is there some real-world compiler that doesn't support it? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5866 To: kossebau, #frameworks, #build_system Cc: elvisangelaccio

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

elvisangelaccio added a comment. In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable the target if `BUILD_TESTING` is false, why is that not enough? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: elvisangelaccio

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

elvisangelaccio added a comment. Oh, I see. +1 then! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY If there is a `org.kde.*.json` file in the git repository of the cmake project, we assume is a flatpak re

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio added reviewers: apol, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7253 To: elvisangelaccio, apol, #frameworks Cc: #frameworks, #build_system

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio added a comment. Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone). One usually already has a build folder around, so the idea is you change some code

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio added a comment. In https://phabricator.kde.org/D7253#134703, @apol wrote: > In https://phabricator.kde.org/D7253#134653, @elvisangelaccio wrote: > > > Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio abandoned this revision. elvisangelaccio added a comment. In https://phabricator.kde.org/D7253#135251, @apol wrote: > Ugh my bad ^^', I don't know what happened. > > > The reason why I'm discussing this is that I think one of the advantages of Flatpak > > is that i

D7347: Add support for uninstalled plugin in kcoreaddons_add_plugin

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If find_package(ECM 5.38) or higher was called, output the plugin in a INSTALL_NAMESPACE subfolder of the "bin" folder. This w

D7347: Add support for uninstalled plugins in kcoreaddons_add_plugin

elvisangelaccio retitled this revision from "Add support for uninstalled plugin in kcoreaddons_add_plugin" to "Add support for uninstalled plugins in kcoreaddons_add_plugin". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7347 To: elvisangelaccio, #build_system, d

D7347: Add support for uninstalled plugins in kcoreaddons_add_plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3dfa71021300: Add support for uninstalled plugins in kcoreaddons_add_plugin (authored by elvisangelaccio). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7347?v

How to prepend CMAKE_LIBRARY_OUTPUT_DIRECTORY to QCoreApplication::libraryPaths() ?

Hi, I have a weird crash in ark if I enable the target generation in the bin subfolder [1]. The problem is that QCoreApplication::libraryPaths() returns the following list: ark.kerfuffle: ("/usr/lib/qt/plugins", "/home/elvis/dev/kde/ark/build/bin") which means that ark loads first its sy

Re: How to prepend CMAKE_LIBRARY_OUTPUT_DIRECTORY to QCoreApplication::libraryPaths() ?

On domenica 11 marzo 2018 19:50:44 CET, David Faure wrote: On dimanche 11 mars 2018 12:08:27 CET Elvis Angelaccio wrote: Hi, I have a weird crash in ark if I enable the target generation in the bin subfolder [1]. The problem is that QCoreApplication::libraryPaths() returns the following list

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio created this revision. elvisangelaccio added reviewers: apol, smartins. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY clazy 1.5 renamed its plug

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio added a comment. Note: this will break with older clazy versions. I'm not sure how to prevent that. One could argue that a developer interested in clazy should probably run the latest version anyway... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabric

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio updated this revision to Diff 50790. elvisangelaccio marked an inline comment as done. elvisangelaccio added a comment. Addressed comments REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18680?vs=50735&id=50790 BRANCH master R

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18680 To: elvisangelaccio, apol, smartins Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ba3341c83b18: Fix ENABLE_CLAZY option with clazy >= 1.5 (authored by elvisangelaccio). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18680?vs=50790&id=

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. Where does this FindTaglib.cmake come from? We should probably use the one from kio-extras, which got a bunch of fixes in the last months. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-bu

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. In D21695#476826 , @heikobecker wrote: > I'm not entirely sure about taglib-config on Windows See https://cgit.kde.org/kio-extras.git/commit/cmake/FindTaglib.cmake?id=548f525f4308810888c85f42a570139029c40

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. @heikobecker are you still interested in this patch? I can take over otherwise. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: ngraham, elvisangela

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. New attempt at https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/6 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: asturmlechne

D21695: Add FindTaglib.cmake

elvisangelaccio abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: elvisangelaccio, kde-buildsystem, kde-frameworks-devel, dfaure, heikobecker Cc: asturmlechner, ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, cblack

D21695: Add FindTaglib.cmake

elvisangelaccio commandeered this revision. elvisangelaccio added a reviewer: heikobecker. elvisangelaccio added a comment. In D21695#675056 , @elvisangelaccio wrote: > New attempt at https://invent.kde.org/frameworks/extra-cmake-modules/-/merge

[Differential] [Updated, 8 lines] D3733: Force colored warnings in ninja's output

elvisangelaccio updated this revision to Diff 9437. elvisangelaccio added a comment. - Add color switch only if the generator is Ninja REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3733?vs=9169&id=9437 BRANCH ninja-colors REVISION DETAIL

[Differential] [Closed] D3733: Force colored warnings in ninja's output

This revision was automatically updated to reflect the committed changes. Closed by commit R240:dc525a42ae70: Enable colored warnings in ninja's output (authored by elvisangelaccio). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3733?vs=9437&id=94