Hi Brad,
thanks for your answer.
Am Freitag, 12. Mai 2006 23:36, schrieb Brad King:
Friedrich W. H. Kossebau wrote:
Alex, William, any other cmake guru, please:
(How) could we build static libraries?
add_library(mylib-static STATIC src1.cxx src2.cxx)
If you want it to have the same name
(Resent, as the first post seems to be lost:)
Hi Alex, :)
Am Samstag, 13. Mai 2006 18:37, schrieb Alexander Neundorf:
On Saturday 13 May 2006 14:14, Friedrich W. H. Kossebau wrote:
Different name is okay, but is there a possibility the libs could share
the object files to be build?
I
Hi,
cmake 2.4.* seems to fail creating moc files in kdepimlibs (current svn).
[ 0%] Building CXX object kxmlrpcclient/CMakeFiles/kxmlrpcclient.dir/server.o
/home/koder/Programmieren/kdesvn/trunk/KDE/kdepimlibs/kxmlrpcclient/server.cpp:185:22:
error: server.moc: Datei oder Verzeichnis nicht
Am Freitag, 11. August 2006 17:26, schrieb William A. Hoffman:
At 11:00 AM 8/11/2006, Friedrich W. H. Kossebau wrote:
Hi Bill,
Am Freitag, 11. August 2006 15:05, schrieb William A. Hoffman:
The dashboard for kdelibs looks good:
Yes, kdebase, kdeutils and kdelibs do fine for me
Taking the list back into address (sorry for not checking before):
Am Freitag, 11. August 2006 22:37, schrieb Alexander Neundorf:
On Friday 11 August 2006 22:23, Friedrich W. H. Kossebau wrote:
Hi Alex,
...
and run cmake:
---8 ---
--
file:
/home/koder/Programmieren/kdesvn/trunk
Am Freitag, 11. August 2006 23:09, schrieb Alexander Neundorf:
On Friday 11 August 2006 22:55, Friedrich W. H. Kossebau wrote:
From what I see cmake 2.4.* itself has some broken inner state here.
Perhaps someone could attach a a debugger to it? ;)
It might have to do with some escaping, so
Am Freitag, 11. August 2006 13:05, schrieb Friedrich W. H. Kossebau:
Hi,
cmake 2.4.* seems to fail creating moc files in kdepimlibs (current svn).
[ 0%] Building CXX object
kxmlrpcclient/CMakeFiles/kxmlrpcclient.dir/server.o
/home/koder/Programmieren/kdesvn/trunk/KDE/kdepimlibs
Am Sonntag, 13. August 2006 04:06, schrieb William A. Hoffman:
At 05:11 PM 8/12/2006, Friedrich W. H. Kossebau wrote:
The passing of 1 as a variable to the macro macro_bool_to_01 was the
culprit. CMakeLists.txt in kdepimlibs contained
macro_bool_to_01(LDAP_FOUND HAVE_LDAP 1
Am Sonntag, 13. August 2006 02:05, schrieb Matt Rogers:
On Saturday 12 August 2006 17:05, Alexander Neundorf wrote:
On Saturday 12 August 2006 23:11, Friedrich W. H. Kossebau wrote:
...
By digging for the last revision that builds, for example, and checking
every single change
Am Freitag, 11. April 2008, um 13:28 Uhr, schrieb Andreas Pakulat:
On 11.04.08 13:34:21, Friedrich W. H. Kossebau wrote:
What is the difference between the build version and api version? Is
build version the long major.minor.patch-level, and api version just
major.minor?
No, SOVERSION
Hi,
the kdeutils/printer-applet/cmake-modules/FindPyQt4.cmake check produces some
noise if PyQt4 is not found:
--- 8 ---
Traceback (most recent call last):
File
/home/koder/Kode/kdesvn/trunk/KDE/kdeutils/printer-applet/cmake-modules/
FindPyQt.py, line 9, in module
import PyQt4.pyqtconfig
Am Mittwoch, 7. Mai 2008, um 23:24 Uhr, schrieb Alexander Neundorf:
On Thursday 01 May 2008, Friedrich W. H. Kossebau wrote:
Hi,
the kdeutils/printer-applet/cmake-modules/FindPyQt4.cmake check produces
some noise if PyQt4 is not found:
--- 8 ---
Traceback (most recent call last
Hi,
see $subject. Is the attached patch okay? I once did a similar patch to the
variants in kdeutils/printer-applet/cmake-module (are they still needed?),
but then I have no real clue what is going on in cmake files.
Cheers
Friedrich
--
Okteta - KDE 4 Hex Editor -
Hi,
to ensure that example code showing how to use a library is up-to-date (and/or
the installed headers/libs are okay) I would like to have that code
automatically test-compiled directly after an installation of the headers/lib
(as triggered by make install). The example code is in files of
Hi Alex,
Vendredi, le 9 avril 2010, à 21:46, vous avez écrit:
On Friday 09 April 2010, Friedrich W. H. Kossebau wrote:
Hi,
TechBase [TB] teaches to install Phonon to $KDEDIR (!=$QTDIR). So I have
done. But I cannot get kdelibs to compile then, it only finds the system
one, which
Vendredi, le 9 avril 2010, à 22:52, Andreas Pakulat a écrit:
On 09.04.10 22:45:41, Friedrich W. H. Kossebau wrote:
Vendredi, le 9 avril 2010, à 21:46, vous avez écrit:
On Friday 09 April 2010, Friedrich W. H. Kossebau wrote:
Hi,
TechBase [TB] teaches to install Phonon to $KDEDIR
Samedi, le 10 avril 2010, à 21:03, vous avez écrit:
On Saturday 10 April 2010, Friedrich W. H. Kossebau wrote:
Vendredi, le 9 avril 2010, à 22:52, Andreas Pakulat a écrit:
On 09.04.10 22:45:41, Friedrich W. H. Kossebau wrote:
Vendredi, le 9 avril 2010, à 21:46, vous avez écrit
Hi,
messing around with the buildsystem I stumbled upon the message to port away
from UsePkgConfig. Trying to gain more experience with cmake I produced the
attached patches, they seem to work for me.
The ones for (K)Exiv2, KDCRaw and Kipi were more complex, did I match the
logic?
Okay to
Jeudi, le 15 avril 2010, à 21:41, Alexander Neundorf a écrit:
On Thursday 15 April 2010, Friedrich W. H. Kossebau wrote:
Hi,
messing around with the buildsystem I stumbled upon the message to port
away from UsePkgConfig. Trying to gain more experience with cmake I
produced the attached
Jeudi, le 15 avril 2010, à 22:33, Alexander Neundorf a écrit:
On Thursday 15 April 2010, Friedrich W. H. Kossebau wrote:
Jeudi, le 15 avril 2010, à 21:41, Alexander Neundorf a écrit:
On Thursday 15 April 2010, Friedrich W. H. Kossebau wrote:
Hi,
messing around
Ping... ?
Cheers
Friedrich
--
KDE Okteta - a simple hex editor - http://utils.kde.org/projects/okteta
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
Mardi, le 27 avril 2010, à 21:30, Alexander Neundorf a écrit:
On Monday 19 April 2010, Friedrich W. H. Kossebau wrote:
Jeudi, le 15 avril 2010, à 22:33, Alexander Neundorf a écrit:
...
This should be changed.
If pkg-config is there and brings a good result, this good result
should
Hi,
I want to add a check for the existance of the proper version of cagibi to the
buildsystem. cagibi is used by the network:/ kio-slave (well, its kded-module)
to get the list of UPnP devices on the local network, via D-Bus calls.
Just, the D-Bus calls are implemented manually in the
Hi Alex, :)
Mercredi, le 18 août 2010, à 00:15, Alexander Neundorf a écrit:
Hi Friedrich, :-)
On Tuesday 17 August 2010, Friedrich W. H. Kossebau wrote:
Hi,
...
So what could I do to test at build-time the correct version of cagibi,
so cagibi can be listed as usual as (missing
Mercredi, le 18 août 2010, à 00:17, Sune Vuorela a écrit:
On 2010-08-17, Friedrich W. H. Kossebau kosse...@kde.org wrote:
So what could I do to test at build-time the correct version of cagibi,
so cagibi can be listed as usual as (missing) dependency?
In general, you should not fail nor
Mardi, le 24 août 2010, à 01:24, Yury G. Kudryashov a écrit:
BTW, what about adding one more parameter to m_l_f that tells whether
dependency is a runtime dep (default to FALSE)? Or even add another macro
because required flag MUST be FALSE for runtime dependencies? Then we'll
be able to say:
Mardi, le 24 août 2010, à 20:40, vous avez écrit:
On Monday 23 August 2010, Friedrich W. H. Kossebau wrote:
The following 4 lines should be good enough:
find_program(CAGIBI_DAEMON NAMES cagibid)
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(Cagibi DEFAULT_MSG
Mardi, le 24 août 2010, à 20:02, Maciej Mrozowski a écrit:
On Tuesday 24 of August 2010 02:34:05 Friedrich W. H. Kossebau wrote:
Mardi, le 24 août 2010, à 01:24, Yury G. Kudryashov a écrit:
BTW, what about adding one more parameter to m_l_f that tells whether
dependency is a runtime dep
Mardi, le 24 août 2010, à 21:23, vous avez écrit:
On Tuesday 24 August 2010, Friedrich W. H. Kossebau wrote:
Mardi, le 24 août 2010, à 20:40, vous avez écrit:
So okay to commit the attached patch, both to trunk and 4.5 branch?
No, no.
Index: kdebase/runtime/cmake/modules/CMakeLists.txt
SVN commit 1168009 by kossebau:
added: file with info for packagers (first entry: runtime of network:/
kio-slave)
as proposed on kde-buildsystem@kde.org
CCMAIL:kde-buildsystem@kde.org
A README.packagers
___
Kde-buildsystem mailing
Hi Christophe,
Mardi, le 24 août 2010, à 21:45, Christophe Giboudeaux a écrit:
Hi,
Sorry but I still think it's a bad idea. macro_log_feature() should only
report missing build dependencies or in the future we'll have all kind
of not-so-useful messages about runtime deps in different modules.
Mardi, le 24 août 2010, à 22:21, Maciej Mrozowski a écrit:
On Tuesday 24 of August 2010 21:21:08 Friedrich W. H. Kossebau wrote:
Might be good if this could be standardized.
I still like Yury's proposal for that, as it integrates into the log
creation, so all dependencies can be seen at one
Thanks for your answers, Yury and Alex, but...
Jeudi, le 5 may 2011, à 20:02, vous avez écrit:
On Wednesday 04 May 2011, Friedrich W. H. Kossebau wrote:
Hi,
I have blindly copied this for cagibi but since then wonder if this is
correct in FindKDE4Internal.cmake:
_set_fancy
Am Freitag, 17. Februar 2012, 17:33:34 schrieb Alexander Neundorf:
A library must never install the Find-module for itself.
This defeats the purpose. This is like putting the remote control right next
to the TV, or the treasure map right into the treasure chest. You don't
know where the plan
Am Freitag, 17. Februar 2012, 19:34:38 schrieb Alexander Neundorf:
On Friday 17 February 2012, Friedrich W. H. Kossebau wrote:
Am Freitag, 17. Februar 2012, 17:33:34 schrieb Alexander Neundorf:
A library must never install the Find-module for itself.
This defeats the purpose
Hi Rex,
Am Sonntag, 10. Juni 2012, 13:00:37 schrieb Rex Dieter:
On 06/10/2012 12:41 PM, Rex Dieter wrote:
Seems some odd cmake borkage is going on trying to build kdesdk-4.8.90
(4.8.80 suffered the same, but I hadn't noticed then), in that any
modules using kde4_add_plugin seem to not get
Am Sonntag, 10. Juni 2012, 20:10:35 schrieb Friedrich W. H. Kossebau:
Hi Rex,
Am Sonntag, 10. Juni 2012, 13:00:37 schrieb Rex Dieter:
On 06/10/2012 12:41 PM, Rex Dieter wrote:
Seems some odd cmake borkage is going on trying to build kdesdk-4.8.90
(4.8.80 suffered the same, but I hadn't
Hi,
I need your, the buildsystem experts', help.
In the bugreport https://bugs.kde.org/show_bug.cgi?id=304794 the problem is
reported that building of Okteta with parallel jobs fails, due to a library
not created already when it is used to link to, cmp. this snippet from the
attached log
Am Donnerstag, 23. August 2012, 18:05:32 schrieb Michael Pyne:
On Thursday, August 23, 2012 23:58:22 Friedrich W. H. Kossebau wrote:
When proposing solutions, please keep in mind that I try to keep the
different modules as independent as possible, so moving things
around/outside
Hi Andreas and Raphael,
Am Freitag, 24. August 2012, 07:15:58 schrieb Andreas Pakulat:
Hi,
On Thu, Aug 23, 2012 at 11:58 PM, Friedrich W. H. Kossebau
kosse...@kde.org wrote:
I cannot reproduce this locally, but this might be just a timing issue.
As this problem has not been reported
plasma/CMakeLists.txt 674550d
Diff: http://git.reviewboard.kde.org/r/110563/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
d70f260
kross/modules/CMakeLists.txt d245fd8
kross/qts/CMakeLists.txt d8cb4a5
plasma/CMakeLists.txt 674550d
Diff: http://git.reviewboard.kde.org/r/110563/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-buildsystem mailing
cmake/modules/KDE4Macros.cmake 3db4e24
kjsembed/kjsembed/CMakeLists.txt d70f260
kross/modules/CMakeLists.txt d245fd8
kross/qts/CMakeLists.txt d8cb4a5
plasma/CMakeLists.txt 674550d
Diff: http://git.reviewboard.kde.org/r/110563/diff/
Testing
---
Thanks,
Friedrich W. H
, 6:45 p.m., Friedrich W. H. Kossebau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110563/
---
(Updated May 22, 2013, 6:45
Hi,
what decides about what gets added to extra-cmake-modules/find-modules and
thus installed?
I would need FindSharedMimeInfo.cmake, but that currently is only in
attic/modules.
For now kcoreaddons has a copy of FindSharedMimeInfo.cmake, and kdepimlibs got
a copy as well. There are some
/KDE4Macros.cmake 3db4e24
kjsembed/kjsembed/CMakeLists.txt d70f260
kross/modules/CMakeLists.txt d245fd8
kross/qts/CMakeLists.txt d8cb4a5
plasma/CMakeLists.txt 674550d
Diff: https://git.reviewboard.kde.org/r/110563/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
On Jan. 29, 2015, 11:15 nachm., Friedrich W. H. Kossebau wrote:
Aha, am not the only one with a patch about Various projects use various
naming conventions, so supporting only lowercase.h headers in
ECMGenerateHeaders is a bit limiting :)
Just that my case are CamelCase.h headers, see
update also with 2 unit tests (hm, not sure if those
tests should cover more combinations with other parameters).
Thanks,
Friedrich W. H. Kossebau
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde
Am Donnerstag, 5. Februar 2015, 12:00:33 schrieb Friedrich W. H. Kossebau:
Hi,
I am about to use ecm_add_app_icon, but cannot see which mininmal version of
ECM needs to be required to expect this macro to exist.
At least at
http://api.kde.org/ecm/module/ECMAddAppIcon.html
should cover more combinations with other parameters).
Thanks,
Friedrich W. H. Kossebau
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122317/#review76062
---
On Feb. 14, 2015, 4:11 nachm., Friedrich W. H. Kossebau wrote
make this part of the if/else
statement in lines 148-152 below?
Friedrich W. H. Kossebau wrote:
Because, if EGH_PREFIX is not set, then the lines in 148-152 will not be
reached. But EGH_ORIGINAL must be always checked if a proper value is set.
So needs to be done outside that if/else
0a2425f
Diff: https://git.reviewboard.kde.org/r/122317/diff/
Testing
---
Manually and in latest update also with 2 unit tests (hm, not sure if those
tests should cover more combinations with other parameters).
Thanks,
Friedrich W. H. Kossebau
Am Freitag, 6. Februar 2015, 09:46:32 schrieb Alex Merry:
Oh! I hadn't even thought about that - yes, modules should definitely
document a since-version. Just having a Since 1.7.0 (or whatever) line in
the documentation would be fine, I'd have thought. I can do that today.
And you did. Thanks
to have seen code where that is not consistent.
But that step to implement is left for those persons who really need it ;)
Diffs
-
modules/ECMGenerateHeaders.cmake bac5086
Diff: https://git.reviewboard.kde.org/r/122317/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
some more next week.
- Friedrich W. H. Kossebau
On Jan. 21, 2015, 9:25 nachm., Daniel Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122193
Hi,
you are a cmake and KDE buildsystem expert?
Prove that yourself and improve the world for others ;)
Here is the challenge:
https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/28/consoleText
Am Dienstag, 16. Juni 2015, 16:00:04 schrieb Friedrich W. H. Kossebau:
Anyone an idea for a workaround?
Forgot to mention:
no, QT5_WRAP_CPP(kis_async_merger_test_SRCS) has no effect.
It really seems cmake's automoc finds kis_async_merger_test.{h,cpp} to not be
worth to run moc on it.
Cheers
Am Montag, 8. Juni 2015, 14:52:12 schrieb Ben Cooksley:
On Sat, Jun 6, 2015 at 10:07 PM, Alex Merry alex.me...@kde.org wrote:
On Friday 05 June 2015 00:58:30 Friedrich W. H. Kossebau wrote:
you are a cmake and KDE buildsystem expert?
Prove that yourself and improve the world for others
Am Dienstag, 16. Juni 2015, 16:00:04 schrieb Friedrich W. H. Kossebau:
Am Montag, 8. Juni 2015, 14:52:12 schrieb Ben Cooksley:
On Sat, Jun 6, 2015 at 10:07 PM, Alex Merry alex.me...@kde.org wrote:
On Friday 05 June 2015 00:58:30 Friedrich W. H. Kossebau wrote:
you are a cmake and KDE
Am Dienstag, 16. Juni 2015, 19:16:11 schrieb Friedrich W. H. Kossebau:
Am Dienstag, 16. Juni 2015, 16:00:04 schrieb Friedrich W. H. Kossebau:
Am Montag, 8. Juni 2015, 14:52:12 schrieb Ben Cooksley:
On Sat, Jun 6, 2015 at 10:07 PM, Alex Merry alex.me...@kde.org wrote:
On Friday 05 June
Am Dienstag, 23. Juni 2015, 21:31:31 schrieb Alex Merry:
On Wednesday 17 June 2015 23:11:33 Friedrich W. H. Kossebau wrote:
Am Dienstag, 16. Juni 2015, 19:16:11 schrieb Friedrich W. H. Kossebau:
Interesting... seems renaming the target KisAsyncMergerTest to
something
else, e.g
Hi,
what approach is best-practise currently for testing internal parts of libs?
E.g. by symbols (classes) are not exported by default?
In Calligra we have code that uses XYZ_TEST_EXPORT macros for those symbols
which should be only exported in test-enabled builds, e.g. by defining
Hi Kevin, Jeremy & David,
thanks all for your replies so far, gives me/us a palette to chose from, nice
:)
Seems exporting symbols only for testing is not a great no-go with known big
traps, okay. So no need to port away from that tomorrow.
So... below:
Am Montag, 31. August 2015, 18:54:19
://bugs.kde.org/show_bug.cgi?id=362577 so please close it on commit.
- Friedrich W. H. Kossebau
On June 14, 2016, 9:14 p.m., Andreas Cord-Landwehr wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Hi,
Am Montag, 30. Mai 2016, 19:42:38 CEST schrieb Ben Cooksley:
> As you may recall, some time ago the CI scripts were adapted to
> forcibly inject ASAN into all test processes launched on the CI system
> to fix Marble's tests, as Marble does not use ECM and thus does not
> enable ASAN as a
tps://git.reviewboard.kde.org/r/126303/#comment62690>
Please add a "Since 5.19.0" (or whatever version the argument OUTFILE will
appear in first) to the end of the description of the argument.
- Friedrich W. H. Kossebau
On Jan. 19, 2016, 9:30 a.m., Domin
that warning only shown once?
Diffs
-
toolchain/Android.cmake 60bd058
Diff: https://git.reviewboard.kde.org/r/127701/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https
as submitted.
Review request for Extra Cmake Modules and Aleix Pol Gonzalez.
Changes
---
Submitted with commit e0cfec7848ba63190957e107c7ef32dbe0119c42 by Friedrich W.
H. Kossebau to branch master.
Repository: extra-cmake-modules
Description
---
Not all projects install something
------------
On April 20, 2016, 8:05 p.m., Friedrich W. H. Kossebau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127701/
&g
>
> (Updated Feb. 7, 2016, 9:32 p.m.)
>
>
> Review request for Build System, Cagibi, David Faure, and Friedrich W. H.
> Kossebau.
>
>
> Repository: cagibi
>
>
> Description
> ---
>
> This is needed for multiarch l
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126422/#review102151
---
Ship it!
Ship It!
- Friedrich W. H. Kossebau
On Feb
/
Testing
---
Thanks,
Friedrich W. H. Kossebau
marked as submitted.
Review request for Extra Cmake Modules.
Changes
---
Submitted with commit b60f1116b2cf0401f52060d7bdf0c524b918d23a by Friedrich W.
H. Kossebau to branch master.
Repository: extra-cmake-modules
Description
---
The RPATH handling part of KDECMakeSettings.cmake
Hi (especially the CMake experts),
as I uploaded this to Phabricator where no group "Buildsystem" or similiar
seems to exist yet, notifying you here manually.
Especially interested in comments on the use of "exported" CMake targets to
allow linking between different QCH files (also naming
her is maintaining).
Still needs the homepage and api link changes from this patch.
- Friedrich W. H. Kossebau
On Nov. 15, 2016, 10:53 a.m., Luigi Toscano wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
d idea, doing.
- Friedrich W. H.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127701/#review94739
---
On April 20, 2016, 8:05 p.m
the
toolchain file is run with every initial initial check? Any proposal how to
make that warning only shown once?
Diffs (updated)
-
toolchain/Android.cmake dccb79f
Diff: https://git.reviewboard.kde.org/r/127701/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
each argument in a separate
block.
modules/ECMAddApkPackageTarget_dependencyHelper.cmake (line 44)
<https://git.reviewboard.kde.org/r/128848/#comment67885>
"#we" what ? :)
- Friedrich W. H. Kossebau
On Sept. 6, 2016, 12:28 p.m., Andreas Cord-Landwehr wrote:
>
> -
Ping...
Am Freitag, 25. November 2016, 00:00:41 CET schrieb Friedrich W. H. Kossebau:
> Hi (especially the CMake experts),
>
> as I uploaded this to Phabricator where no group "Buildsystem" or similiar
> seems to exist yet, notifying you here manually.
>
> Espec
looking at the Android
toolchain?
- Friedrich W. H. Kossebau
On Dec. 12, 2016, 11:39 p.m., Friedrich W. H. Kossebau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
kossebau added a comment.
Given the slightly complicated history of what KDE_INSTALL_USE_QT_SYS_PATHS
does, I omitted a "since" on purpose for now.
Would you agree it makes sense to simplify things be just adding "Since 5.22"
and ignore previous behaviour?
See also
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REPOSITORY
R240 Extra CMake Modules
BRANCH
adddoxforqtsyspaths
REVISION DETAIL
https://phabricator.kde.org/D6773
AFFECTED FILES
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REVISION SUMMARY
when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set,
qmake can be considered a required dependency, otherwise the
kossebau added a comment.
See also https://phabricator.kde.org/D6773 for making the resulting behaviour
documented.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6772
To: kossebau, #frameworks, ltoscano, rdieter
Cc: #build_system
kossebau marked an inline comment as done.
kossebau added a comment.
If there are no objections, will push on Saturday, 29th July
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6772
To: kossebau, #frameworks, ltoscano, rdieter, apol
Cc: #build_system
kossebau added a comment.
In https://phabricator.kde.org/D6772#129531, @apol wrote:
> Works for me.
> Are you sure we don't need to include the `TRY` on other calls?
Any calls you would be thinking off? The ones where this patch does not add
`TRY` are in code which expects
kossebau added a comment.
A regression due to
https://phabricator.kde.org/R240:8ac7abb78d97210c5cbbc87fba83d58d7b843a8d Seems
the "it allows for modules using it to decide what they should do" was never
told the modules using it ;)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
kossebau added a reviewer: apol.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6772
To: kossebau, #frameworks, ltoscano, rdieter, apol
Cc: #build_system
kossebau added a comment.
In https://phabricator.kde.org/D6772#126799, @apol wrote:
> What's the background for the change?
When KDE_INSTALL_USE_QT_SYS_PATHS is explicitely set to ON but no qmake-qt5
executable found (like @rdieter reported to be possible on fedora packaging),
kossebau updated this revision to Diff 16912.
kossebau added a comment.
- use cmake_parse_arguments
- fix english grammar in dox
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6772?vs=16880=16912
BRANCH
handlenoqmakefound
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:f5c11c00198e: Add API dox for KDEInstallDirs'
KDE_INSTALL_USE_QT_SYS_PATHS (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6773?vs=16881=16952#toc
REPOSITORY
R240
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:b58820c4af64: Add or improve "Generated. Don't edit"
messages and make consistent (authored by kossebau).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:03fc1de44ef9: Fix usage of query_qmake: differ between
calls expecting qmake or not (authored by kossebau).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
kossebau added a comment.
+1 as well. Please also add a note in the API dox what BUILD_TESTING will do
on this macro, so this is not magic behaviour and people can plan with this
(like making sure to not `set target_link_libraries(... Qt5::Tests)`
separately, but only pass as args in the
kossebau added a comment.
A different reasoning for why not yet using `#pragma once`: this macro
targets users of projects with at least cmake and Qt. Unless Qt itself does not
use that pragma, let's not risk to screw over people who try to reuse ECM for
some non-mainstream setup, unless we
kossebau added a comment.
Yes, `#pragma once` might be the nicer solution here.
I stayed away from proposing it though, as for one it is not a real standard
by specifications and also by KDE coding traditions.
And I would not like to be the one adding (and thus being responsible) the
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
REPOSITORY
R240 Extra CMake Modules
BRANCH
improvegeneratednote
REVISION DETAIL
https://phabricator.kde.org/D5867
AFFECTED FILES
modules/ECMQmLoader.cpp.in
kossebau added a comment.
@palimaka You have KDE push rights, correct? Will you have time this week to
push this, or do you want someone/me to do that for you?
Would be good to have this in as soon as possible, given tagging release is
<2 weeks away :)
REPOSITORY
R240 Extra CMake
kossebau added a comment.
So pushing now myself, so this todo can be checked off :)
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6249
To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system
1 - 100 of 318 matches
Mail list logo
