Re: [kde-community] What is a GitHub pull request exactly?

On Wed, Sep 23, 2015 at 10:36 PM, Jonathan Frederickson < silverskull...@gmail.com> wrote: > > Would it be possible to integrate Github pull requests with reviewboard? > For example, if someone submits a pull request, have a bot automatically > post it to reviewboard and post a comment on the

Re: [kde-community] What is a GitHub pull request exactly?

On Wed, Sep 23, 2015 at 2:19 AM, Rajeev Bhatta wrote: > Agree 100% > > On Sun, 20 Sep 2015 15:07:29 +0200 > Riccardo Iaconelli wrote: > > > On Sunday, September 20, 2015 03:01:09 PM Luigi Toscano wrote: > > > Riccardo Iaconelli ha scritto: > > > > On

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, 2015-09-19, 23:06:47, Eike Hein wrote: > On 09/19/2015 10:32 PM, Kevin Krammer wrote: > > I don't see there this github review is coming from. > > Review is an interactive process where you ask for changes and > iterate. Once you open the door to doing it on GitHub, you will: > > *

Re: [kde-community] What is a GitHub pull request exactly?

On 2015-09-20, Jaroslaw Staniek wrote: > But effectively it won't be reviews because the KDE reviewers won't use it. > Or do you think we need some dracon law because our community cannot do > self-control? I have just been fooled once regarding github and KDE. That makes me not

Re: [kde-community] What is a GitHub pull request exactly?

On 2015-09-20, Kevin Krammer wrote: > First, I have no idea where this "use github for review" comes from at = > all. > Who wants to do that in the first place? The github pull requests comes automatically with review abilities, so once it is there and one already interacts with

Re: [kde-community] What is a GitHub pull request exactly?

On Sun, Sep 20, 2015 at 12:35 PM, Sune Vuorela wrote: > On 2015-09-20, Jaroslaw Staniek wrote: >> But effectively it won't be reviews because the KDE reviewers won't use it. >> Or do you think we need some dracon law because our community cannot do >>

Re: [kde-community] What is a GitHub pull request exactly?

On Sunday, September 20, 2015 06:39:02 PM Bhushan Shah wrote: > We don't need to replace Facebook.. tada. > > Facebook is not part of our development nor anything.. So lets not > compare with facebook.. When we talk about github and do our reviews > there. It will be recorded there and if github

Re: [kde-community] What is a GitHub pull request exactly?

On 2015-09-20, Riccardo Iaconelli wrote: > How exactly have you been fooled? > Proposal #1 - accepted, Proposal #1 was a pure mirror. No other services used. Before the initial mirror was actually completed, the next proposal comes up to start doing even more github. >

Re: [kde-community] What is a GitHub pull request exactly?

On Sunday, September 20, 2015 12:26:41 PM Sune Vuorela wrote: > Free software needs free tools. I am sorry, but sadly this is not the state of the art. KDE has been created with many non free tools and currently co-exists in many non-free environments. We can either decide to live with it and

Re: [kde-community] What is a GitHub pull request exactly?

On Sunday, September 20, 2015 01:51:19 PM Laszlo Papp wrote: > I just do not happen to see this case strong enough to support, > personally. We have not even tried to see how the mirror works out, > and we already think of whether or not it is a big problem not > allowing pull requests, et al. It

Re: [kde-community] What is a GitHub pull request exactly?

On Sunday, September 20, 2015 03:01:09 PM Luigi Toscano wrote: > Riccardo Iaconelli ha scritto: > > On Sunday, September 20, 2015 12:26:41 PM Sune Vuorela wrote: > >> Free software needs free tools. > > > > I am sorry, but sadly this is not the state of the art. KDE has been > > created with many

Re: [kde-community] What is a GitHub pull request exactly?

On Sunday, September 20, 2015 03:01:09 PM Luigi Toscano wrote: > Riccardo Iaconelli ha scritto: > > On Sunday, September 20, 2015 12:26:41 PM Sune Vuorela wrote: > >> Free software needs free tools. > > > > I am sorry, but sadly this is not the state of the art. KDE has been > > created with many

Re: [kde-community] What is a GitHub pull request exactly?

Riccardo Iaconelli ha scritto: > On Sunday, September 20, 2015 12:26:41 PM Sune Vuorela wrote: >> Free software needs free tools. > > I am sorry, but sadly this is not the state of the art. KDE has been created > with many non free tools and currently co-exists in many non-free > environments.

Re: [kde-community] What is a GitHub pull request exactly?

On Sun, Sep 20, 2015 at 6:33 PM, Riccardo Iaconelli wrote: > exactly, as soon as we could. > But not all tools simply are technical alternatives. Can we replace Facebook? > Sure, we could join Diaspora. But we would be missing out on the community > already present on Facebook.

Re: [kde-community] What is a GitHub pull request exactly?

On 09/19/2015 08:43 PM, Kevin Krammer wrote: > Well, the github side review will make the job of the KDE contributor who > brings the patch into KDE a lot easier, because when they put the patch up > for > review as "their" contribution, most of the things that the contributor knew > about

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, 2015-09-19, 20:56:31, Eike Hein wrote: > On 09/19/2015 08:43 PM, Kevin Krammer wrote: > > Well, the github side review will make the job of the KDE contributor who > > brings the patch into KDE a lot easier, because when they put the patch up > > for review as "their" contribution,

Re: [kde-community] What is a GitHub pull request exactly?

On 09/19/2015 09:55 PM, Kevin Krammer wrote: > Exactly. > So why would one continue to do the prelimiary review in addition to the > required one? > As soon as there is a stream of patches from a new contributor, that > contributor will be asked to get an account of their own. > Need for

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, 2015-09-19, 22:11:10, Eike Hein wrote: > On 09/19/2015 09:55 PM, Kevin Krammer wrote: > > Exactly. > > So why would one continue to do the prelimiary review in addition to the > > required one? > > As soon as there is a stream of patches from a new contributor, that > > contributor

Re: [kde-community] What is a GitHub pull request exactly?

On 19 September 2015 at 23:06, Eike Hein wrote: > > > On 09/19/2015 10:32 PM, Kevin Krammer wrote: >> I don't see there this github review is coming from. > > Review is an interactive process where you ask for changes and > iterate. Once you open the door to doing it on GitHub, you

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, 2015-09-19, 20:20:56, Eike Hein wrote: > On 09/19/2015 08:13 PM, Kevin Krammer wrote: > > I am afraid my understanding of the technical background of this is still > > too hazy. > > How would review "move" from KDE to github? > > If review on reviewboard is required (per project's

Re: [kde-community] What is a GitHub pull request exactly?

On 09/19/2015 08:13 PM, Kevin Krammer wrote: > I am afraid my understanding of the technical background of this is still too > hazy. > How would review "move" from KDE to github? > If review on reviewboard is required (per project's unwritten social > contract), it cannot not happen. > If it

[kde-community] What is a GitHub pull request exactly?

I have some difficulty understanding the perceived difference in workflow, so I'd like to get some input on where my line of thinking and reality differ :-) The following example deals with clones of a repository and the revision of HEAD in the master branch. Example: akonadiclient, three

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, 2015-09-19, 12:06:18, Michael Pyne wrote: > On Sat, September 19, 2015 17:32:33 Kevin Krammer wrote: > > So (a) and (b) workflows differ in that in (a) github mirror and > > git.kde.org have the same state, while in (b) the mirror is for a period > > of time not actually a mirror, but

Re: [kde-community] What is a GitHub pull request exactly?

On 09/19/2015 10:32 PM, Kevin Krammer wrote: > I don't see there this github review is coming from. Review is an interactive process where you ask for changes and iterate. Once you open the door to doing it on GitHub, you will: * Have a hard time making some contributors understand why they

Re: [kde-community] What is a GitHub pull request exactly?

On Sat, Sep 19, 2015 at 5:32 PM, Kevin Krammer wrote: > Where "ahead" could also mean wrong if "klmn" needs to be modified or gets > rejected. > > Is (b) the problem people keep discussing about? > > Because as far as I can tell it is not really an option given that it can lead >

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > If the problem is somewhere in (a), where is it? I'm afraid of code review happening through the pull request instead of our infrastructure. To me github pull requests are not just the "here's the patch", but also the code

Re: [kde-community] What is a GitHub pull request exactly?

On Sat, September 19, 2015 17:32:33 Kevin Krammer wrote: > So (a) and (b) workflows differ in that in (a) github mirror and git.kde.org > have the same state, while in (b) the mirror is for a period of time not > actually a mirror, but "ahead". > > Where "ahead" could also mean wrong if "klmn"

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, September 19, 2015 05:47:38 PM Martin Graesslin wrote: > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > > If the problem is somewhere in (a), where is it? > > I'm afraid of code review happening through the pull request instead of our > infrastructure. To me

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, September 19, 2015 6:11:21 PM CEST you wrote: > On Saturday, September 19, 2015 05:47:38 PM Martin Graesslin wrote: > > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > > > If the problem is somewhere in (a), where is it? > > > > I'm afraid of code review

Re: [kde-community] What is a GitHub pull request exactly?

On Sat, Sep 19, 2015 at 12:07 PM, Boudhayan Gupta wrote: > On 19 September 2015 at 21:17, Martin Graesslin > wrote: > > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > >> If the problem is somewhere in (a), where is it? > > > > I'm

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, September 19, 2015 12:26:34 PM CEST Martin Klapetek wrote: > On Sat, Sep 19, 2015 at 12:07 PM, Boudhayan Gupta wrote: > > On 19 September 2015 at 21:17, Martin Graesslin > > > > wrote: > > > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin

Re: [kde-community] What is a GitHub pull request exactly?

On 09/19/2015 06:22 PM, Martin Graesslin wrote: > And how do we do that? Can we enforce this technically or will that be > weakened over the time the same way as we just turned the mirror into "let's > accept pull requests"? This wishy-washy stuff is nonsense. The sole argument for enabling

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, 2015-09-19, 17:47:38, Martin Graesslin wrote: > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > > If the problem is somewhere in (a), where is it? > > I'm afraid of code review happening through the pull request instead of our > infrastructure. To me github

Re: [kde-community] What is a GitHub pull request exactly?

On Sat, Sep 19, 2015 at 6:37 PM, Martin Graesslin wrote: > What's important to realize: the people have already written the patch at the > point. Some time ago I wrote a patch for a software I hadn't contributed for > before: figuring out how to submit the patch was more way

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, September 19, 2015 6:40:47 PM CEST Kevin Krammer wrote: > On Saturday, 2015-09-19, 17:47:38, Martin Graesslin wrote: > > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > > > If the problem is somewhere in (a), where is it? > > > > I'm afraid of code review

Re: [kde-community] What is a GitHub pull request exactly?

On 09/19/2015 06:53 PM, Riccardo Iaconelli wrote: > On Saturday, September 19, 2015 06:44:24 PM Martin Graesslin wrote: >> No reality would be that it slowly moves code review from KDE to github. And >> I think we have here quite some people in the discussion who would love to >> see that > >

Re: [kde-community] What is a GitHub pull request exactly?

On 19 September 2015 at 21:17, Martin Graesslin wrote: > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: >> If the problem is somewhere in (a), where is it? > > I'm afraid of code review happening through the pull request instead of our > infrastructure.

Re: [kde-community] What is a GitHub pull request exactly?

On Saturday, September 19, 2015 06:44:24 PM Martin Graesslin wrote: > No reality would be that it slowly moves code review from KDE to github. And > I think we have here quite some people in the discussion who would love to > see that I don't think anyone ever thought that... o.o -Riccardo