Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8503 --- This fix causes a nasty regression which causes the plugin list

Review Request: Further fix for Bug 285731

2011-11-27 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103260/ --- Review request for KDE Runtime and Plasma. Description --- Though

Re: Fwd: Requesting freeze exception for JtG

2011-11-27 Thread Sebastian Kügler
On Sunday, November 27, 2011 01:03:34 Pau Garcia i Quiles wrote: On Sun, Nov 27, 2011 at 12:38 AM, Thomas Zander zan...@kde.org wrote: On Saturday 26 November 2011 14.09.21 Boudewijn Rempt wrote: A little flexibility, a little actual testing of the patch would be much more useful than

Re: Review Request: Fix KDateComboBox shrinking in size after a date is entered

2011-11-27 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103133/#review8535 --- Unless there are objections before then, I propose to apply

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Ben Cooksley
On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Thomas Lübking
On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.