[PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.

2012-10-08 Thread Jon Severinsson
The sign of the UTC offset was ignored, and an offset of -0500 (New York) would be treated at +0500 (Pakistan). This commit also adds a unit test for UTC offset parsing and comparasion. --- Hi When mucking around in the frameworks branch of kdelibs I found a bug in the KDateTime string parsing,

Re: Review Request: Device notifier: show mounted device and path

2012-10-08 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/ --- (Updated Oct. 8, 2012, 9:31 a.m.) Review request for KDE Base Apps and

Re: Review Request: Device notifier: show mounted device and path

2012-10-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/#review20057 --- any application which expects the user to access files on disk

Re: Review Request: Device notifier: show mounted device and path

2012-10-08 Thread Aaron J. Seigo
On Oct. 8, 2012, 9:52 a.m., Aaron J. Seigo wrote: any application which expects the user to access files on disk but does not provide a clear representation of mounted / removable devices is broken. there's no point in degrading our own primary UI for such fixable brokenness. can you

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20065 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-08 Thread Dawit Alemayehu
On Oct. 8, 2012, 10:30 a.m., David Faure wrote: konqueror/src/konqsessionmanager.cpp, line 123 http://git.reviewboard.kde.org/r/106503/diff/6/?file=88345#file88345line123 Did you change this if() wrongly? Now the code says if I could find the dialog-warning icon, then

Re: Review Request: Fix Konqueror's MMB click to close tab option

2012-10-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106615/ --- (Updated Oct. 8, 2012, 5:26 p.m.) Review request for KDE Base Apps and

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Oct. 8, 2012, 5:43 p.m.) Review request for KDE Base Apps and

Review Request: Make sure KPropertiesDialog inherits the 'Categories' property when creating a new desktop file from an existing one

2012-10-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106771/ --- Review request for kdelibs and David Faure. Description --- The

Re: [PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.

2012-10-08 Thread Michael Pyne
On Sunday, October 07, 2012 22:23:56 Jon Severinsson wrote: The sign of the UTC offset was ignored, and an offset of -0500 (New York) would be treated at +0500 (Pakistan). This commit also adds a unit test for UTC offset parsing and comparasion. --- Hi When mucking around in the frameworks

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-10-08 Thread Alexander Neundorf
On Sunday 30 September 2012, Alexander Neundorf wrote: On Saturday 29 September 2012, Michael Pyne wrote: On Saturday, September 29, 2012 12:12:43 André Wöbbeking wrote: On Saturday 29 September 2012 11:59:04 Rolf Eike Beer wrote: Am Samstag 29 September 2012, 11:48:16 schrieb André

RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Albert Astals Cid
Hi fellow kde-core-develers, i was thinking that from time to time someone commits some code that breaks the building of the tests. This happens because people is not aware that those parts are unit tested. I think that by enabling the building of the tests by default we at least make sure the

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Àlex Fiestas
Anything to make developers (including myself) more unit test aware, I'm all for it, even if it helps only a little bit.

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Allen Winter
On Monday 08 October 2012 10:40:55 PM Albert Astals Cid wrote: Hi fellow kde-core-develers, i was thinking that from time to time someone commits some code that breaks the building of the tests. This happens because people is not aware that those parts are unit tested. I think that by

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Lamarque V. Souza
Em Monday 08 October 2012, Àlex Fiestas escreveu: Anything to make developers (including myself) more unit test aware, I'm all for it, even if it helps only a little bit. +1 -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Ben Cooksley
On Tue, Oct 9, 2012 at 9:55 AM, Lamarque V. Souza lamar...@kde.org wrote: Em Monday 08 October 2012, Àlex Fiestas escreveu: Anything to make developers (including myself) more unit test aware, I'm all for it, even if it helps only a little bit. +1 +1 from me as well. -- Lamarque

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Andreas Hartmetz
On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: Hi fellow kde-core-develers, i was thinking that from time to time someone commits some code that breaks the building of the tests. This happens because people is not aware that those parts are unit tested. I think that by

Re: [PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.

2012-10-08 Thread David Jarvie
On Sunday 07 October 2012 21:23:56 Jon Severinsson wrote: The sign of the UTC offset was ignored, and an offset of -0500 (New York) would be treated at +0500 (Pakistan). This commit also adds a unit test for UTC offset parsing and comparasion. --- Hi When mucking around in the frameworks

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Martin Gräßlin
On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: Hi fellow kde-core-develers, i was thinking that from time to time someone commits some code that breaks the building of the tests. This happens because people is not aware that those parts are unit tested. I think that by