Re: [Kde-pim] Problems with infrastructure

2014-12-11 Thread Ivan Čukić
Yyou need to setup git correctly, so that gerrit in that command is valid, I see what you're saying, and you're probably right -- there's a bar, indeed. That bar could however be effectively removed by having a spoonfeeding, An alternative to the setup documentation is to actually do it

Re: Re: Review Request for KDecoration

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 00:05:52 Albert Astals Cid wrote: El Dimecres, 10 de desembre de 2014, a les 15:44:02, Thomas Lübking va escriure: On Mittwoch, 10. Dezember 2014 13:11:07 CEST, Christoph Feck wrote: Every interactive on-screen element must have a text, either as a label,

[Kde-pim] Re: Problems with infrastructure

2014-12-11 Thread Thomas Lübking
On Donnerstag, 11. Dezember 2014 09:13:23 CEST, Ivan Čukić wrote: Yyou need to setup git correctly, so that gerrit in that command is valid, I see what you're saying, and you're probably right -- there's a bar, indeed. That bar could however be effectively removed by having a spoonfeeding,

Re: Facebook Flint vis-à-vis Krazy

2014-12-11 Thread Allen Winter
On Thursday, December 11, 2014 03:47:53 AM viv...@gmail.com wrote: Il 02/12/2014 21:40, Allen Winter ha scritto: Howdy, Today I was informed that Facebook has a tool similar in concept to Krazy, called Flint [1] You might want to read [1] and let me know if there are any checkers

Re: KAccounts move into extragear/base

2014-12-11 Thread Martin Klapetek
On Wed, Dec 10, 2014 at 12:43 AM, Albert Astals Cid aa...@kde.org wrote: I'm missing some documentation in the .h files you install from lib. All .h are now fully documented. Also it seems private Q_SLOTS: void getCredentials(); could go into the d pointer via the Q_PRIVATE_SLOT

Re: Ksshaskpass ?

2014-12-11 Thread Jeremy Whiting
ksshaskspass has been in kdereview and has been improved since it got there. Is it ready to be moved to kde/workspace ? On Wed, Nov 5, 2014 at 12:50 PM, David Faure fa...@kde.org wrote: [cutting down on the massive cross-posting] On Monday 03 November 2014 14:13:50 Jeremy Whiting wrote:

Re: Re: Ksshaskpass ?

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 08:33:48 Jeremy Whiting wrote: ksshaskspass has been in kdereview and has been improved since it got there. Is it ready to be moved to kde/workspace ? Sorry for being late for the review. I just cloned the repo and did a quick look for a common problem on X11: the

Re: Re: Ksshaskpass ?

2014-12-11 Thread Jeremy Whiting
Martin, Thanks for the review. I see what you mean, is there an example of doing that on X11, also does that make it so ksshaskpass (or kpassworddialog) won't work on wayland? At any rate if you can point me to another example that does this I'll put a patch for KPasswordDialog on reviewboard

Re: Review Request for KDecoration

2014-12-11 Thread Albert Astals Cid
El Dijous, 11 de desembre de 2014, a les 13:15:55, Martin Gräßlin va escriure: On Thursday 11 December 2014 00:05:52 Albert Astals Cid wrote: El Dimecres, 10 de desembre de 2014, a les 15:44:02, Thomas Lübking va escriure: On Mittwoch, 10. Dezember 2014 13:11:07 CEST, Christoph Feck

Re: Ksshaskpass ?

2014-12-11 Thread Thomas Lübking
On Donnerstag, 11. Dezember 2014 18:37:22 CEST, Jeremy Whiting wrote: Martin, Thanks for the review. I see what you mean, is there an example of doing that on X11 lineEdit-grabKeyboard(); if (QWidget::keyboardGrabber() != lineEdit) { // UNSECURE!!! } ... lineEdit-releaseKeyboard();

Re: [Kde-pim] Problems with infrastructure

2014-12-11 Thread Albert Astals Cid
El Dijous, 11 de desembre de 2014, a les 01:18:57, Jan Kundrát va escriure: Anyway, I know that pre-Gerrit proccess was so painful for me that I actually decided to invest dozens of hours of my time into this, and get the Gerrit + CI ball rolling, and I'm not really willing to go back into

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

2014-12-11 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121248/#review71836 --- Thanks for looking into this! The change looks fine to me.

Re: [Kde-pim] Problems with infrastructure

2014-12-11 Thread Albert Astals Cid
El Dijous, 11 de desembre de 2014, a les 07:48:51, Aaron J. Seigo va escriure: On Wednesday, December 10, 2014 15.27:31 Ben Cooksley wrote: It has come to my attention that some developers have issues with KDE infrastructure in certain areas. This is the first time i've heard I suspect the

Re: Ksshaskpass ?

2014-12-11 Thread Thomas Lübking
https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1dc1986f The InputGuard class should handle everything. In case you need it for QGraphicsWidget's, you may have to adjust the test functions, but in general it should work there as well. Cheers, Thomas

Re: [Kde-pim] Problems with infrastructure

2014-12-11 Thread Jan Kundrát
On Thursday, 11 December 2014 23:20:59 CEST, Albert Astals Cid wrote: You need to understand understand though that changing patch review systems is not your decision to take (nor mine), we need to have a general agreement/consensus when changing systems as important. Changing systems is not

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

2014-12-11 Thread Alberto Sánchez Molero
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121248/ --- (Updated Dec. 12, 2014, 12:17 a.m.) Review request for kdelibs and David

kdepimlibs splitting done

2014-12-11 Thread Aleix Pol
Hi, I have performed the first round of kdepimlibs splitting tonight, as we agreed. Below you can see the for reference how the splitting was performed. Dan, Laurent, can you give me the ok? Then we can proceed to remove the modules from the kdepimlibs repository. Cheers! Aleix kcontacts

Re: Re: Re: Ksshaskpass ?

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 10:37:22 Jeremy Whiting wrote: Martin, Thanks for the review. I see what you mean, is there an example of doing that on X11, also does that make it so ksshaskpass (or kpassworddialog) won't work on wayland? Concerning Wayland: on this windowing system doesn't

Re: Re: Ksshaskpass ?

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 23:25:55 Thomas Lübking wrote: https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1dc 1986f The InputGuard class should handle everything. In case you need it for QGraphicsWidget's, you may have to adjust the test functions, but in general