Re: Reviewing the process for giving people commit rights

2022-04-01 Thread Ivan Čukić
ile this can lead to problems, I'd rather have a different (tooling-based - maintainer notifications when something is merged or pushed directly) solution for this, than changing one of the things that, for me, define the KDE community. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/

Re: Croutons in kdereview

2021-08-30 Thread Ivan Čukić
The type in the future can be QVariant-able while the lambda you pass to `then` might be move only because it uses a unique_ptr somewhere inside. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Croutons in kdereview

2021-08-30 Thread Ivan Čukić
tion you need to pass to `then` when calling it, which you lose if you switch from std::function to a generic Fn parameter. But you can (since you're already using C++20) restrict it with the std::invocable concept to avoid this loss of API usage information. Cheers, Ivan -- dr Ivan Čukić

Re: Croutons in kdereview

2021-08-29 Thread Ivan Čukić
e. Cheers, Ivan [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/ p0323r8.html#expected.synop -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: New repo in kdereview: kalk

2021-02-21 Thread Ivan Čukić
re you start appending (this is for m_units). BTW, these for loops can be replaced with std::transform and std::back_inserter, but I don't want to go overload the review. ;) Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-16 Thread Ivan Čukić
gle line at the end of the function: bargs.setForcesNewWindow(forcesNewWindow); Replacing this with false is IMO more readable as you don't need to scroll up to check what the value of forcesNewWindow is: bargs.setForcesNewWindow(false); Cheers, Ivan -- dr Ivan Čukić i...@cukic.c

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Ivan Čukić
both sentiments - that projects should have different names and that this is a bit off topic for the gitlab migration. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Ivan Čukić
Hi all, While I do like the invent name, I agree there should be a redirect of some sort from git.kde.org to it. The aforementioned Debian salsa server has one as well - https:// git.debian.org/ - a message stating that the new server is 'salsa.debian.org' Cheers, Ivan -- dr Ivan Čukić i

Re: liquidshell in kdereview

2019-03-15 Thread Ivan Čukić
want to use liquidshell instead of plasma or lxqt, why would we stop them? I don't think we've had 'political' discussions in the review phase before, and I don't think we should now. Cheers, Ivan -- dr Ivan Čukić KDE, ivan.cu...@kde.org, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 70

Re: Rebase of kopete branch and push it to master

2018-01-16 Thread Ivan Čukić
Hi all, Would it be possible for sysadmins to just rename master -> master-kde4, and master-kf5 -> master? Cheers, Ivan On Tue, Jan 16, 2018 at 9:20 AM, Pali Rohár wrote: > On Tuesday 16 January 2018 09:05:41 Alexander Semke wrote: >> >> On 16.01.2018 00:45, Pali Rohár

Re: Plasma Vault is in kdereview

2017-03-05 Thread Ivan Čukić
Hi all, All i18n issues should be fixed now, and other ones as well, so I'll be requesting plasma-vault to be moved to the workspace module. I'll also add it to the kdesrcbuild after it is moved. Cheers, Ivan

Re: Plasma Vault is in kdereview

2017-02-16 Thread Ivan Čukić
Hi all, Just an update, so far, the following has been changed so far: - One Messages.sh to create a catalogue used by all components, needs testing; - Applet renamed to org.kde.plasma.vault and plasma_applet_vault.so (to fit the rest); - Icons for the applet added to the breeze plasma and icon

Plasma Vault is in kdereview

2017-02-13 Thread Ivan Čukić
Hi all, I'm announcing that Plasma Vault is in the review phase - you can get it from kde:plasma-vault or with kdesrc-build plasma-vault. Plasma Vault is a system for easy creation of encrypted data storage (not for whole system encryption - we have distribution installers for that). It is

Re: KRandom regression + fix

2016-04-27 Thread Ivan Čukić
If used for crypto, it is a security issue. Now, while I don't expect anyone who implements the crypto stuff to use KRandom, I do agree that KRandom docs should explicitly state this. Cheers, Ivan

Re: KActivities repository split

2016-02-18 Thread Ivan Čukić
Hi Albert, What schedule kio-extras have? Cheerio, Ivan p.s. I'm thinking more and more that kactivities-workspace repository might be a better solution ... -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76

KActivities repository split

2016-02-16 Thread Ivan Čukić
Hi everyone, As previously announced, KActivities has been split into a few separate repositories. This mail is mostly intended to notify our dear packagers of the change, and the plan for the transition period. KActivities framework 5.19 (as released a few days ago) contains everything that it

KRecentDocument with backend plugins

2016-02-01 Thread Ivan Čukić
Hi all, We currently have two ways to track recent documents - KRecentDocument and KActivities. The later provides a more nuanced approach: - it records usage events per activity (document opened, closed, etc.) which allows for different recent documents for different activities - this is

Re: Policy regarding QtWebKit and QtScript

2015-12-22 Thread Ivan Čukić
> Isn't the designated successor for QtScript QJSEngine > (I even assumed there should be some porting tools?) That's what I meant under 'qml engines'. :) A relevant mail by Frederik: http://lists.qt-project.org/pipermail/interest/2015-June/017446.html Cheers, Ivan -- KDE, ivan.cu...@kde.org,

Re: Policy regarding QtWebKit and QtScript

2015-12-22 Thread Ivan Čukić
> QtScript support in Kross depends on Qt's QtScript. Meant to reimplement the scripting mechanisms we have to use Kross instead of QtScript - to expose the scriptable objects to Kross. IIRC (haven't checked Kross for a long time) it supported accessing Qt objects and properties/methods, was

Re: Policy regarding QtWebKit and QtScript

2015-12-22 Thread Ivan Čukić
http://blog.qt.io/blog/2015/12/18/qt-5-6-beta-released/ > Webkit and Qt Quick 1 Removed > > We have removed WebKit and Qt Quick 1 from Qt 5.6 release content. > The source code is still available in the repositories, but these are not > packaged with Qt 5.6 any more. **Qt Script remains

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-10-18 Thread Ivan Čukić
Hi Boudhayan, Before this happens, Spectacle needs to have its own product on BKO. As far as I see, there is only the kscreengenie component in ksnapshot, which was a weird place to have a new application in the first place, and is impossible to find out unless one knows the history of Spectacle.

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-10-18 Thread Ivan Čukić
> Oh yes, I had completely forgotten about that. Thank you so much for > bringing this to notice, Ivan! No problem. I've noticed the issue when I wanted to submit a couple of bugs/wishlist things. :) Cheers, Ivan

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-27 Thread Ivan Čukić
Is there any reason for not changing the command line arguments of Spectacle to fit KSnapshot? It is not like anyone is used to them yet. Cheers, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-27 Thread Ivan Čukić
Hi, Which cmd line options are available in KSnapshot and not in Spectacle? Is it only --freeregion and --child? If those are not supported by Spectacle, a shim (as opposed to a symlink) would not help much IMO. I don't see what a shim would be able to do when passed those arguments if the

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Ivan Čukić
It isn't. The page is just plainly wrong. In that case, I retract my previous comments. Where are the *proper* requirements documented then (for future reference)? That's the list of platforms the Qt CI tests on. It lists both CI tested and untested things there. -- Cheerio, Ivan

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Ivan Čukić
I would have said the docs or the wiki somewhere, but I've just discovered that the docs are wrong... :-) Heh, I had the same approach. :) -- Cheerio, Ivan

Re: Using nullptr instead of Q_NULLPTR

2015-08-13 Thread Ivan Čukić
I prefer the first option, it's the way forward and if someone was using I'd say that requiring a newer gcc just like that would go against the nature of the KF5 project. I don't really see why it is against the nature of KF5. It would not be the first time we require a higher compiler

Re: Using nullptr instead of Q_NULLPTR

2015-08-13 Thread Ivan Čukić
What I don't like in this story is that we set up a rule, an promise with users, which was broken and now it's like it does not matter. Yes, we did set up the rule requirements for gcc 4.5 and MSVC10 back in 2013. Since then, we broke the rule and increased to MSVC11 (VS2012). Now, we can

Re: Using nullptr instead of Q_NULLPTR

2015-08-13 Thread Ivan Čukić
This is from the Officially supported platforms page at http://doc.qt.io/QtSupportedPlatforms/ Qt 5.5: Windows * - MinGW 4.9, MinGW 4.8 (apart from MSVC) Linux - 32/64bitgcc 4.8.1, gcc 4.9.1 I thought that was official enough. Cheers, Ivan

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-13 Thread Ivan Čukić
7. the gui thread listens to dbus and sends a signal to the other threads? It can not send signals since those are not loopy threads. There is no need for a lot of locking if you put one instance of KSycoca. You could do something like this (class names are not real :) ): class MainThread {

Re: Review Request 101885: KRecentDocument support for the K Activity Manager Daemon

2015-05-01 Thread Ivan Čukić
- kio/CMakeLists.txt b517621 kio/kfile/krecentdocument.cpp a7f9283 Diff: https://git.reviewboard.kde.org/r/101885/diff/ Testing --- Been testing for a couple of months now Thanks, Ivan Čukić

Gitorious going offline

2015-03-16 Thread Ivan Čukić
From www.gitorious.org System notice: Gitorious is being acquired by GitLab and gitorious.org will shut down end of May. Please import your repositories to We still have a few projects on there. One notable being Grantlee (at least, my kdesrc-build looks for it over there). I guess this

Re: Gitorious going offline

2015-03-16 Thread Ivan Čukić
And thanks for being on-top of this :). No problem. :) kdesrc-build/kf5-kdepim-build-include updated and pushed. -- Cheerio, Ivan

Re: Gitorious going offline

2015-03-16 Thread Ivan Čukić
If by *we* you mean KDE, no we don't have anything there Not meant to be a yet-another-what-is-a-kde-project type of thread. Just a heads-up of what is happening with the host that more than a few people from KDE are using for KDE-related things. Heads-up mail on KCD because I have *not*

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Ivan Čukić
Hi, I'm volunteering KActivities for the test. Cheerio, Ivan

Re: Adding experimental parts to a KF5 library

2015-01-13 Thread Ivan Čukić
kevin.kof...@chello.at wrote: Ivan Čukić wrote: - 0 soversion to show that the library has no stable ABI. I'd actually set both the soname and the fully-versioned name to libfoo.so.0.1, then if you change something binary-incompatibly, libfoo.so.0.2, etc. (or use libfoo.so.0.1 etc

Re: Adding experimental parts to a KF5 library

2015-01-10 Thread Ivan Čukić
for: - experimental namespace to force the user to see that something is not stable - 0 soversion to show that the library has no stable ABI. Cheerio, Ivan On 10 January 2015 at 10:23, Ivan Čukić ivan.cu...@gmail.com wrote: The C++ committee uses (for example) std::experimental::something I

Adding experimental parts to a KF5 library

2015-01-09 Thread Ivan Čukić
Hi, Because of the short release cycle for the frameworks, it is hard to have bigger new features included into one of them. Slowly evolving APIs while developing stuff leaves a lot of crud and deprecated methods later. What is our policy about having experimental (unstable API/ABI) parts in a

Re: Changes to our Git infrastructure

2014-12-28 Thread Ivan Čukić
Therefore sysadmin proposes that both clone and scratch repositories be eliminated as a concept with the next iteration of our Git infrastructure. N not scratch repos. I can see clones being useless as branches in the actual repos should be used instead, but I personally consider

Re: Changes to branch management

2014-12-23 Thread Ivan Čukić
I'd add Applications/* and Plasma/* to this. Would it be possible to add the Calligra/* release branches to that Seems that release branches are starting with capital letters. Would that be possible and sufficient for the deletable-branch heuristic? -- Cheerio, Ivan KDE, ivan.cukic at

Re: Changes to our Git infrastructure

2014-12-23 Thread Ivan Čukić
I want: * A dashboard to see the patches/Merge requests/whatever against the projects i care * A dashboard to see the patches/Merge requests/whatever against all projects * Upload patches via git diff + web + Web APIs for the above. I always wanted to have an applet that shows my reviews

Re: [Kde-pim] Problems with infrastructure

2014-12-11 Thread Ivan Čukić
Yyou need to setup git correctly, so that gerrit in that command is valid, I see what you're saying, and you're probably right -- there's a bar, indeed. That bar could however be effectively removed by having a spoonfeeding, An alternative to the setup documentation is to actually do it

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Ivan Čukić
I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. If the report is not separated into components, then I'd guess kde-devel is the right place for it. Lets see what the others will say. A question that I'd have for Boris is

Re: Using Gerrit for code review in KDE

2014-09-13 Thread Ivan Čukić
that needs to be reverted because it's actively objectiona- ble. As Ivan pointed out, few of us will ever commit any- thing if we're not confident it would meet with the approval While I do agree that we have a strange and unreally awesome community that behaves really well (and I do trust

Re: Splitting kactivities reporitory

2014-08-26 Thread Ivan Čukić
Does the library make sense without the daemon? If not then it falls into this constraint from https://community.kde.org/Frameworks/Policies : Solutions have a mandatory runtime dependencies, it is part of their design and where their added value comes from That is the reason it ended up in

Splitting kactivities reporitory

2014-08-13 Thread Ivan Čukić
Hi all, What do you think about splitting the kactivities repository into these: - library (would remain in the kactivities repo) - daemon (kactivities-service) - workspace stuff (kcm, doplhin file linking, activities:/ kio, something else?) The reason why this came up again is that the library

Re: Splitting kactivities reporitory

2014-08-13 Thread Ivan Čukić
* there is a flag which allows building only the library at the moment, but that seems not enough. Using that flag allowed me to successfully compile the library on Windows. Sorry, didn't mean that it did not help compiling, just that it seems that a flag does not seem enough for a

Re: Configuration files transfer

2014-04-11 Thread Ivan Čukić
+for (const auto testSubdir: { .kde, .kde5 }) { Shouldn't that be .kde4? Yes, already fixed in the next commit. :) That block of code ($KDEHOME, otherwise ~/.kde, otherwise ~/.kde4) sounds like code that could be shared. Should we have a kde4ConfigHome() and kde4DataHome() in,

Re: Configuration files transfer

2014-04-06 Thread Ivan Čukić
On Friday 04 Apr 2014 21:36:11 Luca Beltrame wrote: David Faure wrote: Kevin Krammer had thoughts on the topic - iirc along the lines of every application should take care of migrating the relevant data ? (cc'ed) To give more context on this question: kactivities (KF5 based) can be used

Configuration files transfer

2014-04-04 Thread Ivan Čukić
Hi all, Since we have changed the location of our config files not to use .kde anymore, we will need some way of moving the old configuration files to their new locations. Should we use kconf_update for this, or is something else in the works? Cheerio, Ivan -- Make your code readable.

Re: kactivities master becomes Qt5/KF5-based

2014-01-28 Thread Ivan Čukić
Ping, 4.13 is looming over. If you want to make it so there's no new releases of 4.12.x anymore and master is KF5 based, please discuss now. Personally I'd suggest against it since seems that even if we dicussed for that happening to kde-workspace people did not get the memo and got angry,

Re: Moving Baloo forward

2014-01-24 Thread Ivan Čukić
Well, the 'worst case' is actually the real case. But, the thing is that it will be actively tested and developed simply because we will have both filesystems with xattr (home etc.), and without (vfat usb-s, encfs stuff and similar). So, both are used at the same time, and regressions will be

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-19 Thread Ivan Čukić
Ideally this would be exposed in the File object, maybe with some sort of QVariantMap userProperties() method. Please don't make it load all attributes and values into the memory if the most common use-case is to load a value for a desired key. I'd rather go for something like

ZSH completion for kdesrc-build

2014-01-11 Thread Ivan Čukić
Hi all, I wanted to post this on the blog, but my server has some issues lately, so I decided this is the best alternative. Some people at Tokamak desired to have completion for kdesrc-build, so I made a very dirty and ugly completion function for it. -- function _ksrccomp() { reply=(`grep

Re: ZSH completion for kdesrc-build

2014-01-11 Thread Ivan Čukić
You are evil :) Thank you dude! On 11 January 2014 21:34, Ivan Čukić ivan.cu...@gmail.com wrote: You are evil :) Thank you dude! On 11 January 2014 17:04, Thiago Macieira thi...@kde.org wrote: On sábado, 11 de janeiro de 2014 11:38:25, Ivan Čukić wrote: function _ksrccomp() { reply

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Ivan Čukić
The most notorious exceptions are to this rule are nepgoogle and webminer. Maintainers of both projects are already working on porting them to Baloo. This I like. Baloo seems to be working very nice (I've been running it for some time now), so if all clients are being ported, then I have no

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Ivan Čukić
On Tuesday, 24. December 2013. 22.03.28 Àlex Fiestas wrote: As I see it, the nepomuk maintainer says it works better than Nepomuk for all cases covered by SC. I don't see any reason not to move forward then. The truthfulness of Vishesh's claim does not enter into it. If we believe it (and I

Re: Nepomuk in 4.13 and beyond

2013-12-13 Thread Ivan Čukić
today before 17:00; this weekend i’m busy, and then next week i’m relatively available again. Monday or later for me. -- Science gathers knowledge faster than society gathers wisdom. -- Isaac Asimov

Re: Nepomuk in 4.13 and beyond

2013-12-13 Thread Ivan Čukić
If both are sqlite, then it's one query - select fid from tagRelation, activityRelation where aid = 'activityId' and tid = 'TagIdentifier'; Now your talkin' This looks nice - It needs to be abstracted into a proper api that can understand that those are separate dbs. (this removes my

Re: Nepomuk in 4.13 and beyond

2013-12-12 Thread Ivan Čukić
Aloha, - Resource Description Framework (RDF) The biggest problem with RDF is that it raises the knowledge needed to I'm not sure this was *the* problem with nepomuk adoption, but lets ignore that for a moment :) So, nepomuk was based on rdf and sparql. Essentially, a simple and

Re: Nepomuk in 4.13 and beyond

2013-12-12 Thread Ivan Čukić
If we all decide to store stuff in sqlite, then it doesn't matter if they are separate database files or the same one. I might be missing a few things here, but asking questions is the road to enlightenment :) - There is no way to query across different stores, which was the main appeal of

Re: Nepomuk in 4.13 and beyond

2013-12-12 Thread Ivan Čukić
for the Plasma Active shell as it currently is, single-store querying might be workable as we tend to keep most of the different resources separated in the UI (though that’s one thing i want to change in future releases, so you can group a set of bookmarks with a given file, e.g.)

Re: KMountPoint::probablySlow and cifs mount points

2013-11-24 Thread Ivan Čukić
and adding cifs to the list of mounttypes that are probablySlow? It's not my place to object since the code isn't mine. Yet i do Whether it is a good to use probablySlow in okular is one question. The other one is whether cifs should be in the probablySlow category. From my point of view,

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
/startactive. - Ivan Čukić On Oct. 24, 2013, 2:04 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Ivan Čukić
On Oct. 24, 2013, 3:35 p.m., Ivan Čukić wrote: Actually, this is something that I wanted to do ever since I saw it on a different screen to the one I had when I made it. If you want to try it with a radial gradient, mind that around the logo, the background needs to be pitch-black

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
to load the images for the theme. Martin Gräßlin wrote: but that's a long time ago, isn't it? So Moore's Law... Anyway could be interesting to do such comparisons on spinning metal. Ivan Čukić wrote: We haven't done any real benchmarks, but it doesn't seem to be noticeably

kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
Hi all, Following kde-workspace (and stealing a few sentences from that announcement), we're planning to merge the frameworks-scratch branch of kactivities into master later today. That means if you're building 4.x branch of Plasma yourself from Git, you should switch to the KDE/4.11 branch.

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
Please no. We have a 4.12 release to make in 2 weeks and back when we did the 4.12 planning the only agreed repo to be freezed for 4.11 was kde-workspace. What about doing an early KDE/4.12 branch from master so that the release can continue as planned, while not slowing us down for further

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
I was planning to branch master into KDE/4.12 after October 30 and before November 6. Forget about it. Decided not to create problems - I'll use the same name for the branch as kdelibs do for the time being - frameworks :) Also it means that you don't want a 4.13.x for kactivities, right?

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
Well, to be honest, if you don't want a 4.13 release i'd prefer you actually use master for KF5. Otherwise people might random-commit fixes to master and then wonder why they never got into a release, so the two situations i think make sense are: People don't really contribute to

Re: QML-using app developers: use private.* imports

2013-09-25 Thread Ivan Čukić
hidden under org.kde.* but that isn't the case anymore if you introduce private.org.kde.* From my POV, Sebastian's proposal is spot-on for that reason alone - it is not a (public) 'qml kde import'. It is a private thing. Cheerio, Ivan p.s. and, in all honesty grepping for org.kde will return

Re: Force push to plasma-framework

2013-08-31 Thread Ivan Čukić
On Sunday 01 September 2013 01:03:59 Ben Cooksley wrote: Hi everyone, Due to an unfortunate accident involving git merge, several branches of the plasma-framework repository were rendered unusable. To correct this, two branches have been forcibly rewound. They are: - master: now at

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Ivan Čukić
This is trivially to work around by a CMake time check and then just define override to empty. Yes, similarly can be done for the nullptr. Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Ivan Čukić
implemented this at a time when Ivan still refused to acknowledge that there is a bug in his plugin at all. There was no real solution in From this point on, I'm ignoring this discussion. I have never said that the plugin is not the reason for the bug 314575, I just explained why it is

Re: Review Request 110663: Don't save state of running activities unless asked to by the session manager

2013-05-27 Thread Ivan Čukić
/110663/#comment24570 This will break things if kamd has not been shut down by ksmserver. (or if it crashes - it will not restart in the activity it was in beforehands) It could use a separate config variable and check those on start. - Ivan Čukić On May 27, 2013, 10:02 a.m., Simon

Re: cxx11-cmake-modules in kdereview

2013-03-02 Thread Ivan Čukić
So, in the end, we have two solutions for projects that are pro C++11: 1) Use the qglobal.h macros as suggested by Thiago. If one desires to know of the features in cmake, it would be enough to parse the output of: gcc -std=c++11 -fPIE -E -dM -I$QTDIR/include -include QtCore/qglobal.h \ -xc++

cxx11-cmake-modules in kdereview

2013-03-01 Thread Ivan Čukić
Hi all! The CMake modules for detecting C++11 features are going to get in kdereview soon. The target for the repository is kdesupport. To clone it, just do the regular: git co kde:cxx11-cmake-modules It would be awesome if our regular CMake experts could give me a few hints on what should be

Re: cxx11-cmake-modules in kdereview

2013-03-01 Thread Ivan Čukić
Can we discuss whether such module should be used? Naturally. Why can't you use the #defines from QtCore? From my POV: - it is not documented - at least, I couldn't find it in Qt 4.8 docs, nor 5.0 (might be a fault of qt-project.org's search mechanism) - it is not extensible - it covers a

Re: cxx11-cmake-modules in kdereview

2013-03-01 Thread Ivan Čukić
One needed feature forgotten, so I'm starting with it: Is it possible for cmake scripts to test the Qt defines? Namely, the kactivities repository is consisted of a few parts that have (as previously agreed) different c++ feature requirements - the library - compilable with any Qt/KDElibs

Re: cxx11-cmake-modules in kdereview

2013-03-01 Thread Ivan Čukić
Why do you need that? Are you adding source files conditionally, depending on whether the compiler supports certain features? Yes, as I said, the library builds with any C++ compiler, but the service requires at least gcc 4.5 equivalent feature set. The service can not use #error since that

Re: cxx11-cmake-modules in kdereview

2013-03-01 Thread Ivan Čukić
The solution is to have missing services then? IMO, better not have something than to lie about it. It is like that mainly for the systems for which don't really want kde workspaces, but rather just applications (having activities, kwin, etc. under windows or mac is not a desire of ours).

Re: Review Request 104417: Copy files instead of moving if parent dir is not writable

2013-02-09 Thread Ivan Čukić
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated Feb. 8, 2013, 10:59 p.m.) Review request for KDE Runtime, Plasma and Ivan Čukić. Description --- When adding an application

Re: Review Request 101885: KRecentDocument support for the K Activity Manager Daemon

2013-02-09 Thread Ivan Čukić
/101885/#review27101 --- On July 31, 2011, 6:11 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101885

Re: Plans for SVN infrastructure shutdown

2013-02-07 Thread Ivan Čukić
You should migrate those to repositories under your scratch namespace on git.kde.org. Hi Ben, My scratch namespace ? I'm not sure to understand... http://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories Cheerio, Ivan

Small API change exception for KActivities::Info

2013-01-15 Thread Ivan Čukić
Hi all, I'm requesting an api freeze exception for the KActivities::Info class to introduce a simple const method: bool isResourceLinked(const KUrl url); The implementation for the method already exists, it is just not published in the API. The reason for this is that because the former

Re: Small API change exception for KActivities::Info

2013-01-15 Thread Ivan Čukić
If it's going to make things faster and it's just exposing an existing method i'd say go for it, after all people are committing patches that are Aaron's stance on this is to leave it as it is since it is only used by SLC which is not released on the desktop, and he doesn't want to introduce

Re: Trojitá, an IMAP e-mail client, and KDE

2012-11-14 Thread Ivan Čukić
Hi, I realize that this might be a slightly unusual case, but I've read through I don't think it would be the first - iirc, some KDE apps already have a Qt- only build mode (Marble if I'm not mistaken) So, would the KDE community be interested in making Trojitá a part of KDE's extragear?

Re: Moving libkfacebook to extragear

2012-10-27 Thread Ivan Čukić
I don't have any knowledge about this, but recently there was some library named libkgoogle which has been renamed to something other to avoid possible trademark hazard. This has been in the thread Review request: moving libkgoogle to extragear starting 2012-05-26. It has been renamed to

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Ivan Čukić
:06 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 17, 2012, 4:06 p.m

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Ivan Čukić
/apps/activitymanager/resources/database - 'select * from nuao_DesktopEvent;' Konqueror was used to open webpages and local directories; urls were opened in multiple windows, multiple tabs, or split-views, and both open/close and focusin/focusout events were registered correctly. Thanks, Ivan

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread Ivan Čukić
; urls were opened in multiple windows, multiple tabs, or split-views, and both open/close and focusin/focusout events were registered correctly. Thanks, Ivan Čukić

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread Ivan Čukić
, visit: http://git.reviewboard.kde.org/r/106908/#review20502 --- On Oct. 17, 2012, 3:27 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Activities support for Konqueror

2012-10-17 Thread Ivan Čukić
opened in multiple windows, multiple tabs, or split-views, and both open/close and focusin/focusout events were registered correctly. Thanks, Ivan Čukić

Review Request: Activities support for Konqueror

2012-10-16 Thread Ivan Čukić
/ Testing --- Yes Thanks, Ivan Čukić

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2012-10-02 Thread Ivan Čukić
making a frameworks branch in the kactivities repo is fine. the library should indeed be easy to port. The core library currently uses only KDebug, i18nc and KUrl. The data models library, the service and the workspace addons use more stuff. So, the core library (that is meant to be used in

Re: Porting KActivities to KF5 (Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity))

2012-10-02 Thread Ivan Čukić
In short, the whole libs / runtime split idea from KDE4, is gone in KF5, replaced with the more modular here is all you need for technology xyz. I know. That is the reason why I decided to keep it in one repository in the first place - to have it as close as possible to the layout it will

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-29 Thread Ivan Čukić
please don't. Debian testing and the next Kubuntu release is currently at 2.8.9 (Debian in fact at 2.8.9~rc1-1) and given that both are frozen there +1 Cheerio, Ivan signature.asc Description: This is a digitally signed message part.

Fwd: KActivities library optimizations

2012-09-03 Thread Ivan Čukić
Hi, The latest master of libkactivities caches and pre-fetches some stuff like the currentActivity, list of activities, list of running activities, activity names and icons, to minimise the amount of d-bus related locks*. What do you think of the idea to go one step further, and instead of

Re: Fwd: KActivities library optimizations

2012-09-03 Thread Ivan Čukić
It adds a lot of things you'd need to be careful about (e.g. how to ensure the data is still in shared memory between when the signal is sent and when the DBus slots are finally called and processed, naming the key for the memory segment, etc.), but the idea is sound. The idea is to keep the

  1   2   >