Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-09-21 Thread Christoph Feck
On Aug. 9, 2011, 9:40 a.m., David Faure wrote: What I don't like about a single button, is that it creates a race. The calculation takes too long, you want to abort it. You click on the button, and half a second before, the calculation actually ended. So your click triggers a

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-08-09 Thread Christoph Feck
On Aug. 9, 2011, 9:40 a.m., David Faure wrote: What I don't like about a single button, is that it creates a race. The calculation takes too long, you want to abort it. You click on the button, and half a second before, the calculation actually ended. So your click triggers a

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-08-08 Thread Kai Uwe Broulik
On Aug. 7, 2011, 11:45 a.m., Thomas Zander wrote: Hmm, did this get committed already? visually the change looks good to me, what do others think? I was in favor of just committing it as there was no feedback (: But I am 3 weeks on vacation now, so feel free to commit or I will do it

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-08-07 Thread Thomas Zander
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/#review5482 --- Hmm, did this get committed already? visually the change looks

Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-07-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- Review request for kdelibs. Summary --- This patch improves the

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-07-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- (Updated July 30, 2011, 2:51 p.m.) Review request for kdelibs. Changes