---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Dec. 4, 2013, 7:32 p.m.)
Status
--
This change has been
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Denis Kuplyakov wrote:
Yes I will finish it, when have time. There are many
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Denis Kuplyakov wrote:
Yes I will finish it, when have time. There are many
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Denis Kuplyakov wrote:
Yes I will finish it, when have time. There are many
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Denis Kuplyakov wrote:
Yes I will finish it, when have time. There are many
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Denis Kuplyakov wrote:
Yes I will finish it, when have time. There are many
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Any chance for an update?
- Kevin
---
This is an automatically generated
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Yes I will finish it, when have time. There are many pre-exams in university.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review42069
---
To get in this patch would benefit from being based on the
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
On Sept. 24, 2013, 6:55 a.m., Kevin Ottens wrote:
I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any
opinion?
If we ignore that point for the moment, and think in terms of KF5, ATM it
would go with KColorScheme in KConfigWidgets. I'm not quite sold on the
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
On Sept. 29, 2013, 4:24 p.m., David Faure wrote:
The name token surprises me a bit. Is this a usual naming scheme for
accessing C++ classes from QML?
Otherwise I would think the QML code would want to just write KColorScheme.
Maybe the registration could be done in a static method,
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Oct. 6, 2013, 7:24 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41068
---
I'm not a huge fan of using Q_INVOKABLE for something that
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41002
---
The name token surprises me a bit. Is this a usual naming
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 29, 2013, 4:27 p.m.)
Review request for KDE Frameworks and
On Sept. 29, 2013, 4:24 p.m., David Faure wrote:
The name token surprises me a bit. Is this a usual naming scheme for
accessing C++ classes from QML?
Otherwise I would think the QML code would want to just write KColorScheme.
Maybe the registration could be done in a static method,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40635
---
I'm not sure we can let that in for kdelibs 4.x / kdeui...
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 24, 2013, 4:08 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40494
---
kdeui/colors/kcolorschemetoken.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 23, 2013, 11:55 a.m.)
Review request for kdelibs.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40547
---
Are you sure you've uploaded a new diff?
Reviewboard shows no
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 23, 2013, 1:04 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 23, 2013, 1:04 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40565
---
kdeui/colors/kcolorschemetoken.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 23, 2013, 1:51 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40571
---
looks ok to me know.
Better add the frameworks review group as
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 23, 2013, 2:43 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
Review request for kdelibs.
Description
---
It is wrapper to access
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 22, 2013, 10:17 a.m.)
Review request for kdelibs.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40458
---
kdeui/colors/kcolorschemetoken.h
On Sept. 22, 2013, 1:55 p.m., Kevin Krammer wrote:
kdeui/colors/kcolorschemetoken.h, line 55
http://git.reviewboard.kde.org/r/112880/diff/1/?file=191110#file191110line55
a property with a setter but no NOTIFYlooks wrong to me for a QML
wrapper
All of the first seven properties
On Sept. 22, 2013, 1:55 p.m., Kevin Krammer wrote:
The main question is still opened: can we make needed enums make usable within
Q_INVOKABLE function? It will be much simplier in implementation for enduser.
- Denis
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---
(Updated Sept. 22, 2013, 4:09 p.m.)
Review request for kdelibs.
Changes
38 matches
Mail list logo
