Review Request 115056: rename knotifications StatusNotifierItem dbus interface in kde-workspace

2014-01-16 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115056/ --- Review request for kde-workspace and Martin Klapetek. Repository:

Re: Review Request 115056: rename knotifications StatusNotifierItem dbus interface in kde-workspace

2014-01-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115056/#review47524 --- Looks good from my side. I'll let Martin have the final

Re: Review Request 114738: kjs: Implement ES6 Object.is

2014-01-16 Thread Bernd Buschinski
On Dec. 30, 2013, 12:54 p.m., Harri Porten wrote: kjs/object_object.cpp, line 48 https://git.reviewboard.kde.org/r/114738/diff/1/?file=227963#file227963line48 Trailing whitespace. thx, locally fixed. (yes I am to lazy to upload the diff here again) - Bernd

Re: Review Request 114455: kjs: Implement ES6 Math.imul

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114455/#review47528 --- This review has been submitted with commit

Re: Review Request 114454: kjs: Implement ES6 Math.hypot

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114454/#review47527 --- This review has been submitted with commit

Re: Review Request 114738: kjs: Implement ES6 Object.is

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114738/#review47532 --- This review has been submitted with commit

Re: Review Request 114738: kjs: Implement ES6 Object.is

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114738/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 114455: kjs: Implement ES6 Math.imul

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114455/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 114454: kjs: Implement ES6 Math.hypot

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114454/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 114623: kjs: Implement es6 Math.fround

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114623/#review47531 --- This review has been submitted with commit

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114464/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 114472: kjs: Implement ES6 Number parseInt, parseFloat

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114472/#review47530 --- This review has been submitted with commit

Re: Review Request 114449: kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, sinh, tanh, trunc Math Functions

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114449/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 114449: kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, sinh, tanh, trunc Math Functions

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114449/#review47526 --- This review has been submitted with commit

Re: Review Request 114623: kjs: Implement es6 Math.fround

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114623/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 114472: kjs: Implement ES6 Number parseInt, parseFloat

2014-01-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114472/ --- (Updated Jan. 16, 2014, 5:56 p.m.) Status -- This change has been

Re: Review Request 115056: rename knotifications StatusNotifierItem dbus interface in kde-workspace

2014-01-16 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115056/ --- (Updated Jan. 16, 2014, 6:04 p.m.) Status -- This change has been

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-16 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114999/ --- (Updated Jan. 16, 2014, 6:06 p.m.) Status -- This change has been

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114464/#review47529 --- This review has been submitted with commit

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-16 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001/ --- (Updated Jan. 16, 2014, 6:06 p.m.) Status -- This change has been

AW: KDE Review: Moving Smb4K to extragear/network

2014-01-16 Thread alexander.reinho...@t-online.de
[...] Until recently the code resided in playground/network (Subversion repository) and I though now is the time to move Smb4K to kdereview with the intension to place it in extragear/network after review. The repository for the review is located at

Re: KDE Review: Moving Smb4K to extragear/network

2014-01-16 Thread Burkhard Lück
Am Mittwoch, 15. Januar 2014, 20:17:52 schrieb Albert Astals Cid: Am Donnerstag, 16. Januar 2014, 09:13:46 schrieb alexander.reinholdt@t- online.de: I don't think your plasmoid is getting properly i18n'ed since i don't see how it would load the smb4k catalog. Have you tried it works? On my

Re: AW: KDE Review: Moving Smb4K to extragear/network

2014-01-16 Thread Albert Astals Cid
El Dijous, 16 de gener de 2014, a les 09:13:46, alexander.reinholdt@t- online.de va escriure: [...] Until recently the code resided in playground/network (Subversion repository) and I though now is the time to move Smb4K to kdereview with the intension to place it in extragear/network

Moving Baloo forward

2014-01-16 Thread Albert Astals Cid
Hi guys, seems we have reached a kind of impasse regarding what to do with Baloo and Nepomuk. Since the 4.13 freeze is coming sooner than you think (less than 6 weeks) I'd like to try to get it moving again. Here comes my proposal: Create a wiki where you clearly explain: * What is Baloo *